From 8cbe13c6560c3abe8ef73b8a376bd84dea281cf4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= <peterix@gmail.com>
Date: Mon, 6 Mar 2017 00:39:25 +0100
Subject: [PATCH 01/28] NOISSUE remove legacy version blacklist

---
 api/logic/minecraft/MinecraftVersionList.cpp | 12 ------------
 api/logic/minecraft/VersionFilterData.cpp    |  2 --
 api/logic/minecraft/VersionFilterData.h      |  2 --
 3 files changed, 16 deletions(-)

diff --git a/api/logic/minecraft/MinecraftVersionList.cpp b/api/logic/minecraft/MinecraftVersionList.cpp
index 2c9a8035..29fa840e 100644
--- a/api/logic/minecraft/MinecraftVersionList.cpp
+++ b/api/logic/minecraft/MinecraftVersionList.cpp
@@ -179,12 +179,6 @@ void MinecraftVersionList::loadBuiltinList()
 			continue;
 		}
 
-		if (g_VersionFilterData.legacyBlacklist.contains(versionID))
-		{
-			qWarning() << "Blacklisted legacy version ignored: " << versionID;
-			continue;
-		}
-
 		// Now, we construct the version object and add it to the list.
 		std::shared_ptr<MinecraftVersion> mcVersion(new MinecraftVersion());
 		mcVersion->m_name = mcVersion->m_descriptor = versionID;
@@ -258,12 +252,6 @@ void MinecraftVersionList::loadMojangList(QJsonDocument jsonDoc, VersionSource s
 			continue;
 		}
 
-		if (g_VersionFilterData.legacyBlacklist.contains(versionID))
-		{
-			qWarning() << "Blacklisted legacy version ignored: " << versionID;
-			continue;
-		}
-
 		// Now, we construct the version object and add it to the list.
 		std::shared_ptr<MinecraftVersion> mcVersion(new MinecraftVersion());
 		mcVersion->m_name = mcVersion->m_descriptor = versionID;
diff --git a/api/logic/minecraft/VersionFilterData.cpp b/api/logic/minecraft/VersionFilterData.cpp
index 0c4a6e3d..60c64473 100644
--- a/api/logic/minecraft/VersionFilterData.cpp
+++ b/api/logic/minecraft/VersionFilterData.cpp
@@ -58,8 +58,6 @@ VersionFilterData::VersionFilterData()
 
 	// don't use installers for those.
 	forgeInstallerBlacklist = QSet<QString>({"1.5.2"});
-	// these won't show up in version lists because they are extremely bad and dangerous
-	legacyBlacklist = QSet<QString>({"rd-160052"});
 	/*
 	 * nothing older than this will be accepted from Mojang servers
 	 * (these versions need to be tested by us first)
diff --git a/api/logic/minecraft/VersionFilterData.h b/api/logic/minecraft/VersionFilterData.h
index f7d4ebe7..f4213e1a 100644
--- a/api/logic/minecraft/VersionFilterData.h
+++ b/api/logic/minecraft/VersionFilterData.h
@@ -20,8 +20,6 @@ struct VersionFilterData
 	QMap<QString, QList<FMLlib>> fmlLibsMapping;
 	// set of minecraft versions for which using forge installers is blacklisted
 	QSet<QString> forgeInstallerBlacklist;
-	// set of 'legacy' versions that will not show up in the version lists.
-	QSet<QString> legacyBlacklist;
 	// no new versions below this date will be accepted from Mojang servers
 	QDateTime legacyCutoffDate;
 	// Libraries that belong to LWJGL

From 7382360771f78e351740393262358bed3297d44c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= <peterix@gmail.com>
Date: Mon, 6 Mar 2017 01:00:44 +0100
Subject: [PATCH 02/28] NOISSUE remove builtin Minecraft versions

---
 api/logic/minecraft/MinecraftVersionList.cpp  |  51 --
 api/logic/minecraft/MinecraftVersionList.h    |   1 -
 api/logic/minecraft/VersionFilterData.cpp     |   9 +-
 api/logic/minecraft/VersionFilterData.h       |   2 -
 application/resources/versions/minecraft.json | 587 ------------------
 application/resources/versions/versions.qrc   |   2 -
 6 files changed, 2 insertions(+), 650 deletions(-)
 delete mode 100644 application/resources/versions/minecraft.json

diff --git a/api/logic/minecraft/MinecraftVersionList.cpp b/api/logic/minecraft/MinecraftVersionList.cpp
index 29fa840e..0dc46289 100644
--- a/api/logic/minecraft/MinecraftVersionList.cpp
+++ b/api/logic/minecraft/MinecraftVersionList.cpp
@@ -26,7 +26,6 @@
 
 #include "ParseUtils.h"
 #include "ProfileUtils.h"
-#include "VersionFilterData.h"
 #include "onesix/OneSixVersionFormat.h"
 #include "MojangVersionFormat.h"
 #include <FileSystem.h>
@@ -89,7 +88,6 @@ public:
 
 MinecraftVersionList::MinecraftVersionList(QObject *parent) : BaseVersionList(parent)
 {
-	loadBuiltinList();
 	loadCachedList();
 }
 
@@ -159,50 +157,6 @@ void MinecraftVersionList::loadCachedList()
 	m_hasLocalIndex = true;
 }
 
-void MinecraftVersionList::loadBuiltinList()
-{
-	qDebug() << "Loading builtin version list.";
-	// grab the version list data from internal resources.
-	const QJsonDocument doc =
-		Json::requireDocument(QString(":/versions/minecraft.json"), "builtin version list");
-	const QJsonObject root = doc.object();
-
-	// parse all the versions
-	for (const auto version : Json::requireArray(root.value("versions")))
-	{
-		QJsonObject versionObj = version.toObject();
-		QString versionID = versionObj.value("id").toString("");
-		QString versionTypeStr = versionObj.value("type").toString("");
-		if (versionID.isEmpty() || versionTypeStr.isEmpty())
-		{
-			qCritical() << "Parsed version is missing ID or type";
-			continue;
-		}
-
-		// Now, we construct the version object and add it to the list.
-		std::shared_ptr<MinecraftVersion> mcVersion(new MinecraftVersion());
-		mcVersion->m_name = mcVersion->m_descriptor = versionID;
-
-		// Parse the timestamp.
-		mcVersion->m_releaseTime = timeFromS3Time(versionObj.value("releaseTime").toString(""));
-		mcVersion->m_versionFileURL = QString();
-		mcVersion->m_versionSource = VersionSource::Builtin;
-		mcVersion->m_type = versionTypeStr;
-		mcVersion->m_appletClass = versionObj.value("appletClass").toString("");
-		mcVersion->m_mainClass = versionObj.value("mainClass").toString("");
-		mcVersion->m_jarChecksum = versionObj.value("checksum").toString("");
-		if (versionObj.contains("+traits"))
-		{
-			for (auto traitVal : Json::requireArray(versionObj.value("+traits")))
-			{
-				mcVersion->m_traits.insert(Json::requireString(traitVal));
-			}
-		}
-		m_lookup[versionID] = mcVersion;
-		m_vlist.append(mcVersion);
-	}
-}
-
 void MinecraftVersionList::loadMojangList(QJsonDocument jsonDoc, VersionSource source)
 {
 	qDebug() << "Loading" << ((source == VersionSource::Remote) ? "remote" : "local") << "version list.";
@@ -259,11 +213,6 @@ void MinecraftVersionList::loadMojangList(QJsonDocument jsonDoc, VersionSource s
 		mcVersion->m_releaseTime = timeFromS3Time(versionObj.value("releaseTime").toString(""));
 		mcVersion->m_updateTime = timeFromS3Time(versionObj.value("time").toString(""));
 
-		if (mcVersion->m_releaseTime < g_VersionFilterData.legacyCutoffDate)
-		{
-			continue;
-		}
-
 		// depends on where we load the version from -- network request or local file?
 		mcVersion->m_versionSource = source;
 		mcVersion->m_versionFileURL = versionObj.value("url").toString("");
diff --git a/api/logic/minecraft/MinecraftVersionList.h b/api/logic/minecraft/MinecraftVersionList.h
index 42333678..fc421966 100644
--- a/api/logic/minecraft/MinecraftVersionList.h
+++ b/api/logic/minecraft/MinecraftVersionList.h
@@ -34,7 +34,6 @@ class MULTIMC_LOGIC_EXPORT MinecraftVersionList : public BaseVersionList
 	Q_OBJECT
 private:
 	void sortInternal();
-	void loadBuiltinList();
 	void loadMojangList(QJsonDocument jsonDoc, VersionSource source);
 	void loadCachedList();
 	void saveCachedList();
diff --git a/api/logic/minecraft/VersionFilterData.cpp b/api/logic/minecraft/VersionFilterData.cpp
index 60c64473..5f4ceee6 100644
--- a/api/logic/minecraft/VersionFilterData.cpp
+++ b/api/logic/minecraft/VersionFilterData.cpp
@@ -58,16 +58,11 @@ VersionFilterData::VersionFilterData()
 
 	// don't use installers for those.
 	forgeInstallerBlacklist = QSet<QString>({"1.5.2"});
-	/*
-	 * nothing older than this will be accepted from Mojang servers
-	 * (these versions need to be tested by us first)
-	 */
+
+	// FIXME: remove, used for deciding when core mods should display
 	legacyCutoffDate = timeFromS3Time("2013-06-25T15:08:56+02:00");
 	lwjglWhitelist =
 		QSet<QString>{"net.java.jinput:jinput",	 "net.java.jinput:jinput-platform",
 					  "net.java.jutils:jutils",	 "org.lwjgl.lwjgl:lwjgl",
 					  "org.lwjgl.lwjgl:lwjgl_util", "org.lwjgl.lwjgl:lwjgl-platform"};
-
-	// Version list magic
-	recommendedMinecraftVersion = "1.7.10";
 }
diff --git a/api/logic/minecraft/VersionFilterData.h b/api/logic/minecraft/VersionFilterData.h
index f4213e1a..2408e704 100644
--- a/api/logic/minecraft/VersionFilterData.h
+++ b/api/logic/minecraft/VersionFilterData.h
@@ -24,7 +24,5 @@ struct VersionFilterData
 	QDateTime legacyCutoffDate;
 	// Libraries that belong to LWJGL
 	QSet<QString> lwjglWhitelist;
-	// Currently recommended minecraft version
-	QString recommendedMinecraftVersion;
 };
 extern VersionFilterData MULTIMC_LOGIC_EXPORT g_VersionFilterData;
diff --git a/application/resources/versions/minecraft.json b/application/resources/versions/minecraft.json
deleted file mode 100644
index 9c08a83f..00000000
--- a/application/resources/versions/minecraft.json
+++ /dev/null
@@ -1,587 +0,0 @@
-{ 
-"versions": [
-	{
-		"id": "1.5.2",
-		"checksum": "6897c3287fb971c9f362eb3ab20f5ddd",
-		"releaseTime": "2013-04-25T17:45:00+02:00",
-		"type": "release",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "1.5.1",
-		"checksum": "5c1219d869b87d233de3033688ec7567",
-		"releaseTime": "2013-03-20T12:00:00+02:00",
-		"type": "release",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "1.5",
-		"checksum": "fd11cbc5b01aae1d62cff0145171f3d9",
-		"releaseTime": "2013-03-07T00:00:00+02:00",
-		"type": "snapshot",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "1.4.7",
-		"checksum": "8e80fb01b321c6b3c7efca397a3eea35",
-		"releaseTime": "2012-12-28T00:00:00+02:00",
-		"type": "release",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "1.4.6",
-		"checksum": "48677dc4c2b98c29918722b5ab27b4fd",
-		"releaseTime": "2012-12-20T00:00:00+02:00",
-		"type": "release",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "1.4.5",
-		"checksum": "b15e2b2b6b4629f0d99a95b6b44412a0",
-		"releaseTime": "2012-11-20T00:00:00+02:00",
-		"type": "release",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "1.4.4",
-		"checksum": "7aa46c8058cba2f38e9d2ddddcc77c72",
-		"releaseTime": "2012-11-14T00:00:00+02:00",
-		"type": "release",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "1.4.3",
-		"checksum": "9cc3295931edb6339f22989fe1b612a6",
-		"releaseTime": "2012-11-01T00:00:00+02:00",
-		"type": "snapshot",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "1.4.2",
-		"checksum": "771175c01778ea67395bc6919a5a9dc5",
-		"releaseTime": "2012-10-25T00:00:00+02:00",
-		"type": "release",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "1.4.1",
-		"checksum": "542621a5298659dc65f383f35170fc4c",
-		"releaseTime": "2012-10-23T00:00:00+02:00",
-		"type": "snapshot",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "1.4",
-		"checksum": "32a654388b54d3e4bb29c1a46e7d6a12",
-		"releaseTime": "2012-10-19T00:00:00+02:00",
-		"type": "snapshot",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "1.3.2",
-		"checksum": "969699f13e5bbe7f12e40ac4f32b7d9a",
-		"releaseTime": "2012-08-16T00:00:00+02:00",
-		"type": "release",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "1.3.1",
-		"checksum": "266ccbc9798afd2eadf3d6c01b4c562a",
-		"releaseTime": "2012-08-01T00:00:00+02:00",
-		"type": "release",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "1.3",
-		"checksum": "a6effac1eaccf5d429aae340cf95ed5d",
-		"releaseTime": "2012-07-26T00:00:00+02:00",
-		"type": "snapshot",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "1.2.5",
-		"checksum": "8e8778078a175a33603a585257f28563",
-		"releaseTime": "2012-03-30T00:00:00+02:00",
-		"type": "release",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "1.2.4",
-		"checksum": "25423eab6d8707f96cc6ad8a21a7250a",
-		"releaseTime": "2012-03-22T00:00:00+02:00",
-		"type": "release",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "1.2.3",
-		"checksum": "12f6c4b1bdcc63f029e3c088a364b8e4",
-		"releaseTime": "2012-03-02T00:00:00+02:00",
-		"type": "release",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "1.2.2",
-		"checksum": "6189e96efaea11e5164b4a4755574324",
-		"releaseTime": "2012-03-01T00:00:01+02:00",
-		"type": "release",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "1.2.1",
-		"checksum": "97067a603eba2b6eb75d3194f81f6bcd",
-		"releaseTime": "2012-03-01T00:00:00+02:00",
-		"type": "release",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "1.1",
-		"checksum": "e92302d2acdba7c97e0d8df1e10d2006",
-		"releaseTime": "2012-01-12T00:00:00+02:00",
-		"type": "release",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "1.0",
-		"checksum": "3820d222b95d0b8c520d9596a756a6e6",
-		"releaseTime": "2011-11-18T00:00:00+02:00",
-		"type": "release",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "b1.8.1",
-		"checksum": "f8c5a2ccd3bc996792bbe436d8cc08bc",
-		"releaseTime": "2011-09-19T00:00:00+02:00",
-		"type": "old_beta",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "b1.8",
-		"checksum": "a59a9fd4c726a573b0a2bdd10d857f59",
-		"releaseTime": "2011-09-15T00:00:00+02:00",
-		"type": "old_beta",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "b1.7.3",
-		"checksum": "eae3353fdaa7e10a59b4cb5b45bfa10d",
-		"releaseTime": "2011-07-08T00:00:00+02:00",
-		"type": "old_beta",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "b1.7.2",
-		"checksum": "dd9215ab1141170d4871f42bff4ab302",
-		"releaseTime": "2011-07-01T00:00:00+02:00",
-		"type": "old_beta",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "b1.7",
-		"checksum": "682419e9ed1a236c3067822d53cda1e4",
-		"releaseTime": "2011-06-30T00:00:00+02:00",
-		"type": "old_beta",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "b1.6.6",
-		"checksum": "ce80072464433cd5b05d505aa8ff29d1",
-		"releaseTime": "2011-05-31T00:00:00+02:00",
-		"type": "old_beta",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "b1.6.5",
-		"checksum": "2aba888864b32038c8d22ee5df71b7c8",
-		"releaseTime": "2011-05-28T00:00:00+02:00",
-		"type": "old_beta",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "b1.6.4",
-		"checksum": "5c4df6f120336f113180698613853dba",
-		"releaseTime": "2011-05-26T00:00:04+02:00",
-		"type": "old_beta",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "b1.6.3",
-		"checksum": "efc2becca965e4f8feb5b4210c6a4fd1",
-		"releaseTime": "2011-05-26T00:00:03+02:00",
-		"type": "old_beta",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "b1.6.2",
-		"checksum": "01330b1c930102a683a4dd8d792e632e",
-		"releaseTime": "2011-05-26T00:00:02+02:00",
-		"type": "old_beta",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "b1.6.1",
-		"checksum": "a7e82c441a57ef4068c533f4d777336a",
-		"releaseTime": "2011-05-26T00:00:01+02:00",
-		"type": "old_beta",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "b1.6",
-		"checksum": "d531e221227a65392259d3141893280d",
-		"releaseTime": "2011-05-26T00:00:00+02:00",
-		"type": "old_beta",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "b1.5_01",
-		"checksum": "d02fa9998e30693d8d989d5f88cf0040",
-		"releaseTime": "2011-04-20T00:00:00+02:00",
-		"type": "old_beta",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "b1.5",
-		"checksum": "24289130902822d73f8722b52bc07cdb",
-		"releaseTime": "2011-04-19T00:00:00+02:00",
-		"type": "old_beta",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "b1.4_01",
-		"checksum": "9379e54b581ba4ef3acc3e326e87db91",
-		"releaseTime": "2011-04-05T00:00:00+02:00",
-		"type": "old_beta",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "b1.4",
-		"checksum": "71e64b61175b371ed148b385f2d14ebf",
-		"releaseTime": "2011-03-31T00:00:00+02:00",
-		"type": "old_beta",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "b1.3_01",
-		"checksum": "4203826f35e1036f089919032c3d19d1",
-		"releaseTime": "2011-02-23T00:00:00+02:00",
-		"type": "old_beta",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "b1.3b",
-		"checksum": "de2164df461d028229ed2e101181bbd4",
-		"releaseTime": "2011-02-22T00:00:00+02:00",
-		"type": "old_beta",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "b1.2_02",
-		"checksum": "1736c5ba4f63a981220c2a18a4120180",
-		"releaseTime": "2011-01-21T00:00:00+02:00",
-		"type": "old_beta",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "b1.2_01",
-		"checksum": "486d83ec00554b45ffa21af2faa0116a",
-		"releaseTime": "2011-01-14T00:00:00+02:00",
-		"type": "old_beta",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "b1.2",
-		"checksum": "6426223efe23c3931a4ef89685be3349",
-		"releaseTime": "2011-01-13T00:00:00+02:00",
-		"type": "old_beta",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "b1.1_02",
-		"checksum": "7d547e495a770c62054ef136add43034",
-		"releaseTime": "2010-12-22T00:00:01+02:00",
-		"type": "old_beta",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "b1.1_01",
-		"checksum": "1f9331f2bfca81b6ce2acdfc1f105837",
-		"releaseTime": "2010-12-22T00:00:00+02:00",
-		"type": "old_beta",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "b1.0.2",
-		"checksum": "d200c465b8c167cc8df6537531fc9a48",
-		"releaseTime": "2010-12-21T00:00:00+02:00",
-		"type": "old_beta",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "b1.0_01",
-		"checksum": "03bd20b870dbbd121de5dca98af4e1ce",
-		"releaseTime": "2010-12-20T00:00:01+02:00",
-		"type": "old_beta",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "b1.0",
-		"checksum": "5f8733dbbf09b4e7c874661a3c29c239",
-		"releaseTime": "2010-12-20T00:00:00+02:00",
-		"type": "old_beta",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "a1.2.6",
-		"checksum": "ddd5e39467f28d1ea1a03b4d9e790867",
-		"releaseTime": "2010-12-03T00:00:00+02:00",
-		"type": "old_alpha",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "a1.2.5",
-		"checksum": "7d3a43037190970ff2e11153b5718b74",
-		"releaseTime": "2010-12-01T00:00:00+02:00",
-		"type": "old_alpha",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "a1.2.4_01",
-		"checksum": "0a1cc8c668faa6dc93fc418e8b4b097a",
-		"releaseTime": "2010-11-30T00:00:00+02:00",
-		"type": "old_alpha",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "a1.2.3_04",
-		"checksum": "b2c25a753c82a1cd228ce71469829dc1",
-		"releaseTime": "2010-11-26T00:00:00+02:00",
-		"type": "old_alpha",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "a1.2.3_02",
-		"checksum": "3ad4808ef2ac3b65d10305315260da03",
-		"releaseTime": "2010-11-25T00:00:00+02:00",
-		"type": "old_alpha",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "a1.2.3_01",
-		"checksum": "70cbab762b17c5b11fefea9b12564119",
-		"releaseTime": "2010-11-24T00:00:01+02:00",
-		"type": "old_alpha",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "a1.2.3",
-		"checksum": "25f053114e34b915e675f82d58f08711",
-		"releaseTime": "2010-11-24T00:00:00+02:00",
-		"type": "old_alpha",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "a1.2.2b",
-		"checksum": "6250fb17f8898c4d970d6bd03c229177",
-		"releaseTime": "2010-11-10T00:00:01+02:00",
-		"type": "old_alpha",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "a1.2.2a",
-		"checksum": "0f9fe018b344fd9dd849005f9bdca803",
-		"releaseTime": "2010-11-10T00:00:00+02:00",
-		"type": "old_alpha",
-		"+traits": ["legacyLaunch", "texturepacks"]
-	},
-	{
-		"id": "a1.2.1_01",
-		"checksum": "0a496e44a7b4e2f493b5893d8e5845bd",
-		"releaseTime": "2010-11-05T00:00:01+02:00",
-		"type": "old_alpha",
-		"+traits": ["legacyLaunch", "no-texturepacks"]
-	},
-	{
-		"id": "a1.2.1",
-		"checksum": "0a496e44a7b4e2f493b5893d8e5845bd",
-		"releaseTime": "2010-11-05T00:00:00+02:00",
-		"type": "old_alpha",
-		"+traits": ["legacyLaunch", "no-texturepacks"]
-	},
-	{
-		"id": "a1.2.0_02",
-		"checksum": "f5bcb4d0c0e78bc220f164b89ae9bd60",
-		"releaseTime": "2010-11-04T00:00:00+02:00",
-		"type": "old_alpha",
-		"+traits": ["legacyLaunch", "no-texturepacks"]
-	},
-	{
-		"id": "a1.2.0_01",
-		"checksum": "b2e9333e967cb89488884c2e5c715d4f",
-		"releaseTime": "2010-10-31T00:00:00+02:00",
-		"type": "old_alpha",
-		"+traits": ["legacyLaunch", "no-texturepacks"]
-	},
-	{
-		"id": "a1.2.0",
-		"checksum": "44c384dae02390f700458b95d82c3e2a",
-		"releaseTime": "2010-10-30T00:00:00+02:00",
-		"type": "old_alpha",
-		"+traits": ["legacyLaunch", "no-texturepacks"]
-	},
-	{
-		"id": "a1.1.2_01",
-		"checksum": "94346e1b8f6ad0e4a284314f0e29207b",
-		"releaseTime": "2010-09-23T00:00:00+02:00",
-		"type": "old_alpha",
-		"+traits": ["legacyLaunch", "no-texturepacks"]
-	},
-	{
-		"id": "a1.1.2",
-		"checksum": "72ba1f834327805cb44164a42b331522",
-		"releaseTime": "2010-09-20T00:00:00+02:00",
-		"type": "old_alpha",
-		"+traits": ["legacyLaunch", "no-texturepacks"]
-	},
-	{
-		"id": "a1.1.0",
-		"checksum": "891fd93e04f5daaf35d73c58e45c01b1",
-		"releaseTime": "2010-09-13T00:00:00+02:00",
-		"type": "old_alpha",
-		"+traits": ["legacyLaunch", "no-texturepacks"]
-	},
-	{
-		"id": "a1.0.17_04",
-		"checksum": "16ed7dc58244772847991e504afcf02f",
-		"releaseTime": "2010-08-23T00:00:00+02:00",
-		"type": "old_alpha",
-		"+traits": ["legacyLaunch", "no-texturepacks"]
-	},
-	{
-		"id": "a1.0.17_02",
-		"checksum": "d89760b0871ef61a55c9f336c0439d58",
-		"releaseTime": "2010-08-20T00:00:00+02:00",
-		"type": "old_alpha",
-		"+traits": ["legacyLaunch", "no-texturepacks"]
-	},
-	{
-		"id": "a1.0.16",
-		"checksum": "6bbde02c13aed5766275f4398ede6aae",
-		"releaseTime": "2010-08-12T00:00:00+02:00",
-		"type": "old_alpha",
-		"+traits": ["legacyLaunch", "no-texturepacks"]
-	},
-	{
-		"id": "a1.0.15",
-		"checksum": "ade257d2080d56fa983763f9c701fa14",
-		"releaseTime": "2010-08-04T00:00:00+02:00",
-		"type": "old_alpha",
-		"+traits": ["legacyLaunch", "no-texturepacks"]
-	},
-	{
-		"id": "a1.0.14",
-		"checksum": "227d0c6fa896a231de6269a074c9a458",
-		"releaseTime": "2010-07-30T00:00:00+02:00",
-		"type": "old_alpha",
-		"+traits": ["legacyLaunch", "no-texturepacks"]
-	},
-	{
-		"id": "a1.0.11",
-		"checksum": "6f1b1dd157fa0df39760f5be3eab01b0",
-		"releaseTime": "2010-07-23T00:00:00+02:00",
-		"type": "old_alpha",
-		"+traits": ["legacyLaunch", "no-texturepacks"]
-	},
-	{
-		"id": "a1.0.5_01",
-		"checksum": "ae5f606caa18222e7568819c910ee423",
-		"releaseTime": "2010-07-13T00:00:00+02:00",
-		"type": "old_alpha",
-		"mainClass": "y",
-		"+traits": ["legacyLaunch", "no-texturepacks"]
-	},
-	{
-		"id": "a1.0.4",
-		"checksum": "13ce7935c3670e7494e26b2704bfa3e9",
-		"releaseTime": "2010-07-09T00:00:00+02:00",
-		"type": "old_alpha",
-		"mainClass": "ax",
-		"+traits": ["legacyLaunch", "no-texturepacks"]
-	},
-	{
-		"id": "inf-20100618",
-		"checksum": "f5f5aa34760facc10486e906a7c60196",
-		"releaseTime": "2010-06-16T00:00:00+02:00",
-		"type": "old_alpha",
-		"mainClass": "net.minecraft.client.d",
-		"appletClass": "net.minecraft.client.MinecraftApplet",
-		"+traits": ["legacyLaunch", "no-texturepacks"]
-	},
-	{
-		"id": "c0.30_01c",
-		"checksum": "fcfd7f83a6b27503cf48202381a5adf2",
-		"releaseTime": "2009-12-22T00:00:00+02:00",
-		"type": "old_alpha",
-		"mainClass": "com.mojang.minecraft.l",
-		"appletClass": "com.mojang.minecraft.MinecraftApplet",
-		"+traits": ["legacyLaunch", "no-texturepacks"]
-	},
-	{
-		"id": "c0.0.13a_03",
-		"checksum": "a9527cb5aef198e0f53e235ebe13dc75",
-		"releaseTime": "2009-05-22T00:00:00+02:00",
-		"type": "old_alpha",
-		"mainClass": "com.mojang.minecraft.c",
-		"appletClass": "com.mojang.minecraft.MinecraftApplet",
-		"+traits": ["legacyLaunch", "no-texturepacks"]
-	},
-	{
-		"id": "c0.0.13a",
-		"checksum": "3617fbf5fbfd2b837ebf5ceb63584908",
-		"releaseTime": "2009-05-31T00:00:00+02:00",
-		"type": "old_alpha",
-		"mainClass": "com.mojang.minecraft.Minecraft",
-		"appletClass": "com.mojang.minecraft.MinecraftApplet",
-		"+traits": ["legacyLaunch", "no-texturepacks"]
-	},
-	{
-		"id": "c0.0.11a",
-		"checksum": "a6e03c2eaf74709facc0d2477648e999",
-		"releaseTime": "2009-05-17T00:00:00+02:00",
-		"type": "old_alpha",
-		"mainClass": "com.mojang.minecraft.Minecraft",
-		"appletClass": "com.mojang.minecraft.MinecraftApplet",
-		"+traits": ["legacyLaunch", "no-texturepacks"]
-	},
-	{
-		"id": "rd-161348",
-		"checksum": "80882b8936a5c8d91500838a6660b504",
-		"releaseTime": "2009-05-16T13:48:00+02:00",
-		"type": "old_alpha",
-		"mainClass": "com.mojang.minecraft.RubyDung",
-		"+traits": ["no-texturepacks"]
-	},
-	{
-		"id": "rd-160052",
-		"checksum": "24c5cc99a2a612697ed2f7d5d04242fe",
-		"releaseTime": "2009-05-16T00:52:00+02:00",
-		"type": "old_alpha",
-		"mainClass": "com.mojang.rubydung.RubyDung",
-		"+traits": ["no-texturepacks"]
-	},
-	{
-		"id": "rd-132328",
-		"checksum": "70e33a81c541b13a477e68c1207124eb",
-		"releaseTime": "2009-05-13T23:28:00+02:00",
-		"type": "old_alpha",
-		"mainClass": "com.mojang.rubydung.RubyDung",
-		"+traits": ["no-texturepacks"]
-	},
-	{
-		"id": "rd-132211",
-		"checksum": "99fdaea10c494b9c3c3254636b98b799",
-		"releaseTime": "2009-05-13T22:11:00+02:00",
-		"type": "old_alpha",
-		"mainClass": "com.mojang.rubydung.RubyDung",
-		"+traits": ["no-texturepacks"]
-	}
-]
-}
diff --git a/application/resources/versions/versions.qrc b/application/resources/versions/versions.qrc
index e9621e97..d9596942 100644
--- a/application/resources/versions/versions.qrc
+++ b/application/resources/versions/versions.qrc
@@ -1,8 +1,6 @@
 <!DOCTYPE RCC>
 <RCC version="1.0">
     <qresource prefix="/versions">
-		<!-- builtin legacy versions -->
-		<file>minecraft.json</file>
 		<!-- LWJGL -->
 		<file>LWJGL/2.9.0.json</file>
 		<file>LWJGL/2.9.1-nightly-20130708-debug3.json</file>

From 1fbe03f982f130bf675b7f94dd9c06aee62da54f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= <peterix@gmail.com>
Date: Fri, 10 Mar 2017 23:34:03 +0100
Subject: [PATCH 03/28] NOISSUE remove unused wonkoclient

---
 CMakeLists.txt              |  1 -
 wonkoclient/CMakeLists.txt  | 10 -----
 wonkoclient/WonkoClient.cpp | 84 -------------------------------------
 wonkoclient/WonkoClient.h   | 36 ----------------
 wonkoclient/main.cpp        | 29 -------------
 5 files changed, 160 deletions(-)
 delete mode 100644 wonkoclient/CMakeLists.txt
 delete mode 100644 wonkoclient/WonkoClient.cpp
 delete mode 100644 wonkoclient/WonkoClient.h
 delete mode 100644 wonkoclient/main.cpp

diff --git a/CMakeLists.txt b/CMakeLists.txt
index d3dcac78..86f8e20a 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -109,4 +109,3 @@ add_subdirectory(api/logic)
 add_subdirectory(api/gui)
 
 add_subdirectory(application)
-add_subdirectory(wonkoclient)
diff --git a/wonkoclient/CMakeLists.txt b/wonkoclient/CMakeLists.txt
deleted file mode 100644
index 381857e0..00000000
--- a/wonkoclient/CMakeLists.txt
+++ /dev/null
@@ -1,10 +0,0 @@
-project(wonkoclient)
-
-SET( SRC_FILES
-main.cpp
-WonkoClient.cpp
-WonkoClient.h
-)
-
-add_executable(MMCClient ${SRC_FILES})
-target_link_libraries(MMCClient MultiMC_logic)
diff --git a/wonkoclient/WonkoClient.cpp b/wonkoclient/WonkoClient.cpp
deleted file mode 100644
index a45939b3..00000000
--- a/wonkoclient/WonkoClient.cpp
+++ /dev/null
@@ -1,84 +0,0 @@
-//
-// Created by robotbrain on 3/27/16.
-//
-
-#include <minecraft/MinecraftVersionList.h>
-#include <Env.h>
-#include <minecraft/liteloader/LiteLoaderVersionList.h>
-#include <minecraft/forge/ForgeVersionList.h>
-#include <minecraft/legacy/LwjglVersionList.h>
-#include <java/JavaInstallList.h>
-#include <settings/INISettingsObject.h>
-#include "WonkoClient.h"
-
-WonkoClient &WonkoClient::getInstance() {
-    static WonkoClient instance;
-    return instance;
-}
-
-void WonkoClient::registerLists() {
-    ENV.initHttpMetaCache();
-    auto mcList = std::make_shared<MinecraftVersionList>();
-    ENV.registerVersionList("net.minecraft", mcList);
-    runTask(mcList->getLoadTask());
-    auto llList = std::make_shared<LiteLoaderVersionList>();
-    ENV.registerVersionList("com.mumfrey.liteloader", llList);
-    runTask(llList->getLoadTask());
-    auto forgeList = std::make_shared<ForgeVersionList>();
-    ENV.registerVersionList("net.minecraftforge", forgeList);
-    runTask(forgeList->getLoadTask());
-    auto lwjglList = std::make_shared<LWJGLVersionList>();
-    ENV.registerVersionList("org.lwjgl.legacy", lwjglList);
-    runTask(lwjglList->getLoadTask());
-    auto javaList = std::make_shared<JavaInstallList>();
-    ENV.registerVersionList("com.java", javaList);
-}
-
-WonkoClient::WonkoClient() {
-    m_settings.reset(new INISettingsObject("multimc.cfg", this));
-    m_instanceList.reset(new InstanceList(m_settings, ".", this));
-}
-
-void WonkoClient::runTask(Task *pTask) {
-    if (pTask == nullptr)
-        return;
-    QEventLoop loop;
-    QObject::connect(pTask, &Task::finished, &loop, &QEventLoop::quit);
-    pTask->start();
-    loop.exec();
-    delete pTask;
-}
-
-void WonkoClient::initGlobalSettings()
-{
-    m_settings->registerSetting("ShowConsole", true);
-    m_settings->registerSetting("AutoCloseConsole", true);
-    m_settings->registerSetting("LogPrePostOutput", true);
-    // Window Size
-    m_settings->registerSetting({"LaunchMaximized", "MCWindowMaximize"}, false);
-    m_settings->registerSetting({"MinecraftWinWidth", "MCWindowWidth"}, 854);
-    m_settings->registerSetting({"MinecraftWinHeight", "MCWindowHeight"}, 480);
-
-    // Memory
-    m_settings->registerSetting({"MinMemAlloc", "MinMemoryAlloc"}, 512);
-    m_settings->registerSetting({"MaxMemAlloc", "MaxMemoryAlloc"}, 1024);
-    m_settings->registerSetting("PermGen", 128);
-
-    // Java Settings
-    m_settings->registerSetting("JavaPath", "");
-    m_settings->registerSetting("JavaTimestamp", 0);
-    m_settings->registerSetting("JavaArchitecture", "");
-    m_settings->registerSetting("JavaVersion", "");
-    m_settings->registerSetting("LastHostname", "");
-    m_settings->registerSetting("JvmArgs", "");
-
-    // Wrapper command for launch
-    m_settings->registerSetting("WrapperCommand", "");
-
-    // Custom Commands
-    m_settings->registerSetting({"PreLaunchCommand", "PreLaunchCmd"}, "");
-    m_settings->registerSetting({"PostExitCommand", "PostExitCmd"}, "");
-
-    // Minecraft launch method
-    m_settings->registerSetting("MCLaunchMethod", "LauncherPart");
-}
diff --git a/wonkoclient/WonkoClient.h b/wonkoclient/WonkoClient.h
deleted file mode 100644
index e6b35805..00000000
--- a/wonkoclient/WonkoClient.h
+++ /dev/null
@@ -1,36 +0,0 @@
-//
-// Created by robotbrain on 3/27/16.
-//
-
-#pragma once
-
-#include <memory>
-#include <InstanceList.h>
-
-#if defined(MMCC)
-#undef MMCC
-#endif
-#define MMCC (WonkoClient::getInstance())
-
-class WonkoClient : public QObject {
-Q_OBJECT
-
-private:
-    WonkoClient();
-
-public:
-    static WonkoClient &getInstance();
-
-    void registerLists();
-    void initGlobalSettings();
-
-    std::shared_ptr<InstanceList> instances() const {
-        return m_instanceList;
-    }
-
-private:
-    std::shared_ptr<InstanceList> m_instanceList;
-    std::shared_ptr<SettingsObject> m_settings;
-
-    void runTask(Task *pTask);
-};
diff --git a/wonkoclient/main.cpp b/wonkoclient/main.cpp
deleted file mode 100644
index eaf92c5d..00000000
--- a/wonkoclient/main.cpp
+++ /dev/null
@@ -1,29 +0,0 @@
-//
-// Created by robotbrain on 3/26/16.
-//
-
-#include "WonkoClient.h"
-#include <QCoreApplication>
-#include <QDebug>
-#include <QtWidgets/QInputDialog>
-#include <QtGui/QDesktopServices>
-#include <QDir>
-
-int main(int argc, char *argv[])
-{
-	QCoreApplication a(argc, argv);
-	if (a.arguments().contains("-d"))
-	{
-		int i = a.arguments().lastIndexOf("-d") + 1;
-		if (i < a.arguments().length())
-		{
-			QDir dir = QDir::current();
-			dir.cd(a.arguments()[i]);
-			QDir::setCurrent(dir.absolutePath());
-			qDebug() << "Using " << dir.absolutePath();
-		}
-	}
-	MMCC.initGlobalSettings();
-	MMCC.registerLists();
-	return a.exec();
-}

From ab868df50eb6f9f3958bdc0a7ab9199dcdf46b3c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= <peterix@gmail.com>
Date: Sat, 11 Mar 2017 01:39:45 +0100
Subject: [PATCH 04/28] NOISSUE Wonko is the new Meta

And then Wonko was the Meta.
---
 api/logic/CMakeLists.txt                      |  50 +++----
 api/logic/Env.cpp                             |  27 ++--
 api/logic/Env.h                               |  11 +-
 .../BaseEntity.cpp}                           |  17 ++-
 .../BaseWonkoEntity.h => meta/BaseEntity.h}   |  12 +-
 .../{wonko/WonkoIndex.cpp => meta/Index.cpp}  |  57 ++++----
 .../{wonko/WonkoIndex.h => meta/Index.h}      |  28 ++--
 api/logic/meta/Index_test.cpp                 |  50 +++++++
 .../WonkoReference.cpp => meta/Reference.cpp} |  18 ++-
 .../WonkoReference.h => meta/Reference.h}     |  15 +-
 .../{wonko/WonkoUtil.cpp => meta/Util.cpp}    |  13 +-
 api/logic/{wonko/WonkoUtil.h => meta/Util.h}  |   4 +-
 .../WonkoVersion.cpp => meta/Version.cpp}     |  47 ++++---
 .../{wonko/WonkoVersion.h => meta/Version.h}  |  26 ++--
 .../VersionList.cpp}                          |  99 ++++++-------
 .../WonkoVersionList.h => meta/VersionList.h} |  37 ++---
 api/logic/meta/format/Format.cpp              |  84 +++++++++++
 api/logic/meta/format/Format.h                |  57 ++++++++
 .../format/FormatV1.cpp}                      |  53 +++----
 .../format/FormatV1.h}                        |  19 +--
 api/logic/meta/tasks/LocalLoadTask.cpp        | 123 ++++++++++++++++
 .../tasks/LocalLoadTask.h}                    |  35 ++---
 api/logic/meta/tasks/RemoteLoadTask.cpp       | 132 ++++++++++++++++++
 .../tasks/RemoteLoadTask.h}                   |  39 +++---
 api/logic/wonko/WonkoIndex_test.cpp           |  50 -------
 api/logic/wonko/format/WonkoFormat.cpp        |  80 -----------
 api/logic/wonko/format/WonkoFormat.h          |  54 -------
 .../tasks/BaseWonkoEntityLocalLoadTask.cpp    | 117 ----------------
 .../tasks/BaseWonkoEntityRemoteLoadTask.cpp   | 126 -----------------
 application/BuildConfig.cpp.in                |   1 -
 application/BuildConfig.h                     |   5 -
 application/CMakeLists.txt                    |  11 +-
 application/WonkoGui.cpp                      |  74 ----------
 application/WonkoGui.h                        |  29 ----
 .../{WonkoPage.cpp => MetadataPage.cpp}       |  74 +++++-----
 .../global/{WonkoPage.h => MetadataPage.h}    |  14 +-
 .../global/{WonkoPage.ui => MetadataPage.ui}  |   4 +-
 37 files changed, 820 insertions(+), 872 deletions(-)
 rename api/logic/{wonko/BaseWonkoEntity.cpp => meta/BaseEntity.cpp} (69%)
 rename api/logic/{wonko/BaseWonkoEntity.h => meta/BaseEntity.h} (86%)
 rename api/logic/{wonko/WonkoIndex.cpp => meta/Index.cpp} (57%)
 rename api/logic/{wonko/WonkoIndex.h => meta/Index.h} (65%)
 create mode 100644 api/logic/meta/Index_test.cpp
 rename api/logic/{wonko/WonkoReference.cpp => meta/Reference.cpp} (70%)
 rename api/logic/{wonko/WonkoReference.h => meta/Reference.h} (77%)
 rename api/logic/{wonko/WonkoUtil.cpp => meta/Util.cpp} (89%)
 rename api/logic/{wonko/WonkoUtil.h => meta/Util.h} (93%)
 rename api/logic/{wonko/WonkoVersion.cpp => meta/Version.cpp} (52%)
 rename api/logic/{wonko/WonkoVersion.h => meta/Version.h} (74%)
 rename api/logic/{wonko/WonkoVersionList.cpp => meta/VersionList.cpp} (62%)
 rename api/logic/{wonko/WonkoVersionList.h => meta/VersionList.h} (67%)
 create mode 100644 api/logic/meta/format/Format.cpp
 create mode 100644 api/logic/meta/format/Format.h
 rename api/logic/{wonko/format/WonkoFormatV1.cpp => meta/format/FormatV1.cpp} (69%)
 rename api/logic/{wonko/format/WonkoFormatV1.h => meta/format/FormatV1.h} (53%)
 create mode 100644 api/logic/meta/tasks/LocalLoadTask.cpp
 rename api/logic/{wonko/tasks/BaseWonkoEntityLocalLoadTask.h => meta/tasks/LocalLoadTask.h} (61%)
 create mode 100644 api/logic/meta/tasks/RemoteLoadTask.cpp
 rename api/logic/{wonko/tasks/BaseWonkoEntityRemoteLoadTask.h => meta/tasks/RemoteLoadTask.h} (61%)
 delete mode 100644 api/logic/wonko/WonkoIndex_test.cpp
 delete mode 100644 api/logic/wonko/format/WonkoFormat.cpp
 delete mode 100644 api/logic/wonko/format/WonkoFormat.h
 delete mode 100644 api/logic/wonko/tasks/BaseWonkoEntityLocalLoadTask.cpp
 delete mode 100644 api/logic/wonko/tasks/BaseWonkoEntityRemoteLoadTask.cpp
 delete mode 100644 application/WonkoGui.cpp
 delete mode 100644 application/WonkoGui.h
 rename application/pages/global/{WonkoPage.cpp => MetadataPage.cpp} (71%)
 rename application/pages/global/{WonkoPage.h => MetadataPage.h} (82%)
 rename application/pages/global/{WonkoPage.ui => MetadataPage.ui} (99%)

diff --git a/api/logic/CMakeLists.txt b/api/logic/CMakeLists.txt
index bcf4b65a..1827b497 100644
--- a/api/logic/CMakeLists.txt
+++ b/api/logic/CMakeLists.txt
@@ -430,32 +430,32 @@ set(TOOLS_SOURCES
 	tools/MCEditTool.h
 )
 
-set(WONKO_SOURCES
-	# Wonko
-	wonko/tasks/BaseWonkoEntityRemoteLoadTask.cpp
-	wonko/tasks/BaseWonkoEntityRemoteLoadTask.h
-	wonko/tasks/BaseWonkoEntityLocalLoadTask.cpp
-	wonko/tasks/BaseWonkoEntityLocalLoadTask.h
-	wonko/format/WonkoFormatV1.cpp
-	wonko/format/WonkoFormatV1.h
-	wonko/format/WonkoFormat.cpp
-	wonko/format/WonkoFormat.h
-	wonko/BaseWonkoEntity.cpp
-	wonko/BaseWonkoEntity.h
-	wonko/WonkoVersionList.cpp
-	wonko/WonkoVersionList.h
-	wonko/WonkoVersion.cpp
-	wonko/WonkoVersion.h
-	wonko/WonkoIndex.cpp
-	wonko/WonkoIndex.h
-	wonko/WonkoUtil.cpp
-	wonko/WonkoUtil.h
-	wonko/WonkoReference.cpp
-	wonko/WonkoReference.h
+set(META_SOURCES
+	# Metadata sources
+	meta/tasks/RemoteLoadTask.cpp
+	meta/tasks/RemoteLoadTask.h
+	meta/tasks/LocalLoadTask.cpp
+	meta/tasks/LocalLoadTask.h
+	meta/format/FormatV1.cpp
+	meta/format/FormatV1.h
+	meta/format/Format.cpp
+	meta/format/Format.h
+	meta/BaseEntity.cpp
+	meta/BaseEntity.h
+	meta/VersionList.cpp
+	meta/VersionList.h
+	meta/Version.cpp
+	meta/Version.h
+	meta/Index.cpp
+	meta/Index.h
+	meta/Util.cpp
+	meta/Util.h
+	meta/Reference.cpp
+	meta/Reference.h
 )
 
-add_unit_test(WonkoIndex
-	SOURCES wonko/WonkoIndex_test.cpp
+add_unit_test(Index
+	SOURCES meta/Index_test.cpp
 	LIBS MultiMC_logic
 	)
 
@@ -480,7 +480,7 @@ set(LOGIC_SOURCES
 	${JAVA_SOURCES}
 	${TRANSLATIONS_SOURCES}
 	${TOOLS_SOURCES}
-	${WONKO_SOURCES}
+	${META_SOURCES}
 	${ICONS_SOURCES}
 )
 
diff --git a/api/logic/Env.cpp b/api/logic/Env.cpp
index a6341ebd..903f1d8a 100644
--- a/api/logic/Env.cpp
+++ b/api/logic/Env.cpp
@@ -7,7 +7,7 @@
 #include <QNetworkAccessManager>
 #include <QDebug>
 #include "tasks/Task.h"
-#include "wonko/WonkoIndex.h"
+#include "meta/Index.h"
 #include <QDebug>
 
 
@@ -18,8 +18,7 @@ public:
 	shared_qobject_ptr<HttpMetaCache> m_metacache;
 	std::shared_ptr<IIconList> m_iconlist;
 	QMap<QString, std::shared_ptr<BaseVersionList>> m_versionLists;
-	shared_qobject_ptr<WonkoIndex> m_wonkoIndex;
-	QString m_wonkoRootUrl;
+	shared_qobject_ptr<Meta::Index> m_metadataIndex;
 };
 
 static Env * instance;
@@ -99,13 +98,13 @@ void Env::registerVersionList(QString name, std::shared_ptr< BaseVersionList > v
 	d->m_versionLists[name] = vlist;
 }
 
-shared_qobject_ptr<WonkoIndex> Env::wonkoIndex()
+shared_qobject_ptr<Meta::Index> Env::metadataIndex()
 {
-	if (!d->m_wonkoIndex)
+	if (!d->m_metadataIndex)
 	{
-		d->m_wonkoIndex.reset(new WonkoIndex());
+		d->m_metadataIndex.reset(new Meta::Index());
 	}
-	return d->m_wonkoIndex;
+	return d->m_metadataIndex;
 }
 
 
@@ -125,7 +124,7 @@ void Env::initHttpMetaCache()
 	m_metacache->addBase("root", QDir::currentPath());
 	m_metacache->addBase("translations", QDir("translations").absolutePath());
 	m_metacache->addBase("icons", QDir("cache/icons").absolutePath());
-	m_metacache->addBase("wonko", QDir("cache/wonko").absolutePath());
+	m_metacache->addBase("meta", QDir("cache/meta").absolutePath());
 	m_metacache->Load();
 }
 
@@ -191,14 +190,4 @@ void Env::updateProxySettings(QString proxyTypeStr, QString addr, int port, QStr
 	qDebug() << proxyDesc;
 }
 
-QString Env::wonkoRootUrl() const
-{
-	return d->m_wonkoRootUrl;
-}
-
-void Env::setWonkoRootUrl(const QString& url)
-{
-	d->m_wonkoRootUrl = url;
-}
-
-#include "Env.moc"
\ No newline at end of file
+#include "Env.moc"
diff --git a/api/logic/Env.h b/api/logic/Env.h
index c72447ce..75ebe4a0 100644
--- a/api/logic/Env.h
+++ b/api/logic/Env.h
@@ -13,7 +13,11 @@ class QNetworkAccessManager;
 class HttpMetaCache;
 class BaseVersionList;
 class BaseVersion;
-class WonkoIndex;
+
+namespace Meta
+{
+class Index;
+}
 
 #if defined(ENV)
 	#undef ENV
@@ -53,10 +57,7 @@ public:
 
 	void registerIconList(std::shared_ptr<IIconList> iconlist);
 
-	shared_qobject_ptr<WonkoIndex> wonkoIndex();
-
-	QString wonkoRootUrl() const;
-	void setWonkoRootUrl(const QString &url);
+	shared_qobject_ptr<Meta::Index> metadataIndex();
 
 protected:
 	Private * d;
diff --git a/api/logic/wonko/BaseWonkoEntity.cpp b/api/logic/meta/BaseEntity.cpp
similarity index 69%
rename from api/logic/wonko/BaseWonkoEntity.cpp
rename to api/logic/meta/BaseEntity.cpp
index e6a0e41e..fd44e29c 100644
--- a/api/logic/wonko/BaseWonkoEntity.cpp
+++ b/api/logic/meta/BaseEntity.cpp
@@ -13,27 +13,30 @@
  * limitations under the License.
  */
 
-#include "BaseWonkoEntity.h"
+#include "BaseEntity.h"
 
 #include "Json.h"
-#include "WonkoUtil.h"
+#include "Util.h"
 
-BaseWonkoEntity::~BaseWonkoEntity()
+namespace Meta
+{
+BaseEntity::~BaseEntity()
 {
 }
 
-void BaseWonkoEntity::store() const
+void BaseEntity::store() const
 {
-	Json::write(serialized(), Wonko::localWonkoDir().absoluteFilePath(localFilename()));
+	Json::write(serialized(), Meta::localDir().absoluteFilePath(localFilename()));
 }
 
-void BaseWonkoEntity::notifyLocalLoadComplete()
+void BaseEntity::notifyLocalLoadComplete()
 {
 	m_localLoaded = true;
 	store();
 }
-void BaseWonkoEntity::notifyRemoteLoadComplete()
+void BaseEntity::notifyRemoteLoadComplete()
 {
 	m_remoteLoaded = true;
 	store();
 }
+}
diff --git a/api/logic/wonko/BaseWonkoEntity.h b/api/logic/meta/BaseEntity.h
similarity index 86%
rename from api/logic/wonko/BaseWonkoEntity.h
rename to api/logic/meta/BaseEntity.h
index c6e8c832..b7a241c6 100644
--- a/api/logic/wonko/BaseWonkoEntity.h
+++ b/api/logic/meta/BaseEntity.h
@@ -21,17 +21,18 @@
 #include "multimc_logic_export.h"
 
 class Task;
-
-class MULTIMC_LOGIC_EXPORT BaseWonkoEntity
+namespace Meta
+{
+class MULTIMC_LOGIC_EXPORT BaseEntity
 {
 public:
-	virtual ~BaseWonkoEntity();
+	virtual ~BaseEntity();
 
-	using Ptr = std::shared_ptr<BaseWonkoEntity>;
+	using Ptr = std::shared_ptr<BaseEntity>;
 
 	virtual std::unique_ptr<Task> remoteUpdateTask() = 0;
 	virtual std::unique_ptr<Task> localUpdateTask() = 0;
-	virtual void merge(const std::shared_ptr<BaseWonkoEntity> &other) = 0;
+	virtual void merge(const std::shared_ptr<BaseEntity> &other) = 0;
 
 	void store() const;
 	virtual QString localFilename() const = 0;
@@ -49,3 +50,4 @@ private:
 	bool m_localLoaded = false;
 	bool m_remoteLoaded = false;
 };
+}
diff --git a/api/logic/wonko/WonkoIndex.cpp b/api/logic/meta/Index.cpp
similarity index 57%
rename from api/logic/wonko/WonkoIndex.cpp
rename to api/logic/meta/Index.cpp
index f6ad201a..8a6b1355 100644
--- a/api/logic/wonko/WonkoIndex.cpp
+++ b/api/logic/meta/Index.cpp
@@ -13,18 +13,20 @@
  * limitations under the License.
  */
 
-#include "WonkoIndex.h"
+#include "Index.h"
 
-#include "WonkoVersionList.h"
-#include "tasks/BaseWonkoEntityLocalLoadTask.h"
-#include "tasks/BaseWonkoEntityRemoteLoadTask.h"
-#include "format/WonkoFormat.h"
+#include "VersionList.h"
+#include "tasks/LocalLoadTask.h"
+#include "tasks/RemoteLoadTask.h"
+#include "format/Format.h"
 
-WonkoIndex::WonkoIndex(QObject *parent)
+namespace Meta
+{
+Index::Index(QObject *parent)
 	: QAbstractListModel(parent)
 {
 }
-WonkoIndex::WonkoIndex(const QVector<WonkoVersionListPtr> &lists, QObject *parent)
+Index::Index(const QVector<VersionListPtr> &lists, QObject *parent)
 	: QAbstractListModel(parent), m_lists(lists)
 {
 	for (int i = 0; i < m_lists.size(); ++i)
@@ -34,14 +36,14 @@ WonkoIndex::WonkoIndex(const QVector<WonkoVersionListPtr> &lists, QObject *paren
 	}
 }
 
-QVariant WonkoIndex::data(const QModelIndex &index, int role) const
+QVariant Index::data(const QModelIndex &index, int role) const
 {
 	if (index.parent().isValid() || index.row() < 0 || index.row() >= m_lists.size())
 	{
 		return QVariant();
 	}
 
-	WonkoVersionListPtr list = m_lists.at(index.row());
+	VersionListPtr list = m_lists.at(index.row());
 	switch (role)
 	{
 	case Qt::DisplayRole:
@@ -56,15 +58,15 @@ QVariant WonkoIndex::data(const QModelIndex &index, int role) const
 	}
 	return QVariant();
 }
-int WonkoIndex::rowCount(const QModelIndex &parent) const
+int Index::rowCount(const QModelIndex &parent) const
 {
 	return m_lists.size();
 }
-int WonkoIndex::columnCount(const QModelIndex &parent) const
+int Index::columnCount(const QModelIndex &parent) const
 {
 	return 1;
 }
-QVariant WonkoIndex::headerData(int section, Qt::Orientation orientation, int role) const
+QVariant Index::headerData(int section, Qt::Orientation orientation, int role) const
 {
 	if (orientation == Qt::Horizontal && role == Qt::DisplayRole && section == 0)
 	{
@@ -76,36 +78,36 @@ QVariant WonkoIndex::headerData(int section, Qt::Orientation orientation, int ro
 	}
 }
 
-std::unique_ptr<Task> WonkoIndex::remoteUpdateTask()
+std::unique_ptr<Task> Index::remoteUpdateTask()
 {
-	return std::unique_ptr<WonkoIndexRemoteLoadTask>(new WonkoIndexRemoteLoadTask(this, this));
+	return std::unique_ptr<IndexRemoteLoadTask>(new IndexRemoteLoadTask(this, this));
 }
-std::unique_ptr<Task> WonkoIndex::localUpdateTask()
+std::unique_ptr<Task> Index::localUpdateTask()
 {
-	return std::unique_ptr<WonkoIndexLocalLoadTask>(new WonkoIndexLocalLoadTask(this, this));
+	return std::unique_ptr<IndexLocalLoadTask>(new IndexLocalLoadTask(this, this));
 }
 
-QJsonObject WonkoIndex::serialized() const
+QJsonObject Index::serialized() const
 {
-	return WonkoFormat::serializeIndex(this);
+	return Format::serializeIndex(this);
 }
 
-bool WonkoIndex::hasUid(const QString &uid) const
+bool Index::hasUid(const QString &uid) const
 {
 	return m_uids.contains(uid);
 }
-WonkoVersionListPtr WonkoIndex::getList(const QString &uid) const
+VersionListPtr Index::getList(const QString &uid) const
 {
 	return m_uids.value(uid, nullptr);
 }
-WonkoVersionListPtr WonkoIndex::getListGuaranteed(const QString &uid) const
+VersionListPtr Index::getListGuaranteed(const QString &uid) const
 {
-	return m_uids.value(uid, std::make_shared<WonkoVersionList>(uid));
+	return m_uids.value(uid, std::make_shared<VersionList>(uid));
 }
 
-void WonkoIndex::merge(const Ptr &other)
+void Index::merge(const Ptr &other)
 {
-	const QVector<WonkoVersionListPtr> lists = std::dynamic_pointer_cast<WonkoIndex>(other)->m_lists;
+	const QVector<VersionListPtr> lists = std::dynamic_pointer_cast<Index>(other)->m_lists;
 	// initial load, no need to merge
 	if (m_lists.isEmpty())
 	{
@@ -120,7 +122,7 @@ void WonkoIndex::merge(const Ptr &other)
 	}
 	else
 	{
-		for (const WonkoVersionListPtr &list : lists)
+		for (const VersionListPtr &list : lists)
 		{
 			if (m_uids.contains(list->uid()))
 			{
@@ -138,10 +140,11 @@ void WonkoIndex::merge(const Ptr &other)
 	}
 }
 
-void WonkoIndex::connectVersionList(const int row, const WonkoVersionListPtr &list)
+void Index::connectVersionList(const int row, const VersionListPtr &list)
 {
-	connect(list.get(), &WonkoVersionList::nameChanged, this, [this, row]()
+	connect(list.get(), &VersionList::nameChanged, this, [this, row]()
 	{
 		emit dataChanged(index(row), index(row), QVector<int>() << Qt::DisplayRole);
 	});
 }
+}
diff --git a/api/logic/wonko/WonkoIndex.h b/api/logic/meta/Index.h
similarity index 65%
rename from api/logic/wonko/WonkoIndex.h
rename to api/logic/meta/Index.h
index fe07c3ef..16e95d5a 100644
--- a/api/logic/wonko/WonkoIndex.h
+++ b/api/logic/meta/Index.h
@@ -18,19 +18,22 @@
 #include <QAbstractListModel>
 #include <memory>
 
-#include "BaseWonkoEntity.h"
+#include "BaseEntity.h"
 
 #include "multimc_logic_export.h"
 
 class Task;
-using WonkoVersionListPtr = std::shared_ptr<class WonkoVersionList>;
 
-class MULTIMC_LOGIC_EXPORT WonkoIndex : public QAbstractListModel, public BaseWonkoEntity
+namespace Meta
+{
+using VersionListPtr = std::shared_ptr<class VersionList>;
+
+class MULTIMC_LOGIC_EXPORT Index : public QAbstractListModel, public BaseEntity
 {
 	Q_OBJECT
 public:
-	explicit WonkoIndex(QObject *parent = nullptr);
-	explicit WonkoIndex(const QVector<WonkoVersionListPtr> &lists, QObject *parent = nullptr);
+	explicit Index(QObject *parent = nullptr);
+	explicit Index(const QVector<VersionListPtr> &lists, QObject *parent = nullptr);
 
 	enum
 	{
@@ -52,17 +55,18 @@ public:
 
 	// queries
 	bool hasUid(const QString &uid) const;
-	WonkoVersionListPtr getList(const QString &uid) const;
-	WonkoVersionListPtr getListGuaranteed(const QString &uid) const;
+	VersionListPtr getList(const QString &uid) const;
+	VersionListPtr getListGuaranteed(const QString &uid) const;
 
-	QVector<WonkoVersionListPtr> lists() const { return m_lists; }
+	QVector<VersionListPtr> lists() const { return m_lists; }
 
 public: // for usage by parsers only
-	void merge(const BaseWonkoEntity::Ptr &other);
+	void merge(const BaseEntity::Ptr &other) override;
 
 private:
-	QVector<WonkoVersionListPtr> m_lists;
-	QHash<QString, WonkoVersionListPtr> m_uids;
+	QVector<VersionListPtr> m_lists;
+	QHash<QString, VersionListPtr> m_uids;
 
-	void connectVersionList(const int row, const WonkoVersionListPtr &list);
+	void connectVersionList(const int row, const VersionListPtr &list);
 };
+}
diff --git a/api/logic/meta/Index_test.cpp b/api/logic/meta/Index_test.cpp
new file mode 100644
index 00000000..d26700ca
--- /dev/null
+++ b/api/logic/meta/Index_test.cpp
@@ -0,0 +1,50 @@
+#include <QTest>
+#include "TestUtil.h"
+
+#include "meta/Index.h"
+#include "meta/VersionList.h"
+#include "Env.h"
+
+class IndexTest : public QObject
+{
+	Q_OBJECT
+private
+slots:
+	void test_isProvidedByEnv()
+	{
+		QVERIFY(ENV.metadataIndex());
+		QCOMPARE(ENV.metadataIndex(), ENV.metadataIndex());
+	}
+
+	void test_providesTasks()
+	{
+		QVERIFY(ENV.metadataIndex()->localUpdateTask() != nullptr);
+		QVERIFY(ENV.metadataIndex()->remoteUpdateTask() != nullptr);
+	}
+
+	void test_hasUid_and_getList()
+	{
+		Meta::Index windex({std::make_shared<Meta::VersionList>("list1"), std::make_shared<Meta::VersionList>("list2"), std::make_shared<Meta::VersionList>("list3")});
+		QVERIFY(windex.hasUid("list1"));
+		QVERIFY(!windex.hasUid("asdf"));
+		QVERIFY(windex.getList("list2") != nullptr);
+		QCOMPARE(windex.getList("list2")->uid(), QString("list2"));
+		QVERIFY(windex.getList("adsf") == nullptr);
+	}
+
+	void test_merge()
+	{
+		Meta::Index windex({std::make_shared<Meta::VersionList>("list1"), std::make_shared<Meta::VersionList>("list2"), std::make_shared<Meta::VersionList>("list3")});
+		QCOMPARE(windex.lists().size(), 3);
+		windex.merge(std::shared_ptr<Meta::Index>(new Meta::Index({std::make_shared<Meta::VersionList>("list1"), std::make_shared<Meta::VersionList>("list2"), std::make_shared<Meta::VersionList>("list3")})));
+		QCOMPARE(windex.lists().size(), 3);
+		windex.merge(std::shared_ptr<Meta::Index>(new Meta::Index({std::make_shared<Meta::VersionList>("list4"), std::make_shared<Meta::VersionList>("list2"), std::make_shared<Meta::VersionList>("list5")})));
+		QCOMPARE(windex.lists().size(), 5);
+		windex.merge(std::shared_ptr<Meta::Index>(new Meta::Index({std::make_shared<Meta::VersionList>("list6")})));
+		QCOMPARE(windex.lists().size(), 6);
+	}
+};
+
+QTEST_GUILESS_MAIN(IndexTest)
+
+#include "Index_test.moc"
diff --git a/api/logic/wonko/WonkoReference.cpp b/api/logic/meta/Reference.cpp
similarity index 70%
rename from api/logic/wonko/WonkoReference.cpp
rename to api/logic/meta/Reference.cpp
index 7193e56e..c5cef172 100644
--- a/api/logic/wonko/WonkoReference.cpp
+++ b/api/logic/meta/Reference.cpp
@@ -13,32 +13,36 @@
  * limitations under the License.
  */
 
-#include "WonkoReference.h"
+#include "Reference.h"
 
-WonkoReference::WonkoReference(const QString &uid)
+namespace Meta
+{
+Reference::Reference(const QString &uid)
 	: m_uid(uid)
 {
 }
 
-QString WonkoReference::uid() const
+QString Reference::uid() const
 {
 	return m_uid;
 }
 
-QString WonkoReference::version() const
+QString Reference::version() const
 {
 	return m_version;
 }
-void WonkoReference::setVersion(const QString &version)
+void Reference::setVersion(const QString &version)
 {
 	m_version = version;
 }
 
-bool WonkoReference::operator==(const WonkoReference &other) const
+bool Reference::operator==(const Reference &other) const
 {
 	return m_uid == other.m_uid && m_version == other.m_version;
 }
-bool WonkoReference::operator!=(const WonkoReference &other) const
+
+bool Reference::operator!=(const Reference &other) const
 {
 	return m_uid != other.m_uid || m_version != other.m_version;
 }
+}
diff --git a/api/logic/wonko/WonkoReference.h b/api/logic/meta/Reference.h
similarity index 77%
rename from api/logic/wonko/WonkoReference.h
rename to api/logic/meta/Reference.h
index ba7427b3..027076cc 100644
--- a/api/logic/wonko/WonkoReference.h
+++ b/api/logic/meta/Reference.h
@@ -20,22 +20,25 @@
 
 #include "multimc_logic_export.h"
 
-class MULTIMC_LOGIC_EXPORT WonkoReference
+namespace Meta
+{
+class MULTIMC_LOGIC_EXPORT Reference
 {
 public:
-	WonkoReference() {}
-	explicit WonkoReference(const QString &uid);
+	Reference() {}
+	explicit Reference(const QString &uid);
 
 	QString uid() const;
 
 	QString version() const;
 	void setVersion(const QString &version);
 
-	bool operator==(const WonkoReference &other) const;
-	bool operator!=(const WonkoReference &other) const;
+	bool operator==(const Reference &other) const;
+	bool operator!=(const Reference &other) const;
 
 private:
 	QString m_uid;
 	QString m_version;
 };
-Q_DECLARE_METATYPE(WonkoReference)
+}
+Q_DECLARE_METATYPE(Meta::Reference)
diff --git a/api/logic/wonko/WonkoUtil.cpp b/api/logic/meta/Util.cpp
similarity index 89%
rename from api/logic/wonko/WonkoUtil.cpp
rename to api/logic/meta/Util.cpp
index 3b8049c4..2ccbe5c4 100644
--- a/api/logic/wonko/WonkoUtil.cpp
+++ b/api/logic/meta/Util.cpp
@@ -13,35 +13,38 @@
  * limitations under the License.
  */
 
-#include "WonkoUtil.h"
+#include "Util.h"
 
 #include <QUrl>
 #include <QDir>
 
 #include "Env.h"
 
-namespace Wonko
+namespace Meta
 {
 QUrl rootUrl()
 {
-	return ENV.wonkoRootUrl();
+	return QUrl("https://meta.multimc.org");
 }
+
 QUrl indexUrl()
 {
 	return rootUrl().resolved(QStringLiteral("index.json"));
 }
+
 QUrl versionListUrl(const QString &uid)
 {
 	return rootUrl().resolved(uid + ".json");
 }
+
 QUrl versionUrl(const QString &uid, const QString &version)
 {
 	return rootUrl().resolved(uid + "/" + version + ".json");
 }
 
-QDir localWonkoDir()
+QDir localDir()
 {
-	return QDir("wonko");
+	return QDir("meta");
 }
 
 }
diff --git a/api/logic/wonko/WonkoUtil.h b/api/logic/meta/Util.h
similarity index 93%
rename from api/logic/wonko/WonkoUtil.h
rename to api/logic/meta/Util.h
index fb58ba1f..28163fe4 100644
--- a/api/logic/wonko/WonkoUtil.h
+++ b/api/logic/meta/Util.h
@@ -21,11 +21,11 @@ class QUrl;
 class QString;
 class QDir;
 
-namespace Wonko
+namespace Meta
 {
 MULTIMC_LOGIC_EXPORT QUrl rootUrl();
 MULTIMC_LOGIC_EXPORT QUrl indexUrl();
 MULTIMC_LOGIC_EXPORT QUrl versionListUrl(const QString &uid);
 MULTIMC_LOGIC_EXPORT QUrl versionUrl(const QString &uid, const QString &version);
-MULTIMC_LOGIC_EXPORT QDir localWonkoDir();
+MULTIMC_LOGIC_EXPORT QDir localDir();
 }
diff --git a/api/logic/wonko/WonkoVersion.cpp b/api/logic/meta/Version.cpp
similarity index 52%
rename from api/logic/wonko/WonkoVersion.cpp
rename to api/logic/meta/Version.cpp
index f5a063be..039f4fef 100644
--- a/api/logic/wonko/WonkoVersion.cpp
+++ b/api/logic/meta/Version.cpp
@@ -13,49 +13,51 @@
  * limitations under the License.
  */
 
-#include "WonkoVersion.h"
+#include "Version.h"
 
 #include <QDateTime>
 
-#include "tasks/BaseWonkoEntityLocalLoadTask.h"
-#include "tasks/BaseWonkoEntityRemoteLoadTask.h"
-#include "format/WonkoFormat.h"
+#include "tasks/LocalLoadTask.h"
+#include "tasks/RemoteLoadTask.h"
+#include "format/Format.h"
 
-WonkoVersion::WonkoVersion(const QString &uid, const QString &version)
+namespace Meta
+{
+Version::Version(const QString &uid, const QString &version)
 	: BaseVersion(), m_uid(uid), m_version(version)
 {
 }
 
-QString WonkoVersion::descriptor()
+QString Version::descriptor()
 {
 	return m_version;
 }
-QString WonkoVersion::name()
+QString Version::name()
 {
 	return m_version;
 }
-QString WonkoVersion::typeString() const
+QString Version::typeString() const
 {
 	return m_type;
 }
 
-QDateTime WonkoVersion::time() const
+QDateTime Version::time() const
 {
 	return QDateTime::fromMSecsSinceEpoch(m_time * 1000, Qt::UTC);
 }
 
-std::unique_ptr<Task> WonkoVersion::remoteUpdateTask()
+std::unique_ptr<Task> Version::remoteUpdateTask()
 {
-	return std::unique_ptr<WonkoVersionRemoteLoadTask>(new WonkoVersionRemoteLoadTask(this, this));
+	return std::unique_ptr<VersionRemoteLoadTask>(new VersionRemoteLoadTask(this, this));
 }
-std::unique_ptr<Task> WonkoVersion::localUpdateTask()
+std::unique_ptr<Task> Version::localUpdateTask()
 {
-	return std::unique_ptr<WonkoVersionLocalLoadTask>(new WonkoVersionLocalLoadTask(this, this));
+	return std::unique_ptr<VersionLocalLoadTask>(new VersionLocalLoadTask(this, this));
 }
 
-void WonkoVersion::merge(const std::shared_ptr<BaseWonkoEntity> &other)
+void Version::merge(const std::shared_ptr<BaseEntity> &other)
 {
-	WonkoVersionPtr version = std::dynamic_pointer_cast<WonkoVersion>(other);
+	VersionPtr version = std::dynamic_pointer_cast<Version>(other);
 	if (m_type != version->m_type)
 	{
 		setType(version->m_type);
@@ -72,31 +74,32 @@ void WonkoVersion::merge(const std::shared_ptr<BaseWonkoEntity> &other)
 	setData(version->m_data);
 }
 
-QString WonkoVersion::localFilename() const
+QString Version::localFilename() const
 {
 	return m_uid + '/' + m_version + ".json";
 }
-QJsonObject WonkoVersion::serialized() const
+QJsonObject Version::serialized() const
 {
-	return WonkoFormat::serializeVersion(this);
+	return Format::serializeVersion(this);
 }
 
-void WonkoVersion::setType(const QString &type)
+void Version::setType(const QString &type)
 {
 	m_type = type;
 	emit typeChanged();
 }
-void WonkoVersion::setTime(const qint64 time)
+void Version::setTime(const qint64 time)
 {
 	m_time = time;
 	emit timeChanged();
 }
-void WonkoVersion::setRequires(const QVector<WonkoReference> &requires)
+void Version::setRequires(const QVector<Reference> &requires)
 {
 	m_requires = requires;
 	emit requiresChanged();
 }
-void WonkoVersion::setData(const VersionFilePtr &data)
+void Version::setData(const VersionFilePtr &data)
 {
 	m_data = data;
 }
+}
diff --git a/api/logic/wonko/WonkoVersion.h b/api/logic/meta/Version.h
similarity index 74%
rename from api/logic/wonko/WonkoVersion.h
rename to api/logic/meta/Version.h
index 397ff14e..4a791880 100644
--- a/api/logic/wonko/WonkoVersion.h
+++ b/api/logic/meta/Version.h
@@ -16,7 +16,6 @@
 #pragma once
 
 #include "BaseVersion.h"
-#include "BaseWonkoEntity.h"
 
 #include <QVector>
 #include <QStringList>
@@ -24,22 +23,26 @@
 #include <memory>
 
 #include "minecraft/VersionFile.h"
-#include "WonkoReference.h"
+
+#include "BaseEntity.h"
+#include "Reference.h"
 
 #include "multimc_logic_export.h"
 
-using WonkoVersionPtr = std::shared_ptr<class WonkoVersion>;
+namespace Meta
+{
+using VersionPtr = std::shared_ptr<class Version>;
 
-class MULTIMC_LOGIC_EXPORT WonkoVersion : public QObject, public BaseVersion, public BaseWonkoEntity
+class MULTIMC_LOGIC_EXPORT Version : public QObject, public BaseVersion, public BaseEntity
 {
 	Q_OBJECT
 	Q_PROPERTY(QString uid READ uid CONSTANT)
 	Q_PROPERTY(QString version READ version CONSTANT)
 	Q_PROPERTY(QString type READ type NOTIFY typeChanged)
 	Q_PROPERTY(QDateTime time READ time NOTIFY timeChanged)
-	Q_PROPERTY(QVector<WonkoReference> requires READ requires NOTIFY requiresChanged)
+	Q_PROPERTY(QVector<Reference> requires READ requires NOTIFY requiresChanged)
 public:
-	explicit WonkoVersion(const QString &uid, const QString &version);
+	explicit Version(const QString &uid, const QString &version);
 
 	QString descriptor() override;
 	QString name() override;
@@ -50,12 +53,12 @@ public:
 	QString type() const { return m_type; }
 	QDateTime time() const;
 	qint64 rawTime() const { return m_time; }
-	QVector<WonkoReference> requires() const { return m_requires; }
+	QVector<Reference> requires() const { return m_requires; }
 	VersionFilePtr data() const { return m_data; }
 
 	std::unique_ptr<Task> remoteUpdateTask() override;
 	std::unique_ptr<Task> localUpdateTask() override;
-	void merge(const std::shared_ptr<BaseWonkoEntity> &other) override;
+	void merge(const std::shared_ptr<BaseEntity> &other) override;
 
 	QString localFilename() const override;
 	QJsonObject serialized() const override;
@@ -63,7 +66,7 @@ public:
 public: // for usage by format parsers only
 	void setType(const QString &type);
 	void setTime(const qint64 time);
-	void setRequires(const QVector<WonkoReference> &requires);
+	void setRequires(const QVector<Reference> &requires);
 	void setData(const VersionFilePtr &data);
 
 signals:
@@ -76,8 +79,9 @@ private:
 	QString m_version;
 	QString m_type;
 	qint64 m_time;
-	QVector<WonkoReference> m_requires;
+	QVector<Reference> m_requires;
 	VersionFilePtr m_data;
 };
+}
 
-Q_DECLARE_METATYPE(WonkoVersionPtr)
+Q_DECLARE_METATYPE(Meta::VersionPtr)
diff --git a/api/logic/wonko/WonkoVersionList.cpp b/api/logic/meta/VersionList.cpp
similarity index 62%
rename from api/logic/wonko/WonkoVersionList.cpp
rename to api/logic/meta/VersionList.cpp
index 191e00f9..11e20c12 100644
--- a/api/logic/wonko/WonkoVersionList.cpp
+++ b/api/logic/meta/VersionList.cpp
@@ -13,21 +13,24 @@
  * limitations under the License.
  */
 
-#include "WonkoVersionList.h"
+#include "VersionList.h"
 
 #include <QDateTime>
 
-#include "WonkoVersion.h"
-#include "tasks/BaseWonkoEntityRemoteLoadTask.h"
-#include "tasks/BaseWonkoEntityLocalLoadTask.h"
-#include "format/WonkoFormat.h"
-#include "WonkoReference.h"
+#include "Version.h"
+#include "tasks/RemoteLoadTask.h"
+#include "tasks/LocalLoadTask.h"
+#include "format/Format.h"
+#include "Reference.h"
+
+namespace Meta
+{
 
 class WVLLoadTask : public Task
 {
 	Q_OBJECT
 public:
-	explicit WVLLoadTask(WonkoVersionList *list, QObject *parent = nullptr)
+	explicit WVLLoadTask(VersionList *list, QObject *parent = nullptr)
 		: Task(parent), m_list(list)
 	{
 	}
@@ -69,53 +72,53 @@ private:
 		m_currentTask->start();
 	}
 
-	WonkoVersionList *m_list;
+	VersionList *m_list;
 	std::unique_ptr<Task> m_currentTask;
 };
 
-WonkoVersionList::WonkoVersionList(const QString &uid, QObject *parent)
+VersionList::VersionList(const QString &uid, QObject *parent)
 	: BaseVersionList(parent), m_uid(uid)
 {
-	setObjectName("Wonko version list: " + uid);
+	setObjectName("Version list: " + uid);
 }
 
-Task *WonkoVersionList::getLoadTask()
+Task *VersionList::getLoadTask()
 {
 	return new WVLLoadTask(this);
 }
 
-bool WonkoVersionList::isLoaded()
+bool VersionList::isLoaded()
 {
 	return isLocalLoaded() && isRemoteLoaded();
 }
 
-const BaseVersionPtr WonkoVersionList::at(int i) const
+const BaseVersionPtr VersionList::at(int i) const
 {
 	return m_versions.at(i);
 }
-int WonkoVersionList::count() const
+int VersionList::count() const
 {
 	return m_versions.size();
 }
 
-void WonkoVersionList::sortVersions()
+void VersionList::sortVersions()
 {
 	beginResetModel();
-	std::sort(m_versions.begin(), m_versions.end(), [](const WonkoVersionPtr &a, const WonkoVersionPtr &b)
+	std::sort(m_versions.begin(), m_versions.end(), [](const VersionPtr &a, const VersionPtr &b)
 	{
 		return *a.get() < *b.get();
 	});
 	endResetModel();
 }
 
-QVariant WonkoVersionList::data(const QModelIndex &index, int role) const
+QVariant VersionList::data(const QModelIndex &index, int role) const
 {
 	if (!index.isValid() || index.row() < 0 || index.row() >= m_versions.size() || index.parent().isValid())
 	{
 		return QVariant();
 	}
 
-	WonkoVersionPtr version = m_versions.at(index.row());
+	VersionPtr version = m_versions.at(index.row());
 
 	switch (role)
 	{
@@ -127,7 +130,7 @@ QVariant WonkoVersionList::data(const QModelIndex &index, int role) const
 	{
 		const auto end = version->requires().end();
 		const auto it = std::find_if(version->requires().begin(), end,
-									 [](const WonkoReference &ref) { return ref.uid() == "net.minecraft"; });
+									 [](const Reference &ref) { return ref.uid() == "net.minecraft"; });
 		if (it != end)
 		{
 			return (*it).version();
@@ -140,21 +143,21 @@ QVariant WonkoVersionList::data(const QModelIndex &index, int role) const
 	case TimeRole: return version->time();
 	case RequiresRole: return QVariant::fromValue(version->requires());
 	case SortRole: return version->rawTime();
-	case WonkoVersionPtrRole: return QVariant::fromValue(version);
+	case VersionPtrRole: return QVariant::fromValue(version);
 	case RecommendedRole: return version == getRecommended();
 	case LatestRole: return version == getLatestStable();
 	default: return QVariant();
 	}
 }
 
-BaseVersionList::RoleList WonkoVersionList::providesRoles() const
+BaseVersionList::RoleList VersionList::providesRoles() const
 {
 	return {VersionPointerRole, VersionRole, VersionIdRole, ParentGameVersionRole,
 				TypeRole, UidRole, TimeRole, RequiresRole, SortRole,
-				RecommendedRole, LatestRole, WonkoVersionPtrRole};
+				RecommendedRole, LatestRole, VersionPtrRole};
 }
 
-QHash<int, QByteArray> WonkoVersionList::roleNames() const
+QHash<int, QByteArray> VersionList::roleNames() const
 {
 	QHash<int, QByteArray> roles = BaseVersionList::roleNames();
 	roles.insert(UidRole, "uid");
@@ -164,48 +167,48 @@ QHash<int, QByteArray> WonkoVersionList::roleNames() const
 	return roles;
 }
 
-std::unique_ptr<Task> WonkoVersionList::remoteUpdateTask()
+std::unique_ptr<Task> VersionList::remoteUpdateTask()
 {
-	return std::unique_ptr<WonkoVersionListRemoteLoadTask>(new WonkoVersionListRemoteLoadTask(this, this));
+	return std::unique_ptr<VersionListRemoteLoadTask>(new VersionListRemoteLoadTask(this, this));
 }
-std::unique_ptr<Task> WonkoVersionList::localUpdateTask()
+std::unique_ptr<Task> VersionList::localUpdateTask()
 {
-	return std::unique_ptr<WonkoVersionListLocalLoadTask>(new WonkoVersionListLocalLoadTask(this, this));
+	return std::unique_ptr<VersionListLocalLoadTask>(new VersionListLocalLoadTask(this, this));
 }
 
-QString WonkoVersionList::localFilename() const
+QString VersionList::localFilename() const
 {
 	return m_uid + ".json";
 }
-QJsonObject WonkoVersionList::serialized() const
+QJsonObject VersionList::serialized() const
 {
-	return WonkoFormat::serializeVersionList(this);
+	return Format::serializeVersionList(this);
 }
 
-QString WonkoVersionList::humanReadable() const
+QString VersionList::humanReadable() const
 {
 	return m_name.isEmpty() ? m_uid : m_name;
 }
 
-bool WonkoVersionList::hasVersion(const QString &version) const
+bool VersionList::hasVersion(const QString &version) const
 {
 	return m_lookup.contains(version);
 }
-WonkoVersionPtr WonkoVersionList::getVersion(const QString &version) const
+VersionPtr VersionList::getVersion(const QString &version) const
 {
 	return m_lookup.value(version);
 }
 
-void WonkoVersionList::setName(const QString &name)
+void VersionList::setName(const QString &name)
 {
 	m_name = name;
 	emit nameChanged(name);
 }
-void WonkoVersionList::setVersions(const QVector<WonkoVersionPtr> &versions)
+void VersionList::setVersions(const QVector<VersionPtr> &versions)
 {
 	beginResetModel();
 	m_versions = versions;
-	std::sort(m_versions.begin(), m_versions.end(), [](const WonkoVersionPtr &a, const WonkoVersionPtr &b)
+	std::sort(m_versions.begin(), m_versions.end(), [](const VersionPtr &a, const VersionPtr &b)
 	{
 		return a->rawTime() > b->rawTime();
 	});
@@ -216,14 +219,14 @@ void WonkoVersionList::setVersions(const QVector<WonkoVersionPtr> &versions)
 	}
 
 	m_latest = m_versions.isEmpty() ? nullptr : m_versions.first();
-	auto recommendedIt = std::find_if(m_versions.constBegin(), m_versions.constEnd(), [](const WonkoVersionPtr &ptr) { return ptr->type() == "release"; });
+	auto recommendedIt = std::find_if(m_versions.constBegin(), m_versions.constEnd(), [](const VersionPtr &ptr) { return ptr->type() == "release"; });
 	m_recommended = recommendedIt == m_versions.constEnd() ? nullptr : *recommendedIt;
 	endResetModel();
 }
 
-void WonkoVersionList::merge(const BaseWonkoEntity::Ptr &other)
+void VersionList::merge(const BaseEntity::Ptr &other)
 {
-	const WonkoVersionListPtr list = std::dynamic_pointer_cast<WonkoVersionList>(other);
+	const VersionListPtr list = std::dynamic_pointer_cast<VersionList>(other);
 	if (m_name != list->m_name)
 	{
 		setName(list->m_name);
@@ -235,7 +238,7 @@ void WonkoVersionList::merge(const BaseWonkoEntity::Ptr &other)
 	}
 	else
 	{
-		for (const WonkoVersionPtr &version : list->m_versions)
+		for (const VersionPtr &version : list->m_versions)
 		{
 			if (m_lookup.contains(version->version()))
 			{
@@ -264,20 +267,22 @@ void WonkoVersionList::merge(const BaseWonkoEntity::Ptr &other)
 	}
 }
 
-void WonkoVersionList::setupAddedVersion(const int row, const WonkoVersionPtr &version)
+void VersionList::setupAddedVersion(const int row, const VersionPtr &version)
 {
-	connect(version.get(), &WonkoVersion::requiresChanged, this, [this, row]() { emit dataChanged(index(row), index(row), QVector<int>() << RequiresRole); });
-	connect(version.get(), &WonkoVersion::timeChanged, this, [this, row]() { emit dataChanged(index(row), index(row), QVector<int>() << TimeRole << SortRole); });
-	connect(version.get(), &WonkoVersion::typeChanged, this, [this, row]() { emit dataChanged(index(row), index(row), QVector<int>() << TypeRole); });
+	connect(version.get(), &Version::requiresChanged, this, [this, row]() { emit dataChanged(index(row), index(row), QVector<int>() << RequiresRole); });
+	connect(version.get(), &Version::timeChanged, this, [this, row]() { emit dataChanged(index(row), index(row), QVector<int>() << TimeRole << SortRole); });
+	connect(version.get(), &Version::typeChanged, this, [this, row]() { emit dataChanged(index(row), index(row), QVector<int>() << TypeRole); });
 }
 
-BaseVersionPtr WonkoVersionList::getLatestStable() const
+BaseVersionPtr VersionList::getLatestStable() const
 {
 	return m_latest;
 }
-BaseVersionPtr WonkoVersionList::getRecommended() const
+BaseVersionPtr VersionList::getRecommended() const
 {
 	return m_recommended;
 }
 
-#include "WonkoVersionList.moc"
+}
+
+#include "VersionList.moc"
diff --git a/api/logic/wonko/WonkoVersionList.h b/api/logic/meta/VersionList.h
similarity index 67%
rename from api/logic/wonko/WonkoVersionList.h
rename to api/logic/meta/VersionList.h
index 43cf73fc..0eb85bf8 100644
--- a/api/logic/wonko/WonkoVersionList.h
+++ b/api/logic/meta/VersionList.h
@@ -16,26 +16,28 @@
 #pragma once
 
 #include "BaseVersionList.h"
-#include "BaseWonkoEntity.h"
+#include "BaseEntity.h"
 #include <memory>
 
-using WonkoVersionPtr = std::shared_ptr<class WonkoVersion>;
-using WonkoVersionListPtr = std::shared_ptr<class WonkoVersionList>;
+namespace Meta
+{
+using VersionPtr = std::shared_ptr<class Version>;
+using VersionListPtr = std::shared_ptr<class VersionList>;
 
-class MULTIMC_LOGIC_EXPORT WonkoVersionList : public BaseVersionList, public BaseWonkoEntity
+class MULTIMC_LOGIC_EXPORT VersionList : public BaseVersionList, public BaseEntity
 {
 	Q_OBJECT
 	Q_PROPERTY(QString uid READ uid CONSTANT)
 	Q_PROPERTY(QString name READ name NOTIFY nameChanged)
 public:
-	explicit WonkoVersionList(const QString &uid, QObject *parent = nullptr);
+	explicit VersionList(const QString &uid, QObject *parent = nullptr);
 
 	enum Roles
 	{
 		UidRole = Qt::UserRole + 100,
 		TimeRole,
 		RequiresRole,
-		WonkoVersionPtrRole
+		VersionPtrRole
 	};
 
 	Task *getLoadTask() override;
@@ -62,31 +64,32 @@ public:
 	QString humanReadable() const;
 
 	bool hasVersion(const QString &version) const;
-	WonkoVersionPtr getVersion(const QString &version) const;
+	VersionPtr getVersion(const QString &version) const;
 
-	QVector<WonkoVersionPtr> versions() const { return m_versions; }
+	QVector<VersionPtr> versions() const { return m_versions; }
 
 public: // for usage only by parsers
 	void setName(const QString &name);
-	void setVersions(const QVector<WonkoVersionPtr> &versions);
-	void merge(const BaseWonkoEntity::Ptr &other);
+	void setVersions(const QVector<VersionPtr> &versions);
+	void merge(const BaseEntity::Ptr &other) override;
 
 signals:
 	void nameChanged(const QString &name);
 
 protected slots:
-	void updateListData(QList<BaseVersionPtr> versions) override {}
+	void updateListData(QList<BaseVersionPtr>) override {}
 
 private:
-	QVector<WonkoVersionPtr> m_versions;
-	QHash<QString, WonkoVersionPtr> m_lookup;
+	QVector<VersionPtr> m_versions;
+	QHash<QString, VersionPtr> m_lookup;
 	QString m_uid;
 	QString m_name;
 
-	WonkoVersionPtr m_recommended;
-	WonkoVersionPtr m_latest;
+	VersionPtr m_recommended;
+	VersionPtr m_latest;
 
-	void setupAddedVersion(const int row, const WonkoVersionPtr &version);
+	void setupAddedVersion(const int row, const VersionPtr &version);
 };
 
-Q_DECLARE_METATYPE(WonkoVersionListPtr)
+}
+Q_DECLARE_METATYPE(Meta::VersionListPtr)
diff --git a/api/logic/meta/format/Format.cpp b/api/logic/meta/format/Format.cpp
new file mode 100644
index 00000000..a3f9f730
--- /dev/null
+++ b/api/logic/meta/format/Format.cpp
@@ -0,0 +1,84 @@
+/* Copyright 2015-2017 MultiMC Contributors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "Format.h"
+
+#include "FormatV1.h"
+
+#include "meta/Index.h"
+#include "meta/Version.h"
+#include "meta/VersionList.h"
+
+namespace Meta
+{
+
+static int formatVersion(const QJsonObject &obj)
+{
+	if (!obj.contains("formatVersion")) {
+		throw ParseException(QObject::tr("Missing required field: 'formatVersion'"));
+	}
+	if (!obj.value("formatVersion").isDouble()) {
+		throw ParseException(QObject::tr("Required field has invalid type: 'formatVersion'"));
+	}
+	return obj.value("formatVersion").toInt();
+}
+
+void Format::parseIndex(const QJsonObject &obj, Index *ptr)
+{
+	const int version = formatVersion(obj);
+	switch (version) {
+	case 1:
+		ptr->merge(FormatV1().parseIndexInternal(obj));
+		break;
+	default:
+		throw ParseException(QObject::tr("Unknown formatVersion: %1").arg(version));
+	}
+}
+void Format::parseVersion(const QJsonObject &obj, Version *ptr)
+{
+	const int version = formatVersion(obj);
+	switch (version) {
+	case 1:
+		ptr->merge(FormatV1().parseVersionInternal(obj));
+		break;
+	default:
+		throw ParseException(QObject::tr("Unknown formatVersion: %1").arg(version));
+	}
+}
+void Format::parseVersionList(const QJsonObject &obj, VersionList *ptr)
+{
+	const int version = formatVersion(obj);
+	switch (version) {
+	case 10:
+		ptr->merge(FormatV1().parseVersionListInternal(obj));
+		break;
+	default:
+		throw ParseException(QObject::tr("Unknown formatVersion: %1").arg(version));
+	}
+}
+
+QJsonObject Format::serializeIndex(const Index *ptr)
+{
+	return FormatV1().serializeIndexInternal(ptr);
+}
+QJsonObject Format::serializeVersion(const Version *ptr)
+{
+	return FormatV1().serializeVersionInternal(ptr);
+}
+QJsonObject Format::serializeVersionList(const VersionList *ptr)
+{
+	return FormatV1().serializeVersionListInternal(ptr);
+}
+}
diff --git a/api/logic/meta/format/Format.h b/api/logic/meta/format/Format.h
new file mode 100644
index 00000000..79605a6f
--- /dev/null
+++ b/api/logic/meta/format/Format.h
@@ -0,0 +1,57 @@
+/* Copyright 2015-2017 MultiMC Contributors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+
+#include <QJsonObject>
+#include <memory>
+
+#include "Exception.h"
+#include "meta/BaseEntity.h"
+
+namespace Meta
+{
+class Index;
+class Version;
+class VersionList;
+
+class ParseException : public Exception
+{
+public:
+	using Exception::Exception;
+};
+
+class Format
+{
+public:
+	virtual ~Format() {}
+
+	static void parseIndex(const QJsonObject &obj, Index *ptr);
+	static void parseVersion(const QJsonObject &obj, Version *ptr);
+	static void parseVersionList(const QJsonObject &obj, VersionList *ptr);
+
+	static QJsonObject serializeIndex(const Index *ptr);
+	static QJsonObject serializeVersion(const Version *ptr);
+	static QJsonObject serializeVersionList(const VersionList *ptr);
+
+protected:
+	virtual BaseEntity::Ptr parseIndexInternal(const QJsonObject &obj) const = 0;
+	virtual BaseEntity::Ptr parseVersionInternal(const QJsonObject &obj) const = 0;
+	virtual BaseEntity::Ptr parseVersionListInternal(const QJsonObject &obj) const = 0;
+	virtual QJsonObject serializeIndexInternal(const Index *ptr) const = 0;
+	virtual QJsonObject serializeVersionInternal(const Version *ptr) const = 0;
+	virtual QJsonObject serializeVersionListInternal(const VersionList *ptr) const = 0;
+};
+}
diff --git a/api/logic/wonko/format/WonkoFormatV1.cpp b/api/logic/meta/format/FormatV1.cpp
similarity index 69%
rename from api/logic/wonko/format/WonkoFormatV1.cpp
rename to api/logic/meta/format/FormatV1.cpp
index 4cecb42f..23f57100 100644
--- a/api/logic/wonko/format/WonkoFormatV1.cpp
+++ b/api/logic/meta/format/FormatV1.cpp
@@ -13,31 +13,33 @@
  * limitations under the License.
  */
 
-#include "WonkoFormatV1.h"
+#include "FormatV1.h"
 #include <minecraft/onesix/OneSixVersionFormat.h>
 
 #include "Json.h"
 
-#include "wonko/WonkoIndex.h"
-#include "wonko/WonkoVersion.h"
-#include "wonko/WonkoVersionList.h"
+#include "meta/Index.h"
+#include "meta/Version.h"
+#include "meta/VersionList.h"
 #include "Env.h"
 
 using namespace Json;
 
-static WonkoVersionPtr parseCommonVersion(const QString &uid, const QJsonObject &obj)
+namespace Meta
+{
+static VersionPtr parseCommonVersion(const QString &uid, const QJsonObject &obj)
 {
 	const QVector<QJsonObject> requiresRaw = obj.contains("requires") ? requireIsArrayOf<QJsonObject>(obj, "requires") : QVector<QJsonObject>();
-	QVector<WonkoReference> requires;
+	QVector<Reference> requires;
 	requires.reserve(requiresRaw.size());
 	std::transform(requiresRaw.begin(), requiresRaw.end(), std::back_inserter(requires), [](const QJsonObject &rObj)
 	{
-		WonkoReference ref(requireString(rObj, "uid"));
+		Reference ref(requireString(rObj, "uid"));
 		ref.setVersion(ensureString(rObj, "version", QString()));
 		return ref;
 	});
 
-	WonkoVersionPtr version = std::make_shared<WonkoVersion>(uid, requireString(obj, "version"));
+	VersionPtr version = std::make_shared<Version>(uid, requireString(obj, "version"));
 	if (obj.value("time").isString())
 	{
 		version->setTime(QDateTime::fromString(requireString(obj, "time"), Qt::ISODate).toMSecsSinceEpoch() / 1000);
@@ -50,10 +52,10 @@ static WonkoVersionPtr parseCommonVersion(const QString &uid, const QJsonObject
 	version->setRequires(requires);
 	return version;
 }
-static void serializeCommonVersion(const WonkoVersion *version, QJsonObject &obj)
+static void serializeCommonVersion(const Version *version, QJsonObject &obj)
 {
 	QJsonArray requires;
-	for (const WonkoReference &ref : version->requires())
+	for (const Reference &ref : version->requires())
 	{
 		if (ref.version().isEmpty())
 		{
@@ -76,48 +78,48 @@ static void serializeCommonVersion(const WonkoVersion *version, QJsonObject &obj
 	obj.insert("requires", requires);
 }
 
-BaseWonkoEntity::Ptr WonkoFormatV1::parseIndexInternal(const QJsonObject &obj) const
+BaseEntity::Ptr FormatV1::parseIndexInternal(const QJsonObject &obj) const
 {
 	const QVector<QJsonObject> objects = requireIsArrayOf<QJsonObject>(obj, "index");
-	QVector<WonkoVersionListPtr> lists;
+	QVector<VersionListPtr> lists;
 	lists.reserve(objects.size());
 	std::transform(objects.begin(), objects.end(), std::back_inserter(lists), [](const QJsonObject &obj)
 	{
-		WonkoVersionListPtr list = std::make_shared<WonkoVersionList>(requireString(obj, "uid"));
+		VersionListPtr list = std::make_shared<VersionList>(requireString(obj, "uid"));
 		list->setName(ensureString(obj, "name", QString()));
 		return list;
 	});
-	return std::make_shared<WonkoIndex>(lists);
+	return std::make_shared<Index>(lists);
 }
-BaseWonkoEntity::Ptr WonkoFormatV1::parseVersionInternal(const QJsonObject &obj) const
+BaseEntity::Ptr FormatV1::parseVersionInternal(const QJsonObject &obj) const
 {
-	WonkoVersionPtr version = parseCommonVersion(requireString(obj, "uid"), obj);
+	VersionPtr version = parseCommonVersion(requireString(obj, "uid"), obj);
 
 	version->setData(OneSixVersionFormat::versionFileFromJson(QJsonDocument(obj),
 										   QString("%1/%2.json").arg(version->uid(), version->version()),
 										   obj.contains("order")));
 	return version;
 }
-BaseWonkoEntity::Ptr WonkoFormatV1::parseVersionListInternal(const QJsonObject &obj) const
+BaseEntity::Ptr FormatV1::parseVersionListInternal(const QJsonObject &obj) const
 {
 	const QString uid = requireString(obj, "uid");
 
 	const QVector<QJsonObject> versionsRaw = requireIsArrayOf<QJsonObject>(obj, "versions");
-	QVector<WonkoVersionPtr> versions;
+	QVector<VersionPtr> versions;
 	versions.reserve(versionsRaw.size());
 	std::transform(versionsRaw.begin(), versionsRaw.end(), std::back_inserter(versions), [this, uid](const QJsonObject &vObj)
 	{ return parseCommonVersion(uid, vObj); });
 
-	WonkoVersionListPtr list = std::make_shared<WonkoVersionList>(uid);
+	VersionListPtr list = std::make_shared<VersionList>(uid);
 	list->setName(ensureString(obj, "name", QString()));
 	list->setVersions(versions);
 	return list;
 }
 
-QJsonObject WonkoFormatV1::serializeIndexInternal(const WonkoIndex *ptr) const
+QJsonObject FormatV1::serializeIndexInternal(const Index *ptr) const
 {
 	QJsonArray index;
-	for (const WonkoVersionListPtr &list : ptr->lists())
+	for (const VersionListPtr &list : ptr->lists())
 	{
 		QJsonObject out;
 		out["uid"] = list->uid();
@@ -129,21 +131,21 @@ QJsonObject WonkoFormatV1::serializeIndexInternal(const WonkoIndex *ptr) const
 	out["index"] = index;
 	return out;
 }
-QJsonObject WonkoFormatV1::serializeVersionInternal(const WonkoVersion *ptr) const
+QJsonObject FormatV1::serializeVersionInternal(const Version *ptr) const
 {
 	QJsonObject obj = OneSixVersionFormat::versionFileToJson(ptr->data(), true).object();
 	serializeCommonVersion(ptr, obj);
 	obj.insert("formatVersion", 1);
 	obj.insert("uid", ptr->uid());
 	// TODO: the name should be looked up in the UI based on the uid
-	obj.insert("name", ENV.wonkoIndex()->getListGuaranteed(ptr->uid())->name());
+	obj.insert("name", ENV.metadataIndex()->getListGuaranteed(ptr->uid())->name());
 
 	return obj;
 }
-QJsonObject WonkoFormatV1::serializeVersionListInternal(const WonkoVersionList *ptr) const
+QJsonObject FormatV1::serializeVersionListInternal(const VersionList *ptr) const
 {
 	QJsonArray versions;
-	for (const WonkoVersionPtr &version : ptr->versions())
+	for (const VersionPtr &version : ptr->versions())
 	{
 		QJsonObject obj;
 		serializeCommonVersion(version.get(), obj);
@@ -156,3 +158,4 @@ QJsonObject WonkoFormatV1::serializeVersionListInternal(const WonkoVersionList *
 	out["versions"] = versions;
 	return out;
 }
+}
diff --git a/api/logic/wonko/format/WonkoFormatV1.h b/api/logic/meta/format/FormatV1.h
similarity index 53%
rename from api/logic/wonko/format/WonkoFormatV1.h
rename to api/logic/meta/format/FormatV1.h
index 2ae3acd1..ab986083 100644
--- a/api/logic/wonko/format/WonkoFormatV1.h
+++ b/api/logic/meta/format/FormatV1.h
@@ -15,16 +15,19 @@
 
 #pragma once
 
-#include "WonkoFormat.h"
+#include "Format.h"
 
-class WonkoFormatV1 : public WonkoFormat
+namespace Meta
+{
+class FormatV1 : public Format
 {
 public:
-	BaseWonkoEntity::Ptr parseIndexInternal(const QJsonObject &obj) const override;
-	BaseWonkoEntity::Ptr parseVersionInternal(const QJsonObject &obj) const override;
-	BaseWonkoEntity::Ptr parseVersionListInternal(const QJsonObject &obj) const override;
+	BaseEntity::Ptr parseIndexInternal(const QJsonObject &obj) const override;
+	BaseEntity::Ptr parseVersionInternal(const QJsonObject &obj) const override;
+	BaseEntity::Ptr parseVersionListInternal(const QJsonObject &obj) const override;
 
-	QJsonObject serializeIndexInternal(const WonkoIndex *ptr) const override;
-	QJsonObject serializeVersionInternal(const WonkoVersion *ptr) const override;
-	QJsonObject serializeVersionListInternal(const WonkoVersionList *ptr) const override;
+	QJsonObject serializeIndexInternal(const Index *ptr) const override;
+	QJsonObject serializeVersionInternal(const Version *ptr) const override;
+	QJsonObject serializeVersionListInternal(const VersionList *ptr) const override;
 };
+}
diff --git a/api/logic/meta/tasks/LocalLoadTask.cpp b/api/logic/meta/tasks/LocalLoadTask.cpp
new file mode 100644
index 00000000..33ea8016
--- /dev/null
+++ b/api/logic/meta/tasks/LocalLoadTask.cpp
@@ -0,0 +1,123 @@
+/* Copyright 2015-2017 MultiMC Contributors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "LocalLoadTask.h"
+
+#include <QFile>
+
+#include "meta/format/Format.h"
+#include "meta/Util.h"
+#include "meta/Index.h"
+#include "meta/Version.h"
+#include "meta/VersionList.h"
+#include "Env.h"
+#include "Json.h"
+
+namespace Meta
+{
+LocalLoadTask::LocalLoadTask(BaseEntity *entity, QObject *parent)
+	: Task(parent), m_entity(entity)
+{
+}
+
+void LocalLoadTask::executeTask()
+{
+	const QString fname = Meta::localDir().absoluteFilePath(filename());
+	if (!QFile::exists(fname))
+	{
+		emitFailed(tr("File doesn't exist"));
+		return;
+	}
+
+	setStatus(tr("Reading %1...").arg(name()));
+	setProgress(0, 0);
+
+	try
+	{
+		parse(Json::requireObject(Json::requireDocument(fname, name()), name()));
+		m_entity->notifyLocalLoadComplete();
+		emitSucceeded();
+	}
+	catch (Exception &e)
+	{
+		emitFailed(tr("Unable to parse file %1: %2").arg(fname, e.cause()));
+	}
+}
+
+
+// INDEX
+IndexLocalLoadTask::IndexLocalLoadTask(Index *index, QObject *parent)
+	: LocalLoadTask(index, parent)
+{
+}
+QString IndexLocalLoadTask::filename() const
+{
+	return "index.json";
+}
+QString IndexLocalLoadTask::name() const
+{
+	return tr("Metadata Index");
+}
+void IndexLocalLoadTask::parse(const QJsonObject &obj) const
+{
+	Format::parseIndex(obj, dynamic_cast<Index *>(entity()));
+}
+
+
+// VERSION LIST
+VersionListLocalLoadTask::VersionListLocalLoadTask(VersionList *list, QObject *parent)
+	: LocalLoadTask(list, parent)
+{
+}
+QString VersionListLocalLoadTask::filename() const
+{
+	return list()->uid() + ".json";
+}
+QString VersionListLocalLoadTask::name() const
+{
+	return tr("Version List for %1").arg(list()->humanReadable());
+}
+void VersionListLocalLoadTask::parse(const QJsonObject &obj) const
+{
+	Format::parseVersionList(obj, list());
+}
+VersionList *VersionListLocalLoadTask::list() const
+{
+	return dynamic_cast<VersionList *>(entity());
+}
+
+
+// VERSION
+VersionLocalLoadTask::VersionLocalLoadTask(Version *version, QObject *parent)
+	: LocalLoadTask(version, parent)
+{
+}
+QString VersionLocalLoadTask::filename() const
+{
+	return version()->uid() + "/" + version()->version() + ".json";
+}
+QString VersionLocalLoadTask::name() const
+{
+	return tr(" Version for %1").arg(version()->name());
+}
+void VersionLocalLoadTask::parse(const QJsonObject &obj) const
+{
+	Format::parseVersion(obj, version());
+}
+Version *VersionLocalLoadTask::version() const
+{
+	return dynamic_cast<Version *>(entity());
+}
+}
diff --git a/api/logic/wonko/tasks/BaseWonkoEntityLocalLoadTask.h b/api/logic/meta/tasks/LocalLoadTask.h
similarity index 61%
rename from api/logic/wonko/tasks/BaseWonkoEntityLocalLoadTask.h
rename to api/logic/meta/tasks/LocalLoadTask.h
index a4f530c7..36ae1b6f 100644
--- a/api/logic/wonko/tasks/BaseWonkoEntityLocalLoadTask.h
+++ b/api/logic/meta/tasks/LocalLoadTask.h
@@ -18,64 +18,67 @@
 #include "tasks/Task.h"
 #include <memory>
 
-class BaseWonkoEntity;
-class WonkoIndex;
-class WonkoVersionList;
-class WonkoVersion;
+namespace Meta
+{
+class BaseEntity;
+class Index;
+class VersionList;
+class Version;
 
-class BaseWonkoEntityLocalLoadTask : public Task
+class LocalLoadTask : public Task
 {
 	Q_OBJECT
 public:
-	explicit BaseWonkoEntityLocalLoadTask(BaseWonkoEntity *entity, QObject *parent = nullptr);
+	explicit LocalLoadTask(BaseEntity *entity, QObject *parent = nullptr);
 
 protected:
 	virtual QString filename() const = 0;
 	virtual QString name() const = 0;
 	virtual void parse(const QJsonObject &obj) const = 0;
 
-	BaseWonkoEntity *entity() const { return m_entity; }
+	BaseEntity *entity() const { return m_entity; }
 
 private:
 	void executeTask() override;
 
-	BaseWonkoEntity *m_entity;
+	BaseEntity *m_entity;
 };
 
-class WonkoIndexLocalLoadTask : public BaseWonkoEntityLocalLoadTask
+class IndexLocalLoadTask : public LocalLoadTask
 {
 	Q_OBJECT
 public:
-	explicit WonkoIndexLocalLoadTask(WonkoIndex *index, QObject *parent = nullptr);
+	explicit IndexLocalLoadTask(Index *index, QObject *parent = nullptr);
 
 private:
 	QString filename() const override;
 	QString name() const override;
 	void parse(const QJsonObject &obj) const override;
 };
-class WonkoVersionListLocalLoadTask : public BaseWonkoEntityLocalLoadTask
+class VersionListLocalLoadTask : public LocalLoadTask
 {
 	Q_OBJECT
 public:
-	explicit WonkoVersionListLocalLoadTask(WonkoVersionList *list, QObject *parent = nullptr);
+	explicit VersionListLocalLoadTask(VersionList *list, QObject *parent = nullptr);
 
 private:
 	QString filename() const override;
 	QString name() const override;
 	void parse(const QJsonObject &obj) const override;
 
-	WonkoVersionList *list() const;
+	VersionList *list() const;
 };
-class WonkoVersionLocalLoadTask : public BaseWonkoEntityLocalLoadTask
+class VersionLocalLoadTask : public LocalLoadTask
 {
 	Q_OBJECT
 public:
-	explicit WonkoVersionLocalLoadTask(WonkoVersion *version, QObject *parent = nullptr);
+	explicit VersionLocalLoadTask(Version *version, QObject *parent = nullptr);
 
 private:
 	QString filename() const override;
 	QString name() const override;
 	void parse(const QJsonObject &obj) const override;
 
-	WonkoVersion *version() const;
+	Version *version() const;
 };
+}
diff --git a/api/logic/meta/tasks/RemoteLoadTask.cpp b/api/logic/meta/tasks/RemoteLoadTask.cpp
new file mode 100644
index 00000000..69a59c07
--- /dev/null
+++ b/api/logic/meta/tasks/RemoteLoadTask.cpp
@@ -0,0 +1,132 @@
+/* Copyright 2015-2017 MultiMC Contributors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "RemoteLoadTask.h"
+
+#include "net/Download.h"
+#include "net/HttpMetaCache.h"
+#include "net/NetJob.h"
+#include "meta/format/Format.h"
+#include "meta/Util.h"
+#include "meta/Index.h"
+#include "meta/Version.h"
+#include "meta/VersionList.h"
+#include "Env.h"
+#include "Json.h"
+
+namespace Meta
+{
+
+RemoteLoadTask::RemoteLoadTask(BaseEntity *entity, QObject *parent)
+	: Task(parent), m_entity(entity)
+{
+}
+
+void RemoteLoadTask::executeTask()
+{
+	NetJob *job = new NetJob(name());
+
+	auto entry = ENV.metacache()->resolveEntry("meta", url().toString());
+	entry->setStale(true);
+	m_dl = Net::Download::makeCached(url(), entry);
+	job->addNetAction(m_dl);
+	connect(job, &NetJob::failed, this, &RemoteLoadTask::emitFailed);
+	connect(job, &NetJob::succeeded, this, &RemoteLoadTask::networkFinished);
+	connect(job, &NetJob::status, this, &RemoteLoadTask::setStatus);
+	connect(job, &NetJob::progress, this, &RemoteLoadTask::setProgress);
+	job->start();
+}
+
+void RemoteLoadTask::networkFinished()
+{
+	setStatus(tr("Parsing..."));
+	setProgress(0, 0);
+
+	try
+	{
+		parse(Json::requireObject(Json::requireDocument(m_dl->getTargetFilepath(), name()), name()));
+		m_entity->notifyRemoteLoadComplete();
+		emitSucceeded();
+	}
+	catch (Exception &e)
+	{
+		emitFailed(tr("Unable to parse response: %1").arg(e.cause()));
+	}
+}
+
+// INDEX
+IndexRemoteLoadTask::IndexRemoteLoadTask(Index *index, QObject *parent)
+	: RemoteLoadTask(index, parent)
+{
+}
+QUrl IndexRemoteLoadTask::url() const
+{
+	return Meta::indexUrl();
+}
+QString IndexRemoteLoadTask::name() const
+{
+	return tr("Metadata Index");
+}
+void IndexRemoteLoadTask::parse(const QJsonObject &obj) const
+{
+	Format::parseIndex(obj, dynamic_cast<Index *>(entity()));
+}
+
+
+// VERSION LIST
+VersionListRemoteLoadTask::VersionListRemoteLoadTask(VersionList *list, QObject *parent)
+	: RemoteLoadTask(list, parent)
+{
+}
+QUrl VersionListRemoteLoadTask::url() const
+{
+	return Meta::versionListUrl(list()->uid());
+}
+QString VersionListRemoteLoadTask::name() const
+{
+	return tr("Version List for %1").arg(list()->humanReadable());
+}
+void VersionListRemoteLoadTask::parse(const QJsonObject &obj) const
+{
+	Format::parseVersionList(obj, list());
+}
+VersionList* Meta::VersionListRemoteLoadTask::list() const
+{
+	return dynamic_cast<VersionList *>(entity());
+}
+
+
+// VERSION
+VersionRemoteLoadTask::VersionRemoteLoadTask(Version *version, QObject *parent)
+	: RemoteLoadTask(version, parent)
+{
+}
+QUrl VersionRemoteLoadTask::url() const
+{
+	return Meta::versionUrl(version()->uid(), version()->version());
+}
+QString VersionRemoteLoadTask::name() const
+{
+	return tr("Meta Version for %1").arg(version()->name());
+}
+void VersionRemoteLoadTask::parse(const QJsonObject &obj) const
+{
+	Format::parseVersion(obj, version());
+}
+Version *VersionRemoteLoadTask::version() const
+{
+	return dynamic_cast<Version *>(entity());
+}
+}
diff --git a/api/logic/wonko/tasks/BaseWonkoEntityRemoteLoadTask.h b/api/logic/meta/tasks/RemoteLoadTask.h
similarity index 61%
rename from api/logic/wonko/tasks/BaseWonkoEntityRemoteLoadTask.h
rename to api/logic/meta/tasks/RemoteLoadTask.h
index 0eab089a..3b09404f 100644
--- a/api/logic/wonko/tasks/BaseWonkoEntityRemoteLoadTask.h
+++ b/api/logic/meta/tasks/RemoteLoadTask.h
@@ -20,26 +20,28 @@
 
 namespace Net
 {
-	class Download;
+class Download;
 }
 
-class BaseWonkoEntity;
-class WonkoIndex;
-class WonkoVersionList;
-class WonkoVersion;
+namespace Meta
+{
+class BaseEntity;
+class Index;
+class VersionList;
+class Version;
 
-class BaseWonkoEntityRemoteLoadTask : public Task
+class RemoteLoadTask : public Task
 {
 	Q_OBJECT
 public:
-	explicit BaseWonkoEntityRemoteLoadTask(BaseWonkoEntity *entity, QObject *parent = nullptr);
+	explicit RemoteLoadTask(BaseEntity *entity, QObject *parent = nullptr);
 
 protected:
 	virtual QUrl url() const = 0;
 	virtual QString name() const = 0;
 	virtual void parse(const QJsonObject &obj) const = 0;
 
-	BaseWonkoEntity *entity() const { return m_entity; }
+	BaseEntity *entity() const { return m_entity; }
 
 private slots:
 	void networkFinished();
@@ -47,44 +49,47 @@ private slots:
 private:
 	void executeTask() override;
 
-	BaseWonkoEntity *m_entity;
+	BaseEntity *m_entity;
 	std::shared_ptr<Net::Download> m_dl;
 };
 
-class WonkoIndexRemoteLoadTask : public BaseWonkoEntityRemoteLoadTask
+class IndexRemoteLoadTask : public RemoteLoadTask
 {
 	Q_OBJECT
 public:
-	explicit WonkoIndexRemoteLoadTask(WonkoIndex *index, QObject *parent = nullptr);
+	explicit IndexRemoteLoadTask(Index *index, QObject *parent = nullptr);
 
 private:
 	QUrl url() const override;
 	QString name() const override;
 	void parse(const QJsonObject &obj) const override;
 };
-class WonkoVersionListRemoteLoadTask : public BaseWonkoEntityRemoteLoadTask
+
+class VersionListRemoteLoadTask : public RemoteLoadTask
 {
 	Q_OBJECT
 public:
-	explicit WonkoVersionListRemoteLoadTask(WonkoVersionList *list, QObject *parent = nullptr);
+	explicit VersionListRemoteLoadTask(VersionList *list, QObject *parent = nullptr);
 
 private:
 	QUrl url() const override;
 	QString name() const override;
 	void parse(const QJsonObject &obj) const override;
 
-	WonkoVersionList *list() const;
+	VersionList *list() const;
 };
-class WonkoVersionRemoteLoadTask : public BaseWonkoEntityRemoteLoadTask
+
+class VersionRemoteLoadTask : public RemoteLoadTask
 {
 	Q_OBJECT
 public:
-	explicit WonkoVersionRemoteLoadTask(WonkoVersion *version, QObject *parent = nullptr);
+	explicit VersionRemoteLoadTask(Version *version, QObject *parent = nullptr);
 
 private:
 	QUrl url() const override;
 	QString name() const override;
 	void parse(const QJsonObject &obj) const override;
 
-	WonkoVersion *version() const;
+	Version *version() const;
 };
+}
diff --git a/api/logic/wonko/WonkoIndex_test.cpp b/api/logic/wonko/WonkoIndex_test.cpp
deleted file mode 100644
index d7b92f21..00000000
--- a/api/logic/wonko/WonkoIndex_test.cpp
+++ /dev/null
@@ -1,50 +0,0 @@
-#include <QTest>
-#include "TestUtil.h"
-
-#include "wonko/WonkoIndex.h"
-#include "wonko/WonkoVersionList.h"
-#include "Env.h"
-
-class WonkoIndexTest : public QObject
-{
-	Q_OBJECT
-private
-slots:
-	void test_isProvidedByEnv()
-	{
-		QVERIFY(ENV.wonkoIndex());
-		QCOMPARE(ENV.wonkoIndex(), ENV.wonkoIndex());
-	}
-
-	void test_providesTasks()
-	{
-		QVERIFY(ENV.wonkoIndex()->localUpdateTask() != nullptr);
-		QVERIFY(ENV.wonkoIndex()->remoteUpdateTask() != nullptr);
-	}
-
-	void test_hasUid_and_getList()
-	{
-		WonkoIndex windex({std::make_shared<WonkoVersionList>("list1"), std::make_shared<WonkoVersionList>("list2"), std::make_shared<WonkoVersionList>("list3")});
-		QVERIFY(windex.hasUid("list1"));
-		QVERIFY(!windex.hasUid("asdf"));
-		QVERIFY(windex.getList("list2") != nullptr);
-		QCOMPARE(windex.getList("list2")->uid(), QString("list2"));
-		QVERIFY(windex.getList("adsf") == nullptr);
-	}
-
-	void test_merge()
-	{
-		WonkoIndex windex({std::make_shared<WonkoVersionList>("list1"), std::make_shared<WonkoVersionList>("list2"), std::make_shared<WonkoVersionList>("list3")});
-		QCOMPARE(windex.lists().size(), 3);
-		windex.merge(std::shared_ptr<WonkoIndex>(new WonkoIndex({std::make_shared<WonkoVersionList>("list1"), std::make_shared<WonkoVersionList>("list2"), std::make_shared<WonkoVersionList>("list3")})));
-		QCOMPARE(windex.lists().size(), 3);
-		windex.merge(std::shared_ptr<WonkoIndex>(new WonkoIndex({std::make_shared<WonkoVersionList>("list4"), std::make_shared<WonkoVersionList>("list2"), std::make_shared<WonkoVersionList>("list5")})));
-		QCOMPARE(windex.lists().size(), 5);
-		windex.merge(std::shared_ptr<WonkoIndex>(new WonkoIndex({std::make_shared<WonkoVersionList>("list6")})));
-		QCOMPARE(windex.lists().size(), 6);
-	}
-};
-
-QTEST_GUILESS_MAIN(WonkoIndexTest)
-
-#include "WonkoIndex_test.moc"
diff --git a/api/logic/wonko/format/WonkoFormat.cpp b/api/logic/wonko/format/WonkoFormat.cpp
deleted file mode 100644
index a5d593ca..00000000
--- a/api/logic/wonko/format/WonkoFormat.cpp
+++ /dev/null
@@ -1,80 +0,0 @@
-/* Copyright 2015-2017 MultiMC Contributors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#include "WonkoFormat.h"
-
-#include "WonkoFormatV1.h"
-
-#include "wonko/WonkoIndex.h"
-#include "wonko/WonkoVersion.h"
-#include "wonko/WonkoVersionList.h"
-
-static int formatVersion(const QJsonObject &obj)
-{
-	if (!obj.contains("formatVersion")) {
-		throw WonkoParseException(QObject::tr("Missing required field: 'formatVersion'"));
-	}
-	if (!obj.value("formatVersion").isDouble()) {
-		throw WonkoParseException(QObject::tr("Required field has invalid type: 'formatVersion'"));
-	}
-	return obj.value("formatVersion").toInt();
-}
-
-void WonkoFormat::parseIndex(const QJsonObject &obj, WonkoIndex *ptr)
-{
-	const int version = formatVersion(obj);
-	switch (version) {
-	case 1:
-		ptr->merge(WonkoFormatV1().parseIndexInternal(obj));
-		break;
-	default:
-		throw WonkoParseException(QObject::tr("Unknown formatVersion: %1").arg(version));
-	}
-}
-void WonkoFormat::parseVersion(const QJsonObject &obj, WonkoVersion *ptr)
-{
-	const int version = formatVersion(obj);
-	switch (version) {
-	case 1:
-		ptr->merge(WonkoFormatV1().parseVersionInternal(obj));
-		break;
-	default:
-		throw WonkoParseException(QObject::tr("Unknown formatVersion: %1").arg(version));
-	}
-}
-void WonkoFormat::parseVersionList(const QJsonObject &obj, WonkoVersionList *ptr)
-{
-	const int version = formatVersion(obj);
-	switch (version) {
-	case 10:
-		ptr->merge(WonkoFormatV1().parseVersionListInternal(obj));
-		break;
-	default:
-		throw WonkoParseException(QObject::tr("Unknown formatVersion: %1").arg(version));
-	}
-}
-
-QJsonObject WonkoFormat::serializeIndex(const WonkoIndex *ptr)
-{
-	return WonkoFormatV1().serializeIndexInternal(ptr);
-}
-QJsonObject WonkoFormat::serializeVersion(const WonkoVersion *ptr)
-{
-	return WonkoFormatV1().serializeVersionInternal(ptr);
-}
-QJsonObject WonkoFormat::serializeVersionList(const WonkoVersionList *ptr)
-{
-	return WonkoFormatV1().serializeVersionListInternal(ptr);
-}
diff --git a/api/logic/wonko/format/WonkoFormat.h b/api/logic/wonko/format/WonkoFormat.h
deleted file mode 100644
index 63ea9473..00000000
--- a/api/logic/wonko/format/WonkoFormat.h
+++ /dev/null
@@ -1,54 +0,0 @@
-/* Copyright 2015-2017 MultiMC Contributors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#pragma once
-
-#include <QJsonObject>
-#include <memory>
-
-#include "Exception.h"
-#include "wonko/BaseWonkoEntity.h"
-
-class WonkoIndex;
-class WonkoVersion;
-class WonkoVersionList;
-
-class WonkoParseException : public Exception
-{
-public:
-	using Exception::Exception;
-};
-
-class WonkoFormat
-{
-public:
-	virtual ~WonkoFormat() {}
-
-	static void parseIndex(const QJsonObject &obj, WonkoIndex *ptr);
-	static void parseVersion(const QJsonObject &obj, WonkoVersion *ptr);
-	static void parseVersionList(const QJsonObject &obj, WonkoVersionList *ptr);
-
-	static QJsonObject serializeIndex(const WonkoIndex *ptr);
-	static QJsonObject serializeVersion(const WonkoVersion *ptr);
-	static QJsonObject serializeVersionList(const WonkoVersionList *ptr);
-
-protected:
-	virtual BaseWonkoEntity::Ptr parseIndexInternal(const QJsonObject &obj) const = 0;
-	virtual BaseWonkoEntity::Ptr parseVersionInternal(const QJsonObject &obj) const = 0;
-	virtual BaseWonkoEntity::Ptr parseVersionListInternal(const QJsonObject &obj) const = 0;
-	virtual QJsonObject serializeIndexInternal(const WonkoIndex *ptr) const = 0;
-	virtual QJsonObject serializeVersionInternal(const WonkoVersion *ptr) const = 0;
-	virtual QJsonObject serializeVersionListInternal(const WonkoVersionList *ptr) const = 0;
-};
diff --git a/api/logic/wonko/tasks/BaseWonkoEntityLocalLoadTask.cpp b/api/logic/wonko/tasks/BaseWonkoEntityLocalLoadTask.cpp
deleted file mode 100644
index caffa744..00000000
--- a/api/logic/wonko/tasks/BaseWonkoEntityLocalLoadTask.cpp
+++ /dev/null
@@ -1,117 +0,0 @@
-/* Copyright 2015-2017 MultiMC Contributors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#include "BaseWonkoEntityLocalLoadTask.h"
-
-#include <QFile>
-
-#include "wonko/format/WonkoFormat.h"
-#include "wonko/WonkoUtil.h"
-#include "wonko/WonkoIndex.h"
-#include "wonko/WonkoVersion.h"
-#include "wonko/WonkoVersionList.h"
-#include "Env.h"
-#include "Json.h"
-
-BaseWonkoEntityLocalLoadTask::BaseWonkoEntityLocalLoadTask(BaseWonkoEntity *entity, QObject *parent)
-	: Task(parent), m_entity(entity)
-{
-}
-
-void BaseWonkoEntityLocalLoadTask::executeTask()
-{
-	const QString fname = Wonko::localWonkoDir().absoluteFilePath(filename());
-	if (!QFile::exists(fname))
-	{
-		emitFailed(tr("File doesn't exist"));
-		return;
-	}
-
-	setStatus(tr("Reading %1...").arg(name()));
-	setProgress(0, 0);
-
-	try
-	{
-		parse(Json::requireObject(Json::requireDocument(fname, name()), name()));
-		m_entity->notifyLocalLoadComplete();
-		emitSucceeded();
-	}
-	catch (Exception &e)
-	{
-		emitFailed(tr("Unable to parse file %1: %2").arg(fname, e.cause()));
-	}
-}
-
-//      WONKO INDEX      //
-WonkoIndexLocalLoadTask::WonkoIndexLocalLoadTask(WonkoIndex *index, QObject *parent)
-	: BaseWonkoEntityLocalLoadTask(index, parent)
-{
-}
-QString WonkoIndexLocalLoadTask::filename() const
-{
-	return "index.json";
-}
-QString WonkoIndexLocalLoadTask::name() const
-{
-	return tr("Wonko Index");
-}
-void WonkoIndexLocalLoadTask::parse(const QJsonObject &obj) const
-{
-	WonkoFormat::parseIndex(obj, dynamic_cast<WonkoIndex *>(entity()));
-}
-
-//      WONKO VERSION LIST      //
-WonkoVersionListLocalLoadTask::WonkoVersionListLocalLoadTask(WonkoVersionList *list, QObject *parent)
-	: BaseWonkoEntityLocalLoadTask(list, parent)
-{
-}
-QString WonkoVersionListLocalLoadTask::filename() const
-{
-	return list()->uid() + ".json";
-}
-QString WonkoVersionListLocalLoadTask::name() const
-{
-	return tr("Wonko Version List for %1").arg(list()->humanReadable());
-}
-void WonkoVersionListLocalLoadTask::parse(const QJsonObject &obj) const
-{
-	WonkoFormat::parseVersionList(obj, list());
-}
-WonkoVersionList *WonkoVersionListLocalLoadTask::list() const
-{
-	return dynamic_cast<WonkoVersionList *>(entity());
-}
-
-//      WONKO VERSION      //
-WonkoVersionLocalLoadTask::WonkoVersionLocalLoadTask(WonkoVersion *version, QObject *parent)
-	: BaseWonkoEntityLocalLoadTask(version, parent)
-{
-}
-QString WonkoVersionLocalLoadTask::filename() const
-{
-	return version()->uid() + "/" + version()->version() + ".json";
-}
-QString WonkoVersionLocalLoadTask::name() const
-{
-	return tr("Wonko Version for %1").arg(version()->name());
-}
-void WonkoVersionLocalLoadTask::parse(const QJsonObject &obj) const
-{
-	WonkoFormat::parseVersion(obj, version());
-}
-WonkoVersion *WonkoVersionLocalLoadTask::version() const
-{
-	return dynamic_cast<WonkoVersion *>(entity());
-}
diff --git a/api/logic/wonko/tasks/BaseWonkoEntityRemoteLoadTask.cpp b/api/logic/wonko/tasks/BaseWonkoEntityRemoteLoadTask.cpp
deleted file mode 100644
index 999d245b..00000000
--- a/api/logic/wonko/tasks/BaseWonkoEntityRemoteLoadTask.cpp
+++ /dev/null
@@ -1,126 +0,0 @@
-/* Copyright 2015-2017 MultiMC Contributors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#include "BaseWonkoEntityRemoteLoadTask.h"
-
-#include "net/Download.h"
-#include "net/HttpMetaCache.h"
-#include "net/NetJob.h"
-#include "wonko/format/WonkoFormat.h"
-#include "wonko/WonkoUtil.h"
-#include "wonko/WonkoIndex.h"
-#include "wonko/WonkoVersion.h"
-#include "wonko/WonkoVersionList.h"
-#include "Env.h"
-#include "Json.h"
-
-BaseWonkoEntityRemoteLoadTask::BaseWonkoEntityRemoteLoadTask(BaseWonkoEntity *entity, QObject *parent)
-	: Task(parent), m_entity(entity)
-{
-}
-
-void BaseWonkoEntityRemoteLoadTask::executeTask()
-{
-	NetJob *job = new NetJob(name());
-
-	auto entry = ENV.metacache()->resolveEntry("wonko", url().toString());
-	entry->setStale(true);
-	m_dl = Net::Download::makeCached(url(), entry);
-	job->addNetAction(m_dl);
-	connect(job, &NetJob::failed, this, &BaseWonkoEntityRemoteLoadTask::emitFailed);
-	connect(job, &NetJob::succeeded, this, &BaseWonkoEntityRemoteLoadTask::networkFinished);
-	connect(job, &NetJob::status, this, &BaseWonkoEntityRemoteLoadTask::setStatus);
-	connect(job, &NetJob::progress, this, &BaseWonkoEntityRemoteLoadTask::setProgress);
-	job->start();
-}
-
-void BaseWonkoEntityRemoteLoadTask::networkFinished()
-{
-	setStatus(tr("Parsing..."));
-	setProgress(0, 0);
-
-	try
-	{
-		parse(Json::requireObject(Json::requireDocument(m_dl->getTargetFilepath(), name()), name()));
-		m_entity->notifyRemoteLoadComplete();
-		emitSucceeded();
-	}
-	catch (Exception &e)
-	{
-		emitFailed(tr("Unable to parse response: %1").arg(e.cause()));
-	}
-}
-
-//      WONKO INDEX      //
-WonkoIndexRemoteLoadTask::WonkoIndexRemoteLoadTask(WonkoIndex *index, QObject *parent)
-	: BaseWonkoEntityRemoteLoadTask(index, parent)
-{
-}
-QUrl WonkoIndexRemoteLoadTask::url() const
-{
-	return Wonko::indexUrl();
-}
-QString WonkoIndexRemoteLoadTask::name() const
-{
-	return tr("Wonko Index");
-}
-void WonkoIndexRemoteLoadTask::parse(const QJsonObject &obj) const
-{
-	WonkoFormat::parseIndex(obj, dynamic_cast<WonkoIndex *>(entity()));
-}
-
-//      WONKO VERSION LIST      //
-WonkoVersionListRemoteLoadTask::WonkoVersionListRemoteLoadTask(WonkoVersionList *list, QObject *parent)
-	: BaseWonkoEntityRemoteLoadTask(list, parent)
-{
-}
-QUrl WonkoVersionListRemoteLoadTask::url() const
-{
-	return Wonko::versionListUrl(list()->uid());
-}
-QString WonkoVersionListRemoteLoadTask::name() const
-{
-	return tr("Wonko Version List for %1").arg(list()->humanReadable());
-}
-void WonkoVersionListRemoteLoadTask::parse(const QJsonObject &obj) const
-{
-	WonkoFormat::parseVersionList(obj, list());
-}
-WonkoVersionList *WonkoVersionListRemoteLoadTask::list() const
-{
-	return dynamic_cast<WonkoVersionList *>(entity());
-}
-
-//      WONKO VERSION      //
-WonkoVersionRemoteLoadTask::WonkoVersionRemoteLoadTask(WonkoVersion *version, QObject *parent)
-	: BaseWonkoEntityRemoteLoadTask(version, parent)
-{
-}
-QUrl WonkoVersionRemoteLoadTask::url() const
-{
-	return Wonko::versionUrl(version()->uid(), version()->version());
-}
-QString WonkoVersionRemoteLoadTask::name() const
-{
-	return tr("Wonko Version for %1").arg(version()->name());
-}
-void WonkoVersionRemoteLoadTask::parse(const QJsonObject &obj) const
-{
-	WonkoFormat::parseVersion(obj, version());
-}
-WonkoVersion *WonkoVersionRemoteLoadTask::version() const
-{
-	return dynamic_cast<WonkoVersion *>(entity());
-}
diff --git a/application/BuildConfig.cpp.in b/application/BuildConfig.cpp.in
index 70bc93d3..99551867 100644
--- a/application/BuildConfig.cpp.in
+++ b/application/BuildConfig.cpp.in
@@ -33,7 +33,6 @@ Config::Config()
 	VERSION_STR = "@MultiMC_VERSION_STRING@";
 	NEWS_RSS_URL = "@MultiMC_NEWS_RSS_URL@";
 	PASTE_EE_KEY = "@MultiMC_PASTE_EE_API_KEY@";
-	WONKO_ROOT_URL = "@MultiMC_WONKO_ROOT_URL@";
 }
 
 QString Config::printableVersionString() const
diff --git a/application/BuildConfig.h b/application/BuildConfig.h
index 75109b1c..1c9466ba 100644
--- a/application/BuildConfig.h
+++ b/application/BuildConfig.h
@@ -60,11 +60,6 @@ public:
 	 */
 	QString PASTE_EE_KEY;
 
-	/**
-	 * Root URL for wonko things. Other wonko URLs will be resolved relative to this.
-	 */
-	QString WONKO_ROOT_URL;
-
 	/**
 	 * \brief Converts the Version to a string.
 	 * \return The version number in string format (major.minor.revision.build).
diff --git a/application/CMakeLists.txt b/application/CMakeLists.txt
index 90fa1aca..55457b1c 100644
--- a/application/CMakeLists.txt
+++ b/application/CMakeLists.txt
@@ -30,9 +30,6 @@ set(MultiMC_ANALYTICS_ID "" CACHE STRING "ID you can get from Google analytics")
 include(GetGitRevisionDescription)
 get_git_head_revision(MultiMC_GIT_REFSPEC MultiMC_GIT_COMMIT)
 
-# Root URL for wonko files
-set(MultiMC_WONKO_ROOT_URL "" CACHE STRING "Root URL for wonko stuff")
-
 message(STATUS "Git commit: ${MultiMC_GIT_COMMIT}")
 message(STATUS "Git refspec: ${MultiMC_GIT_REFSPEC}")
 
@@ -99,8 +96,6 @@ SET(MULTIMC_SOURCES
 	VersionProxyModel.cpp
 	ColorCache.h
 	ColorCache.cpp
-	WonkoGui.h
-	WonkoGui.cpp
 
 	# GUI - windows
 	MainWindow.h
@@ -189,8 +184,8 @@ SET(MULTIMC_SOURCES
 	pages/global/ProxyPage.h
 	pages/global/PasteEEPage.cpp
 	pages/global/PasteEEPage.h
-	pages/global/WonkoPage.cpp
-	pages/global/WonkoPage.h
+	pages/global/MetadataPage.cpp
+	pages/global/MetadataPage.h
 
 	# GUI - dialogs
 	dialogs/AboutDialog.cpp
@@ -289,7 +284,7 @@ SET(MULTIMC_UIS
 	pages/global/MultiMCPage.ui
 	pages/global/ProxyPage.ui
 	pages/global/PasteEEPage.ui
-	pages/global/WonkoPage.ui
+	pages/global/MetadataPage.ui
 
 	# Dialogs
 	dialogs/CopyInstanceDialog.ui
diff --git a/application/WonkoGui.cpp b/application/WonkoGui.cpp
deleted file mode 100644
index 4d376fdc..00000000
--- a/application/WonkoGui.cpp
+++ /dev/null
@@ -1,74 +0,0 @@
-#include "WonkoGui.h"
-
-#include "dialogs/ProgressDialog.h"
-#include "wonko/WonkoIndex.h"
-#include "wonko/WonkoVersionList.h"
-#include "wonko/WonkoVersion.h"
-#include "Env.h"
-
-WonkoIndexPtr Wonko::ensureIndexLoaded(QWidget *parent)
-{
-	if (!ENV.wonkoIndex()->isLocalLoaded())
-	{
-		ProgressDialog(parent).execWithTask(ENV.wonkoIndex()->localUpdateTask());
-		if (!ENV.wonkoIndex()->isRemoteLoaded() && ENV.wonkoIndex()->lists().size() == 0)
-		{
-			ProgressDialog(parent).execWithTask(ENV.wonkoIndex()->remoteUpdateTask());
-		}
-	}
-	return ENV.wonkoIndex();
-}
-
-WonkoVersionListPtr Wonko::ensureVersionListExists(const QString &uid, QWidget *parent)
-{
-	ensureIndexLoaded(parent);
-	if (!ENV.wonkoIndex()->isRemoteLoaded() && !ENV.wonkoIndex()->hasUid(uid))
-	{
-		ProgressDialog(parent).execWithTask(ENV.wonkoIndex()->remoteUpdateTask());
-	}
-	return ENV.wonkoIndex()->getList(uid);
-}
-WonkoVersionListPtr Wonko::ensureVersionListLoaded(const QString &uid, QWidget *parent)
-{
-	WonkoVersionListPtr list = ensureVersionListExists(uid, parent);
-	if (!list)
-	{
-		return nullptr;
-	}
-	if (!list->isLocalLoaded())
-	{
-		ProgressDialog(parent).execWithTask(list->localUpdateTask());
-		if (!list->isLocalLoaded())
-		{
-			ProgressDialog(parent).execWithTask(list->remoteUpdateTask());
-		}
-	}
-	return list->isComplete() ? list : nullptr;
-}
-
-WonkoVersionPtr Wonko::ensureVersionExists(const QString &uid, const QString &version, QWidget *parent)
-{
-	WonkoVersionListPtr list = ensureVersionListLoaded(uid, parent);
-	if (!list)
-	{
-		return nullptr;
-	}
-	return list->getVersion(version);
-}
-WonkoVersionPtr Wonko::ensureVersionLoaded(const QString &uid, const QString &version, QWidget *parent, const UpdateType update)
-{
-	WonkoVersionPtr vptr = ensureVersionExists(uid, version, parent);
-	if (!vptr)
-	{
-		return nullptr;
-	}
-	if (!vptr->isLocalLoaded() || update == AlwaysUpdate)
-	{
-		ProgressDialog(parent).execWithTask(vptr->localUpdateTask());
-		if (!vptr->isLocalLoaded() || update == AlwaysUpdate)
-		{
-			ProgressDialog(parent).execWithTask(vptr->remoteUpdateTask());
-		}
-	}
-	return vptr->isComplete() ? vptr : nullptr;
-}
diff --git a/application/WonkoGui.h b/application/WonkoGui.h
deleted file mode 100644
index ad0bee89..00000000
--- a/application/WonkoGui.h
+++ /dev/null
@@ -1,29 +0,0 @@
-#pragma once
-
-#include <memory>
-#include "QObjectPtr.h"
-
-class QWidget;
-class QString;
-
-using WonkoIndexPtr = shared_qobject_ptr<class WonkoIndex>;
-using WonkoVersionListPtr = std::shared_ptr<class WonkoVersionList>;
-using WonkoVersionPtr = std::shared_ptr<class WonkoVersion>;
-
-namespace Wonko
-{
-enum UpdateType
-{
-	AlwaysUpdate,
-	UpdateIfNeeded
-};
-
-/// Ensures that the index has been loaded, either from the local cache or remotely
-WonkoIndexPtr ensureIndexLoaded(QWidget *parent);
-/// Ensures that the given uid exists. Returns a nullptr if it doesn't.
-WonkoVersionListPtr ensureVersionListExists(const QString &uid, QWidget *parent);
-/// Ensures that the given uid exists and is loaded, either from the local cache or remotely. Returns nullptr if it doesn't exist or couldn't be loaded.
-WonkoVersionListPtr ensureVersionListLoaded(const QString &uid, QWidget *parent);
-WonkoVersionPtr ensureVersionExists(const QString &uid, const QString &version, QWidget *parent);
-WonkoVersionPtr ensureVersionLoaded(const QString &uid, const QString &version, QWidget *parent, const UpdateType update = UpdateIfNeeded);
-}
diff --git a/application/pages/global/WonkoPage.cpp b/application/pages/global/MetadataPage.cpp
similarity index 71%
rename from application/pages/global/WonkoPage.cpp
rename to application/pages/global/MetadataPage.cpp
index 1a72b18d..4e355997 100644
--- a/application/pages/global/WonkoPage.cpp
+++ b/application/pages/global/MetadataPage.cpp
@@ -13,8 +13,8 @@
  * limitations under the License.
  */
 
-#include "WonkoPage.h"
-#include "ui_WonkoPage.h"
+#include "MetadataPage.h"
+#include "ui_MetadataPage.h"
 
 #include <QDateTime>
 #include <QSortFilterProxyModel>
@@ -23,18 +23,20 @@
 #include "dialogs/ProgressDialog.h"
 #include "VersionProxyModel.h"
 
-#include "wonko/WonkoIndex.h"
-#include "wonko/WonkoVersionList.h"
-#include "wonko/WonkoVersion.h"
+#include "meta/Index.h"
+#include "meta/VersionList.h"
+#include "meta/Version.h"
 #include "Env.h"
 #include "MultiMC.h"
 
-static QString formatRequires(const WonkoVersionPtr &version)
+using namespace Meta;
+
+static QString formatRequires(const VersionPtr &version)
 {
 	QStringList lines;
-	for (const WonkoReference &ref : version->requires())
+	for (const Reference &ref : version->requires())
 	{
-		const QString readable = ENV.wonkoIndex()->hasUid(ref.uid()) ? ENV.wonkoIndex()->getList(ref.uid())->humanReadable() : ref.uid();
+		const QString readable = ENV.metadataIndex()->hasUid(ref.uid()) ? ENV.metadataIndex()->getList(ref.uid())->humanReadable() : ref.uid();
 		if (ref.version().isEmpty())
 		{
 			lines.append(readable);
@@ -47,9 +49,9 @@ static QString formatRequires(const WonkoVersionPtr &version)
 	return lines.join('\n');
 }
 
-WonkoPage::WonkoPage(QWidget *parent) :
+MetadataPage::MetadataPage(QWidget *parent) :
 	QWidget(parent),
-	ui(new Ui::WonkoPage)
+	ui(new Ui::MetadataPage)
 {
 	ui->setupUi(this);
 	ui->tabWidget->tabBar()->hide();
@@ -61,11 +63,11 @@ WonkoPage::WonkoPage(QWidget *parent) :
 	m_fileProxy->setFilterRole(Qt::DisplayRole);
 	m_fileProxy->setFilterKeyColumn(0);
 	m_fileProxy->sort(0);
-	m_fileProxy->setSourceModel(ENV.wonkoIndex().get());
+	m_fileProxy->setSourceModel(ENV.metadataIndex().get());
 	ui->indexView->setModel(m_fileProxy);
 
 	m_filterProxy = new QSortFilterProxyModel(this);
-	m_filterProxy->setSortRole(WonkoVersionList::SortRole);
+	m_filterProxy->setSortRole(VersionList::SortRole);
 	m_filterProxy->setFilterCaseSensitivity(Qt::CaseInsensitive);
 	m_filterProxy->setFilterRole(Qt::DisplayRole);
 	m_filterProxy->setFilterKeyColumn(0);
@@ -75,40 +77,40 @@ WonkoPage::WonkoPage(QWidget *parent) :
 	m_versionProxy = new VersionProxyModel(this);
 	m_filterProxy->setSourceModel(m_versionProxy);
 
-	connect(ui->indexView->selectionModel(), &QItemSelectionModel::currentChanged, this, &WonkoPage::updateCurrentVersionList);
-	connect(ui->versionsView->selectionModel(), &QItemSelectionModel::currentChanged, this, &WonkoPage::updateVersion);
-	connect(m_filterProxy, &QSortFilterProxyModel::dataChanged, this, &WonkoPage::versionListDataChanged);
+	connect(ui->indexView->selectionModel(), &QItemSelectionModel::currentChanged, this, &MetadataPage::updateCurrentVersionList);
+	connect(ui->versionsView->selectionModel(), &QItemSelectionModel::currentChanged, this, &MetadataPage::updateVersion);
+	connect(m_filterProxy, &QSortFilterProxyModel::dataChanged, this, &MetadataPage::versionListDataChanged);
 
 	updateCurrentVersionList(QModelIndex());
 	updateVersion();
 }
 
-WonkoPage::~WonkoPage()
+MetadataPage::~MetadataPage()
 {
 	delete ui;
 }
 
-QIcon WonkoPage::icon() const
+QIcon MetadataPage::icon() const
 {
 	return MMC->getThemedIcon("looney");
 }
 
-void WonkoPage::on_refreshIndexBtn_clicked()
+void MetadataPage::on_refreshIndexBtn_clicked()
 {
-	ProgressDialog(this).execWithTask(ENV.wonkoIndex()->remoteUpdateTask());
+	ProgressDialog(this).execWithTask(ENV.metadataIndex()->remoteUpdateTask());
 }
-void WonkoPage::on_refreshFileBtn_clicked()
+void MetadataPage::on_refreshFileBtn_clicked()
 {
-	WonkoVersionListPtr list = ui->indexView->currentIndex().data(WonkoIndex::ListPtrRole).value<WonkoVersionListPtr>();
+	VersionListPtr list = ui->indexView->currentIndex().data(Index::ListPtrRole).value<VersionListPtr>();
 	if (!list)
 	{
 		return;
 	}
 	ProgressDialog(this).execWithTask(list->remoteUpdateTask());
 }
-void WonkoPage::on_refreshVersionBtn_clicked()
+void MetadataPage::on_refreshVersionBtn_clicked()
 {
-	WonkoVersionPtr version = ui->versionsView->currentIndex().data(WonkoVersionList::WonkoVersionPtrRole).value<WonkoVersionPtr>();
+	VersionPtr version = ui->versionsView->currentIndex().data(VersionList::VersionPtrRole).value<VersionPtr>();
 	if (!version)
 	{
 		return;
@@ -116,7 +118,7 @@ void WonkoPage::on_refreshVersionBtn_clicked()
 	ProgressDialog(this).execWithTask(version->remoteUpdateTask());
 }
 
-void WonkoPage::on_fileSearchEdit_textChanged(const QString &search)
+void MetadataPage::on_fileSearchEdit_textChanged(const QString &search)
 {
 	if (search.isEmpty())
 	{
@@ -129,7 +131,7 @@ void WonkoPage::on_fileSearchEdit_textChanged(const QString &search)
 		m_fileProxy->setFilterRegExp(".*" + parts.join(".*") + ".*");
 	}
 }
-void WonkoPage::on_versionSearchEdit_textChanged(const QString &search)
+void MetadataPage::on_versionSearchEdit_textChanged(const QString &search)
 {
 	if (search.isEmpty())
 	{
@@ -143,11 +145,11 @@ void WonkoPage::on_versionSearchEdit_textChanged(const QString &search)
 	}
 }
 
-void WonkoPage::updateCurrentVersionList(const QModelIndex &index)
+void MetadataPage::updateCurrentVersionList(const QModelIndex &index)
 {
 	if (index.isValid())
 	{
-		WonkoVersionListPtr list = index.data(WonkoIndex::ListPtrRole).value<WonkoVersionListPtr>();
+		VersionListPtr list = index.data(Index::ListPtrRole).value<VersionListPtr>();
 		ui->versionsBox->setEnabled(true);
 		ui->refreshFileBtn->setEnabled(true);
 		ui->fileUidLabel->setEnabled(true);
@@ -183,7 +185,7 @@ void WonkoPage::updateCurrentVersionList(const QModelIndex &index)
 	}
 }
 
-void WonkoPage::versionListDataChanged(const QModelIndex &tl, const QModelIndex &br)
+void MetadataPage::versionListDataChanged(const QModelIndex &tl, const QModelIndex &br)
 {
 	if (QItemSelection(tl, br).contains(ui->versionsView->currentIndex()))
 	{
@@ -191,10 +193,10 @@ void WonkoPage::versionListDataChanged(const QModelIndex &tl, const QModelIndex
 	}
 }
 
-void WonkoPage::updateVersion()
+void MetadataPage::updateVersion()
 {
-	WonkoVersionPtr version = std::dynamic_pointer_cast<WonkoVersion>(
-				ui->versionsView->currentIndex().data(WonkoVersionList::VersionPointerRole).value<BaseVersionPtr>());
+	VersionPtr version = std::dynamic_pointer_cast<Version>(
+				ui->versionsView->currentIndex().data(VersionList::VersionPointerRole).value<BaseVersionPtr>());
 	if (version)
 	{
 		ui->refreshVersionBtn->setEnabled(true);
@@ -223,16 +225,16 @@ void WonkoPage::updateVersion()
 	}
 }
 
-void WonkoPage::opened()
+void MetadataPage::opened()
 {
-	if (!ENV.wonkoIndex()->isLocalLoaded())
+	if (!ENV.metadataIndex()->isLocalLoaded())
 	{
-		std::unique_ptr<Task> task = ENV.wonkoIndex()->localUpdateTask();
+		std::unique_ptr<Task> task = ENV.metadataIndex()->localUpdateTask();
 		connect(task.get(), &Task::finished, this, [this]()
 		{
-			if (!ENV.wonkoIndex()->isRemoteLoaded())
+			if (!ENV.metadataIndex()->isRemoteLoaded())
 			{
-				ProgressDialog(this).execWithTask(ENV.wonkoIndex()->remoteUpdateTask());
+				ProgressDialog(this).execWithTask(ENV.metadataIndex()->remoteUpdateTask());
 			}
 		});
 		ProgressDialog(this).execWithTask(task);
diff --git a/application/pages/global/WonkoPage.h b/application/pages/global/MetadataPage.h
similarity index 82%
rename from application/pages/global/WonkoPage.h
rename to application/pages/global/MetadataPage.h
index 1d576c15..f75b4952 100644
--- a/application/pages/global/WonkoPage.h
+++ b/application/pages/global/MetadataPage.h
@@ -20,21 +20,21 @@
 #include "pages/BasePage.h"
 
 namespace Ui {
-class WonkoPage;
+class MetadataPage;
 }
 
 class QSortFilterProxyModel;
 class VersionProxyModel;
 
-class WonkoPage : public QWidget, public BasePage
+class MetadataPage : public QWidget, public BasePage
 {
 	Q_OBJECT
 public:
-	explicit WonkoPage(QWidget *parent = 0);
-	~WonkoPage();
+	explicit MetadataPage(QWidget *parent = 0);
+	~MetadataPage();
 
-	QString id() const override { return "wonko-global"; }
-	QString displayName() const override { return tr("Wonko"); }
+	QString id() const override { return "metadata-global"; }
+	QString displayName() const override { return tr("Metadata"); }
 	QIcon icon() const override;
 	void opened() override;
 
@@ -48,7 +48,7 @@ private slots:
 	void versionListDataChanged(const QModelIndex &tl, const QModelIndex &br);
 
 private:
-	Ui::WonkoPage *ui;
+	Ui::MetadataPage *ui;
 	QSortFilterProxyModel *m_fileProxy;
 	QSortFilterProxyModel *m_filterProxy;
 	VersionProxyModel *m_versionProxy;
diff --git a/application/pages/global/WonkoPage.ui b/application/pages/global/MetadataPage.ui
similarity index 99%
rename from application/pages/global/WonkoPage.ui
rename to application/pages/global/MetadataPage.ui
index 2d14ceca..0bd33f32 100644
--- a/application/pages/global/WonkoPage.ui
+++ b/application/pages/global/MetadataPage.ui
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <ui version="4.0">
- <class>WonkoPage</class>
- <widget class="QWidget" name="WonkoPage">
+ <class>MetadataPage</class>
+ <widget class="QWidget" name="MetadataPage">
   <property name="geometry">
    <rect>
     <x>0</x>

From 8321187a20eec9871f327aa23f421e79dcfdd409 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= <peterix@gmail.com>
Date: Sun, 12 Mar 2017 16:00:06 +0100
Subject: [PATCH 05/28] NOISSUE fix downloading of metadata files

---
 api/logic/meta/Util.cpp                       |   2 +-
 api/logic/meta/VersionList.cpp                |   2 +-
 api/logic/meta/format/Format.cpp              |  40 +++---
 api/logic/meta/format/FormatV1.cpp            | 119 ++++++++++--------
 application/CMakeLists.txt                    |   6 +-
 application/MultiMC.cpp                       |   2 +
 application/VersionProxyModel.cpp             |   2 +-
 .../{MetadataPage.cpp => PackagesPage.cpp}    |  42 +++----
 .../global/{MetadataPage.h => PackagesPage.h} |  14 +--
 .../{MetadataPage.ui => PackagesPage.ui}      |  12 +-
 10 files changed, 129 insertions(+), 112 deletions(-)
 rename application/pages/global/{MetadataPage.cpp => PackagesPage.cpp} (86%)
 rename application/pages/global/{MetadataPage.h => PackagesPage.h} (82%)
 rename application/pages/global/{MetadataPage.ui => PackagesPage.ui} (97%)

diff --git a/api/logic/meta/Util.cpp b/api/logic/meta/Util.cpp
index 2ccbe5c4..76941f83 100644
--- a/api/logic/meta/Util.cpp
+++ b/api/logic/meta/Util.cpp
@@ -34,7 +34,7 @@ QUrl indexUrl()
 
 QUrl versionListUrl(const QString &uid)
 {
-	return rootUrl().resolved(uid + ".json");
+	return rootUrl().resolved(uid + "/index.json");
 }
 
 QUrl versionUrl(const QString &uid, const QString &version)
diff --git a/api/logic/meta/VersionList.cpp b/api/logic/meta/VersionList.cpp
index 11e20c12..aab3e0f7 100644
--- a/api/logic/meta/VersionList.cpp
+++ b/api/logic/meta/VersionList.cpp
@@ -178,7 +178,7 @@ std::unique_ptr<Task> VersionList::localUpdateTask()
 
 QString VersionList::localFilename() const
 {
-	return m_uid + ".json";
+	return m_uid + "/index.json";
 }
 QJsonObject VersionList::serialized() const
 {
diff --git a/api/logic/meta/format/Format.cpp b/api/logic/meta/format/Format.cpp
index a3f9f730..e0fddb0b 100644
--- a/api/logic/meta/format/Format.cpp
+++ b/api/logic/meta/format/Format.cpp
@@ -39,29 +39,19 @@ void Format::parseIndex(const QJsonObject &obj, Index *ptr)
 {
 	const int version = formatVersion(obj);
 	switch (version) {
-	case 1:
+	case 0:
 		ptr->merge(FormatV1().parseIndexInternal(obj));
 		break;
 	default:
 		throw ParseException(QObject::tr("Unknown formatVersion: %1").arg(version));
 	}
 }
-void Format::parseVersion(const QJsonObject &obj, Version *ptr)
-{
-	const int version = formatVersion(obj);
-	switch (version) {
-	case 1:
-		ptr->merge(FormatV1().parseVersionInternal(obj));
-		break;
-	default:
-		throw ParseException(QObject::tr("Unknown formatVersion: %1").arg(version));
-	}
-}
+
 void Format::parseVersionList(const QJsonObject &obj, VersionList *ptr)
 {
 	const int version = formatVersion(obj);
 	switch (version) {
-	case 10:
+	case 0:
 		ptr->merge(FormatV1().parseVersionListInternal(obj));
 		break;
 	default:
@@ -69,16 +59,32 @@ void Format::parseVersionList(const QJsonObject &obj, VersionList *ptr)
 	}
 }
 
+void Format::parseVersion(const QJsonObject &obj, Version *ptr)
+{
+	const int version = formatVersion(obj);
+	switch (version) {
+	case 0:
+		ptr->merge(FormatV1().parseVersionInternal(obj));
+		break;
+	default:
+		throw ParseException(QObject::tr("Unknown formatVersion: %1").arg(version));
+	}
+}
+
+
 QJsonObject Format::serializeIndex(const Index *ptr)
 {
 	return FormatV1().serializeIndexInternal(ptr);
 }
-QJsonObject Format::serializeVersion(const Version *ptr)
-{
-	return FormatV1().serializeVersionInternal(ptr);
-}
+
 QJsonObject Format::serializeVersionList(const VersionList *ptr)
 {
 	return FormatV1().serializeVersionListInternal(ptr);
 }
+
+QJsonObject Format::serializeVersion(const Version *ptr)
+{
+	return FormatV1().serializeVersionInternal(ptr);
+}
+
 }
diff --git a/api/logic/meta/format/FormatV1.cpp b/api/logic/meta/format/FormatV1.cpp
index 23f57100..ee2c5291 100644
--- a/api/logic/meta/format/FormatV1.cpp
+++ b/api/logic/meta/format/FormatV1.cpp
@@ -27,6 +27,44 @@ using namespace Json;
 
 namespace Meta
 {
+
+static const int currentFormatVersion = 0;
+
+// Index
+
+BaseEntity::Ptr FormatV1::parseIndexInternal(const QJsonObject &obj) const
+{
+	const QVector<QJsonObject> objects = requireIsArrayOf<QJsonObject>(obj, "packages");
+	QVector<VersionListPtr> lists;
+	lists.reserve(objects.size());
+	std::transform(objects.begin(), objects.end(), std::back_inserter(lists), [](const QJsonObject &obj)
+	{
+		VersionListPtr list = std::make_shared<VersionList>(requireString(obj, "uid"));
+		list->setName(ensureString(obj, "name", QString()));
+		return list;
+	});
+	return std::make_shared<Index>(lists);
+}
+
+QJsonObject FormatV1::serializeIndexInternal(const Index *ptr) const
+{
+	QJsonArray packages;
+	for (const VersionListPtr &list : ptr->lists())
+	{
+		QJsonObject out;
+		out["uid"] = list->uid();
+		out["name"] = list->name();
+		packages.append(out);
+	}
+	QJsonObject out;
+	out["formatVersion"] = currentFormatVersion;
+	out["packages"] = packages;
+	return out;
+}
+
+
+// Version
+
 static VersionPtr parseCommonVersion(const QString &uid, const QJsonObject &obj)
 {
 	const QVector<QJsonObject> requiresRaw = obj.contains("requires") ? requireIsArrayOf<QJsonObject>(obj, "requires") : QVector<QJsonObject>();
@@ -40,18 +78,22 @@ static VersionPtr parseCommonVersion(const QString &uid, const QJsonObject &obj)
 	});
 
 	VersionPtr version = std::make_shared<Version>(uid, requireString(obj, "version"));
-	if (obj.value("time").isString())
-	{
-		version->setTime(QDateTime::fromString(requireString(obj, "time"), Qt::ISODate).toMSecsSinceEpoch() / 1000);
-	}
-	else
-	{
-		version->setTime(requireInteger(obj, "time"));
-	}
+	version->setTime(QDateTime::fromString(requireString(obj, "releaseTime"), Qt::ISODate).toMSecsSinceEpoch() / 1000);
 	version->setType(ensureString(obj, "type", QString()));
 	version->setRequires(requires);
 	return version;
 }
+
+BaseEntity::Ptr FormatV1::parseVersionInternal(const QJsonObject &obj) const
+{
+	VersionPtr version = parseCommonVersion(requireString(obj, "uid"), obj);
+
+	version->setData(OneSixVersionFormat::versionFileFromJson(QJsonDocument(obj),
+										   QString("%1/%2.json").arg(version->uid(), version->version()),
+										   obj.contains("order")));
+	return version;
+}
+
 static void serializeCommonVersion(const Version *version, QJsonObject &obj)
 {
 	QJsonArray requires;
@@ -74,32 +116,25 @@ static void serializeCommonVersion(const Version *version, QJsonObject &obj)
 
 	obj.insert("version", version->version());
 	obj.insert("type", version->type());
-	obj.insert("time", version->time().toString(Qt::ISODate));
+	obj.insert("releaseTime", version->time().toString(Qt::ISODate));
 	obj.insert("requires", requires);
 }
 
-BaseEntity::Ptr FormatV1::parseIndexInternal(const QJsonObject &obj) const
+QJsonObject FormatV1::serializeVersionInternal(const Version *ptr) const
 {
-	const QVector<QJsonObject> objects = requireIsArrayOf<QJsonObject>(obj, "index");
-	QVector<VersionListPtr> lists;
-	lists.reserve(objects.size());
-	std::transform(objects.begin(), objects.end(), std::back_inserter(lists), [](const QJsonObject &obj)
-	{
-		VersionListPtr list = std::make_shared<VersionList>(requireString(obj, "uid"));
-		list->setName(ensureString(obj, "name", QString()));
-		return list;
-	});
-	return std::make_shared<Index>(lists);
-}
-BaseEntity::Ptr FormatV1::parseVersionInternal(const QJsonObject &obj) const
-{
-	VersionPtr version = parseCommonVersion(requireString(obj, "uid"), obj);
+	QJsonObject obj = OneSixVersionFormat::versionFileToJson(ptr->data(), true).object();
+	serializeCommonVersion(ptr, obj);
+	obj.insert("formatVersion", currentFormatVersion);
+	obj.insert("uid", ptr->uid());
+	// TODO: the name should be looked up in the UI based on the uid
+	obj.insert("name", ENV.metadataIndex()->getListGuaranteed(ptr->uid())->name());
 
-	version->setData(OneSixVersionFormat::versionFileFromJson(QJsonDocument(obj),
-										   QString("%1/%2.json").arg(version->uid(), version->version()),
-										   obj.contains("order")));
-	return version;
+	return obj;
 }
+
+
+// Version list / package
+
 BaseEntity::Ptr FormatV1::parseVersionListInternal(const QJsonObject &obj) const
 {
 	const QString uid = requireString(obj, "uid");
@@ -116,32 +151,6 @@ BaseEntity::Ptr FormatV1::parseVersionListInternal(const QJsonObject &obj) const
 	return list;
 }
 
-QJsonObject FormatV1::serializeIndexInternal(const Index *ptr) const
-{
-	QJsonArray index;
-	for (const VersionListPtr &list : ptr->lists())
-	{
-		QJsonObject out;
-		out["uid"] = list->uid();
-		out["version"] = list->name();
-		index.append(out);
-	}
-	QJsonObject out;
-	out["formatVersion"] = 1;
-	out["index"] = index;
-	return out;
-}
-QJsonObject FormatV1::serializeVersionInternal(const Version *ptr) const
-{
-	QJsonObject obj = OneSixVersionFormat::versionFileToJson(ptr->data(), true).object();
-	serializeCommonVersion(ptr, obj);
-	obj.insert("formatVersion", 1);
-	obj.insert("uid", ptr->uid());
-	// TODO: the name should be looked up in the UI based on the uid
-	obj.insert("name", ENV.metadataIndex()->getListGuaranteed(ptr->uid())->name());
-
-	return obj;
-}
 QJsonObject FormatV1::serializeVersionListInternal(const VersionList *ptr) const
 {
 	QJsonArray versions;
@@ -152,7 +161,7 @@ QJsonObject FormatV1::serializeVersionListInternal(const VersionList *ptr) const
 		versions.append(obj);
 	}
 	QJsonObject out;
-	out["formatVersion"] = 10;
+	out["formatVersion"] = currentFormatVersion;
 	out["uid"] = ptr->uid();
 	out["name"] = ptr->name().isNull() ? QJsonValue() : ptr->name();
 	out["versions"] = versions;
diff --git a/application/CMakeLists.txt b/application/CMakeLists.txt
index 55457b1c..1b6ff3fd 100644
--- a/application/CMakeLists.txt
+++ b/application/CMakeLists.txt
@@ -184,8 +184,8 @@ SET(MULTIMC_SOURCES
 	pages/global/ProxyPage.h
 	pages/global/PasteEEPage.cpp
 	pages/global/PasteEEPage.h
-	pages/global/MetadataPage.cpp
-	pages/global/MetadataPage.h
+	pages/global/PackagesPage.cpp
+	pages/global/PackagesPage.h
 
 	# GUI - dialogs
 	dialogs/AboutDialog.cpp
@@ -284,7 +284,7 @@ SET(MULTIMC_UIS
 	pages/global/MultiMCPage.ui
 	pages/global/ProxyPage.ui
 	pages/global/PasteEEPage.ui
-	pages/global/MetadataPage.ui
+	pages/global/PackagesPage.ui
 
 	# Dialogs
 	dialogs/CopyInstanceDialog.ui
diff --git a/application/MultiMC.cpp b/application/MultiMC.cpp
index 081de41c..3a91fb5f 100644
--- a/application/MultiMC.cpp
+++ b/application/MultiMC.cpp
@@ -10,6 +10,7 @@
 #include "pages/global/ExternalToolsPage.h"
 #include "pages/global/AccountListPage.h"
 #include "pages/global/PasteEEPage.h"
+#include "pages/global/PackagesPage.h"
 
 #include "themes/ITheme.h"
 #include "themes/SystemTheme.h"
@@ -842,6 +843,7 @@ void MultiMC::initGlobalSettings()
 		m_globalSettingsProvider->addPage<MinecraftPage>();
 		m_globalSettingsProvider->addPage<JavaPage>();
 		m_globalSettingsProvider->addPage<ProxyPage>();
+        m_globalSettingsProvider->addPage<PackagesPage>();
 		m_globalSettingsProvider->addPage<ExternalToolsPage>();
 		m_globalSettingsProvider->addPage<AccountListPage>();
 		m_globalSettingsProvider->addPage<PasteEEPage>();
diff --git a/application/VersionProxyModel.cpp b/application/VersionProxyModel.cpp
index 22df7e09..50b94d9e 100644
--- a/application/VersionProxyModel.cpp
+++ b/application/VersionProxyModel.cpp
@@ -313,9 +313,9 @@ void VersionProxyModel::setSourceModel(QAbstractItemModel *replacingRaw)
 	auto replacing = dynamic_cast<BaseVersionList *>(replacingRaw);
 	beginResetModel();
 
+	m_columns.clear();
 	if(!replacing)
 	{
-		m_columns.clear();
 		roles.clear();
 		filterModel->setSourceModel(replacing);
 		return;
diff --git a/application/pages/global/MetadataPage.cpp b/application/pages/global/PackagesPage.cpp
similarity index 86%
rename from application/pages/global/MetadataPage.cpp
rename to application/pages/global/PackagesPage.cpp
index 4e355997..52efaf9a 100644
--- a/application/pages/global/MetadataPage.cpp
+++ b/application/pages/global/PackagesPage.cpp
@@ -13,8 +13,8 @@
  * limitations under the License.
  */
 
-#include "MetadataPage.h"
-#include "ui_MetadataPage.h"
+#include "PackagesPage.h"
+#include "ui_PackagesPage.h"
 
 #include <QDateTime>
 #include <QSortFilterProxyModel>
@@ -49,9 +49,9 @@ static QString formatRequires(const VersionPtr &version)
 	return lines.join('\n');
 }
 
-MetadataPage::MetadataPage(QWidget *parent) :
+PackagesPage::PackagesPage(QWidget *parent) :
 	QWidget(parent),
-	ui(new Ui::MetadataPage)
+	ui(new Ui::PackagesPage)
 {
 	ui->setupUi(this);
 	ui->tabWidget->tabBar()->hide();
@@ -77,29 +77,29 @@ MetadataPage::MetadataPage(QWidget *parent) :
 	m_versionProxy = new VersionProxyModel(this);
 	m_filterProxy->setSourceModel(m_versionProxy);
 
-	connect(ui->indexView->selectionModel(), &QItemSelectionModel::currentChanged, this, &MetadataPage::updateCurrentVersionList);
-	connect(ui->versionsView->selectionModel(), &QItemSelectionModel::currentChanged, this, &MetadataPage::updateVersion);
-	connect(m_filterProxy, &QSortFilterProxyModel::dataChanged, this, &MetadataPage::versionListDataChanged);
+	connect(ui->indexView->selectionModel(), &QItemSelectionModel::currentChanged, this, &PackagesPage::updateCurrentVersionList);
+	connect(ui->versionsView->selectionModel(), &QItemSelectionModel::currentChanged, this, &PackagesPage::updateVersion);
+	connect(m_filterProxy, &QSortFilterProxyModel::dataChanged, this, &PackagesPage::versionListDataChanged);
 
 	updateCurrentVersionList(QModelIndex());
 	updateVersion();
 }
 
-MetadataPage::~MetadataPage()
+PackagesPage::~PackagesPage()
 {
 	delete ui;
 }
 
-QIcon MetadataPage::icon() const
+QIcon PackagesPage::icon() const
 {
-	return MMC->getThemedIcon("looney");
+	return MMC->getThemedIcon("packages");
 }
 
-void MetadataPage::on_refreshIndexBtn_clicked()
+void PackagesPage::on_refreshIndexBtn_clicked()
 {
 	ProgressDialog(this).execWithTask(ENV.metadataIndex()->remoteUpdateTask());
 }
-void MetadataPage::on_refreshFileBtn_clicked()
+void PackagesPage::on_refreshFileBtn_clicked()
 {
 	VersionListPtr list = ui->indexView->currentIndex().data(Index::ListPtrRole).value<VersionListPtr>();
 	if (!list)
@@ -108,7 +108,7 @@ void MetadataPage::on_refreshFileBtn_clicked()
 	}
 	ProgressDialog(this).execWithTask(list->remoteUpdateTask());
 }
-void MetadataPage::on_refreshVersionBtn_clicked()
+void PackagesPage::on_refreshVersionBtn_clicked()
 {
 	VersionPtr version = ui->versionsView->currentIndex().data(VersionList::VersionPtrRole).value<VersionPtr>();
 	if (!version)
@@ -118,7 +118,7 @@ void MetadataPage::on_refreshVersionBtn_clicked()
 	ProgressDialog(this).execWithTask(version->remoteUpdateTask());
 }
 
-void MetadataPage::on_fileSearchEdit_textChanged(const QString &search)
+void PackagesPage::on_fileSearchEdit_textChanged(const QString &search)
 {
 	if (search.isEmpty())
 	{
@@ -131,7 +131,7 @@ void MetadataPage::on_fileSearchEdit_textChanged(const QString &search)
 		m_fileProxy->setFilterRegExp(".*" + parts.join(".*") + ".*");
 	}
 }
-void MetadataPage::on_versionSearchEdit_textChanged(const QString &search)
+void PackagesPage::on_versionSearchEdit_textChanged(const QString &search)
 {
 	if (search.isEmpty())
 	{
@@ -145,7 +145,7 @@ void MetadataPage::on_versionSearchEdit_textChanged(const QString &search)
 	}
 }
 
-void MetadataPage::updateCurrentVersionList(const QModelIndex &index)
+void PackagesPage::updateCurrentVersionList(const QModelIndex &index)
 {
 	if (index.isValid())
 	{
@@ -181,11 +181,11 @@ void MetadataPage::updateCurrentVersionList(const QModelIndex &index)
 		ui->fileNameLabel->setEnabled(false);
 		ui->fileName->clear();
 		m_versionProxy->setSourceModel(nullptr);
-		ui->refreshFileBtn->setText(tr("Refresh ___"));
+		ui->refreshFileBtn->setText(tr("Refresh"));
 	}
 }
 
-void MetadataPage::versionListDataChanged(const QModelIndex &tl, const QModelIndex &br)
+void PackagesPage::versionListDataChanged(const QModelIndex &tl, const QModelIndex &br)
 {
 	if (QItemSelection(tl, br).contains(ui->versionsView->currentIndex()))
 	{
@@ -193,7 +193,7 @@ void MetadataPage::versionListDataChanged(const QModelIndex &tl, const QModelInd
 	}
 }
 
-void MetadataPage::updateVersion()
+void PackagesPage::updateVersion()
 {
 	VersionPtr version = std::dynamic_pointer_cast<Version>(
 				ui->versionsView->currentIndex().data(VersionList::VersionPointerRole).value<BaseVersionPtr>());
@@ -221,11 +221,11 @@ void MetadataPage::updateVersion()
 		ui->versionType->clear();
 		ui->versionRequiresLabel->setEnabled(false);
 		ui->versionRequires->clear();
-		ui->refreshVersionBtn->setText(tr("Refresh ___"));
+		ui->refreshVersionBtn->setText(tr("Refresh"));
 	}
 }
 
-void MetadataPage::opened()
+void PackagesPage::opened()
 {
 	if (!ENV.metadataIndex()->isLocalLoaded())
 	{
diff --git a/application/pages/global/MetadataPage.h b/application/pages/global/PackagesPage.h
similarity index 82%
rename from application/pages/global/MetadataPage.h
rename to application/pages/global/PackagesPage.h
index f75b4952..80c2886d 100644
--- a/application/pages/global/MetadataPage.h
+++ b/application/pages/global/PackagesPage.h
@@ -20,21 +20,21 @@
 #include "pages/BasePage.h"
 
 namespace Ui {
-class MetadataPage;
+class PackagesPage;
 }
 
 class QSortFilterProxyModel;
 class VersionProxyModel;
 
-class MetadataPage : public QWidget, public BasePage
+class PackagesPage : public QWidget, public BasePage
 {
 	Q_OBJECT
 public:
-	explicit MetadataPage(QWidget *parent = 0);
-	~MetadataPage();
+	explicit PackagesPage(QWidget *parent = 0);
+	~PackagesPage();
 
-	QString id() const override { return "metadata-global"; }
-	QString displayName() const override { return tr("Metadata"); }
+	QString id() const override { return "packages-global"; }
+	QString displayName() const override { return tr("Packages"); }
 	QIcon icon() const override;
 	void opened() override;
 
@@ -48,7 +48,7 @@ private slots:
 	void versionListDataChanged(const QModelIndex &tl, const QModelIndex &br);
 
 private:
-	Ui::MetadataPage *ui;
+	Ui::PackagesPage *ui;
 	QSortFilterProxyModel *m_fileProxy;
 	QSortFilterProxyModel *m_filterProxy;
 	VersionProxyModel *m_versionProxy;
diff --git a/application/pages/global/MetadataPage.ui b/application/pages/global/PackagesPage.ui
similarity index 97%
rename from application/pages/global/MetadataPage.ui
rename to application/pages/global/PackagesPage.ui
index 0bd33f32..158bf1b4 100644
--- a/application/pages/global/MetadataPage.ui
+++ b/application/pages/global/PackagesPage.ui
@@ -1,13 +1,13 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <ui version="4.0">
- <class>MetadataPage</class>
- <widget class="QWidget" name="MetadataPage">
+ <class>PackagesPage</class>
+ <widget class="QWidget" name="PackagesPage">
   <property name="geometry">
    <rect>
     <x>0</x>
     <y>0</y>
-    <width>640</width>
-    <height>480</height>
+    <width>636</width>
+    <height>621</height>
    </rect>
   </property>
   <property name="windowTitle">
@@ -67,7 +67,7 @@
             <item>
              <widget class="QPushButton" name="refreshVersionBtn">
               <property name="text">
-               <string>Refresh ___</string>
+               <string>Refresh</string>
               </property>
              </widget>
             </item>
@@ -180,7 +180,7 @@
             <item>
              <widget class="QPushButton" name="refreshFileBtn">
               <property name="text">
-               <string>Refresh ___</string>
+               <string>Refresh</string>
               </property>
              </widget>
             </item>

From 2980322c3b34b252ead838daee7a844853feccf6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= <peterix@gmail.com>
Date: Sun, 12 Mar 2017 19:45:28 +0100
Subject: [PATCH 06/28] NOISSUE Remove Minecraft version list and versions.

---
 api/logic/BaseInstance.cpp                    |   1 -
 api/logic/CMakeLists.txt                      |   4 -
 api/logic/InstanceCreationTask.cpp            |   4 +-
 api/logic/minecraft/MinecraftInstance.cpp     |   3 +-
 api/logic/minecraft/MinecraftVersion.cpp      | 230 -------
 api/logic/minecraft/MinecraftVersion.h        | 132 ----
 api/logic/minecraft/MinecraftVersionList.cpp  | 614 ------------------
 api/logic/minecraft/MinecraftVersionList.h    |  72 --
 api/logic/minecraft/MojangVersionFormat.cpp   |   1 -
 api/logic/minecraft/forge/ForgeInstaller.cpp  |   9 +-
 .../minecraft/ftb/FTBInstanceProvider.cpp     |  14 +-
 api/logic/minecraft/ftb/FTBPlugin.cpp         |   2 -
 .../minecraft/ftb/FTBProfileStrategy.cpp      |   1 -
 api/logic/minecraft/ftb/FTBVersion.h          |  32 -
 api/logic/minecraft/legacy/LegacyUpdate.cpp   |   1 -
 .../onesix/OneSixProfileStrategy.cpp          |   3 +-
 api/logic/minecraft/onesix/OneSixUpdate.cpp   |   3 +-
 .../minecraft/onesix/OneSixVersionFormat.cpp  |   1 -
 application/MainWindow.cpp                    |  17 +-
 application/MainWindow.h                      |   1 -
 application/MultiMC.cpp                       |  12 -
 application/MultiMC.h                         |   3 -
 application/dialogs/NewInstanceDialog.cpp     |  11 +-
 application/pages/VersionPage.cpp             |   8 +-
 24 files changed, 33 insertions(+), 1146 deletions(-)
 delete mode 100644 api/logic/minecraft/MinecraftVersion.cpp
 delete mode 100644 api/logic/minecraft/MinecraftVersion.h
 delete mode 100644 api/logic/minecraft/MinecraftVersionList.cpp
 delete mode 100644 api/logic/minecraft/MinecraftVersionList.h
 delete mode 100644 api/logic/minecraft/ftb/FTBVersion.h

diff --git a/api/logic/BaseInstance.cpp b/api/logic/BaseInstance.cpp
index 6d719c32..ee9e919d 100644
--- a/api/logic/BaseInstance.cpp
+++ b/api/logic/BaseInstance.cpp
@@ -23,7 +23,6 @@
 #include "settings/Setting.h"
 #include "settings/OverrideSetting.h"
 
-#include "minecraft/MinecraftVersionList.h"
 #include "FileSystem.h"
 #include "Commandline.h"
 
diff --git a/api/logic/CMakeLists.txt b/api/logic/CMakeLists.txt
index 1827b497..f14b8662 100644
--- a/api/logic/CMakeLists.txt
+++ b/api/logic/CMakeLists.txt
@@ -252,10 +252,6 @@ set(MINECRAFT_SOURCES
 	minecraft/JarMod.h
 	minecraft/MinecraftInstance.cpp
 	minecraft/MinecraftInstance.h
-	minecraft/MinecraftVersion.cpp
-	minecraft/MinecraftVersion.h
-	minecraft/MinecraftVersionList.cpp
-	minecraft/MinecraftVersionList.h
 	minecraft/Rule.cpp
 	minecraft/Rule.h
 	minecraft/OpSys.cpp
diff --git a/api/logic/InstanceCreationTask.cpp b/api/logic/InstanceCreationTask.cpp
index 00156701..e7b0de7c 100644
--- a/api/logic/InstanceCreationTask.cpp
+++ b/api/logic/InstanceCreationTask.cpp
@@ -4,7 +4,6 @@
 #include "FileSystem.h"
 
 //FIXME: remove this
-#include "minecraft/MinecraftVersion.h"
 #include "minecraft/onesix/OneSixInstance.h"
 
 InstanceCreationTask::InstanceCreationTask(SettingsObjectPtr settings, BaseInstanceProvider* target, BaseVersionPtr version,
@@ -21,12 +20,14 @@ InstanceCreationTask::InstanceCreationTask(SettingsObjectPtr settings, BaseInsta
 void InstanceCreationTask::executeTask()
 {
 	setStatus(tr("Creating instance from version %1").arg(m_version->name()));
+    /*
 	auto minecraftVersion = std::dynamic_pointer_cast<MinecraftVersion>(m_version);
 	if(!minecraftVersion)
 	{
 		emitFailed(tr("The supplied version is not a Minecraft version."));
 		return ;
 	}
+	*/
 
 	QString stagingPath = m_target->getStagedInstancePath();
 	QDir rootDir(stagingPath);
@@ -34,7 +35,6 @@ void InstanceCreationTask::executeTask()
 	auto instanceSettings = std::make_shared<INISettingsObject>(FS::PathCombine(stagingPath, "instance.cfg"));
 	instanceSettings->registerSetting("InstanceType", "Legacy");
 
-	auto mcVer = std::dynamic_pointer_cast<MinecraftVersion>(m_version);
 	instanceSettings->set("InstanceType", "OneSix");
 	InstancePtr inst(new OneSixInstance(m_globalSettings, instanceSettings, stagingPath));
 	inst->setIntendedVersionId(m_version->descriptor());
diff --git a/api/logic/minecraft/MinecraftInstance.cpp b/api/logic/minecraft/MinecraftInstance.cpp
index 7b1aef1e..b88d0c2a 100644
--- a/api/logic/minecraft/MinecraftInstance.cpp
+++ b/api/logic/minecraft/MinecraftInstance.cpp
@@ -5,7 +5,6 @@
 #include <settings/Setting.h>
 #include "settings/SettingsObject.h"
 #include "Env.h"
-#include "minecraft/MinecraftVersionList.h"
 #include <MMCStrings.h>
 #include <pathmatcher/RegexpMatcher.h>
 #include <pathmatcher/MultiMatcher.h>
@@ -24,6 +23,8 @@
 
 #include <icons/IIconList.h>
 
+#include <QCoreApplication>
+
 #define IBUS "@im=ibus"
 
 // all of this because keeping things compatible with deprecated old settings
diff --git a/api/logic/minecraft/MinecraftVersion.cpp b/api/logic/minecraft/MinecraftVersion.cpp
deleted file mode 100644
index 248c7eed..00000000
--- a/api/logic/minecraft/MinecraftVersion.cpp
+++ /dev/null
@@ -1,230 +0,0 @@
-#include "MinecraftVersion.h"
-#include "MinecraftProfile.h"
-#include "VersionBuildError.h"
-#include "ProfileUtils.h"
-#include "settings/SettingsObject.h"
-
-bool MinecraftVersion::usesLegacyLauncher()
-{
-	return m_traits.contains("legacyLaunch") || m_traits.contains("aplhaLaunch");
-}
-
-QString MinecraftVersion::descriptor()
-{
-	return m_descriptor;
-}
-
-QString MinecraftVersion::name()
-{
-	return m_name;
-}
-
-QString MinecraftVersion::typeString() const
-{
-	if(m_type == "snapshot")
-	{
-		return QObject::tr("Snapshot");
-	}
-	else if (m_type == "release")
-	{
-		return QObject::tr("Regular release");
-	}
-	else if (m_type == "old_alpha")
-	{
-		return QObject::tr("Alpha");
-	}
-	else if (m_type == "old_beta")
-	{
-		return QObject::tr("Beta");
-	}
-	else
-	{
-		return QString();
-	}
-}
-
-VersionSource MinecraftVersion::getVersionSource()
-{
-	return m_versionSource;
-}
-
-bool MinecraftVersion::hasJarMods()
-{
-	return false;
-}
-
-bool MinecraftVersion::isMinecraftVersion()
-{
-	return true;
-}
-
-void MinecraftVersion::applyFileTo(MinecraftProfile *profile)
-{
-	if(m_versionSource == VersionSource::Local && getVersionFile())
-	{
-		getVersionFile()->applyTo(profile);
-	}
-	else
-	{
-		throw VersionIncomplete(QObject::tr("Can't apply incomplete/builtin Minecraft version %1").arg(m_name));
-	}
-}
-
-QString MinecraftVersion::getUrl() const
-{
-	// legacy fallback
-	if(m_versionFileURL.isEmpty())
-	{
-		return QString("http://") + URLConstants::AWS_DOWNLOAD_VERSIONS + m_descriptor + "/" + m_descriptor + ".json";
-	}
-	// current
-	return m_versionFileURL;
-}
-
-VersionFilePtr MinecraftVersion::getVersionFile()
-{
-	QFileInfo versionFile(QString("versions/%1/%1.dat").arg(m_descriptor));
-	m_problems.clear();
-	m_problemSeverity = PROBLEM_NONE;
-	if(!versionFile.exists())
-	{
-		if(m_loadedVersionFile)
-		{
-			m_loadedVersionFile.reset();
-		}
-		addProblem(PROBLEM_WARNING, QObject::tr("The patch file doesn't exist locally. It's possible it just needs to be downloaded."));
-	}
-	else
-	{
-		try
-		{
-			if(versionFile.lastModified() != m_loadedVersionFileTimestamp)
-			{
-				auto loadedVersionFile = ProfileUtils::parseBinaryJsonFile(versionFile);
-				loadedVersionFile->name = "Minecraft";
-				loadedVersionFile->setCustomizable(true);
-				m_loadedVersionFileTimestamp = versionFile.lastModified();
-				m_loadedVersionFile = loadedVersionFile;
-			}
-		}
-		catch(Exception e)
-		{
-			m_loadedVersionFile.reset();
-			addProblem(PROBLEM_ERROR, QObject::tr("The patch file couldn't be read:\n%1").arg(e.cause()));
-		}
-	}
-	return m_loadedVersionFile;
-}
-
-bool MinecraftVersion::isCustomizable()
-{
-	switch(m_versionSource)
-	{
-		case VersionSource::Local:
-		case VersionSource::Remote:
-			// locally cached file, or a remote file that we can acquire can be customized
-			return true;
-		case VersionSource::Builtin:
-			// builtins do not follow the normal OneSix format. They are not customizable.
-		default:
-			// Everything else is undefined and therefore not customizable.
-			return false;
-	}
-	return false;
-}
-
-const QList<PatchProblem> &MinecraftVersion::getProblems()
-{
-	if(m_versionSource != VersionSource::Builtin && getVersionFile())
-	{
-		return getVersionFile()->getProblems();
-	}
-	return ProfilePatch::getProblems();
-}
-
-ProblemSeverity MinecraftVersion::getProblemSeverity()
-{
-	if(m_versionSource != VersionSource::Builtin && getVersionFile())
-	{
-		return getVersionFile()->getProblemSeverity();
-	}
-	return ProfilePatch::getProblemSeverity();
-}
-
-void MinecraftVersion::applyTo(MinecraftProfile *profile)
-{
-	// do we have this one cached?
-	if (m_versionSource == VersionSource::Local)
-	{
-		applyFileTo(profile);
-		return;
-	}
-	// if not builtin, do not proceed any further.
-	if (m_versionSource != VersionSource::Builtin)
-	{
-		throw VersionIncomplete(QObject::tr(
-			"Minecraft version %1 could not be applied: version files are missing.").arg(m_descriptor));
-	}
-	profile->applyMinecraftVersion(m_descriptor);
-	profile->applyMainClass(m_mainClass);
-	profile->applyAppletClass(m_appletClass);
-	profile->applyMinecraftArguments(" ${auth_player_name} ${auth_session}"); // all builtin versions are legacy
-	profile->applyMinecraftVersionType(m_type);
-	profile->applyTraits(m_traits);
-	profile->applyProblemSeverity(m_problemSeverity);
-}
-
-int MinecraftVersion::getOrder()
-{
-	return order;
-}
-
-void MinecraftVersion::setOrder(int order)
-{
-	this->order = order;
-}
-
-QList<JarmodPtr> MinecraftVersion::getJarMods()
-{
-	return QList<JarmodPtr>();
-}
-
-QString MinecraftVersion::getName()
-{
-	return "Minecraft";
-}
-QString MinecraftVersion::getVersion()
-{
-	return m_descriptor;
-}
-QString MinecraftVersion::getID()
-{
-	return "net.minecraft";
-}
-QString MinecraftVersion::getFilename()
-{
-	return QString();
-}
-QDateTime MinecraftVersion::getReleaseDateTime()
-{
-	return m_releaseTime;
-}
-
-
-bool MinecraftVersion::needsUpdate()
-{
-	return m_versionSource == VersionSource::Remote || hasUpdate();
-}
-
-bool MinecraftVersion::hasUpdate()
-{
-	return m_versionSource == VersionSource::Remote || (m_versionSource == VersionSource::Local && upstreamUpdate);
-}
-
-bool MinecraftVersion::isCustom()
-{
-	// if we add any other source types, this will evaluate to false for them.
-	return m_versionSource != VersionSource::Builtin
-		&& m_versionSource != VersionSource::Local
-		&& m_versionSource != VersionSource::Remote;
-}
diff --git a/api/logic/minecraft/MinecraftVersion.h b/api/logic/minecraft/MinecraftVersion.h
deleted file mode 100644
index 7ac9bcbb..00000000
--- a/api/logic/minecraft/MinecraftVersion.h
+++ /dev/null
@@ -1,132 +0,0 @@
-/* Copyright 2013-2017 MultiMC Contributors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#pragma once
-
-#include <QStringList>
-#include <QSet>
-#include <QDateTime>
-
-#include "BaseVersion.h"
-#include "ProfilePatch.h"
-#include "VersionFile.h"
-
-#include "multimc_logic_export.h"
-
-class MinecraftProfile;
-class MinecraftVersion;
-typedef std::shared_ptr<MinecraftVersion> MinecraftVersionPtr;
-
-class MULTIMC_LOGIC_EXPORT MinecraftVersion : public BaseVersion, public ProfilePatch
-{
-friend class MinecraftVersionList;
-
-public: /* methods */
-	bool usesLegacyLauncher();
-	virtual QString descriptor() override;
-	virtual QString name() override;
-	virtual QString typeString() const override;
-	virtual bool hasJarMods() override;
-	virtual bool isMinecraftVersion() override;
-	virtual void applyTo(MinecraftProfile *profile) override;
-	virtual int getOrder() override;
-	virtual void setOrder(int order) override;
-	virtual QList<JarmodPtr> getJarMods() override;
-	virtual QString getID() override;
-	virtual QString getVersion() override;
-	virtual QString getName() override;
-	virtual QString getFilename() override;
-	QDateTime getReleaseDateTime() override;
-	VersionSource getVersionSource() override;
-
-	bool needsUpdate();
-	bool hasUpdate();
-	virtual bool isCustom() override;
-	virtual bool isMoveable() override
-	{
-		return false;
-	}
-	virtual bool isCustomizable() override;
-	virtual bool isRemovable() override
-	{
-		return false;
-	}
-	virtual bool isRevertible() override
-	{
-		return false;
-	}
-	virtual bool isEditable() override
-	{
-		return false;
-	}
-	virtual bool isVersionChangeable() override
-	{
-		return true;
-	}
-
-	virtual VersionFilePtr getVersionFile() override;
-
-	// virtual QJsonDocument toJson(bool saveOrder) override;
-
-	QString getUrl() const;
-
-	virtual const QList<PatchProblem> &getProblems() override;
-	virtual ProblemSeverity getProblemSeverity() override;
-
-private: /* methods */
-	void applyFileTo(MinecraftProfile *profile);
-
-protected: /* data */
-	VersionSource m_versionSource = VersionSource::Builtin;
-
-	/// The URL that this version will be downloaded from.
-	QString m_versionFileURL;
-
-	/// the human readable version name
-	QString m_name;
-
-	/// the version ID.
-	QString m_descriptor;
-
-	/// version traits. added by MultiMC
-	QSet<QString> m_traits;
-
-	/// The main class this version uses (if any, can be empty).
-	QString m_mainClass;
-
-	/// The applet class this version uses (if any, can be empty).
-	QString m_appletClass;
-
-	/// The type of this release
-	QString m_type;
-
-	/// the time this version was actually released by Mojang
-	QDateTime m_releaseTime;
-
-	/// the time this version was last updated by Mojang
-	QDateTime m_updateTime;
-
-	/// MD5 hash of the minecraft jar
-	QString m_jarChecksum;
-
-	/// order of this file... default = -2
-	int order = -2;
-
-	/// an update available from Mojang
-	MinecraftVersionPtr upstreamUpdate;
-
-	QDateTime m_loadedVersionFileTimestamp;
-	mutable VersionFilePtr m_loadedVersionFile;
-};
diff --git a/api/logic/minecraft/MinecraftVersionList.cpp b/api/logic/minecraft/MinecraftVersionList.cpp
deleted file mode 100644
index 0dc46289..00000000
--- a/api/logic/minecraft/MinecraftVersionList.cpp
+++ /dev/null
@@ -1,614 +0,0 @@
-/* Copyright 2013-2017 MultiMC Contributors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#include <QtXml>
-#include "Json.h"
-#include <QtAlgorithms>
-#include <QtNetwork>
-
-#include "Env.h"
-#include "Exception.h"
-
-#include "MinecraftVersionList.h"
-#include "net/URLConstants.h"
-
-#include "ParseUtils.h"
-#include "ProfileUtils.h"
-#include "onesix/OneSixVersionFormat.h"
-#include "MojangVersionFormat.h"
-#include <FileSystem.h>
-
-static const char * localVersionCache = "versions/versions.dat";
-
-class MCVListLoadTask : public Task
-{
-	Q_OBJECT
-
-public:
-	explicit MCVListLoadTask(MinecraftVersionList *vlist);
-	virtual ~MCVListLoadTask() override{};
-
-	virtual void executeTask() override;
-
-protected
-slots:
-	void list_downloaded();
-
-protected:
-	QNetworkReply *vlistReply;
-	MinecraftVersionList *m_list;
-	MinecraftVersion *m_currentStable;
-};
-
-class MCVListVersionUpdateTask : public Task
-{
-	Q_OBJECT
-
-public:
-	explicit MCVListVersionUpdateTask(MinecraftVersionList *vlist, std::shared_ptr<MinecraftVersion> updatedVersion);
-	virtual ~MCVListVersionUpdateTask() override{};
-	virtual void executeTask() override;
-	bool canAbort() const override;
-
-public slots:
-	bool abort() override;
-
-protected
-slots:
-	void json_downloaded();
-
-protected:
-	NetJobPtr specificVersionDownloadJob;
-	QByteArray versionIndexData;
-	std::shared_ptr<MinecraftVersion> updatedVersion;
-	MinecraftVersionList *m_list;
-	bool m_aborted = false;
-};
-
-class ListLoadError : public Exception
-{
-public:
-	ListLoadError(QString cause) : Exception(cause) {};
-	virtual ~ListLoadError() noexcept
-	{
-	}
-};
-
-MinecraftVersionList::MinecraftVersionList(QObject *parent) : BaseVersionList(parent)
-{
-	loadCachedList();
-}
-
-Task *MinecraftVersionList::getLoadTask()
-{
-	return new MCVListLoadTask(this);
-}
-
-bool MinecraftVersionList::isLoaded()
-{
-	return m_loaded;
-}
-
-const BaseVersionPtr MinecraftVersionList::at(int i) const
-{
-	return m_vlist.at(i);
-}
-
-int MinecraftVersionList::count() const
-{
-	return m_vlist.count();
-}
-
-static bool cmpVersions(BaseVersionPtr first, BaseVersionPtr second)
-{
-	auto left = std::dynamic_pointer_cast<MinecraftVersion>(first);
-	auto right = std::dynamic_pointer_cast<MinecraftVersion>(second);
-	return left->getReleaseDateTime() > right->getReleaseDateTime();
-}
-
-void MinecraftVersionList::sortInternal()
-{
-	qSort(m_vlist.begin(), m_vlist.end(), cmpVersions);
-}
-
-void MinecraftVersionList::loadCachedList()
-{
-	QFile localIndex(localVersionCache);
-	if (!localIndex.exists())
-	{
-		return;
-	}
-	if (!localIndex.open(QIODevice::ReadOnly))
-	{
-		// FIXME: this is actually a very bad thing! How do we deal with this?
-		qCritical() << "The minecraft version cache can't be read.";
-		return;
-	}
-	auto data = localIndex.readAll();
-	try
-	{
-		localIndex.close();
-		QJsonDocument jsonDoc = QJsonDocument::fromBinaryData(data);
-		if (jsonDoc.isNull())
-		{
-			throw ListLoadError(tr("Error reading the version list."));
-		}
-		loadMojangList(jsonDoc, VersionSource::Local);
-	}
-	catch (Exception &e)
-	{
-		// the cache has gone bad for some reason... flush it.
-		qCritical() << "The minecraft version cache is corrupted. Flushing cache.";
-		localIndex.remove();
-		return;
-	}
-	m_hasLocalIndex = true;
-}
-
-void MinecraftVersionList::loadMojangList(QJsonDocument jsonDoc, VersionSource source)
-{
-	qDebug() << "Loading" << ((source == VersionSource::Remote) ? "remote" : "local") << "version list.";
-
-	if (!jsonDoc.isObject())
-	{
-		throw ListLoadError(tr("Error parsing version list JSON: jsonDoc is not an object"));
-	}
-
-	QJsonObject root = jsonDoc.object();
-
-	try
-	{
-		QJsonObject latest = Json::requireObject(root.value("latest"));
-		m_latestReleaseID = Json::requireString(latest.value("release"));
-		m_latestSnapshotID = Json::requireString(latest.value("snapshot"));
-	}
-	catch (Exception &err)
-	{
-		qCritical()
-			<< tr("Error parsing version list JSON: couldn't determine latest versions");
-	}
-
-	// Now, get the array of versions.
-	if (!root.value("versions").isArray())
-	{
-		throw ListLoadError(tr("Error parsing version list JSON: version list object is "
-							   "missing 'versions' array"));
-	}
-	QJsonArray versions = root.value("versions").toArray();
-
-	QList<BaseVersionPtr> tempList;
-	for (auto version : versions)
-	{
-		// Load the version info.
-		if (!version.isObject())
-		{
-			qCritical() << "Error while parsing version list : invalid JSON structure";
-			continue;
-		}
-
-		QJsonObject versionObj = version.toObject();
-		QString versionID = versionObj.value("id").toString("");
-		if (versionID.isEmpty())
-		{
-			qCritical() << "Error while parsing version : version ID is missing";
-			continue;
-		}
-
-		// Now, we construct the version object and add it to the list.
-		std::shared_ptr<MinecraftVersion> mcVersion(new MinecraftVersion());
-		mcVersion->m_name = mcVersion->m_descriptor = versionID;
-
-		mcVersion->m_releaseTime = timeFromS3Time(versionObj.value("releaseTime").toString(""));
-		mcVersion->m_updateTime = timeFromS3Time(versionObj.value("time").toString(""));
-
-		// depends on where we load the version from -- network request or local file?
-		mcVersion->m_versionSource = source;
-		mcVersion->m_versionFileURL = versionObj.value("url").toString("");
-		QString versionTypeStr = versionObj.value("type").toString("");
-		if (versionTypeStr.isEmpty())
-		{
-			qCritical() << "Ignoring" << versionID
-						 << "because it doesn't have the version type set.";
-			continue;
-		}
-		// OneSix or Legacy. use filter to determine type
-		if (versionTypeStr == "release")
-		{
-		}
-		else if (versionTypeStr == "snapshot") // It's a snapshot... yay
-		{
-		}
-		else if (versionTypeStr == "old_alpha")
-		{
-		}
-		else if (versionTypeStr == "old_beta")
-		{
-		}
-		else
-		{
-			qCritical() << "Ignoring" << versionID
-						 << "because it has an invalid version type.";
-			continue;
-		}
-		mcVersion->m_type = versionTypeStr;
-		qDebug() << "Loaded version" << versionID << "from"
-					<< ((source == VersionSource::Remote) ? "remote" : "local") << "version list.";
-		tempList.append(mcVersion);
-	}
-	updateListData(tempList);
-	if(source == VersionSource::Remote)
-	{
-		m_loaded = true;
-	}
-}
-
-void MinecraftVersionList::sortVersions()
-{
-	beginResetModel();
-	sortInternal();
-	endResetModel();
-}
-
-QVariant MinecraftVersionList::data(const QModelIndex& index, int role) const
-{
-	if (!index.isValid())
-		return QVariant();
-
-	if (index.row() > count())
-		return QVariant();
-
-	auto version = std::dynamic_pointer_cast<MinecraftVersion>(m_vlist[index.row()]);
-	switch (role)
-	{
-	case VersionPointerRole:
-		return qVariantFromValue(m_vlist[index.row()]);
-
-	case VersionRole:
-		return version->name();
-
-	case VersionIdRole:
-		return version->descriptor();
-
-	case RecommendedRole:
-		return version->descriptor() == m_latestReleaseID;
-
-	case LatestRole:
-	{
-		if(version->descriptor() != m_latestSnapshotID)
-			return false;
-		MinecraftVersionPtr latestRelease = std::dynamic_pointer_cast<MinecraftVersion>(getLatestStable());
-		/*
-		if(latestRelease && latestRelease->m_releaseTime > version->m_releaseTime)
-		{
-			return false;
-		}
-		*/
-		return true;
-	}
-
-	case TypeRole:
-		return version->typeString();
-
-	default:
-		return QVariant();
-	}
-}
-
-BaseVersionList::RoleList MinecraftVersionList::providesRoles() const
-{
-	return {VersionPointerRole, VersionRole, VersionIdRole, RecommendedRole, LatestRole, TypeRole};
-}
-
-BaseVersionPtr MinecraftVersionList::getLatestStable() const
-{
-	if(m_lookup.contains(m_latestReleaseID))
-		return m_lookup[m_latestReleaseID];
-	return BaseVersionPtr();
-}
-
-BaseVersionPtr MinecraftVersionList::getRecommended() const
-{
-	return getLatestStable();
-}
-
-void MinecraftVersionList::updateListData(QList<BaseVersionPtr> versions)
-{
-	beginResetModel();
-	for (auto version : versions)
-	{
-		auto descr = version->descriptor();
-
-		if (!m_lookup.contains(descr))
-		{
-			m_lookup[version->descriptor()] = version;
-			m_vlist.append(version);
-			continue;
-		}
-		auto orig = std::dynamic_pointer_cast<MinecraftVersion>(m_lookup[descr]);
-		auto added = std::dynamic_pointer_cast<MinecraftVersion>(version);
-		// updateListData is called after Mojang list loads. those can be local or remote
-		// remote comes always after local
-		// any other options are ignored
-		if (orig->m_versionSource != VersionSource::Local || added->m_versionSource != VersionSource::Remote)
-		{
-			continue;
-		}
-		// alright, it's an update. put it inside the original, for further processing.
-		orig->upstreamUpdate = added;
-	}
-	sortInternal();
-	endResetModel();
-}
-
-MCVListLoadTask::MCVListLoadTask(MinecraftVersionList *vlist)
-{
-	m_list = vlist;
-	m_currentStable = NULL;
-	vlistReply = nullptr;
-}
-
-void MCVListLoadTask::executeTask()
-{
-	setStatus(tr("Loading instance version list..."));
-	vlistReply = ENV.qnam().get(QNetworkRequest(QUrl("https://launchermeta.mojang.com/mc/game/version_manifest.json")));
-	connect(vlistReply, SIGNAL(finished()), this, SLOT(list_downloaded()));
-}
-
-void MCVListLoadTask::list_downloaded()
-{
-	if (vlistReply->error() != QNetworkReply::NoError)
-	{
-		vlistReply->deleteLater();
-		emitFailed("Failed to load Minecraft main version list" + vlistReply->errorString());
-		return;
-	}
-
-	auto data = vlistReply->readAll();
-	vlistReply->deleteLater();
-	try
-	{
-		QJsonParseError jsonError;
-		QJsonDocument jsonDoc = QJsonDocument::fromJson(data, &jsonError);
-		if (jsonError.error != QJsonParseError::NoError)
-		{
-			throw ListLoadError(
-				tr("Error parsing version list JSON: %1").arg(jsonError.errorString()));
-		}
-		m_list->loadMojangList(jsonDoc, VersionSource::Remote);
-	}
-	catch (Exception &e)
-	{
-		emitFailed(e.cause());
-		return;
-	}
-
-	emitSucceeded();
-	return;
-}
-
-MCVListVersionUpdateTask::MCVListVersionUpdateTask(MinecraftVersionList *vlist, std::shared_ptr<MinecraftVersion> updatedVersion)
-	: Task()
-{
-	m_list = vlist;
-	this->updatedVersion = updatedVersion;
-}
-
-void MCVListVersionUpdateTask::executeTask()
-{
-	if(m_aborted)
-	{
-		emitFailed(tr("Task aborted."));
-		return;
-	}
-	auto job = new NetJob("Version index");
-	job->addNetAction(Net::Download::makeByteArray(QUrl(updatedVersion->getUrl()), &versionIndexData));
-	specificVersionDownloadJob.reset(job);
-	connect(specificVersionDownloadJob.get(), SIGNAL(succeeded()), SLOT(json_downloaded()));
-	connect(specificVersionDownloadJob.get(), SIGNAL(failed(QString)), SIGNAL(failed(QString)));
-	connect(specificVersionDownloadJob.get(), SIGNAL(progress(qint64, qint64)), SIGNAL(progress(qint64, qint64)));
-	specificVersionDownloadJob->start();
-}
-
-bool MCVListVersionUpdateTask::canAbort() const
-{
-	return true;
-}
-
-bool MCVListVersionUpdateTask::abort()
-{
-	m_aborted = true;
-	if(specificVersionDownloadJob)
-	{
-		return specificVersionDownloadJob->abort();
-	}
-	return true;
-}
-
-void MCVListVersionUpdateTask::json_downloaded()
-{
-	specificVersionDownloadJob.reset();
-
-	QJsonParseError jsonError;
-	QJsonDocument jsonDoc = QJsonDocument::fromJson(versionIndexData, &jsonError);
-	versionIndexData.clear();
-
-	if (jsonError.error != QJsonParseError::NoError)
-	{
-		emitFailed(tr("The download version file is not valid."));
-		return;
-	}
-	VersionFilePtr file;
-	try
-	{
-		file = MojangVersionFormat::versionFileFromJson(jsonDoc, "net.minecraft.json");
-	}
-	catch (Exception &e)
-	{
-		emitFailed(tr("Couldn't process version file: %1").arg(e.cause()));
-		return;
-	}
-
-	// Strip LWJGL from the version file. We use our own.
-	ProfileUtils::removeLwjglFromPatch(file);
-
-	// TODO: recognize and add LWJGL versions here.
-
-	file->fileId = "net.minecraft";
-
-	// now dump the file to disk
-	auto doc = OneSixVersionFormat::versionFileToJson(file, false);
-	auto newdata = doc.toBinaryData();
-	auto id = updatedVersion->descriptor();
-	QString targetPath = "versions/" + id + "/" + id + ".dat";
-	FS::ensureFilePathExists(targetPath);
-	QSaveFile vfile1(targetPath);
-	if (!vfile1.open(QIODevice::Truncate | QIODevice::WriteOnly))
-	{
-		emitFailed(tr("Can't open %1 for writing.").arg(targetPath));
-		return;
-	}
-	qint64 actual = 0;
-	if ((actual = vfile1.write(newdata)) != newdata.size())
-	{
-		emitFailed(tr("Failed to write into %1. Written %2 out of %3.")
-					   .arg(targetPath)
-					   .arg(actual)
-					   .arg(newdata.size()));
-		return;
-	}
-	if (!vfile1.commit())
-	{
-		emitFailed(tr("Can't commit changes to %1").arg(targetPath));
-		return;
-	}
-
-	m_list->finalizeUpdate(id);
-	emitSucceeded();
-}
-
-std::shared_ptr<Task> MinecraftVersionList::createUpdateTask(QString version)
-{
-	auto iter = m_lookup.find(version);
-	if(iter == m_lookup.end())
-		return nullptr;
-
-	auto mcversion = std::dynamic_pointer_cast<MinecraftVersion>(*iter);
-	if(!mcversion)
-	{
-		return nullptr;
-	}
-
-	return std::shared_ptr<Task>(new MCVListVersionUpdateTask(this, mcversion));
-}
-
-void MinecraftVersionList::saveCachedList()
-{
-	// FIXME: throw.
-	if (!FS::ensureFilePathExists(localVersionCache))
-		return;
-	QSaveFile tfile(localVersionCache);
-	if (!tfile.open(QIODevice::WriteOnly | QIODevice::Truncate))
-		return;
-	QJsonObject toplevel;
-	QJsonArray entriesArr;
-	for (auto version : m_vlist)
-	{
-		auto mcversion = std::dynamic_pointer_cast<MinecraftVersion>(version);
-		// do not save the remote versions.
-		if (mcversion->m_versionSource != VersionSource::Local)
-			continue;
-		QJsonObject entryObj;
-
-		entryObj.insert("id", mcversion->descriptor());
-		entryObj.insert("version", mcversion->descriptor());
-		entryObj.insert("time", timeToS3Time(mcversion->m_updateTime));
-		entryObj.insert("releaseTime", timeToS3Time(mcversion->m_releaseTime));
-		entryObj.insert("url", mcversion->m_versionFileURL);
-		entryObj.insert("type", mcversion->m_type);
-		entriesArr.append(entryObj);
-	}
-	toplevel.insert("versions", entriesArr);
-
-	{
-		bool someLatest = false;
-		QJsonObject latestObj;
-		if(!m_latestReleaseID.isNull())
-		{
-			latestObj.insert("release", m_latestReleaseID);
-			someLatest = true;
-		}
-		if(!m_latestSnapshotID.isNull())
-		{
-			latestObj.insert("snapshot", m_latestSnapshotID);
-			someLatest = true;
-		}
-		if(someLatest)
-		{
-			toplevel.insert("latest", latestObj);
-		}
-	}
-
-	QJsonDocument doc(toplevel);
-	QByteArray jsonData = doc.toBinaryData();
-	qint64 result = tfile.write(jsonData);
-	if (result == -1)
-		return;
-	if (result != jsonData.size())
-		return;
-	tfile.commit();
-}
-
-void MinecraftVersionList::finalizeUpdate(QString version)
-{
-	int idx = -1;
-	for (int i = 0; i < m_vlist.size(); i++)
-	{
-		if (version == m_vlist[i]->descriptor())
-		{
-			idx = i;
-			break;
-		}
-	}
-	if (idx == -1)
-	{
-		return;
-	}
-
-	auto updatedVersion = std::dynamic_pointer_cast<MinecraftVersion>(m_vlist[idx]);
-
-	// reject any updates to builtin versions.
-	if (updatedVersion->m_versionSource == VersionSource::Builtin)
-		return;
-
-	// if we have an update for the version, replace it, make the update local
-	if (updatedVersion->upstreamUpdate)
-	{
-		auto updatedWith = updatedVersion->upstreamUpdate;
-		updatedWith->m_versionSource = VersionSource::Local;
-		m_vlist[idx] = updatedWith;
-		m_lookup[version] = updatedWith;
-	}
-	else
-	{
-		// otherwise, just set the version as local;
-		updatedVersion->m_versionSource = VersionSource::Local;
-	}
-
-	dataChanged(index(idx), index(idx));
-
-	saveCachedList();
-}
-
-#include "MinecraftVersionList.moc"
diff --git a/api/logic/minecraft/MinecraftVersionList.h b/api/logic/minecraft/MinecraftVersionList.h
deleted file mode 100644
index fc421966..00000000
--- a/api/logic/minecraft/MinecraftVersionList.h
+++ /dev/null
@@ -1,72 +0,0 @@
-/* Copyright 2013-2017 MultiMC Contributors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#pragma once
-
-#include <QObject>
-#include <QList>
-#include <QSet>
-
-#include "BaseVersionList.h"
-#include "tasks/Task.h"
-#include "minecraft/MinecraftVersion.h"
-#include <net/NetJob.h>
-
-#include "multimc_logic_export.h"
-
-class MCVListLoadTask;
-class MCVListVersionUpdateTask;
-
-class MULTIMC_LOGIC_EXPORT MinecraftVersionList : public BaseVersionList
-{
-	Q_OBJECT
-private:
-	void sortInternal();
-	void loadMojangList(QJsonDocument jsonDoc, VersionSource source);
-	void loadCachedList();
-	void saveCachedList();
-	void finalizeUpdate(QString version);
-public:
-	friend class MCVListLoadTask;
-	friend class MCVListVersionUpdateTask;
-
-	explicit MinecraftVersionList(QObject *parent = 0);
-
-	std::shared_ptr<Task> createUpdateTask(QString version);
-
-	virtual Task *getLoadTask() override;
-	virtual bool isLoaded() override;
-	virtual const BaseVersionPtr at(int i) const override;
-	virtual int count() const override;
-	virtual void sortVersions() override;
-	virtual QVariant data(const QModelIndex & index, int role) const override;
-	virtual RoleList providesRoles() const override;
-
-	virtual BaseVersionPtr getLatestStable() const override;
-	virtual BaseVersionPtr getRecommended() const override;
-
-protected:
-	QList<BaseVersionPtr> m_vlist;
-	QMap<QString, BaseVersionPtr> m_lookup;
-
-	bool m_loaded = false;
-	bool m_hasLocalIndex = false;
-	QString m_latestReleaseID = "INVALID";
-	QString m_latestSnapshotID = "INVALID";
-
-protected
-slots:
-	virtual void updateListData(QList<BaseVersionPtr> versions) override;
-};
diff --git a/api/logic/minecraft/MojangVersionFormat.cpp b/api/logic/minecraft/MojangVersionFormat.cpp
index 34129c9e..1312421f 100644
--- a/api/logic/minecraft/MojangVersionFormat.cpp
+++ b/api/logic/minecraft/MojangVersionFormat.cpp
@@ -1,6 +1,5 @@
 #include "MojangVersionFormat.h"
 #include "onesix/OneSixVersionFormat.h"
-#include "MinecraftVersion.h"
 #include "VersionBuildError.h"
 #include "MojangDownloadInfo.h"
 
diff --git a/api/logic/minecraft/forge/ForgeInstaller.cpp b/api/logic/minecraft/forge/ForgeInstaller.cpp
index a9c12fcd..f7ce4dec 100644
--- a/api/logic/minecraft/forge/ForgeInstaller.cpp
+++ b/api/logic/minecraft/forge/ForgeInstaller.cpp
@@ -23,7 +23,6 @@
 #include "minecraft/onesix/OneSixInstance.h"
 #include <minecraft/onesix/OneSixVersionFormat.h>
 #include "minecraft/VersionFilterData.h"
-#include "minecraft/MinecraftVersion.h"
 #include "Env.h"
 #include "Exception.h"
 #include <FileSystem.h>
@@ -137,6 +136,9 @@ void ForgeInstaller::prepare(const QString &filename, const QString &universalUr
 
 bool ForgeInstaller::add(OneSixInstance *to)
 {
+	return false;
+	// TODO: move to python code.
+/*
 	if (!BaseInstaller::add(to))
 	{
 		return false;
@@ -286,10 +288,14 @@ bool ForgeInstaller::add(OneSixInstance *to)
 	file.commit();
 
 	return true;
+	*/
 }
 
 bool ForgeInstaller::addLegacy(OneSixInstance *to)
 {
+	return false;
+	//FIXME: move to python code.
+	/*
 	if (!BaseInstaller::add(to))
 	{
 		return false;
@@ -339,6 +345,7 @@ bool ForgeInstaller::addLegacy(OneSixInstance *to)
 	file.write(QJsonDocument(obj).toJson());
 	file.close();
 	return true;
+	*/
 }
 
 class ForgeInstallTask : public Task
diff --git a/api/logic/minecraft/ftb/FTBInstanceProvider.cpp b/api/logic/minecraft/ftb/FTBInstanceProvider.cpp
index 1321ea1b..fe23a84e 100644
--- a/api/logic/minecraft/ftb/FTBInstanceProvider.cpp
+++ b/api/logic/minecraft/ftb/FTBInstanceProvider.cpp
@@ -9,7 +9,6 @@
 #include <FileSystem.h>
 
 #include "Env.h"
-#include "minecraft/MinecraftVersion.h"
 
 #include "LegacyFTBInstance.h"
 #include "OneSixFTBInstance.h"
@@ -246,17 +245,8 @@ InstancePtr FTBInstanceProvider::createInstance(const FTBRecord & record) const
 	m_settings->registerSetting("InstanceType", "Legacy");
 
 	// all legacy versions are built in. therefore we can do this even if we don't have ALL the versions Mojang has on their servers.
-	auto mcVersion = std::dynamic_pointer_cast<MinecraftVersion>(ENV.getVersion("net.minecraft", record.mcVersion));
-	if (mcVersion && mcVersion->usesLegacyLauncher())
-	{
-		m_settings->set("InstanceType", "LegacyFTB");
-		inst.reset(new LegacyFTBInstance(m_globalSettings, m_settings, record.instanceDir));
-	}
-	else
-	{
-		m_settings->set("InstanceType", "OneSixFTB");
-		inst.reset(new OneSixFTBInstance(m_globalSettings, m_settings, record.instanceDir));
-	}
+	m_settings->set("InstanceType", "OneSixFTB");
+	inst.reset(new OneSixFTBInstance(m_globalSettings, m_settings, record.instanceDir));
 
 	// initialize
 	{
diff --git a/api/logic/minecraft/ftb/FTBPlugin.cpp b/api/logic/minecraft/ftb/FTBPlugin.cpp
index d14eea63..541879a1 100644
--- a/api/logic/minecraft/ftb/FTBPlugin.cpp
+++ b/api/logic/minecraft/ftb/FTBPlugin.cpp
@@ -1,11 +1,9 @@
 #include "FTBPlugin.h"
 #include <Env.h>
-#include "FTBVersion.h"
 #include "LegacyFTBInstance.h"
 #include "OneSixFTBInstance.h"
 #include <BaseInstance.h>
 #include <InstanceList.h>
-#include <minecraft/MinecraftVersionList.h>
 #include <settings/INISettingsObject.h>
 #include <FileSystem.h>
 
diff --git a/api/logic/minecraft/ftb/FTBProfileStrategy.cpp b/api/logic/minecraft/ftb/FTBProfileStrategy.cpp
index e4e6a6ae..92a1555a 100644
--- a/api/logic/minecraft/ftb/FTBProfileStrategy.cpp
+++ b/api/logic/minecraft/ftb/FTBProfileStrategy.cpp
@@ -2,7 +2,6 @@
 #include "OneSixFTBInstance.h"
 
 #include "minecraft/VersionBuildError.h"
-#include "minecraft/MinecraftVersionList.h"
 #include <FileSystem.h>
 
 #include <QDir>
diff --git a/api/logic/minecraft/ftb/FTBVersion.h b/api/logic/minecraft/ftb/FTBVersion.h
deleted file mode 100644
index 805319b4..00000000
--- a/api/logic/minecraft/ftb/FTBVersion.h
+++ /dev/null
@@ -1,32 +0,0 @@
-#pragma once
-#include <minecraft/MinecraftVersion.h>
-
-class FTBVersion : public BaseVersion
-{
-public:
-	FTBVersion(MinecraftVersionPtr parent) : m_version(parent){};
-
-public:
-	virtual QString descriptor() override
-	{
-		return m_version->descriptor();
-	}
-
-	virtual QString name() override
-	{
-		return m_version->name();
-	}
-
-	virtual QString typeString() const override
-	{
-		return m_version->typeString();
-	}
-
-	MinecraftVersionPtr getMinecraftVersion()
-	{
-		return m_version;
-	}
-
-private:
-	MinecraftVersionPtr m_version;
-};
diff --git a/api/logic/minecraft/legacy/LegacyUpdate.cpp b/api/logic/minecraft/legacy/LegacyUpdate.cpp
index fbef47f5..337a3e4e 100644
--- a/api/logic/minecraft/legacy/LegacyUpdate.cpp
+++ b/api/logic/minecraft/legacy/LegacyUpdate.cpp
@@ -27,7 +27,6 @@
 #include "LegacyModList.h"
 
 #include "LwjglVersionList.h"
-#include "minecraft/MinecraftVersionList.h"
 #include "LegacyInstance.h"
 #include <FileSystem.h>
 
diff --git a/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp b/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
index 07c9f075..2b023e82 100644
--- a/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
+++ b/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
@@ -3,7 +3,6 @@
 #include "OneSixVersionFormat.h"
 
 #include "minecraft/VersionBuildError.h"
-#include "minecraft/MinecraftVersionList.h"
 #include "Env.h"
 #include <FileSystem.h>
 
@@ -11,6 +10,8 @@
 #include <QUuid>
 #include <QJsonDocument>
 #include <QJsonArray>
+#include <QSaveFile>
+#include <QResource>
 
 OneSixProfileStrategy::OneSixProfileStrategy(OneSixInstance* instance)
 {
diff --git a/api/logic/minecraft/onesix/OneSixUpdate.cpp b/api/logic/minecraft/onesix/OneSixUpdate.cpp
index 4bc80bfe..ec40e086 100644
--- a/api/logic/minecraft/onesix/OneSixUpdate.cpp
+++ b/api/logic/minecraft/onesix/OneSixUpdate.cpp
@@ -24,7 +24,6 @@
 #include <QDataStream>
 
 #include "BaseInstance.h"
-#include "minecraft/MinecraftVersionList.h"
 #include "minecraft/MinecraftProfile.h"
 #include "minecraft/Library.h"
 #include "net/URLConstants.h"
@@ -44,6 +43,7 @@ OneSixUpdate::OneSixUpdate(OneSixInstance *inst, QObject *parent) : Task(parent)
 
 	// add a version update task, if necessary
 	{
+		/*
 		auto list = std::dynamic_pointer_cast<MinecraftVersionList>(ENV.getVersionList("net.minecraft"));
 		auto version = std::dynamic_pointer_cast<MinecraftVersion>(list->findVersion(m_inst->intendedVersionId()));
 		if (version == nullptr)
@@ -67,6 +67,7 @@ OneSixUpdate::OneSixUpdate(OneSixInstance *inst, QObject *parent) : Task(parent)
 				m_tasks.append(versionUpdateTask);
 			}
 		}
+		*/
 	}
 
 	// libraries download
diff --git a/api/logic/minecraft/onesix/OneSixVersionFormat.cpp b/api/logic/minecraft/onesix/OneSixVersionFormat.cpp
index 541fb109..403eb112 100644
--- a/api/logic/minecraft/onesix/OneSixVersionFormat.cpp
+++ b/api/logic/minecraft/onesix/OneSixVersionFormat.cpp
@@ -1,7 +1,6 @@
 #include "OneSixVersionFormat.h"
 #include <Json.h>
 #include "minecraft/ParseUtils.h"
-#include <minecraft/MinecraftVersion.h>
 #include <minecraft/VersionBuildError.h>
 #include <minecraft/MojangVersionFormat.h>
 
diff --git a/application/MainWindow.cpp b/application/MainWindow.cpp
index 3bdf540d..9073c006 100644
--- a/application/MainWindow.cpp
+++ b/application/MainWindow.cpp
@@ -54,7 +54,6 @@
 #include <java/JavaUtils.h>
 #include <java/JavaInstallList.h>
 #include <launch/LaunchTask.h>
-#include <minecraft/MinecraftVersionList.h>
 #include <minecraft/legacy/LwjglVersionList.h>
 #include <minecraft/auth/MojangAccountList.h>
 #include <SkinUtils.h>
@@ -558,6 +557,7 @@ MainWindow::MainWindow(QWidget *parent) : QMainWindow(parent), ui(new MainWindow
 	// run the things that load and download other things... FIXME: this is NOT the place
 	// FIXME: invisible actions in the background = NOPE.
 	{
+		/*
 		if (!MMC->minecraftlist()->isLoaded())
 		{
 			m_versionLoadTask = MMC->minecraftlist()->getLoadTask();
@@ -567,6 +567,7 @@ MainWindow::MainWindow(QWidget *parent) : QMainWindow(parent), ui(new MainWindow
 		{
 			MMC->lwjgllist()->loadList();
 		}
+		*/
 
 		m_newsChecker->reloadNews();
 		updateNewsLabel();
@@ -1014,18 +1015,6 @@ void MainWindow::setCatBackground(bool enabled)
 	}
 }
 
-// FIXME: eliminate, should not be needed
-void MainWindow::waitForMinecraftVersions()
-{
-	if (!MMC->minecraftlist()->isLoaded() && m_versionLoadTask && m_versionLoadTask->isRunning())
-	{
-		QEventLoop waitLoop;
-		waitLoop.connect(m_versionLoadTask, &Task::failed, &waitLoop, &QEventLoop::quit);
-		waitLoop.connect(m_versionLoadTask, &Task::succeeded, &waitLoop, &QEventLoop::quit);
-		waitLoop.exec();
-	}
-}
-
 void MainWindow::runModalTask(Task *task)
 {
 	connect(task, &Task::failed, [this](QString reason)
@@ -1117,8 +1106,6 @@ void MainWindow::on_actionAddInstance_triggered()
 		groupName = map["group"].toString();
 	} while(0);
 
-	waitForMinecraftVersions();
-
 	if(groupName.isEmpty())
 	{
 		groupName = MMC->settings()->get("LastUsedGroupForNewInstance").toString();
diff --git a/application/MainWindow.h b/application/MainWindow.h
index 6b30c86e..a7ab9172 100644
--- a/application/MainWindow.h
+++ b/application/MainWindow.h
@@ -167,7 +167,6 @@ private:
 	void updateInstanceToolIcon(QString new_icon);
 	void setSelectedInstanceById(const QString &id);
 
-	void waitForMinecraftVersions();
 	void runModalTask(Task *task);
 	void instanceFromVersion(QString instName, QString instGroup, QString instIcon, BaseVersionPtr version);
 	void instanceFromZipPack(QString instName, QString instGroup, QString instIcon, QUrl url);
diff --git a/application/MultiMC.cpp b/application/MultiMC.cpp
index 3a91fb5f..98b73a6e 100644
--- a/application/MultiMC.cpp
+++ b/application/MultiMC.cpp
@@ -42,7 +42,6 @@
 #include "icons/IconList.h"
 //FIXME: get rid of this
 #include "minecraft/legacy/LwjglVersionList.h"
-#include "minecraft/MinecraftVersionList.h"
 #include "minecraft/liteloader/LiteLoaderVersionList.h"
 #include "minecraft/forge/ForgeVersionList.h"
 
@@ -338,7 +337,6 @@ MultiMC::MultiMC(int &argc, char **argv) : QApplication(argc, argv)
 	initIcons();
 	initThemes();
 	// make sure we have at least some minecraft versions before we init instances
-	minecraftlist();
 	initInstances();
 	initAccounts();
 	initNetwork();
@@ -890,16 +888,6 @@ std::shared_ptr<LiteLoaderVersionList> MultiMC::liteloaderlist()
 	return m_liteloaderlist;
 }
 
-std::shared_ptr<MinecraftVersionList> MultiMC::minecraftlist()
-{
-	if (!m_minecraftlist)
-	{
-		m_minecraftlist.reset(new MinecraftVersionList());
-		ENV.registerVersionList("net.minecraft", m_minecraftlist);
-	}
-	return m_minecraftlist;
-}
-
 std::shared_ptr<JavaInstallList> MultiMC::javalist()
 {
 	if (!m_javalist)
diff --git a/application/MultiMC.h b/application/MultiMC.h
index d8062bb5..8dc2e609 100644
--- a/application/MultiMC.h
+++ b/application/MultiMC.h
@@ -18,7 +18,6 @@ class SetupWizard;
 class FolderInstanceProvider;
 class GenericPageProvider;
 class QFile;
-class MinecraftVersionList;
 class LWJGLVersionList;
 class HttpMetaCache;
 class SettingsObject;
@@ -96,7 +95,6 @@ public:
 	}
 
 	std::shared_ptr<TranslationsModel> translations();
-	std::shared_ptr<MinecraftVersionList> minecraftlist();
 	std::shared_ptr<LWJGLVersionList> lwjgllist();
 	std::shared_ptr<ForgeVersionList> forgelist();
 	std::shared_ptr<LiteLoaderVersionList> liteloaderlist();
@@ -204,7 +202,6 @@ private:
 	std::shared_ptr<LWJGLVersionList> m_lwjgllist;
 	std::shared_ptr<ForgeVersionList> m_forgelist;
 	std::shared_ptr<LiteLoaderVersionList> m_liteloaderlist;
-	std::shared_ptr<MinecraftVersionList> m_minecraftlist;
 	std::shared_ptr<JavaInstallList> m_javalist;
 	std::shared_ptr<TranslationsModel> m_translations;
 	std::shared_ptr<GenericPageProvider> m_globalSettingsProvider;
diff --git a/application/dialogs/NewInstanceDialog.cpp b/application/dialogs/NewInstanceDialog.cpp
index d53e1959..2e8e3ff7 100644
--- a/application/dialogs/NewInstanceDialog.cpp
+++ b/application/dialogs/NewInstanceDialog.cpp
@@ -19,7 +19,6 @@
 
 #include <BaseVersion.h>
 #include <icons/IconList.h>
-#include <minecraft/MinecraftVersionList.h>
 #include <tasks/Task.h>
 #include <InstanceList.h>
 
@@ -62,7 +61,12 @@ NewInstanceDialog::NewInstanceDialog(const QString & initialGroup, QWidget *pare
 	resize(minimumSizeHint());
 	layout()->setSizeConstraint(QLayout::SetFixedSize);
 
-	setSelectedVersion(MMC->minecraftlist()->getRecommended());
+	// FIXME: bring this back...
+	auto vlist = ENV.getVersionList("net.minecraft");
+	if(vlist)
+	{
+		setSelectedVersion(vlist->getRecommended());
+	}
 	InstIconKey = "default";
 	ui->iconButton->setIcon(MMC->icons()->getIcon(InstIconKey));
 
@@ -192,8 +196,7 @@ BaseVersionPtr NewInstanceDialog::selectedVersion() const
 
 void NewInstanceDialog::on_btnChangeVersion_clicked()
 {
-	VersionSelectDialog vselect(MMC->minecraftlist().get(), tr("Change Minecraft version"),
-								this);
+	VersionSelectDialog vselect(ENV.getVersionList("net.minecraft").get(), tr("Change Minecraft version"), this);
 	vselect.exec();
 	if (vselect.result() == QDialog::Accepted)
 	{
diff --git a/application/pages/VersionPage.cpp b/application/pages/VersionPage.cpp
index 8decc649..b90b3e43 100644
--- a/application/pages/VersionPage.cpp
+++ b/application/pages/VersionPage.cpp
@@ -42,8 +42,6 @@
 #include "minecraft/liteloader/LiteLoaderInstaller.h"
 #include "minecraft/auth/MojangAccountList.h"
 #include "minecraft/Mod.h"
-#include "minecraft/MinecraftVersion.h"
-#include "minecraft/MinecraftVersionList.h"
 #include "icons/IconList.h"
 #include "Exception.h"
 
@@ -489,6 +487,8 @@ int VersionPage::currentRow()
 
 void VersionPage::on_customizeBtn_clicked()
 {
+	// TODO: implement
+	/*
 	auto version = currentRow();
 	if(version == -1)
 	{
@@ -510,6 +510,7 @@ void VersionPage::on_customizeBtn_clicked()
 	}
 	updateButtons();
 	preselect(currentIdx);
+	*/
 }
 
 void VersionPage::on_editBtn_clicked()
@@ -530,6 +531,8 @@ void VersionPage::on_editBtn_clicked()
 
 void VersionPage::on_revertBtn_clicked()
 {
+	// TODO: implement
+	/*
 	auto version = currentRow();
 	if(version == -1)
 	{
@@ -551,6 +554,7 @@ void VersionPage::on_revertBtn_clicked()
 	updateButtons();
 	preselect(currentIdx);
 	m_container->refreshContainer();
+	*/
 }
 
 #include "VersionPage.moc"

From f6eb8fa1e43a412edb49401107de30d497f0f593 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= <peterix@gmail.com>
Date: Sun, 12 Mar 2017 20:08:56 +0100
Subject: [PATCH 07/28] NOISSUE Remove hardcoded LWJGL (modern)

---
 .../onesix/OneSixProfileStrategy.cpp          |  8 +---
 application/CMakeLists.txt                    |  1 -
 application/main.cpp                          |  1 -
 .../resources/versions/LWJGL/2.9.0.json       | 45 -------------------
 .../LWJGL/2.9.1-nightly-20130708-debug3.json  | 45 -------------------
 .../resources/versions/LWJGL/2.9.1.json       | 45 -------------------
 .../LWJGL/2.9.2-nightly-20140822.json         | 45 -------------------
 application/resources/versions/versions.qrc   | 10 -----
 8 files changed, 2 insertions(+), 198 deletions(-)
 delete mode 100644 application/resources/versions/LWJGL/2.9.0.json
 delete mode 100644 application/resources/versions/LWJGL/2.9.1-nightly-20130708-debug3.json
 delete mode 100644 application/resources/versions/LWJGL/2.9.1.json
 delete mode 100644 application/resources/versions/LWJGL/2.9.2-nightly-20140822.json
 delete mode 100644 application/resources/versions/versions.qrc

diff --git a/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp b/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
index 2b023e82..e3d3f674 100644
--- a/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
+++ b/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
@@ -121,12 +121,8 @@ void OneSixProfileStrategy::loadDefaultBuiltinPatches()
 		}
 		else
 		{
-			// NOTE: this is obviously fake, is fixed in unstable.
-			QResource LWJGL(":/versions/LWJGL/2.9.1.json");
-			auto lwjgl = ProfileUtils::parseJsonFile(LWJGL.absoluteFilePath(), false);
-			lwjgl->setVanilla(true);
-			lwjgl->setCustomizable(true);
-			lwjglPatch = std::dynamic_pointer_cast<ProfilePatch>(lwjgl);
+			auto lwjglversion = ENV.getVersion("org.lwjgl", "2.9.1" /*m_instance->intendedVersionId()*/);
+			lwjglPatch = std::dynamic_pointer_cast<ProfilePatch>(lwjglversion);
 		}
 		if (!lwjglPatch)
 		{
diff --git a/application/CMakeLists.txt b/application/CMakeLists.txt
index 1b6ff3fd..f03225da 100644
--- a/application/CMakeLists.txt
+++ b/application/CMakeLists.txt
@@ -313,7 +313,6 @@ set(MULTIMC_QRCS
 	resources/pe_blue/pe_blue.qrc
 	resources/OSX/OSX.qrc
 	resources/iOS/iOS.qrc
-	resources/versions/versions.qrc
 	resources/certs/certs.qrc
 )
 
diff --git a/application/main.cpp b/application/main.cpp
index fde9e10d..0f258926 100644
--- a/application/main.cpp
+++ b/application/main.cpp
@@ -38,7 +38,6 @@ int main(int argc, char *argv[])
 	{
 		Q_INIT_RESOURCE(multimc);
 		Q_INIT_RESOURCE(backgrounds);
-		Q_INIT_RESOURCE(versions);
 
 		Q_INIT_RESOURCE(pe_dark);
 		Q_INIT_RESOURCE(pe_light);
diff --git a/application/resources/versions/LWJGL/2.9.0.json b/application/resources/versions/LWJGL/2.9.0.json
deleted file mode 100644
index 5dbd624e..00000000
--- a/application/resources/versions/LWJGL/2.9.0.json
+++ /dev/null
@@ -1,45 +0,0 @@
- {
-	"fileId": "org.lwjgl",
-	"name": "LWJGL",
-	"version": "2.9.0",
-	"+libraries": [
-		{
-			"name": "net.java.jinput:jinput:2.0.5"
-		},
-		{
-			"name": "net.java.jinput:jinput-platform:2.0.5",
-			"natives": {
-				"linux": "natives-linux",
-				"windows": "natives-windows",
-				"osx": "natives-osx"
-			},
-			"extract": {
-				"exclude": [
-					"META-INF/"
-				]
-			}
-		},
-		{
-			"name": "net.java.jutils:jutils:1.0.0"
-		},
-		{
-			"name": "org.lwjgl.lwjgl:lwjgl:2.9.0"
-		},
-		{
-			"name": "org.lwjgl.lwjgl:lwjgl_util:2.9.0"
-		},
-		{
-			"name": "org.lwjgl.lwjgl:lwjgl-platform:2.9.0",
-			"natives": {
-				"linux": "natives-linux",
-				"windows": "natives-windows",
-				"osx": "natives-osx"
-			},
-			"extract": {
-				"exclude": [
-					"META-INF/"
-				]
-			}
-		}
-	]
-}
diff --git a/application/resources/versions/LWJGL/2.9.1-nightly-20130708-debug3.json b/application/resources/versions/LWJGL/2.9.1-nightly-20130708-debug3.json
deleted file mode 100644
index 7265b3b0..00000000
--- a/application/resources/versions/LWJGL/2.9.1-nightly-20130708-debug3.json
+++ /dev/null
@@ -1,45 +0,0 @@
-{
-	"fileId": "org.lwjgl",
-	"name": "LWJGL",
-	"version": "2.9.1-nightly-20130708-debug3",
-	"+libraries": [
-		{
-			"name": "net.java.jinput:jinput:2.0.5"
-		},
-		{
-			"name": "net.java.jinput:jinput-platform:2.0.5",
-			"natives": {
-				"linux": "natives-linux",
-				"windows": "natives-windows",
-				"osx": "natives-osx"
-			},
-			"extract": {
-				"exclude": [
-					"META-INF/"
-				]
-			}
-		},
-		{
-			"name": "net.java.jutils:jutils:1.0.0"
-		},
-		{
-			"name": "org.lwjgl.lwjgl:lwjgl:2.9.1-nightly-20130708-debug3"
-		},
-		{
-			"name": "org.lwjgl.lwjgl:lwjgl_util:2.9.1-nightly-20130708-debug3"
-		},
-		{
-			"name": "org.lwjgl.lwjgl:lwjgl-platform:2.9.1-nightly-20130708-debug3",
-			"natives": {
-				"linux": "natives-linux",
-				"windows": "natives-windows",
-				"osx": "natives-osx"
-			},
-			"extract": {
-				"exclude": [
-					"META-INF/"
-				]
-			}
-		}
-	]
-}
diff --git a/application/resources/versions/LWJGL/2.9.1.json b/application/resources/versions/LWJGL/2.9.1.json
deleted file mode 100644
index e7f5e947..00000000
--- a/application/resources/versions/LWJGL/2.9.1.json
+++ /dev/null
@@ -1,45 +0,0 @@
- {
-	"fileId": "org.lwjgl",
-	"name": "LWJGL",
-	"version": "2.9.1",
-	"+libraries": [
-		{
-			"name": "net.java.jinput:jinput:2.0.5"
-		},
-		{
-			"name": "net.java.jinput:jinput-platform:2.0.5",
-			"natives": {
-				"linux": "natives-linux",
-				"windows": "natives-windows",
-				"osx": "natives-osx"
-			},
-			"extract": {
-				"exclude": [
-					"META-INF/"
-				]
-			}
-		},
-		{
-			"name": "net.java.jutils:jutils:1.0.0"
-		},
-		{
-			"name": "org.lwjgl.lwjgl:lwjgl:2.9.1"
-		},
-		{
-			"name": "org.lwjgl.lwjgl:lwjgl_util:2.9.1"
-		},
-		{
-			"name": "org.lwjgl.lwjgl:lwjgl-platform:2.9.1",
-			"natives": {
-				"linux": "natives-linux",
-				"windows": "natives-windows",
-				"osx": "natives-osx"
-			},
-			"extract": {
-				"exclude": [
-					"META-INF/"
-				]
-			}
-		}
-	]
-}
diff --git a/application/resources/versions/LWJGL/2.9.2-nightly-20140822.json b/application/resources/versions/LWJGL/2.9.2-nightly-20140822.json
deleted file mode 100644
index 25b22eb9..00000000
--- a/application/resources/versions/LWJGL/2.9.2-nightly-20140822.json
+++ /dev/null
@@ -1,45 +0,0 @@
-{
-	"fileId": "org.lwjgl",
-	"name": "LWJGL",
-	"version": "2.9.2-nightly-20140822",
-	"+libraries": [
-		{
-			"name": "net.java.jinput:jinput:2.0.5"
-		},
-		{
-			"name": "net.java.jinput:jinput-platform:2.0.5",
-			"natives": {
-				"linux": "natives-linux",
-				"windows": "natives-windows",
-				"osx": "natives-osx"
-			},
-			"extract": {
-				"exclude": [
-					"META-INF/"
-				]
-			}
-		},
-		{
-			"name": "net.java.jutils:jutils:1.0.0"
-		},
-		{
-			"name": "org.lwjgl.lwjgl:lwjgl:2.9.2-nightly-20140822"
-		},
-		{
-			"name": "org.lwjgl.lwjgl:lwjgl_util:2.9.2-nightly-20140822"
-		},
-		{
-			"name": "org.lwjgl.lwjgl:lwjgl-platform:2.9.2-nightly-20140822",
-			"natives": {
-				"linux": "natives-linux",
-				"windows": "natives-windows",
-				"osx": "natives-osx"
-			},
-			"extract": {
-				"exclude": [
-					"META-INF/"
-				]
-			}
-		}
-	]
-}
diff --git a/application/resources/versions/versions.qrc b/application/resources/versions/versions.qrc
deleted file mode 100644
index d9596942..00000000
--- a/application/resources/versions/versions.qrc
+++ /dev/null
@@ -1,10 +0,0 @@
-<!DOCTYPE RCC>
-<RCC version="1.0">
-    <qresource prefix="/versions">
-		<!-- LWJGL -->
-		<file>LWJGL/2.9.0.json</file>
-		<file>LWJGL/2.9.1-nightly-20130708-debug3.json</file>
-		<file>LWJGL/2.9.1.json</file>
-		<file>LWJGL/2.9.2-nightly-20140822.json</file>
-    </qresource>
-</RCC>

From 40cf38bc3225c614e7e81d074f890e6f9da0507b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= <peterix@gmail.com>
Date: Sun, 12 Mar 2017 23:19:45 +0100
Subject: [PATCH 08/28] NOISSUE remove liteloader and forge

---
 api/logic/CMakeLists.txt                      |  14 +-
 api/logic/minecraft/MinecraftProfile.cpp      |   5 +
 api/logic/minecraft/MinecraftProfile.h        |   4 +
 api/logic/minecraft/forge/ForgeInstaller.cpp  | 465 ------------------
 api/logic/minecraft/forge/ForgeInstaller.h    |  52 --
 api/logic/minecraft/forge/ForgeVersion.cpp    |  55 ---
 api/logic/minecraft/forge/ForgeVersion.h      |  42 --
 .../minecraft/forge/ForgeVersionList.cpp      | 333 -------------
 api/logic/minecraft/forge/ForgeVersionList.h  |  90 ----
 api/logic/minecraft/forge/LegacyForge.cpp     |  56 ---
 api/logic/minecraft/forge/LegacyForge.h       |  25 -
 .../liteloader/LiteLoaderInstaller.cpp        | 106 ----
 .../liteloader/LiteLoaderInstaller.h          |  39 --
 .../liteloader/LiteLoaderVersionList.cpp      | 332 -------------
 .../liteloader/LiteLoaderVersionList.h        | 123 -----
 application/MultiMC.cpp                       |  22 -
 application/MultiMC.h                         |   6 -
 application/pages/VersionPage.cpp             |  33 +-
 18 files changed, 26 insertions(+), 1776 deletions(-)
 delete mode 100644 api/logic/minecraft/forge/ForgeInstaller.cpp
 delete mode 100644 api/logic/minecraft/forge/ForgeInstaller.h
 delete mode 100644 api/logic/minecraft/forge/ForgeVersion.cpp
 delete mode 100644 api/logic/minecraft/forge/ForgeVersion.h
 delete mode 100644 api/logic/minecraft/forge/ForgeVersionList.cpp
 delete mode 100644 api/logic/minecraft/forge/ForgeVersionList.h
 delete mode 100644 api/logic/minecraft/forge/LegacyForge.cpp
 delete mode 100644 api/logic/minecraft/forge/LegacyForge.h
 delete mode 100644 api/logic/minecraft/liteloader/LiteLoaderInstaller.cpp
 delete mode 100644 api/logic/minecraft/liteloader/LiteLoaderInstaller.h
 delete mode 100644 api/logic/minecraft/liteloader/LiteLoaderVersionList.cpp
 delete mode 100644 api/logic/minecraft/liteloader/LiteLoaderVersionList.h

diff --git a/api/logic/CMakeLists.txt b/api/logic/CMakeLists.txt
index f14b8662..b605fbd3 100644
--- a/api/logic/CMakeLists.txt
+++ b/api/logic/CMakeLists.txt
@@ -296,22 +296,10 @@ set(MINECRAFT_SOURCES
 	minecraft/AssetsUtils.cpp
 
 	# Forge and all things forge related
-	minecraft/forge/ForgeVersion.h
-	minecraft/forge/ForgeVersion.cpp
-	minecraft/forge/ForgeVersionList.h
-	minecraft/forge/ForgeVersionList.cpp
 	minecraft/forge/ForgeXzDownload.h
 	minecraft/forge/ForgeXzDownload.cpp
-	minecraft/forge/LegacyForge.h
-	minecraft/forge/LegacyForge.cpp
-	minecraft/forge/ForgeInstaller.h
-	minecraft/forge/ForgeInstaller.cpp
 
-	# Liteloader and related things
-	minecraft/liteloader/LiteLoaderInstaller.h
-	minecraft/liteloader/LiteLoaderInstaller.cpp
-	minecraft/liteloader/LiteLoaderVersionList.h
-	minecraft/liteloader/LiteLoaderVersionList.cpp
+	# Skin upload utilities
 	minecraft/SkinUpload.cpp
 	minecraft/SkinUpload.h
 	)
diff --git a/api/logic/minecraft/MinecraftProfile.cpp b/api/logic/minecraft/MinecraftProfile.cpp
index 46235a18..b74141d6 100644
--- a/api/logic/minecraft/MinecraftProfile.cpp
+++ b/api/logic/minecraft/MinecraftProfile.cpp
@@ -621,6 +621,11 @@ void MinecraftProfile::installJarMods(QStringList selectedFiles)
 	m_strategy->installJarMods(selectedFiles);
 }
 
+void MinecraftProfile::installVersion(BaseVersionPtr version)
+{
+	// TODO: implement
+}
+
 /*
  * TODO: get rid of this. Get rid of all order numbers.
  */
diff --git a/api/logic/minecraft/MinecraftProfile.h b/api/logic/minecraft/MinecraftProfile.h
index 392c8f5f..a6845e9c 100644
--- a/api/logic/minecraft/MinecraftProfile.h
+++ b/api/logic/minecraft/MinecraftProfile.h
@@ -24,6 +24,7 @@
 #include "Library.h"
 #include "VersionFile.h"
 #include "JarMod.h"
+#include "BaseVersion.h"
 #include "MojangDownloadInfo.h"
 
 #include "multimc_logic_export.h"
@@ -58,6 +59,9 @@ public:
 	/// install more jar mods
 	void installJarMods(QStringList selectedFiles);
 
+	/// install more jar mods
+	void installVersion(BaseVersionPtr version);
+
 	/// DEPRECATED, remove ASAP
 	int getFreeOrderNumber();
 
diff --git a/api/logic/minecraft/forge/ForgeInstaller.cpp b/api/logic/minecraft/forge/ForgeInstaller.cpp
deleted file mode 100644
index f7ce4dec..00000000
--- a/api/logic/minecraft/forge/ForgeInstaller.cpp
+++ /dev/null
@@ -1,465 +0,0 @@
-/* Copyright 2013-2017 MultiMC Contributors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#include "ForgeInstaller.h"
-#include "ForgeVersionList.h"
-
-#include "minecraft/MinecraftProfile.h"
-#include "minecraft/GradleSpecifier.h"
-#include "net/HttpMetaCache.h"
-#include "tasks/Task.h"
-#include "minecraft/onesix/OneSixInstance.h"
-#include <minecraft/onesix/OneSixVersionFormat.h>
-#include "minecraft/VersionFilterData.h"
-#include "Env.h"
-#include "Exception.h"
-#include <FileSystem.h>
-
-#include <quazip.h>
-#include <quazipfile.h>
-#include <QStringList>
-#include <QRegularExpression>
-#include <QRegularExpressionMatch>
-
-#include <QJsonDocument>
-#include <QJsonArray>
-#include <QSaveFile>
-#include <QCryptographicHash>
-
-ForgeInstaller::ForgeInstaller() : BaseInstaller()
-{
-}
-
-void ForgeInstaller::prepare(const QString &filename, const QString &universalUrl)
-{
-	VersionFilePtr newVersion;
-	m_universal_url = universalUrl;
-
-	QuaZip zip(filename);
-	if (!zip.open(QuaZip::mdUnzip))
-		return;
-
-	QuaZipFile file(&zip);
-
-	// read the install profile
-	if (!zip.setCurrentFile("install_profile.json"))
-		return;
-
-	QJsonParseError jsonError;
-	if (!file.open(QIODevice::ReadOnly))
-		return;
-	QJsonDocument jsonDoc = QJsonDocument::fromJson(file.readAll(), &jsonError);
-	file.close();
-	if (jsonError.error != QJsonParseError::NoError)
-		return;
-
-	if (!jsonDoc.isObject())
-		return;
-
-	QJsonObject root = jsonDoc.object();
-
-	auto installVal = root.value("install");
-	auto versionInfoVal = root.value("versionInfo");
-	if (!installVal.isObject() || !versionInfoVal.isObject())
-		return;
-
-	try
-	{
-		newVersion = OneSixVersionFormat::versionFileFromJson(QJsonDocument(versionInfoVal.toObject()), QString(), false);
-	}
-	catch(Exception &err)
-	{
-		qWarning() << "Forge: Fatal error while parsing version file:" << err.what();
-		return;
-	}
-
-	for(auto problem: newVersion->getProblems())
-	{
-		qWarning() << "Forge: Problem found: " << problem.getDescription();
-	}
-	if(newVersion->getProblemSeverity() == ProblemSeverity::PROBLEM_ERROR)
-	{
-		qWarning() << "Forge: Errors found while parsing version file";
-		return;
-	}
-
-	QJsonObject installObj = installVal.toObject();
-	QString libraryName = installObj.value("path").toString();
-	internalPath = installObj.value("filePath").toString();
-	m_forgeVersionString = installObj.value("version").toString().remove("Forge", Qt::CaseInsensitive).trimmed();
-
-	// where do we put the library? decode the mojang path
-	GradleSpecifier lib(libraryName);
-
-	auto cacheentry = ENV.metacache()->resolveEntry("libraries", lib.toPath());
-	finalPath = "libraries/" + lib.toPath();
-	if (!FS::ensureFilePathExists(finalPath))
-		return;
-
-	if (!zip.setCurrentFile(internalPath))
-		return;
-	if (!file.open(QIODevice::ReadOnly))
-		return;
-	{
-		QByteArray data = file.readAll();
-		// extract file
-		QSaveFile extraction(finalPath);
-		if (!extraction.open(QIODevice::WriteOnly))
-			return;
-		if (extraction.write(data) != data.size())
-			return;
-		if (!extraction.commit())
-			return;
-		QCryptographicHash md5sum(QCryptographicHash::Md5);
-		md5sum.addData(data);
-
-		cacheentry->setStale(false);
-		cacheentry->setMD5Sum(md5sum.result().toHex().constData());
-		ENV.metacache()->updateEntry(cacheentry);
-	}
-	file.close();
-
-	m_forge_json = newVersion;
-}
-
-bool ForgeInstaller::add(OneSixInstance *to)
-{
-	return false;
-	// TODO: move to python code.
-/*
-	if (!BaseInstaller::add(to))
-	{
-		return false;
-	}
-
-	if (!m_forge_json)
-	{
-		return false;
-	}
-
-	// A blacklist
-	QSet<QString> blacklist{"authlib", "realms"};
-	QList<QString> xzlist{"org.scala-lang", "com.typesafe"};
-
-	// get the minecraft version from the instance
-	VersionFilePtr minecraft;
-	auto minecraftPatch = to->getMinecraftProfile()->versionPatch("net.minecraft");
-	if(minecraftPatch)
-	{
-		minecraft = std::dynamic_pointer_cast<VersionFile>(minecraftPatch);
-		if(!minecraft)
-		{
-			auto mcWrap = std::dynamic_pointer_cast<MinecraftVersion>(minecraftPatch);
-			if(mcWrap)
-			{
-				minecraft = mcWrap->getVersionFile();
-			}
-		}
-	}
-
-	// for each library in the version we are adding (except for the blacklisted)
-	QMutableListIterator<LibraryPtr> iter(m_forge_json->libraries);
-	while (iter.hasNext())
-	{
-		auto library = iter.next();
-		QString libName = library->artifactId();
-		QString libVersion = library->version();
-		QString rawName = library->rawName();
-
-		// ignore lwjgl libraries.
-		if (g_VersionFilterData.lwjglWhitelist.contains(library->artifactPrefix()))
-		{
-			iter.remove();
-			continue;
-		}
-		// ignore other blacklisted (realms, authlib)
-		if (blacklist.contains(libName))
-		{
-			iter.remove();
-			continue;
-		}
-		// if minecraft version was found, ignore everything that is already in the minecraft version
-		if(minecraft)
-		{
-			bool found = false;
-			for (auto & lib: minecraft->libraries)
-			{
-				if(library->artifactPrefix() == lib->artifactPrefix() && library->version() == lib->version())
-				{
-					found = true;
-					break;
-				}
-			}
-			if (found)
-				continue;
-		}
-
-		// if this is the actual forge lib, set an absolute url for the download
-		if (m_forge_version->type == ForgeVersion::Gradle)
-		{
-			if (libName == "forge")
-			{
-				library->setClassifier("universal");
-			}
-			else if (libName == "minecraftforge")
-			{
-				QString forgeCoord("net.minecraftforge:forge:%1:universal");
-				// using insane form of the MC version...
-				QString longVersion = m_forge_version->mcver + "-" + m_forge_version->jobbuildver;
-				GradleSpecifier spec(forgeCoord.arg(longVersion));
-				library->setRawName(spec);
-			}
-		}
-		else
-		{
-			if (libName.contains("minecraftforge"))
-			{
-				library->setAbsoluteUrl(m_universal_url);
-			}
-		}
-
-		// mark bad libraries based on the xzlist above
-		for (auto entry : xzlist)
-		{
-			qDebug() << "Testing " << rawName << " : " << entry;
-			if (rawName.startsWith(entry))
-			{
-				library->setHint("forge-pack-xz");
-				break;
-			}
-		}
-	}
-	QString &args = m_forge_json->minecraftArguments;
-	QStringList tweakers;
-	{
-		QRegularExpression expression("--tweakClass ([a-zA-Z0-9\\.]*)");
-		QRegularExpressionMatch match = expression.match(args);
-		while (match.hasMatch())
-		{
-			tweakers.append(match.captured(1));
-			args.remove(match.capturedStart(), match.capturedLength());
-			match = expression.match(args);
-		}
-		if(tweakers.size())
-		{
-			args.operator=(args.trimmed());
-			m_forge_json->addTweakers = tweakers;
-		}
-	}
-	if(minecraft && args == minecraft->minecraftArguments)
-	{
-		args.clear();
-	}
-
-	m_forge_json->name = "Forge";
-	m_forge_json->fileId = id();
-	m_forge_json->version = m_forgeVersionString;
-	m_forge_json->dependsOnMinecraftVersion = to->intendedVersionId();
-	m_forge_json->order = 5;
-
-	// reset some things we do not want to be passed along.
-	m_forge_json->m_releaseTime = QDateTime();
-	m_forge_json->m_updateTime = QDateTime();
-	m_forge_json->minimumLauncherVersion = -1;
-	m_forge_json->type.clear();
-	m_forge_json->minecraftArguments.clear();
-	m_forge_json->minecraftVersion.clear();
-
-	QSaveFile file(filename(to->instanceRoot()));
-	if (!file.open(QFile::WriteOnly))
-	{
-		qCritical() << "Error opening" << file.fileName()
-					 << "for reading:" << file.errorString();
-		return false;
-	}
-	file.write(OneSixVersionFormat::versionFileToJson(m_forge_json, true).toJson());
-	file.commit();
-
-	return true;
-	*/
-}
-
-bool ForgeInstaller::addLegacy(OneSixInstance *to)
-{
-	return false;
-	//FIXME: move to python code.
-	/*
-	if (!BaseInstaller::add(to))
-	{
-		return false;
-	}
-	auto entry = ENV.metacache()->resolveEntry("minecraftforge", m_forge_version->filename());
-	finalPath = FS::PathCombine(to->jarModsDir(), m_forge_version->filename());
-	if (!FS::ensureFilePathExists(finalPath))
-	{
-		return false;
-	}
-	if (!QFile::copy(entry->getFullPath(), finalPath))
-	{
-		return false;
-	}
-	QJsonObject obj;
-	obj.insert("order", 5);
-	{
-		QJsonArray jarmodsPlus;
-		{
-			QJsonObject libObj;
-			libObj.insert("name", m_forge_version->universal_filename);
-			jarmodsPlus.append(libObj);
-		}
-		obj.insert("+jarMods", jarmodsPlus);
-	}
-
-	obj.insert("name", QString("Forge"));
-	obj.insert("fileId", id());
-	obj.insert("version", m_forge_version->jobbuildver);
-	obj.insert("mcVersion", to->intendedVersionId());
-	if (g_VersionFilterData.fmlLibsMapping.contains(m_forge_version->mcver))
-	{
-		QJsonArray traitsPlus;
-		traitsPlus.append(QString("legacyFML"));
-		obj.insert("+traits", traitsPlus);
-	}
-	auto fullversion = to->getMinecraftProfile();
-	fullversion->remove("net.minecraftforge");
-
-	QFile file(filename(to->instanceRoot()));
-	if (!file.open(QFile::WriteOnly))
-	{
-		qCritical() << "Error opening" << file.fileName()
-					 << "for reading:" << file.errorString();
-		return false;
-	}
-	file.write(QJsonDocument(obj).toJson());
-	file.close();
-	return true;
-	*/
-}
-
-class ForgeInstallTask : public Task
-{
-	Q_OBJECT
-public:
-	ForgeInstallTask(ForgeInstaller *installer, OneSixInstance *instance,
-					 BaseVersionPtr version, QObject *parent = 0)
-		: Task(parent), m_installer(installer), m_instance(instance), m_version(version)
-	{
-	}
-
-protected:
-	void executeTask() override
-	{
-		setStatus(tr("Installing Forge..."));
-		ForgeVersionPtr forgeVersion = std::dynamic_pointer_cast<ForgeVersion>(m_version);
-		if (!forgeVersion)
-		{
-			emitFailed(tr("Unknown error occured"));
-			return;
-		}
-		prepare(forgeVersion);
-	}
-	void prepare(ForgeVersionPtr forgeVersion)
-	{
-		auto entry = ENV.metacache()->resolveEntry("minecraftforge", forgeVersion->filename());
-		auto installFunction = [this, entry, forgeVersion]()
-		{
-			if (!install(entry, forgeVersion))
-			{
-				qCritical() << "Failure installing Forge";
-				emitFailed(tr("Failure to install Forge"));
-			}
-			else
-			{
-				reload();
-			}
-		};
-
-		/*
-		 * HACK IF the local non-stale file is too small, mark is as stale
-		 *
-		 * This fixes some problems with bad files acquired because of unhandled HTTP redirects
-		 * in old versions of MultiMC.
-		 */
-		if (!entry->isStale())
-		{
-			QFileInfo localFile(entry->getFullPath());
-			if (localFile.size() <= 0x4000)
-			{
-				entry->setStale(true);
-			}
-		}
-
-		if (entry->isStale())
-		{
-			NetJob *fjob = new NetJob("Forge download");
-			fjob->addNetAction(Net::Download::makeCached(forgeVersion->url(), entry));
-			connect(fjob, &NetJob::progress, this, &Task::setProgress);
-			connect(fjob, &NetJob::status, this, &Task::setStatus);
-			connect(fjob, &NetJob::failed, [this](QString reason)
-			{ emitFailed(tr("Failure to download Forge:\n%1").arg(reason)); });
-			connect(fjob, &NetJob::succeeded, installFunction);
-			fjob->start();
-		}
-		else
-		{
-			installFunction();
-		}
-	}
-	bool install(const std::shared_ptr<MetaEntry> &entry, const ForgeVersionPtr &forgeVersion)
-	{
-		if (forgeVersion->usesInstaller())
-		{
-			QString forgePath = entry->getFullPath();
-			m_installer->prepare(forgePath, forgeVersion->universal_url);
-			return m_installer->add(m_instance);
-		}
-		else
-			return m_installer->addLegacy(m_instance);
-	}
-	void reload()
-	{
-		try
-		{
-			m_instance->reloadProfile();
-			emitSucceeded();
-		}
-		catch (Exception &e)
-		{
-			emitFailed(e.cause());
-		}
-		catch (...)
-		{
-			emitFailed(tr("Failed to load the version description file for reasons unknown."));
-		}
-	}
-
-private:
-	ForgeInstaller *m_installer;
-	OneSixInstance *m_instance;
-	BaseVersionPtr m_version;
-};
-
-Task *ForgeInstaller::createInstallTask(OneSixInstance *instance,
-													BaseVersionPtr version, QObject *parent)
-{
-	if (!version)
-	{
-		return nullptr;
-	}
-	m_forge_version = std::dynamic_pointer_cast<ForgeVersion>(version);
-	return new ForgeInstallTask(this, instance, version, parent);
-}
-
-#include "ForgeInstaller.moc"
diff --git a/api/logic/minecraft/forge/ForgeInstaller.h b/api/logic/minecraft/forge/ForgeInstaller.h
deleted file mode 100644
index 26286be7..00000000
--- a/api/logic/minecraft/forge/ForgeInstaller.h
+++ /dev/null
@@ -1,52 +0,0 @@
-/* Copyright 2013-2017 MultiMC Contributors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#pragma once
-
-#include "BaseInstaller.h"
-
-#include <QString>
-#include <memory>
-
-#include "multimc_logic_export.h"
-
-class VersionFile;
-class ForgeInstallTask;
-struct ForgeVersion;
-
-class MULTIMC_LOGIC_EXPORT ForgeInstaller : public BaseInstaller
-{
-	friend class ForgeInstallTask;
-public:
-	ForgeInstaller();
-	virtual ~ForgeInstaller(){}
-	virtual Task *createInstallTask(OneSixInstance *instance, BaseVersionPtr version, QObject *parent) override;
-	virtual QString id() const override { return "net.minecraftforge"; }
-
-protected:
-	void prepare(const QString &filename, const QString &universalUrl);
-	bool add(OneSixInstance *to) override;
-	bool addLegacy(OneSixInstance *to);
-
-private:
-	// the parsed version json, read from the installer
-	std::shared_ptr<VersionFile> m_forge_json;
-	// the actual forge version
-	std::shared_ptr<ForgeVersion> m_forge_version;
-	QString internalPath;
-	QString finalPath;
-	QString m_forgeVersionString;
-	QString m_universal_url;
-};
diff --git a/api/logic/minecraft/forge/ForgeVersion.cpp b/api/logic/minecraft/forge/ForgeVersion.cpp
deleted file mode 100644
index b859a28c..00000000
--- a/api/logic/minecraft/forge/ForgeVersion.cpp
+++ /dev/null
@@ -1,55 +0,0 @@
-#include "ForgeVersion.h"
-#include "minecraft/VersionFilterData.h"
-#include <QObject>
-
-QString ForgeVersion::name()
-{
-	return "Forge " + jobbuildver;
-}
-
-QString ForgeVersion::descriptor()
-{
-	return universal_filename;
-}
-
-QString ForgeVersion::typeString() const
-{
-	if (is_recommended)
-		return QObject::tr("Recommended");
-	return QString();
-}
-
-bool ForgeVersion::operator<(BaseVersion &a)
-{
-	ForgeVersion *pa = dynamic_cast<ForgeVersion *>(&a);
-	if (!pa)
-		return true;
-	return m_buildnr < pa->m_buildnr;
-}
-
-bool ForgeVersion::operator>(BaseVersion &a)
-{
-	ForgeVersion *pa = dynamic_cast<ForgeVersion *>(&a);
-	if (!pa)
-		return false;
-	return m_buildnr > pa->m_buildnr;
-}
-
-bool ForgeVersion::usesInstaller()
-{
-	if(installer_url.isEmpty())
-		return false;
-	if(g_VersionFilterData.forgeInstallerBlacklist.contains(mcver))
-		return false;
-	return true;
-}
-
-QString ForgeVersion::filename()
-{
-	return usesInstaller() ? installer_filename : universal_filename;
-}
-
-QString ForgeVersion::url()
-{
-	return usesInstaller() ? installer_url : universal_url;
-}
diff --git a/api/logic/minecraft/forge/ForgeVersion.h b/api/logic/minecraft/forge/ForgeVersion.h
deleted file mode 100644
index e77d32f1..00000000
--- a/api/logic/minecraft/forge/ForgeVersion.h
+++ /dev/null
@@ -1,42 +0,0 @@
-#pragma once
-#include <QString>
-#include <memory>
-#include "BaseVersion.h"
-
-struct ForgeVersion;
-typedef std::shared_ptr<ForgeVersion> ForgeVersionPtr;
-
-struct ForgeVersion : public BaseVersion
-{
-	virtual QString descriptor() override;
-	virtual QString name() override;
-	virtual QString typeString() const override;
-	virtual bool operator<(BaseVersion &a) override;
-	virtual bool operator>(BaseVersion &a) override;
-
-	QString filename();
-	QString url();
-	
-	enum
-	{
-		Invalid,
-		Legacy,
-		Gradle
-	} type = Invalid;
-	
-	bool usesInstaller();
-
-	int m_buildnr = 0;
-	QString branch;
-	QString universal_url;
-	QString changelog_url;
-	QString installer_url;
-	QString jobbuildver;
-	QString mcver;
-	QString mcver_sane;
-	QString universal_filename;
-	QString installer_filename;
-	bool is_recommended = false;
-};
-
-Q_DECLARE_METATYPE(ForgeVersionPtr)
diff --git a/api/logic/minecraft/forge/ForgeVersionList.cpp b/api/logic/minecraft/forge/ForgeVersionList.cpp
deleted file mode 100644
index 2fb3d012..00000000
--- a/api/logic/minecraft/forge/ForgeVersionList.cpp
+++ /dev/null
@@ -1,333 +0,0 @@
-/* Copyright 2013-2017 MultiMC Contributors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#include "ForgeVersionList.h"
-#include "ForgeVersion.h"
-
-#include "net/NetJob.h"
-#include "net/URLConstants.h"
-#include "Env.h"
-
-#include <QtNetwork>
-#include <QtXml>
-#include <QRegExp>
-
-#include <QDebug>
-
-ForgeVersionList::ForgeVersionList(QObject *parent) : BaseVersionList(parent)
-{
-}
-
-Task *ForgeVersionList::getLoadTask()
-{
-	return new ForgeListLoadTask(this);
-}
-
-bool ForgeVersionList::isLoaded()
-{
-	return m_loaded;
-}
-
-const BaseVersionPtr ForgeVersionList::at(int i) const
-{
-	return m_vlist.at(i);
-}
-
-int ForgeVersionList::count() const
-{
-	return m_vlist.count();
-}
-
-int ForgeVersionList::columnCount(const QModelIndex &parent) const
-{
-	return 1;
-}
-
-QVariant ForgeVersionList::data(const QModelIndex &index, int role) const
-{
-	if (!index.isValid())
-		return QVariant();
-
-	if (index.row() > count())
-		return QVariant();
-
-	auto version = std::dynamic_pointer_cast<ForgeVersion>(m_vlist[index.row()]);
-	switch (role)
-	{
-	case VersionPointerRole:
-		return qVariantFromValue(m_vlist[index.row()]);
-
-	case VersionRole:
-		return version->name();
-
-	case VersionIdRole:
-		return version->descriptor();
-
-	case ParentGameVersionRole:
-		return version->mcver_sane;
-
-	case RecommendedRole:
-		return version->is_recommended;
-
-	case BranchRole:
-		return version->branch;
-
-	default:
-		return QVariant();
-	}
-}
-
-BaseVersionList::RoleList ForgeVersionList::providesRoles() const
-{
-	return {VersionPointerRole, VersionRole, VersionIdRole, ParentGameVersionRole, RecommendedRole, BranchRole};
-}
-
-BaseVersionPtr ForgeVersionList::getLatestStable() const
-{
-	return BaseVersionPtr();
-}
-
-void ForgeVersionList::updateListData(QList<BaseVersionPtr> versions)
-{
-	beginResetModel();
-	m_vlist = versions;
-	m_loaded = true;
-	endResetModel();
-	// NOW SORT!!
-	// sort();
-}
-
-void ForgeVersionList::sortVersions()
-{
-	// NO-OP for now
-}
-
-ForgeListLoadTask::ForgeListLoadTask(ForgeVersionList *vlist) : Task()
-{
-	m_list = vlist;
-}
-
-void ForgeListLoadTask::executeTask()
-{
-	setStatus(tr("Fetching Forge version lists..."));
-	auto job = new NetJob("Version index");
-	// we do not care if the version is stale or not.
-	auto forgeListEntry = ENV.metacache()->resolveEntry("minecraftforge", "list.json");
-	auto gradleForgeListEntry = ENV.metacache()->resolveEntry("minecraftforge", "json");
-
-	// verify by poking the server.
-	forgeListEntry->setStale(true);
-	gradleForgeListEntry->setStale(true);
-
-	job->addNetAction(listDownload = Net::Download::makeCached(QUrl(URLConstants::FORGE_LEGACY_URL),forgeListEntry));
-	job->addNetAction(gradleListDownload = Net::Download::makeCached(QUrl(URLConstants::FORGE_GRADLE_URL), gradleForgeListEntry));
-
-	connect(listDownload.get(), SIGNAL(failed(int)), SLOT(listFailed()));
-	connect(gradleListDownload.get(), SIGNAL(failed(int)), SLOT(gradleListFailed()));
-
-	listJob.reset(job);
-	connect(listJob.get(), SIGNAL(succeeded()), SLOT(listDownloaded()));
-	connect(listJob.get(), SIGNAL(progress(qint64, qint64)), SIGNAL(progress(qint64, qint64)));
-	listJob->start();
-}
-
-bool ForgeListLoadTask::abort()
-{
-	return listJob->abort();
-}
-
-bool ForgeListLoadTask::parseForgeGradleList(QList<BaseVersionPtr> &out)
-{
-	QMap<int, std::shared_ptr<ForgeVersion>> lookup;
-	QByteArray data;
-	{
-		auto filename = gradleListDownload->getTargetFilepath();
-		QFile listFile(filename);
-		if (!listFile.open(QIODevice::ReadOnly))
-		{
-			return false;
-		}
-		data = listFile.readAll();
-		gradleListDownload.reset();
-	}
-
-	QJsonParseError jsonError;
-	QJsonDocument jsonDoc = QJsonDocument::fromJson(data, &jsonError);
-
-	if (jsonError.error != QJsonParseError::NoError)
-	{
-		emitFailed("Error parsing gradle version list JSON:" + jsonError.errorString());
-		return false;
-	}
-
-	if (!jsonDoc.isObject())
-	{
-		emitFailed("Error parsing gradle version list JSON: JSON root is not an object");
-		return false;
-	}
-
-	QJsonObject root = jsonDoc.object();
-
-	// we probably could hard code these, but it might still be worth doing it this way
-	const QString webpath = root.value("webpath").toString();
-	const QString artifact = root.value("artifact").toString();
-
-	QJsonObject numbers = root.value("number").toObject();
-	for (auto it = numbers.begin(); it != numbers.end(); ++it)
-	{
-		QJsonObject number = it.value().toObject();
-		std::shared_ptr<ForgeVersion> fVersion(new ForgeVersion());
-		fVersion->m_buildnr = number.value("build").toDouble();
-		if(fVersion->m_buildnr >= 953 && fVersion->m_buildnr <= 965)
-		{
-			qDebug() << fVersion->m_buildnr;
-		}
-		fVersion->jobbuildver = number.value("version").toString();
-		fVersion->branch = number.value("branch").toString("");
-		fVersion->mcver = number.value("mcversion").toString();
-		fVersion->universal_filename = "";
-		fVersion->installer_filename = "";
-		// HACK: here, we fix the minecraft version used by forge.
-		// HACK: this will inevitably break (later)
-		// FIXME: replace with a dictionary
-		fVersion->mcver_sane = fVersion->mcver;
-		fVersion->mcver_sane.replace("_pre", "-pre");
-
-		QString universal_filename, installer_filename;
-		QJsonArray files = number.value("files").toArray();
-		for (auto fIt = files.begin(); fIt != files.end(); ++fIt)
-		{
-			// TODO with gradle we also get checksums, use them
-			QJsonArray file = (*fIt).toArray();
-			if (file.size() < 3)
-			{
-				continue;
-			}
-
-			QString extension = file.at(0).toString();
-			QString part = file.at(1).toString();
-			QString checksum = file.at(2).toString();
-
-			// insane form of mcver is used here
-			QString longVersion = fVersion->mcver + "-" + fVersion->jobbuildver;
-			if (!fVersion->branch.isEmpty())
-			{
-				longVersion = longVersion + "-" + fVersion->branch;
-			}
-			QString filename = artifact + "-" + longVersion + "-" + part + "." + extension;
-
-			QString url = QString("%1/%2/%3")
-							  .arg(webpath)
-							  .arg(longVersion)
-							  .arg(filename);
-
-			if (part == "installer")
-			{
-				fVersion->installer_url = url;
-				installer_filename = filename;
-			}
-			else if (part == "universal" || part == "client")
-			{
-				fVersion->universal_url = url;
-				universal_filename = filename;
-			}
-			else if (part == "changelog")
-			{
-				fVersion->changelog_url = url;
-			}
-		}
-		if (fVersion->installer_url.isEmpty() && fVersion->universal_url.isEmpty())
-		{
-			continue;
-		}
-		fVersion->universal_filename = universal_filename;
-		fVersion->installer_filename = installer_filename;
-		fVersion->type = ForgeVersion::Gradle;
-		out.append(fVersion);
-		lookup[fVersion->m_buildnr] = fVersion;
-	}
-	QJsonObject promos = root.value("promos").toObject();
-	for (auto it = promos.begin(); it != promos.end(); ++it)
-	{
-		QString key = it.key();
-		int build = it.value().toInt();
-		QRegularExpression regexp("^(?<mcversion>[0-9]+(.[0-9]+)*)-(?<label>[a-z]+)$");
-		auto match = regexp.match(key);
-		if(!match.hasMatch())
-		{
-			qDebug() << key << "doesn't match." << "build" << build;
-			continue;
-		}
-
-		QString label = match.captured("label");
-		if(label != "recommended")
-		{
-			continue;
-		}
-		QString mcversion = match.captured("mcversion");
-		qDebug() << "Forge build" << build << "is the" << label << "for Minecraft" << mcversion << QString("<%1>").arg(key);
-		lookup[build]->is_recommended = true;
-	}
-	return true;
-}
-
-void ForgeListLoadTask::listDownloaded()
-{
-	QList<BaseVersionPtr> list;
-	bool ret = true;
-
-	if (!parseForgeGradleList(list))
-	{
-		ret = false;
-	}
-
-	if (!ret)
-	{
-		return;
-	}
-	std::sort(list.begin(), list.end(), [](const BaseVersionPtr & l, const BaseVersionPtr & r)
-	{ return (*l > *r); });
-
-	m_list->updateListData(list);
-
-	emitSucceeded();
-	return;
-}
-
-void ForgeListLoadTask::listFailed()
-{
-	auto &reply = listDownload->m_reply;
-	if (reply)
-	{
-		qCritical() << "Getting forge version list failed: " << reply->errorString();
-	}
-	else
-	{
-		qCritical() << "Getting forge version list failed for reasons unknown.";
-	}
-}
-
-void ForgeListLoadTask::gradleListFailed()
-{
-	auto &reply = gradleListDownload->m_reply;
-	if (reply)
-	{
-		qCritical() << "Getting forge version list failed: " << reply->errorString();
-	}
-	else
-	{
-		qCritical() << "Getting forge version list failed for reasons unknown.";
-	}
-}
diff --git a/api/logic/minecraft/forge/ForgeVersionList.h b/api/logic/minecraft/forge/ForgeVersionList.h
deleted file mode 100644
index ee4b79d2..00000000
--- a/api/logic/minecraft/forge/ForgeVersionList.h
+++ /dev/null
@@ -1,90 +0,0 @@
-/* Copyright 2013-2017 MultiMC Contributors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#pragma once
-
-#include "ForgeVersion.h"
-
-#include <QObject>
-#include <QAbstractListModel>
-#include <QUrl>
-#include <QNetworkReply>
-
-#include "BaseVersionList.h"
-#include "tasks/Task.h"
-#include "net/NetJob.h"
-
-#include "multimc_logic_export.h"
-
-class MULTIMC_LOGIC_EXPORT ForgeVersionList : public BaseVersionList
-{
-	Q_OBJECT
-public:
-	friend class ForgeListLoadTask;
-
-	explicit ForgeVersionList(QObject *parent = 0);
-
-	virtual Task *getLoadTask() override;
-	virtual bool isLoaded() override;
-	virtual const BaseVersionPtr at(int i) const override;
-	virtual int count() const override;
-	virtual void sortVersions() override;
-
-	virtual BaseVersionPtr getLatestStable() const override;
-
-	ForgeVersionPtr findVersionByVersionNr(QString version);
-
-	virtual QVariant data(const QModelIndex &index, int role) const override;
-	virtual RoleList providesRoles() const override;
-
-	virtual int columnCount(const QModelIndex &parent) const override;
-
-protected:
-	QList<BaseVersionPtr> m_vlist;
-
-	bool m_loaded = false;
-
-protected
-slots:
-	virtual void updateListData(QList<BaseVersionPtr> versions) override;
-};
-
-class ForgeListLoadTask : public Task
-{
-	Q_OBJECT
-
-public:
-	explicit ForgeListLoadTask(ForgeVersionList *vlist);
-
-	virtual void executeTask();
-	virtual bool abort();
-
-protected
-slots:
-	void listDownloaded();
-	void listFailed();
-	void gradleListFailed();
-
-protected:
-	NetJobPtr listJob;
-	ForgeVersionList *m_list;
-
-	Net::Download::Ptr listDownload;
-	Net::Download::Ptr gradleListDownload;
-
-private:
-	bool parseForgeList(QList<BaseVersionPtr> &out);
-	bool parseForgeGradleList(QList<BaseVersionPtr> &out);
-};
diff --git a/api/logic/minecraft/forge/LegacyForge.cpp b/api/logic/minecraft/forge/LegacyForge.cpp
deleted file mode 100644
index 2e4508e9..00000000
--- a/api/logic/minecraft/forge/LegacyForge.cpp
+++ /dev/null
@@ -1,56 +0,0 @@
-/* Copyright 2013-2017 MultiMC Contributors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#include "LegacyForge.h"
-
-MinecraftForge::MinecraftForge(const QString &file) : Mod(file)
-{
-}
-
-bool MinecraftForge::FixVersionIfNeeded(QString newVersion)
-{/*
-	wxString reportedVersion = GetModVersion();
-	if(reportedVersion == "..." || reportedVersion.empty())
-	{
-		std::auto_ptr<wxFFileInputStream> in(new wxFFileInputStream("forge.zip"));
-		wxTempFileOutputStream out("forge.zip");
-		wxTextOutputStream textout(out);
-		wxZipInputStream inzip(*in);
-		wxZipOutputStream outzip(out);
-		std::auto_ptr<wxZipEntry> entry;
-		// preserve metadata
-		outzip.CopyArchiveMetaData(inzip);
-		// copy all entries
-		while (entry.reset(inzip.GetNextEntry()), entry.get() != NULL)
-			if (!outzip.CopyEntry(entry.release(), inzip))
-				return false;
-		// release last entry
-		in.reset();
-		outzip.PutNextEntry("forgeversion.properties");
-
-		wxStringTokenizer tokenizer(newVersion,".");
-		wxString verFile;
-		verFile << wxString("forge.major.number=") << tokenizer.GetNextToken() << "\n";
-		verFile << wxString("forge.minor.number=") << tokenizer.GetNextToken() << "\n";
-		verFile << wxString("forge.revision.number=") << tokenizer.GetNextToken() << "\n";
-		verFile << wxString("forge.build.number=") << tokenizer.GetNextToken() << "\n";
-		auto buf = verFile.ToUTF8();
-		outzip.Write(buf.data(), buf.length());
-		// check if we succeeded
-		return inzip.Eof() && outzip.Close() && out.Commit();
-	}
-	*/
-	return true;
-}
diff --git a/api/logic/minecraft/forge/LegacyForge.h b/api/logic/minecraft/forge/LegacyForge.h
deleted file mode 100644
index 4a51e74a..00000000
--- a/api/logic/minecraft/forge/LegacyForge.h
+++ /dev/null
@@ -1,25 +0,0 @@
-/* Copyright 2013-2017 MultiMC Contributors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#pragma once
-
-#include "minecraft/Mod.h"
-
-class MinecraftForge : public Mod
-{
-public:
-	MinecraftForge(const QString &file);
-	bool FixVersionIfNeeded(QString newVersion);
-};
diff --git a/api/logic/minecraft/liteloader/LiteLoaderInstaller.cpp b/api/logic/minecraft/liteloader/LiteLoaderInstaller.cpp
deleted file mode 100644
index 2a88cfd6..00000000
--- a/api/logic/minecraft/liteloader/LiteLoaderInstaller.cpp
+++ /dev/null
@@ -1,106 +0,0 @@
-/* Copyright 2013-2017 MultiMC Contributors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#include "LiteLoaderInstaller.h"
-
-#include <QJsonArray>
-#include <QJsonDocument>
-
-#include <QDebug>
-
-#include "minecraft/MinecraftProfile.h"
-#include "minecraft/Library.h"
-#include "minecraft/onesix/OneSixInstance.h"
-#include <minecraft/onesix/OneSixVersionFormat.h>
-#include "minecraft/liteloader/LiteLoaderVersionList.h"
-#include "Exception.h"
-
-LiteLoaderInstaller::LiteLoaderInstaller() : BaseInstaller()
-{
-}
-
-void LiteLoaderInstaller::prepare(LiteLoaderVersionPtr version)
-{
-	m_version = version;
-}
-bool LiteLoaderInstaller::add(OneSixInstance *to)
-{
-	if (!BaseInstaller::add(to))
-	{
-		return false;
-	}
-	QFile file(filename(to->instanceRoot()));
-	if (!file.open(QFile::WriteOnly))
-	{
-		qCritical() << "Error opening" << file.fileName()
-					 << "for reading:" << file.errorString();
-		return false;
-	}
-	file.write(OneSixVersionFormat::versionFileToJson(m_version->getVersionFile(), true).toJson());
-	file.close();
-
-	return true;
-}
-
-class LiteLoaderInstallTask : public Task
-{
-	Q_OBJECT
-public:
-	LiteLoaderInstallTask(LiteLoaderInstaller *installer, OneSixInstance *instance, BaseVersionPtr version, QObject *parent)
-		: Task(parent), m_installer(installer), m_instance(instance), m_version(version)
-	{
-	}
-
-protected:
-	void executeTask() override
-	{
-		LiteLoaderVersionPtr liteloaderVersion = std::dynamic_pointer_cast<LiteLoaderVersion>(m_version);
-		if (!liteloaderVersion)
-		{
-			return;
-		}
-		m_installer->prepare(liteloaderVersion);
-		if (!m_installer->add(m_instance))
-		{
-			emitFailed(tr("For reasons unknown, the LiteLoader installation failed. Check your MultiMC log files for details."));
-			return;
-		}
-		try
-		{
-			m_instance->reloadProfile();
-			emitSucceeded();
-		}
-		catch (Exception &e)
-		{
-			emitFailed(e.cause());
-		}
-		catch (...)
-		{
-			emitFailed(tr("Failed to load the version description file for reasons unknown."));
-		}
-	}
-
-private:
-	LiteLoaderInstaller *m_installer;
-	OneSixInstance *m_instance;
-	BaseVersionPtr m_version;
-};
-
-Task *LiteLoaderInstaller::createInstallTask(OneSixInstance *instance, BaseVersionPtr version, QObject *parent)
-{
-	return new LiteLoaderInstallTask(this, instance, version, parent);
-}
-
-#include "LiteLoaderInstaller.moc"
diff --git a/api/logic/minecraft/liteloader/LiteLoaderInstaller.h b/api/logic/minecraft/liteloader/LiteLoaderInstaller.h
deleted file mode 100644
index 65e6c192..00000000
--- a/api/logic/minecraft/liteloader/LiteLoaderInstaller.h
+++ /dev/null
@@ -1,39 +0,0 @@
-/* Copyright 2013-2017 MultiMC Contributors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#pragma once
-
-#include <QString>
-#include <QMap>
-
-#include "BaseInstaller.h"
-#include "LiteLoaderVersionList.h"
-
-#include "multimc_logic_export.h"
-
-class MULTIMC_LOGIC_EXPORT LiteLoaderInstaller : public BaseInstaller
-{
-public:
-	LiteLoaderInstaller();
-
-	void prepare(LiteLoaderVersionPtr version);
-	bool add(OneSixInstance *to) override;
-	virtual QString id() const override { return "com.mumfrey.liteloader"; }
-
-	Task *createInstallTask(OneSixInstance *instance, BaseVersionPtr version, QObject *parent) override;
-
-private:
-	LiteLoaderVersionPtr m_version;
-};
diff --git a/api/logic/minecraft/liteloader/LiteLoaderVersionList.cpp b/api/logic/minecraft/liteloader/LiteLoaderVersionList.cpp
deleted file mode 100644
index 023d2f14..00000000
--- a/api/logic/minecraft/liteloader/LiteLoaderVersionList.cpp
+++ /dev/null
@@ -1,332 +0,0 @@
-/* Copyright 2013-2017 MultiMC Contributors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#include "LiteLoaderVersionList.h"
-#include <minecraft/onesix/OneSixVersionFormat.h>
-#include "Env.h"
-#include "net/URLConstants.h"
-#include "Exception.h"
-
-#include <QtXml>
-
-#include <QJsonDocument>
-#include <QJsonObject>
-#include <QJsonArray>
-#include <QJsonValue>
-#include <QJsonParseError>
-
-#include <QtAlgorithms>
-
-#include <QtNetwork>
-
-LiteLoaderVersionList::LiteLoaderVersionList(QObject *parent) : BaseVersionList(parent)
-{
-}
-
-Task *LiteLoaderVersionList::getLoadTask()
-{
-	return new LLListLoadTask(this);
-}
-
-bool LiteLoaderVersionList::isLoaded()
-{
-	return m_loaded;
-}
-
-const BaseVersionPtr LiteLoaderVersionList::at(int i) const
-{
-	return m_vlist.at(i);
-}
-
-int LiteLoaderVersionList::count() const
-{
-	return m_vlist.count();
-}
-
-static bool cmpVersions(BaseVersionPtr first, BaseVersionPtr second)
-{
-	auto left = std::dynamic_pointer_cast<LiteLoaderVersion>(first);
-	auto right = std::dynamic_pointer_cast<LiteLoaderVersion>(second);
-	return left->timestamp > right->timestamp;
-}
-
-VersionFilePtr LiteLoaderVersion::getVersionFile()
-{
-	auto f = std::make_shared<VersionFile>();
-	f->mainClass = "net.minecraft.launchwrapper.Launch";
-	f->addTweakers += tweakClass;
-	f->order = 10;
-	f->libraries = libraries;
-	f->name = "LiteLoader";
-	f->fileId = "com.mumfrey.liteloader";
-	f->version = version;
-	f->minecraftVersion = mcVersion;
-	return f;
-}
-
-void LiteLoaderVersionList::sortVersions()
-{
-	beginResetModel();
-	std::sort(m_vlist.begin(), m_vlist.end(), cmpVersions);
-	endResetModel();
-}
-
-QVariant LiteLoaderVersionList::data(const QModelIndex &index, int role) const
-{
-	if (!index.isValid())
-		return QVariant();
-
-	if (index.row() > count())
-		return QVariant();
-
-	auto version = std::dynamic_pointer_cast<LiteLoaderVersion>(m_vlist[index.row()]);
-	switch (role)
-	{
-	case VersionPointerRole:
-		return qVariantFromValue(m_vlist[index.row()]);
-
-	case VersionRole:
-		return version->name();
-
-	case VersionIdRole:
-		return version->descriptor();
-
-	case ParentGameVersionRole:
-		return version->mcVersion;
-
-	case LatestRole:
-		return version->isLatest;
-
-	case RecommendedRole:
-		return version->isRecommended;
-
-	case TypeRole:
-		return version->isSnapshot ? tr("Snapshot") : tr("Release");
-
-	default:
-		return QVariant();
-	}
-}
-
-BaseVersionList::RoleList LiteLoaderVersionList::providesRoles() const
-{
-	return {VersionPointerRole, VersionRole, VersionIdRole, ParentGameVersionRole, RecommendedRole, LatestRole, TypeRole};
-}
-
-BaseVersionPtr LiteLoaderVersionList::getLatestStable() const
-{
-	for (int i = 0; i < m_vlist.length(); i++)
-	{
-		auto ver = std::dynamic_pointer_cast<LiteLoaderVersion>(m_vlist.at(i));
-		if (ver->isRecommended)
-		{
-			return m_vlist.at(i);
-		}
-	}
-	return BaseVersionPtr();
-}
-
-void LiteLoaderVersionList::updateListData(QList<BaseVersionPtr> versions)
-{
-	beginResetModel();
-	m_vlist = versions;
-	m_loaded = true;
-	std::sort(m_vlist.begin(), m_vlist.end(), cmpVersions);
-	endResetModel();
-}
-
-LLListLoadTask::LLListLoadTask(LiteLoaderVersionList *vlist)
-{
-	m_list = vlist;
-}
-
-LLListLoadTask::~LLListLoadTask()
-{
-}
-
-void LLListLoadTask::executeTask()
-{
-	setStatus(tr("Loading LiteLoader version list..."));
-	auto job = new NetJob("Version index");
-	// we do not care if the version is stale or not.
-	auto liteloaderEntry = ENV.metacache()->resolveEntry("liteloader", "versions.json");
-
-	// verify by poking the server.
-	liteloaderEntry->setStale(true);
-
-	job->addNetAction(listDownload = Net::Download::makeCached(QUrl(URLConstants::LITELOADER_URL), liteloaderEntry));
-
-	connect(listDownload.get(), SIGNAL(failed(int)), SLOT(listFailed()));
-
-	listJob.reset(job);
-	connect(listJob.get(), SIGNAL(succeeded()), SLOT(listDownloaded()));
-	connect(listJob.get(), SIGNAL(progress(qint64, qint64)), SIGNAL(progress(qint64, qint64)));
-	listJob->start();
-}
-
-void LLListLoadTask::listFailed()
-{
-	emitFailed("Failed to load LiteLoader version list.");
-	return;
-}
-
-void LLListLoadTask::listDownloaded()
-{
-	QByteArray data;
-	{
-		auto filename = listDownload->getTargetFilepath();
-		QFile listFile(filename);
-		if (!listFile.open(QIODevice::ReadOnly))
-		{
-			emitFailed("Failed to open the LiteLoader version list.");
-			return;
-		}
-		data = listFile.readAll();
-		listFile.close();
-		listDownload.reset();
-	}
-
-	QJsonParseError jsonError;
-	QJsonDocument jsonDoc = QJsonDocument::fromJson(data, &jsonError);
-
-	if (jsonError.error != QJsonParseError::NoError)
-	{
-		emitFailed("Error parsing version list JSON:" + jsonError.errorString());
-		return;
-	}
-
-	if (!jsonDoc.isObject())
-	{
-		emitFailed("Error parsing version list JSON: jsonDoc is not an object");
-		return;
-	}
-
-	const QJsonObject root = jsonDoc.object();
-
-	// Now, get the array of versions.
-	if (!root.value("versions").isObject())
-	{
-		emitFailed("Error parsing version list JSON: missing 'versions' object");
-		return;
-	}
-
-	auto meta = root.value("meta").toObject();
-	QString description = meta.value("description").toString(tr("This is a lightweight loader for mods that don't change game mechanics."));
-	QString defaultUrl = meta.value("url").toString("http://dl.liteloader.com");
-	QString authors = meta.value("authors").toString("Mumfrey");
-	auto versions = root.value("versions").toObject();
-
-	QList<BaseVersionPtr> tempList;
-	for (auto vIt = versions.begin(); vIt != versions.end(); ++vIt)
-	{
-		const QString mcVersion = vIt.key();
-		const QJsonObject versionObject = vIt.value().toObject();
-
-		auto processArtefacts = [&](QJsonObject artefacts, bool notSnapshots, std::shared_ptr<LiteLoaderVersion> &latest)
-		{
-			QString latestVersion;
-			QList<BaseVersionPtr> perMcVersionList;
-			for (auto aIt = artefacts.begin(); aIt != artefacts.end(); ++aIt)
-			{
-				const QString identifier = aIt.key();
-				const QJsonObject artefact = aIt.value().toObject();
-				if (identifier == "latest")
-				{
-					latestVersion = artefact.value("version").toString();
-					continue;
-				}
-				LiteLoaderVersionPtr version(new LiteLoaderVersion());
-				version->version = artefact.value("version").toString();
-				version->mcVersion = mcVersion;
-				version->md5 = artefact.value("md5").toString();
-				version->timestamp = artefact.value("timestamp").toString().toLong();
-				version->tweakClass = artefact.value("tweakClass").toString();
-				version->authors = authors;
-				version->description = description;
-				version->defaultUrl = defaultUrl;
-				version->isSnapshot = !notSnapshots;
-				const QJsonArray libs = artefact.value("libraries").toArray();
-				for (auto lIt = libs.begin(); lIt != libs.end(); ++lIt)
-				{
-					auto libobject = (*lIt).toObject();
-					try
-					{
-						auto lib = OneSixVersionFormat::libraryFromJson(libobject, "versions.json");
-						// hack to make liteloader 1.7.10_00 work
-						if(lib->rawName() == GradleSpecifier("org.ow2.asm:asm-all:5.0.3"))
-						{
-							lib->setRepositoryURL("http://repo.maven.apache.org/maven2/");
-						}
-						version->libraries.append(lib);
-					}
-					catch (Exception &e)
-					{
-						qCritical() << "Couldn't read JSON object:";
-						continue; // FIXME: ignores bad libraries and continues loading
-					}
-				}
-				auto liteloaderLib = std::make_shared<Library>("com.mumfrey:liteloader:" + version->version);
-				liteloaderLib->setRepositoryURL("http://dl.liteloader.com/versions/");
-				if(!notSnapshots)
-				{
-					liteloaderLib->setHint("always-stale");
-				}
-				version->libraries.append(liteloaderLib);
-				perMcVersionList.append(version);
-			}
-			if(notSnapshots)
-			{
-				for (auto version : perMcVersionList)
-				{
-					auto v = std::dynamic_pointer_cast<LiteLoaderVersion>(version);
-					if(v->version == latestVersion)
-					{
-						latest = v;
-					}
-				}
-			}
-			tempList.append(perMcVersionList);
-		};
-
-		std::shared_ptr<LiteLoaderVersion> latestSnapshot;
-		std::shared_ptr<LiteLoaderVersion> latestRelease;
-		// are there actually released versions for this mc version?
-		if(versionObject.contains("artefacts"))
-		{
-			const QJsonObject artefacts = versionObject.value("artefacts").toObject().value("com.mumfrey:liteloader").toObject();
-			processArtefacts(artefacts, true, latestRelease);
-		}
-		if(versionObject.contains("snapshots"))
-		{
-			QJsonObject artefacts = versionObject.value("snapshots").toObject().value("com.mumfrey:liteloader").toObject();
-			processArtefacts(artefacts, false, latestSnapshot);
-		}
-		if(latestSnapshot)
-		{
-			latestSnapshot->isLatest = true;
-		}
-		else if(latestRelease)
-		{
-			latestRelease->isLatest = true;
-		}
-		if(latestRelease)
-		{
-			latestRelease->isRecommended = true;
-		}
-	}
-	m_list->updateListData(tempList);
-
-	emitSucceeded();
-}
diff --git a/api/logic/minecraft/liteloader/LiteLoaderVersionList.h b/api/logic/minecraft/liteloader/LiteLoaderVersionList.h
deleted file mode 100644
index 6074978c..00000000
--- a/api/logic/minecraft/liteloader/LiteLoaderVersionList.h
+++ /dev/null
@@ -1,123 +0,0 @@
-/* Copyright 2013-2017 MultiMC Contributors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#pragma once
-
-#include <QObject>
-
-#include <QString>
-#include <QStringList>
-#include "BaseVersion.h"
-#include "BaseVersionList.h"
-#include "tasks/Task.h"
-#include "net/NetJob.h"
-#include <minecraft/Library.h>
-#include <minecraft/VersionFile.h>
-
-#include "multimc_logic_export.h"
-
-class LLListLoadTask;
-class QNetworkReply;
-
-class LiteLoaderVersion : public BaseVersion
-{
-public:
-	QString descriptor() override
-	{
-		if (isLatest)
-		{
-			return QObject::tr("Latest");
-		}
-		return QString();
-	}
-	QString typeString() const override
-	{
-		return mcVersion;
-	}
-	QString name() override
-	{
-		return version;
-	}
-	VersionFilePtr getVersionFile();
-
-	// important info
-	QString version;
-	QString mcVersion;
-	QString md5;
-	long timestamp = 0;
-	bool isLatest = false;
-	bool isRecommended = false;
-	bool isSnapshot = false;
-
-	QString tweakClass;
-	QList<LibraryPtr> libraries;
-
-	// meta
-	QString defaultUrl;
-	QString description;
-	QString authors;
-};
-typedef std::shared_ptr<LiteLoaderVersion> LiteLoaderVersionPtr;
-
-class MULTIMC_LOGIC_EXPORT LiteLoaderVersionList : public BaseVersionList
-{
-	Q_OBJECT
-public:
-	friend class LLListLoadTask;
-
-	explicit LiteLoaderVersionList(QObject *parent = 0);
-
-	Task *getLoadTask() override;
-	bool isLoaded() override;
-	const BaseVersionPtr at(int i) const override;
-	int count() const override;
-	void sortVersions() override;
-	QVariant data ( const QModelIndex & index, int role = Qt::DisplayRole ) const override;
-	RoleList providesRoles() const override;
-
-	virtual BaseVersionPtr getLatestStable() const override;
-
-protected:
-	QList<BaseVersionPtr> m_vlist;
-
-	bool m_loaded = false;
-
-protected
-slots:
-	void updateListData(QList<BaseVersionPtr> versions) override;
-};
-
-class LLListLoadTask : public Task
-{
-	Q_OBJECT
-
-public:
-	explicit LLListLoadTask(LiteLoaderVersionList *vlist);
-	~LLListLoadTask();
-
-	virtual void executeTask();
-
-protected
-slots:
-	void listDownloaded();
-	void listFailed();
-
-protected:
-	NetJobPtr listJob;
-	Net::Download::Ptr listDownload;
-	LiteLoaderVersionList *m_list;
-};
-
-Q_DECLARE_METATYPE(LiteLoaderVersionPtr)
diff --git a/application/MultiMC.cpp b/application/MultiMC.cpp
index 98b73a6e..942b1d93 100644
--- a/application/MultiMC.cpp
+++ b/application/MultiMC.cpp
@@ -42,8 +42,6 @@
 #include "icons/IconList.h"
 //FIXME: get rid of this
 #include "minecraft/legacy/LwjglVersionList.h"
-#include "minecraft/liteloader/LiteLoaderVersionList.h"
-#include "minecraft/forge/ForgeVersionList.h"
 
 #include "net/HttpMetaCache.h"
 #include "net/URLConstants.h"
@@ -868,26 +866,6 @@ std::shared_ptr<LWJGLVersionList> MultiMC::lwjgllist()
 	return m_lwjgllist;
 }
 
-std::shared_ptr<ForgeVersionList> MultiMC::forgelist()
-{
-	if (!m_forgelist)
-	{
-		m_forgelist.reset(new ForgeVersionList());
-		ENV.registerVersionList("net.minecraftforge", m_forgelist);
-	}
-	return m_forgelist;
-}
-
-std::shared_ptr<LiteLoaderVersionList> MultiMC::liteloaderlist()
-{
-	if (!m_liteloaderlist)
-	{
-		m_liteloaderlist.reset(new LiteLoaderVersionList());
-		ENV.registerVersionList("com.mumfrey.liteloader", m_liteloaderlist);
-	}
-	return m_liteloaderlist;
-}
-
 std::shared_ptr<JavaInstallList> MultiMC::javalist()
 {
 	if (!m_javalist)
diff --git a/application/MultiMC.h b/application/MultiMC.h
index 8dc2e609..a9cbdec7 100644
--- a/application/MultiMC.h
+++ b/application/MultiMC.h
@@ -25,8 +25,6 @@ class InstanceList;
 class MojangAccountList;
 class IconList;
 class QNetworkAccessManager;
-class ForgeVersionList;
-class LiteLoaderVersionList;
 class JavaInstallList;
 class UpdateChecker;
 class BaseProfilerFactory;
@@ -96,8 +94,6 @@ public:
 
 	std::shared_ptr<TranslationsModel> translations();
 	std::shared_ptr<LWJGLVersionList> lwjgllist();
-	std::shared_ptr<ForgeVersionList> forgelist();
-	std::shared_ptr<LiteLoaderVersionList> liteloaderlist();
 	std::shared_ptr<JavaInstallList> javalist();
 
 	std::shared_ptr<InstanceList> instances() const
@@ -200,8 +196,6 @@ private:
 	std::shared_ptr<UpdateChecker> m_updateChecker;
 	std::shared_ptr<MojangAccountList> m_accounts;
 	std::shared_ptr<LWJGLVersionList> m_lwjgllist;
-	std::shared_ptr<ForgeVersionList> m_forgelist;
-	std::shared_ptr<LiteLoaderVersionList> m_liteloaderlist;
 	std::shared_ptr<JavaInstallList> m_javalist;
 	std::shared_ptr<TranslationsModel> m_translations;
 	std::shared_ptr<GenericPageProvider> m_globalSettingsProvider;
diff --git a/application/pages/VersionPage.cpp b/application/pages/VersionPage.cpp
index b90b3e43..42eb31de 100644
--- a/application/pages/VersionPage.cpp
+++ b/application/pages/VersionPage.cpp
@@ -36,10 +36,6 @@
 #include <QUrl>
 
 #include "minecraft/MinecraftProfile.h"
-#include "minecraft/forge/ForgeVersionList.h"
-#include "minecraft/forge/ForgeInstaller.h"
-#include "minecraft/liteloader/LiteLoaderVersionList.h"
-#include "minecraft/liteloader/LiteLoaderInstaller.h"
 #include "minecraft/auth/MojangAccountList.h"
 #include "minecraft/Mod.h"
 #include "icons/IconList.h"
@@ -375,16 +371,18 @@ int VersionPage::doUpdate()
 
 void VersionPage::on_forgeBtn_clicked()
 {
-	VersionSelectDialog vselect(MMC->forgelist().get(), tr("Select Forge version"), this);
+	auto vlist = ENV.getVersionList("net.minecraftforge");
+	if(!vlist)
+	{
+		return;
+	}
+	VersionSelectDialog vselect(vlist.get(), tr("Select Forge version"), this);
 	vselect.setExactFilter(BaseVersionList::ParentGameVersionRole, m_inst->currentVersionId());
-	vselect.setEmptyString(tr("No Forge versions are currently available for Minecraft ") +
-						   m_inst->currentVersionId());
+	vselect.setEmptyString(tr("No Forge versions are currently available for Minecraft ") + m_inst->currentVersionId());
 	vselect.setEmptyErrorString(tr("Couldn't load or download the Forge version lists!"));
 	if (vselect.exec() && vselect.selectedVersion())
 	{
-		ProgressDialog dialog(this);
-		dialog.execWithTask(
-			ForgeInstaller().createInstallTask(m_inst, vselect.selectedVersion(), this));
+		m_profile->installVersion(vselect.selectedVersion());
 		preselect(m_profile->rowCount(QModelIndex())-1);
 		m_container->refreshContainer();
 	}
@@ -392,17 +390,18 @@ void VersionPage::on_forgeBtn_clicked()
 
 void VersionPage::on_liteloaderBtn_clicked()
 {
-	VersionSelectDialog vselect(MMC->liteloaderlist().get(), tr("Select LiteLoader version"),
-								this);
+	auto vlist = ENV.getVersionList("com.liteloader");
+	if(!vlist)
+	{
+		return;
+	}
+	VersionSelectDialog vselect(vlist.get(), tr("Select LiteLoader version"), this);
 	vselect.setExactFilter(BaseVersionList::ParentGameVersionRole, m_inst->currentVersionId());
-	vselect.setEmptyString(tr("No LiteLoader versions are currently available for Minecraft ") +
-						   m_inst->currentVersionId());
+	vselect.setEmptyString(tr("No LiteLoader versions are currently available for Minecraft ") + m_inst->currentVersionId());
 	vselect.setEmptyErrorString(tr("Couldn't load or download the LiteLoader version lists!"));
 	if (vselect.exec() && vselect.selectedVersion())
 	{
-		ProgressDialog dialog(this);
-		dialog.execWithTask(
-			LiteLoaderInstaller().createInstallTask(m_inst, vselect.selectedVersion(), this));
+		m_profile->installVersion(vselect.selectedVersion());
 		preselect(m_profile->rowCount(QModelIndex())-1);
 		m_container->refreshContainer();
 	}

From 0060b506257b906d40ef53d1e23404dba76afcee Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= <peterix@gmail.com>
Date: Fri, 17 Mar 2017 01:48:54 +0100
Subject: [PATCH 09/28] NOISSUE simplify.

---
 api/logic/CMakeLists.txt                  |   2 -
 api/logic/Env.cpp                         |   2 +-
 api/logic/meta/BaseEntity.cpp             |   7 +-
 api/logic/meta/BaseEntity.h               |   5 +-
 api/logic/meta/Index.cpp                  |  27 ++--
 api/logic/meta/Index.h                    |   7 +-
 api/logic/meta/Index_test.cpp             |   6 +-
 api/logic/meta/Util.h                     |   3 -
 api/logic/meta/Version.cpp                |  13 +-
 api/logic/meta/Version.h                  |   2 +-
 api/logic/meta/VersionList.cpp            |  14 +-
 api/logic/meta/VersionList.h              |   3 +-
 api/logic/meta/format/Format.cpp          | 101 ++++++++++---
 api/logic/meta/format/Format.h            |  23 +--
 api/logic/meta/format/FormatV1.cpp        | 170 ----------------------
 api/logic/meta/format/FormatV1.h          |  33 -----
 api/logic/meta/tasks/LocalLoadTask.cpp    |  72 +--------
 api/logic/meta/tasks/LocalLoadTask.h      |  47 +-----
 api/logic/meta/tasks/RemoteLoadTask.cpp   | 141 +++++++-----------
 api/logic/meta/tasks/RemoteLoadTask.h     |  51 +------
 application/pages/global/PackagesPage.cpp |   2 +-
 21 files changed, 193 insertions(+), 538 deletions(-)
 delete mode 100644 api/logic/meta/format/FormatV1.cpp
 delete mode 100644 api/logic/meta/format/FormatV1.h

diff --git a/api/logic/CMakeLists.txt b/api/logic/CMakeLists.txt
index b605fbd3..42754157 100644
--- a/api/logic/CMakeLists.txt
+++ b/api/logic/CMakeLists.txt
@@ -420,8 +420,6 @@ set(META_SOURCES
 	meta/tasks/RemoteLoadTask.h
 	meta/tasks/LocalLoadTask.cpp
 	meta/tasks/LocalLoadTask.h
-	meta/format/FormatV1.cpp
-	meta/format/FormatV1.h
 	meta/format/Format.cpp
 	meta/format/Format.h
 	meta/BaseEntity.cpp
diff --git a/api/logic/Env.cpp b/api/logic/Env.cpp
index 903f1d8a..d7be4a28 100644
--- a/api/logic/Env.cpp
+++ b/api/logic/Env.cpp
@@ -124,7 +124,7 @@ void Env::initHttpMetaCache()
 	m_metacache->addBase("root", QDir::currentPath());
 	m_metacache->addBase("translations", QDir("translations").absolutePath());
 	m_metacache->addBase("icons", QDir("cache/icons").absolutePath());
-	m_metacache->addBase("meta", QDir("cache/meta").absolutePath());
+	m_metacache->addBase("meta", QDir("meta").absolutePath());
 	m_metacache->Load();
 }
 
diff --git a/api/logic/meta/BaseEntity.cpp b/api/logic/meta/BaseEntity.cpp
index fd44e29c..87cd55c8 100644
--- a/api/logic/meta/BaseEntity.cpp
+++ b/api/logic/meta/BaseEntity.cpp
@@ -24,19 +24,18 @@ BaseEntity::~BaseEntity()
 {
 }
 
-void BaseEntity::store() const
+QUrl BaseEntity::url() const
 {
-	Json::write(serialized(), Meta::localDir().absoluteFilePath(localFilename()));
+	return rootUrl().resolved(localFilename());
 }
 
 void BaseEntity::notifyLocalLoadComplete()
 {
 	m_localLoaded = true;
-	store();
 }
+
 void BaseEntity::notifyRemoteLoadComplete()
 {
 	m_remoteLoaded = true;
-	store();
 }
 }
diff --git a/api/logic/meta/BaseEntity.h b/api/logic/meta/BaseEntity.h
index b7a241c6..7064e9d2 100644
--- a/api/logic/meta/BaseEntity.h
+++ b/api/logic/meta/BaseEntity.h
@@ -17,6 +17,7 @@
 
 #include <QObject>
 #include <memory>
+#include <QJsonObject>
 
 #include "multimc_logic_export.h"
 
@@ -33,10 +34,10 @@ public:
 	virtual std::unique_ptr<Task> remoteUpdateTask() = 0;
 	virtual std::unique_ptr<Task> localUpdateTask() = 0;
 	virtual void merge(const std::shared_ptr<BaseEntity> &other) = 0;
+	virtual void parse(const QJsonObject &obj) = 0;
 
-	void store() const;
 	virtual QString localFilename() const = 0;
-	virtual QJsonObject serialized() const = 0;
+	virtual QUrl url() const;
 
 	bool isComplete() const { return m_localLoaded || m_remoteLoaded; }
 
diff --git a/api/logic/meta/Index.cpp b/api/logic/meta/Index.cpp
index 8a6b1355..e0e8bc5d 100644
--- a/api/logic/meta/Index.cpp
+++ b/api/logic/meta/Index.cpp
@@ -80,29 +80,36 @@ QVariant Index::headerData(int section, Qt::Orientation orientation, int role) c
 
 std::unique_ptr<Task> Index::remoteUpdateTask()
 {
-	return std::unique_ptr<IndexRemoteLoadTask>(new IndexRemoteLoadTask(this, this));
+	return std::unique_ptr<RemoteLoadTask>(new RemoteLoadTask(this));
 }
 std::unique_ptr<Task> Index::localUpdateTask()
 {
-	return std::unique_ptr<IndexLocalLoadTask>(new IndexLocalLoadTask(this, this));
-}
-
-QJsonObject Index::serialized() const
-{
-	return Format::serializeIndex(this);
+	return std::unique_ptr<LocalLoadTask>(new LocalLoadTask(this));
 }
 
 bool Index::hasUid(const QString &uid) const
 {
 	return m_uids.contains(uid);
 }
-VersionListPtr Index::getList(const QString &uid) const
+
+VersionListPtr Index::get(const QString &uid)
 {
 	return m_uids.value(uid, nullptr);
 }
-VersionListPtr Index::getListGuaranteed(const QString &uid) const
+
+VersionPtr Index::get(const QString &uid, const QString &version)
 {
-	return m_uids.value(uid, std::make_shared<VersionList>(uid));
+	auto list = get(uid);
+	if(list)
+	{
+		return list->getVersion(version);
+	}
+	return nullptr;
+}
+
+void Index::parse(const QJsonObject& obj)
+{
+	parseIndex(obj, this);
 }
 
 void Index::merge(const Ptr &other)
diff --git a/api/logic/meta/Index.h b/api/logic/meta/Index.h
index 16e95d5a..37341656 100644
--- a/api/logic/meta/Index.h
+++ b/api/logic/meta/Index.h
@@ -27,6 +27,7 @@ class Task;
 namespace Meta
 {
 using VersionListPtr = std::shared_ptr<class VersionList>;
+using VersionPtr = std::shared_ptr<class Version>;
 
 class MULTIMC_LOGIC_EXPORT Index : public QAbstractListModel, public BaseEntity
 {
@@ -51,17 +52,21 @@ public:
 	std::unique_ptr<Task> localUpdateTask() override;
 
 	QString localFilename() const override { return "index.json"; }
-	QJsonObject serialized() const override;
 
 	// queries
+	VersionListPtr get(const QString &uid);
+	VersionPtr get(const QString &uid, const QString &version);
 	bool hasUid(const QString &uid) const;
+	/*
 	VersionListPtr getList(const QString &uid) const;
 	VersionListPtr getListGuaranteed(const QString &uid) const;
+	*/
 
 	QVector<VersionListPtr> lists() const { return m_lists; }
 
 public: // for usage by parsers only
 	void merge(const BaseEntity::Ptr &other) override;
+	void parse(const QJsonObject &obj) override;
 
 private:
 	QVector<VersionListPtr> m_lists;
diff --git a/api/logic/meta/Index_test.cpp b/api/logic/meta/Index_test.cpp
index d26700ca..b4dbd009 100644
--- a/api/logic/meta/Index_test.cpp
+++ b/api/logic/meta/Index_test.cpp
@@ -27,9 +27,9 @@ slots:
 		Meta::Index windex({std::make_shared<Meta::VersionList>("list1"), std::make_shared<Meta::VersionList>("list2"), std::make_shared<Meta::VersionList>("list3")});
 		QVERIFY(windex.hasUid("list1"));
 		QVERIFY(!windex.hasUid("asdf"));
-		QVERIFY(windex.getList("list2") != nullptr);
-		QCOMPARE(windex.getList("list2")->uid(), QString("list2"));
-		QVERIFY(windex.getList("adsf") == nullptr);
+		QVERIFY(windex.get("list2") != nullptr);
+		QCOMPARE(windex.get("list2")->uid(), QString("list2"));
+		QVERIFY(windex.get("adsf") == nullptr);
 	}
 
 	void test_merge()
diff --git a/api/logic/meta/Util.h b/api/logic/meta/Util.h
index 28163fe4..188bcaa3 100644
--- a/api/logic/meta/Util.h
+++ b/api/logic/meta/Util.h
@@ -24,8 +24,5 @@ class QDir;
 namespace Meta
 {
 MULTIMC_LOGIC_EXPORT QUrl rootUrl();
-MULTIMC_LOGIC_EXPORT QUrl indexUrl();
-MULTIMC_LOGIC_EXPORT QUrl versionListUrl(const QString &uid);
-MULTIMC_LOGIC_EXPORT QUrl versionUrl(const QString &uid, const QString &version);
 MULTIMC_LOGIC_EXPORT QDir localDir();
 }
diff --git a/api/logic/meta/Version.cpp b/api/logic/meta/Version.cpp
index 039f4fef..b79c178a 100644
--- a/api/logic/meta/Version.cpp
+++ b/api/logic/meta/Version.cpp
@@ -48,11 +48,16 @@ QDateTime Version::time() const
 
 std::unique_ptr<Task> Version::remoteUpdateTask()
 {
-	return std::unique_ptr<VersionRemoteLoadTask>(new VersionRemoteLoadTask(this, this));
+	return std::unique_ptr<RemoteLoadTask>(new RemoteLoadTask(this));
 }
 std::unique_ptr<Task> Version::localUpdateTask()
 {
-	return std::unique_ptr<VersionLocalLoadTask>(new VersionLocalLoadTask(this, this));
+	return std::unique_ptr<LocalLoadTask>(new LocalLoadTask(this));
+}
+
+void Version::parse(const QJsonObject& obj)
+{
+	parseVersion(obj, this);
 }
 
 void Version::merge(const std::shared_ptr<BaseEntity> &other)
@@ -78,10 +83,6 @@ QString Version::localFilename() const
 {
 	return m_uid + '/' + m_version + ".json";
 }
-QJsonObject Version::serialized() const
-{
-	return Format::serializeVersion(this);
-}
 
 void Version::setType(const QString &type)
 {
diff --git a/api/logic/meta/Version.h b/api/logic/meta/Version.h
index 4a791880..635b79f6 100644
--- a/api/logic/meta/Version.h
+++ b/api/logic/meta/Version.h
@@ -59,9 +59,9 @@ public:
 	std::unique_ptr<Task> remoteUpdateTask() override;
 	std::unique_ptr<Task> localUpdateTask() override;
 	void merge(const std::shared_ptr<BaseEntity> &other) override;
+	void parse(const QJsonObject &obj) override;
 
 	QString localFilename() const override;
-	QJsonObject serialized() const override;
 
 public: // for usage by format parsers only
 	void setType(const QString &type);
diff --git a/api/logic/meta/VersionList.cpp b/api/logic/meta/VersionList.cpp
index aab3e0f7..7196d4be 100644
--- a/api/logic/meta/VersionList.cpp
+++ b/api/logic/meta/VersionList.cpp
@@ -169,21 +169,17 @@ QHash<int, QByteArray> VersionList::roleNames() const
 
 std::unique_ptr<Task> VersionList::remoteUpdateTask()
 {
-	return std::unique_ptr<VersionListRemoteLoadTask>(new VersionListRemoteLoadTask(this, this));
+	return std::unique_ptr<RemoteLoadTask>(new RemoteLoadTask(this));
 }
 std::unique_ptr<Task> VersionList::localUpdateTask()
 {
-	return std::unique_ptr<VersionListLocalLoadTask>(new VersionListLocalLoadTask(this, this));
+	return std::unique_ptr<LocalLoadTask>(new LocalLoadTask(this));
 }
 
 QString VersionList::localFilename() const
 {
 	return m_uid + "/index.json";
 }
-QJsonObject VersionList::serialized() const
-{
-	return Format::serializeVersionList(this);
-}
 
 QString VersionList::humanReadable() const
 {
@@ -224,6 +220,11 @@ void VersionList::setVersions(const QVector<VersionPtr> &versions)
 	endResetModel();
 }
 
+void VersionList::parse(const QJsonObject& obj)
+{
+	parseVersionList(obj, this);
+}
+
 void VersionList::merge(const BaseEntity::Ptr &other)
 {
 	const VersionListPtr list = std::dynamic_pointer_cast<VersionList>(other);
@@ -285,4 +286,5 @@ BaseVersionPtr VersionList::getRecommended() const
 
 }
 
+
 #include "VersionList.moc"
diff --git a/api/logic/meta/VersionList.h b/api/logic/meta/VersionList.h
index 0eb85bf8..934b20e4 100644
--- a/api/logic/meta/VersionList.h
+++ b/api/logic/meta/VersionList.h
@@ -17,6 +17,7 @@
 
 #include "BaseVersionList.h"
 #include "BaseEntity.h"
+#include <QJsonObject>
 #include <memory>
 
 namespace Meta
@@ -57,7 +58,6 @@ public:
 	std::unique_ptr<Task> localUpdateTask() override;
 
 	QString localFilename() const override;
-	QJsonObject serialized() const override;
 
 	QString uid() const { return m_uid; }
 	QString name() const { return m_name; }
@@ -72,6 +72,7 @@ public: // for usage only by parsers
 	void setName(const QString &name);
 	void setVersions(const QVector<VersionPtr> &versions);
 	void merge(const BaseEntity::Ptr &other) override;
+	void parse(const QJsonObject &obj) override;
 
 signals:
 	void nameChanged(const QString &name);
diff --git a/api/logic/meta/format/Format.cpp b/api/logic/meta/format/Format.cpp
index e0fddb0b..39d3f14f 100644
--- a/api/logic/meta/format/Format.cpp
+++ b/api/logic/meta/format/Format.cpp
@@ -15,15 +15,85 @@
 
 #include "Format.h"
 
-#include "FormatV1.h"
+#include "minecraft/onesix/OneSixVersionFormat.h""
 
 #include "meta/Index.h"
 #include "meta/Version.h"
 #include "meta/VersionList.h"
 
+#include "Json.h"
+using namespace Json;
+
 namespace Meta
 {
 
+static const int currentFormatVersion = 0;
+
+// Index
+static BaseEntity::Ptr parseIndexInternal(const QJsonObject &obj)
+{
+	const QVector<QJsonObject> objects = requireIsArrayOf<QJsonObject>(obj, "packages");
+	QVector<VersionListPtr> lists;
+	lists.reserve(objects.size());
+	std::transform(objects.begin(), objects.end(), std::back_inserter(lists), [](const QJsonObject &obj)
+	{
+		VersionListPtr list = std::make_shared<VersionList>(requireString(obj, "uid"));
+		list->setName(ensureString(obj, "name", QString()));
+		return list;
+	});
+	return std::make_shared<Index>(lists);
+}
+
+// Version
+static VersionPtr parseCommonVersion(const QString &uid, const QJsonObject &obj)
+{
+	const QVector<QJsonObject> requiresRaw = obj.contains("requires") ? requireIsArrayOf<QJsonObject>(obj, "requires") : QVector<QJsonObject>();
+	QVector<Reference> requires;
+	requires.reserve(requiresRaw.size());
+	std::transform(requiresRaw.begin(), requiresRaw.end(), std::back_inserter(requires), [](const QJsonObject &rObj)
+	{
+		Reference ref(requireString(rObj, "uid"));
+		ref.setVersion(ensureString(rObj, "version", QString()));
+		return ref;
+	});
+
+	VersionPtr version = std::make_shared<Version>(uid, requireString(obj, "version"));
+	version->setTime(QDateTime::fromString(requireString(obj, "releaseTime"), Qt::ISODate).toMSecsSinceEpoch() / 1000);
+	version->setType(ensureString(obj, "type", QString()));
+	version->setRequires(requires);
+	return version;
+}
+
+static BaseEntity::Ptr parseVersionInternal(const QJsonObject &obj)
+{
+	VersionPtr version = parseCommonVersion(requireString(obj, "uid"), obj);
+
+	version->setData(OneSixVersionFormat::versionFileFromJson(QJsonDocument(obj),
+										   QString("%1/%2.json").arg(version->uid(), version->version()),
+										   obj.contains("order")));
+	return version;
+}
+
+// Version list / package
+static BaseEntity::Ptr parseVersionListInternal(const QJsonObject &obj)
+{
+	const QString uid = requireString(obj, "uid");
+
+	const QVector<QJsonObject> versionsRaw = requireIsArrayOf<QJsonObject>(obj, "versions");
+	QVector<VersionPtr> versions;
+	versions.reserve(versionsRaw.size());
+	std::transform(versionsRaw.begin(), versionsRaw.end(), std::back_inserter(versions), [uid](const QJsonObject &vObj)
+	{
+		return parseCommonVersion(uid, vObj);
+	});
+
+	VersionListPtr list = std::make_shared<VersionList>(uid);
+	list->setName(ensureString(obj, "name", QString()));
+	list->setVersions(versions);
+	return list;
+}
+
+
 static int formatVersion(const QJsonObject &obj)
 {
 	if (!obj.contains("formatVersion")) {
@@ -35,56 +105,39 @@ static int formatVersion(const QJsonObject &obj)
 	return obj.value("formatVersion").toInt();
 }
 
-void Format::parseIndex(const QJsonObject &obj, Index *ptr)
+void parseIndex(const QJsonObject &obj, Index *ptr)
 {
 	const int version = formatVersion(obj);
 	switch (version) {
 	case 0:
-		ptr->merge(FormatV1().parseIndexInternal(obj));
+		ptr->merge(parseIndexInternal(obj));
 		break;
 	default:
 		throw ParseException(QObject::tr("Unknown formatVersion: %1").arg(version));
 	}
 }
 
-void Format::parseVersionList(const QJsonObject &obj, VersionList *ptr)
+void parseVersionList(const QJsonObject &obj, VersionList *ptr)
 {
 	const int version = formatVersion(obj);
 	switch (version) {
 	case 0:
-		ptr->merge(FormatV1().parseVersionListInternal(obj));
+		ptr->merge(parseVersionListInternal(obj));
 		break;
 	default:
 		throw ParseException(QObject::tr("Unknown formatVersion: %1").arg(version));
 	}
 }
 
-void Format::parseVersion(const QJsonObject &obj, Version *ptr)
+void parseVersion(const QJsonObject &obj, Version *ptr)
 {
 	const int version = formatVersion(obj);
 	switch (version) {
 	case 0:
-		ptr->merge(FormatV1().parseVersionInternal(obj));
+		ptr->merge(parseVersionInternal(obj));
 		break;
 	default:
 		throw ParseException(QObject::tr("Unknown formatVersion: %1").arg(version));
 	}
 }
-
-
-QJsonObject Format::serializeIndex(const Index *ptr)
-{
-	return FormatV1().serializeIndexInternal(ptr);
-}
-
-QJsonObject Format::serializeVersionList(const VersionList *ptr)
-{
-	return FormatV1().serializeVersionListInternal(ptr);
-}
-
-QJsonObject Format::serializeVersion(const Version *ptr)
-{
-	return FormatV1().serializeVersionInternal(ptr);
-}
-
 }
diff --git a/api/logic/meta/format/Format.h b/api/logic/meta/format/Format.h
index 79605a6f..aaed07fc 100644
--- a/api/logic/meta/format/Format.h
+++ b/api/logic/meta/format/Format.h
@@ -33,25 +33,8 @@ public:
 	using Exception::Exception;
 };
 
-class Format
-{
-public:
-	virtual ~Format() {}
+void parseIndex(const QJsonObject &obj, Index *ptr);
+void parseVersion(const QJsonObject &obj, Version *ptr);
+void parseVersionList(const QJsonObject &obj, VersionList *ptr);
 
-	static void parseIndex(const QJsonObject &obj, Index *ptr);
-	static void parseVersion(const QJsonObject &obj, Version *ptr);
-	static void parseVersionList(const QJsonObject &obj, VersionList *ptr);
-
-	static QJsonObject serializeIndex(const Index *ptr);
-	static QJsonObject serializeVersion(const Version *ptr);
-	static QJsonObject serializeVersionList(const VersionList *ptr);
-
-protected:
-	virtual BaseEntity::Ptr parseIndexInternal(const QJsonObject &obj) const = 0;
-	virtual BaseEntity::Ptr parseVersionInternal(const QJsonObject &obj) const = 0;
-	virtual BaseEntity::Ptr parseVersionListInternal(const QJsonObject &obj) const = 0;
-	virtual QJsonObject serializeIndexInternal(const Index *ptr) const = 0;
-	virtual QJsonObject serializeVersionInternal(const Version *ptr) const = 0;
-	virtual QJsonObject serializeVersionListInternal(const VersionList *ptr) const = 0;
-};
 }
diff --git a/api/logic/meta/format/FormatV1.cpp b/api/logic/meta/format/FormatV1.cpp
deleted file mode 100644
index ee2c5291..00000000
--- a/api/logic/meta/format/FormatV1.cpp
+++ /dev/null
@@ -1,170 +0,0 @@
-/* Copyright 2015-2017 MultiMC Contributors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#include "FormatV1.h"
-#include <minecraft/onesix/OneSixVersionFormat.h>
-
-#include "Json.h"
-
-#include "meta/Index.h"
-#include "meta/Version.h"
-#include "meta/VersionList.h"
-#include "Env.h"
-
-using namespace Json;
-
-namespace Meta
-{
-
-static const int currentFormatVersion = 0;
-
-// Index
-
-BaseEntity::Ptr FormatV1::parseIndexInternal(const QJsonObject &obj) const
-{
-	const QVector<QJsonObject> objects = requireIsArrayOf<QJsonObject>(obj, "packages");
-	QVector<VersionListPtr> lists;
-	lists.reserve(objects.size());
-	std::transform(objects.begin(), objects.end(), std::back_inserter(lists), [](const QJsonObject &obj)
-	{
-		VersionListPtr list = std::make_shared<VersionList>(requireString(obj, "uid"));
-		list->setName(ensureString(obj, "name", QString()));
-		return list;
-	});
-	return std::make_shared<Index>(lists);
-}
-
-QJsonObject FormatV1::serializeIndexInternal(const Index *ptr) const
-{
-	QJsonArray packages;
-	for (const VersionListPtr &list : ptr->lists())
-	{
-		QJsonObject out;
-		out["uid"] = list->uid();
-		out["name"] = list->name();
-		packages.append(out);
-	}
-	QJsonObject out;
-	out["formatVersion"] = currentFormatVersion;
-	out["packages"] = packages;
-	return out;
-}
-
-
-// Version
-
-static VersionPtr parseCommonVersion(const QString &uid, const QJsonObject &obj)
-{
-	const QVector<QJsonObject> requiresRaw = obj.contains("requires") ? requireIsArrayOf<QJsonObject>(obj, "requires") : QVector<QJsonObject>();
-	QVector<Reference> requires;
-	requires.reserve(requiresRaw.size());
-	std::transform(requiresRaw.begin(), requiresRaw.end(), std::back_inserter(requires), [](const QJsonObject &rObj)
-	{
-		Reference ref(requireString(rObj, "uid"));
-		ref.setVersion(ensureString(rObj, "version", QString()));
-		return ref;
-	});
-
-	VersionPtr version = std::make_shared<Version>(uid, requireString(obj, "version"));
-	version->setTime(QDateTime::fromString(requireString(obj, "releaseTime"), Qt::ISODate).toMSecsSinceEpoch() / 1000);
-	version->setType(ensureString(obj, "type", QString()));
-	version->setRequires(requires);
-	return version;
-}
-
-BaseEntity::Ptr FormatV1::parseVersionInternal(const QJsonObject &obj) const
-{
-	VersionPtr version = parseCommonVersion(requireString(obj, "uid"), obj);
-
-	version->setData(OneSixVersionFormat::versionFileFromJson(QJsonDocument(obj),
-										   QString("%1/%2.json").arg(version->uid(), version->version()),
-										   obj.contains("order")));
-	return version;
-}
-
-static void serializeCommonVersion(const Version *version, QJsonObject &obj)
-{
-	QJsonArray requires;
-	for (const Reference &ref : version->requires())
-	{
-		if (ref.version().isEmpty())
-		{
-			QJsonObject out;
-			out["uid"] = ref.uid();
-			requires.append(out);
-		}
-		else
-		{
-			QJsonObject out;
-			out["uid"] = ref.uid();
-			out["version"] = ref.version();
-			requires.append(out);
-		}
-	}
-
-	obj.insert("version", version->version());
-	obj.insert("type", version->type());
-	obj.insert("releaseTime", version->time().toString(Qt::ISODate));
-	obj.insert("requires", requires);
-}
-
-QJsonObject FormatV1::serializeVersionInternal(const Version *ptr) const
-{
-	QJsonObject obj = OneSixVersionFormat::versionFileToJson(ptr->data(), true).object();
-	serializeCommonVersion(ptr, obj);
-	obj.insert("formatVersion", currentFormatVersion);
-	obj.insert("uid", ptr->uid());
-	// TODO: the name should be looked up in the UI based on the uid
-	obj.insert("name", ENV.metadataIndex()->getListGuaranteed(ptr->uid())->name());
-
-	return obj;
-}
-
-
-// Version list / package
-
-BaseEntity::Ptr FormatV1::parseVersionListInternal(const QJsonObject &obj) const
-{
-	const QString uid = requireString(obj, "uid");
-
-	const QVector<QJsonObject> versionsRaw = requireIsArrayOf<QJsonObject>(obj, "versions");
-	QVector<VersionPtr> versions;
-	versions.reserve(versionsRaw.size());
-	std::transform(versionsRaw.begin(), versionsRaw.end(), std::back_inserter(versions), [this, uid](const QJsonObject &vObj)
-	{ return parseCommonVersion(uid, vObj); });
-
-	VersionListPtr list = std::make_shared<VersionList>(uid);
-	list->setName(ensureString(obj, "name", QString()));
-	list->setVersions(versions);
-	return list;
-}
-
-QJsonObject FormatV1::serializeVersionListInternal(const VersionList *ptr) const
-{
-	QJsonArray versions;
-	for (const VersionPtr &version : ptr->versions())
-	{
-		QJsonObject obj;
-		serializeCommonVersion(version.get(), obj);
-		versions.append(obj);
-	}
-	QJsonObject out;
-	out["formatVersion"] = currentFormatVersion;
-	out["uid"] = ptr->uid();
-	out["name"] = ptr->name().isNull() ? QJsonValue() : ptr->name();
-	out["versions"] = versions;
-	return out;
-}
-}
diff --git a/api/logic/meta/format/FormatV1.h b/api/logic/meta/format/FormatV1.h
deleted file mode 100644
index ab986083..00000000
--- a/api/logic/meta/format/FormatV1.h
+++ /dev/null
@@ -1,33 +0,0 @@
-/* Copyright 2015-2017 MultiMC Contributors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#pragma once
-
-#include "Format.h"
-
-namespace Meta
-{
-class FormatV1 : public Format
-{
-public:
-	BaseEntity::Ptr parseIndexInternal(const QJsonObject &obj) const override;
-	BaseEntity::Ptr parseVersionInternal(const QJsonObject &obj) const override;
-	BaseEntity::Ptr parseVersionListInternal(const QJsonObject &obj) const override;
-
-	QJsonObject serializeIndexInternal(const Index *ptr) const override;
-	QJsonObject serializeVersionInternal(const Version *ptr) const override;
-	QJsonObject serializeVersionListInternal(const VersionList *ptr) const override;
-};
-}
diff --git a/api/logic/meta/tasks/LocalLoadTask.cpp b/api/logic/meta/tasks/LocalLoadTask.cpp
index 33ea8016..b64fc5d3 100644
--- a/api/logic/meta/tasks/LocalLoadTask.cpp
+++ b/api/logic/meta/tasks/LocalLoadTask.cpp
@@ -34,19 +34,18 @@ LocalLoadTask::LocalLoadTask(BaseEntity *entity, QObject *parent)
 
 void LocalLoadTask::executeTask()
 {
-	const QString fname = Meta::localDir().absoluteFilePath(filename());
+	const QString fname = Meta::localDir().absoluteFilePath(m_entity->localFilename());
 	if (!QFile::exists(fname))
 	{
 		emitFailed(tr("File doesn't exist"));
 		return;
 	}
-
-	setStatus(tr("Reading %1...").arg(name()));
+	setStatus(tr("Reading %1...").arg(fname));
 	setProgress(0, 0);
 
 	try
 	{
-		parse(Json::requireObject(Json::requireDocument(fname, name()), name()));
+		m_entity->parse(Json::requireObject(Json::requireDocument(fname, fname), fname));
 		m_entity->notifyLocalLoadComplete();
 		emitSucceeded();
 	}
@@ -55,69 +54,4 @@ void LocalLoadTask::executeTask()
 		emitFailed(tr("Unable to parse file %1: %2").arg(fname, e.cause()));
 	}
 }
-
-
-// INDEX
-IndexLocalLoadTask::IndexLocalLoadTask(Index *index, QObject *parent)
-	: LocalLoadTask(index, parent)
-{
-}
-QString IndexLocalLoadTask::filename() const
-{
-	return "index.json";
-}
-QString IndexLocalLoadTask::name() const
-{
-	return tr("Metadata Index");
-}
-void IndexLocalLoadTask::parse(const QJsonObject &obj) const
-{
-	Format::parseIndex(obj, dynamic_cast<Index *>(entity()));
-}
-
-
-// VERSION LIST
-VersionListLocalLoadTask::VersionListLocalLoadTask(VersionList *list, QObject *parent)
-	: LocalLoadTask(list, parent)
-{
-}
-QString VersionListLocalLoadTask::filename() const
-{
-	return list()->uid() + ".json";
-}
-QString VersionListLocalLoadTask::name() const
-{
-	return tr("Version List for %1").arg(list()->humanReadable());
-}
-void VersionListLocalLoadTask::parse(const QJsonObject &obj) const
-{
-	Format::parseVersionList(obj, list());
-}
-VersionList *VersionListLocalLoadTask::list() const
-{
-	return dynamic_cast<VersionList *>(entity());
-}
-
-
-// VERSION
-VersionLocalLoadTask::VersionLocalLoadTask(Version *version, QObject *parent)
-	: LocalLoadTask(version, parent)
-{
-}
-QString VersionLocalLoadTask::filename() const
-{
-	return version()->uid() + "/" + version()->version() + ".json";
-}
-QString VersionLocalLoadTask::name() const
-{
-	return tr(" Version for %1").arg(version()->name());
-}
-void VersionLocalLoadTask::parse(const QJsonObject &obj) const
-{
-	Format::parseVersion(obj, version());
-}
-Version *VersionLocalLoadTask::version() const
-{
-	return dynamic_cast<Version *>(entity());
-}
 }
diff --git a/api/logic/meta/tasks/LocalLoadTask.h b/api/logic/meta/tasks/LocalLoadTask.h
index 36ae1b6f..905660ed 100644
--- a/api/logic/meta/tasks/LocalLoadTask.h
+++ b/api/logic/meta/tasks/LocalLoadTask.h
@@ -25,60 +25,15 @@ class Index;
 class VersionList;
 class Version;
 
+// FIXME: this is now just an odd function, get rid of it
 class LocalLoadTask : public Task
 {
 	Q_OBJECT
 public:
 	explicit LocalLoadTask(BaseEntity *entity, QObject *parent = nullptr);
 
-protected:
-	virtual QString filename() const = 0;
-	virtual QString name() const = 0;
-	virtual void parse(const QJsonObject &obj) const = 0;
-
-	BaseEntity *entity() const { return m_entity; }
-
 private:
 	void executeTask() override;
-
 	BaseEntity *m_entity;
 };
-
-class IndexLocalLoadTask : public LocalLoadTask
-{
-	Q_OBJECT
-public:
-	explicit IndexLocalLoadTask(Index *index, QObject *parent = nullptr);
-
-private:
-	QString filename() const override;
-	QString name() const override;
-	void parse(const QJsonObject &obj) const override;
-};
-class VersionListLocalLoadTask : public LocalLoadTask
-{
-	Q_OBJECT
-public:
-	explicit VersionListLocalLoadTask(VersionList *list, QObject *parent = nullptr);
-
-private:
-	QString filename() const override;
-	QString name() const override;
-	void parse(const QJsonObject &obj) const override;
-
-	VersionList *list() const;
-};
-class VersionLocalLoadTask : public LocalLoadTask
-{
-	Q_OBJECT
-public:
-	explicit VersionLocalLoadTask(Version *version, QObject *parent = nullptr);
-
-private:
-	QString filename() const override;
-	QString name() const override;
-	void parse(const QJsonObject &obj) const override;
-
-	Version *version() const;
-};
 }
diff --git a/api/logic/meta/tasks/RemoteLoadTask.cpp b/api/logic/meta/tasks/RemoteLoadTask.cpp
index 69a59c07..b73af021 100644
--- a/api/logic/meta/tasks/RemoteLoadTask.cpp
+++ b/api/logic/meta/tasks/RemoteLoadTask.cpp
@@ -34,99 +34,70 @@ RemoteLoadTask::RemoteLoadTask(BaseEntity *entity, QObject *parent)
 {
 }
 
+class ParsingValidator : public Net::Validator
+{
+public: /* con/des */
+	ParsingValidator(BaseEntity *entity) : m_entity(entity)
+	{
+	};
+	virtual ~ParsingValidator()
+	{
+	};
+
+public: /* methods */
+	bool init(QNetworkRequest &) override
+	{
+		return true;
+	}
+	bool write(QByteArray & data) override
+	{
+		this->data.append(data);
+		return true;
+	}
+	bool abort() override
+	{
+		return true;
+	}
+	bool validate(QNetworkReply &) override
+	{
+		auto fname = m_entity->localFilename();
+		try
+		{
+			m_entity->parse(Json::requireObject(Json::requireDocument(data, fname), fname));
+			m_entity->notifyRemoteLoadComplete();
+			return true;
+		}
+		catch (Exception &e)
+		{
+			qWarning() << "Unable to parse response:" << e.cause();
+			return false;
+		}
+	}
+
+private: /* data */
+	QByteArray data;
+	BaseEntity *m_entity;
+};
+
 void RemoteLoadTask::executeTask()
 {
-	NetJob *job = new NetJob(name());
+	// FIXME: leak here!!!
+	NetJob *job = new NetJob(tr("Download of meta file %1").arg(m_entity->localFilename()));
 
-	auto entry = ENV.metacache()->resolveEntry("meta", url().toString());
+	auto url = m_entity->url();
+	auto entry = ENV.metacache()->resolveEntry("meta", m_entity->localFilename());
 	entry->setStale(true);
-	m_dl = Net::Download::makeCached(url(), entry);
+	m_dl = Net::Download::makeCached(url, entry);
+	/*
+	 * The validator parses the file and loads it into the object.
+	 * If that fails, the file is not written to storage.
+	 */
+	m_dl->addValidator(new ParsingValidator(m_entity));
 	job->addNetAction(m_dl);
 	connect(job, &NetJob::failed, this, &RemoteLoadTask::emitFailed);
-	connect(job, &NetJob::succeeded, this, &RemoteLoadTask::networkFinished);
+	connect(job, &NetJob::succeeded, this, &RemoteLoadTask::succeeded);
 	connect(job, &NetJob::status, this, &RemoteLoadTask::setStatus);
 	connect(job, &NetJob::progress, this, &RemoteLoadTask::setProgress);
 	job->start();
 }
-
-void RemoteLoadTask::networkFinished()
-{
-	setStatus(tr("Parsing..."));
-	setProgress(0, 0);
-
-	try
-	{
-		parse(Json::requireObject(Json::requireDocument(m_dl->getTargetFilepath(), name()), name()));
-		m_entity->notifyRemoteLoadComplete();
-		emitSucceeded();
-	}
-	catch (Exception &e)
-	{
-		emitFailed(tr("Unable to parse response: %1").arg(e.cause()));
-	}
-}
-
-// INDEX
-IndexRemoteLoadTask::IndexRemoteLoadTask(Index *index, QObject *parent)
-	: RemoteLoadTask(index, parent)
-{
-}
-QUrl IndexRemoteLoadTask::url() const
-{
-	return Meta::indexUrl();
-}
-QString IndexRemoteLoadTask::name() const
-{
-	return tr("Metadata Index");
-}
-void IndexRemoteLoadTask::parse(const QJsonObject &obj) const
-{
-	Format::parseIndex(obj, dynamic_cast<Index *>(entity()));
-}
-
-
-// VERSION LIST
-VersionListRemoteLoadTask::VersionListRemoteLoadTask(VersionList *list, QObject *parent)
-	: RemoteLoadTask(list, parent)
-{
-}
-QUrl VersionListRemoteLoadTask::url() const
-{
-	return Meta::versionListUrl(list()->uid());
-}
-QString VersionListRemoteLoadTask::name() const
-{
-	return tr("Version List for %1").arg(list()->humanReadable());
-}
-void VersionListRemoteLoadTask::parse(const QJsonObject &obj) const
-{
-	Format::parseVersionList(obj, list());
-}
-VersionList* Meta::VersionListRemoteLoadTask::list() const
-{
-	return dynamic_cast<VersionList *>(entity());
-}
-
-
-// VERSION
-VersionRemoteLoadTask::VersionRemoteLoadTask(Version *version, QObject *parent)
-	: RemoteLoadTask(version, parent)
-{
-}
-QUrl VersionRemoteLoadTask::url() const
-{
-	return Meta::versionUrl(version()->uid(), version()->version());
-}
-QString VersionRemoteLoadTask::name() const
-{
-	return tr("Meta Version for %1").arg(version()->name());
-}
-void VersionRemoteLoadTask::parse(const QJsonObject &obj) const
-{
-	Format::parseVersion(obj, version());
-}
-Version *VersionRemoteLoadTask::version() const
-{
-	return dynamic_cast<Version *>(entity());
-}
 }
diff --git a/api/logic/meta/tasks/RemoteLoadTask.h b/api/logic/meta/tasks/RemoteLoadTask.h
index 3b09404f..6d81d8ea 100644
--- a/api/logic/meta/tasks/RemoteLoadTask.h
+++ b/api/logic/meta/tasks/RemoteLoadTask.h
@@ -30,66 +30,17 @@ class Index;
 class VersionList;
 class Version;
 
+// FIXME: this is now just an oddly constructed NetJob, get rid of it.
 class RemoteLoadTask : public Task
 {
 	Q_OBJECT
 public:
 	explicit RemoteLoadTask(BaseEntity *entity, QObject *parent = nullptr);
 
-protected:
-	virtual QUrl url() const = 0;
-	virtual QString name() const = 0;
-	virtual void parse(const QJsonObject &obj) const = 0;
-
-	BaseEntity *entity() const { return m_entity; }
-
-private slots:
-	void networkFinished();
-
 private:
 	void executeTask() override;
 
 	BaseEntity *m_entity;
 	std::shared_ptr<Net::Download> m_dl;
 };
-
-class IndexRemoteLoadTask : public RemoteLoadTask
-{
-	Q_OBJECT
-public:
-	explicit IndexRemoteLoadTask(Index *index, QObject *parent = nullptr);
-
-private:
-	QUrl url() const override;
-	QString name() const override;
-	void parse(const QJsonObject &obj) const override;
-};
-
-class VersionListRemoteLoadTask : public RemoteLoadTask
-{
-	Q_OBJECT
-public:
-	explicit VersionListRemoteLoadTask(VersionList *list, QObject *parent = nullptr);
-
-private:
-	QUrl url() const override;
-	QString name() const override;
-	void parse(const QJsonObject &obj) const override;
-
-	VersionList *list() const;
-};
-
-class VersionRemoteLoadTask : public RemoteLoadTask
-{
-	Q_OBJECT
-public:
-	explicit VersionRemoteLoadTask(Version *version, QObject *parent = nullptr);
-
-private:
-	QUrl url() const override;
-	QString name() const override;
-	void parse(const QJsonObject &obj) const override;
-
-	Version *version() const;
-};
 }
diff --git a/application/pages/global/PackagesPage.cpp b/application/pages/global/PackagesPage.cpp
index 52efaf9a..81ad4da1 100644
--- a/application/pages/global/PackagesPage.cpp
+++ b/application/pages/global/PackagesPage.cpp
@@ -36,7 +36,7 @@ static QString formatRequires(const VersionPtr &version)
 	QStringList lines;
 	for (const Reference &ref : version->requires())
 	{
-		const QString readable = ENV.metadataIndex()->hasUid(ref.uid()) ? ENV.metadataIndex()->getList(ref.uid())->humanReadable() : ref.uid();
+		const QString readable = ENV.metadataIndex()->hasUid(ref.uid()) ? ENV.metadataIndex()->get(ref.uid())->humanReadable() : ref.uid();
 		if (ref.version().isEmpty())
 		{
 			lines.append(readable);

From e46aba9da584338db8d8a1a8a487bdcc6cf84343 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= <peterix@gmail.com>
Date: Sat, 18 Mar 2017 02:22:36 +0100
Subject: [PATCH 10/28] NOISSUE sanitize loading and downloading of metadata
 files

---
 api/logic/CMakeLists.txt                      |  10 +-
 api/logic/meta/BaseEntity.cpp                 | 119 ++++++++++++++++--
 api/logic/meta/BaseEntity.h                   |  45 +++++--
 api/logic/meta/Index.cpp                      |  13 +-
 api/logic/meta/Index.h                        |   7 --
 api/logic/meta/Index_test.cpp                 |   6 -
 .../{format/Format.cpp => JsonFormat.cpp}     |  15 +--
 .../meta/{format/Format.h => JsonFormat.h}    |   0
 api/logic/meta/Util.cpp                       |  50 --------
 api/logic/meta/Util.h                         |  28 -----
 api/logic/meta/Version.cpp                    |  13 +-
 api/logic/meta/Version.h                      |   2 -
 api/logic/meta/VersionList.cpp                |  70 +----------
 api/logic/meta/VersionList.h                  |   3 -
 api/logic/meta/tasks/LocalLoadTask.cpp        |  57 ---------
 api/logic/meta/tasks/LocalLoadTask.h          |  39 ------
 api/logic/meta/tasks/RemoteLoadTask.cpp       | 103 ---------------
 api/logic/meta/tasks/RemoteLoadTask.h         |  46 -------
 application/MainWindow.cpp                    |  15 +--
 application/pages/global/PackagesPage.cpp     |  33 +----
 20 files changed, 164 insertions(+), 510 deletions(-)
 rename api/logic/meta/{format/Format.cpp => JsonFormat.cpp} (95%)
 rename api/logic/meta/{format/Format.h => JsonFormat.h} (100%)
 delete mode 100644 api/logic/meta/Util.cpp
 delete mode 100644 api/logic/meta/Util.h
 delete mode 100644 api/logic/meta/tasks/LocalLoadTask.cpp
 delete mode 100644 api/logic/meta/tasks/LocalLoadTask.h
 delete mode 100644 api/logic/meta/tasks/RemoteLoadTask.cpp
 delete mode 100644 api/logic/meta/tasks/RemoteLoadTask.h

diff --git a/api/logic/CMakeLists.txt b/api/logic/CMakeLists.txt
index 42754157..544ace80 100644
--- a/api/logic/CMakeLists.txt
+++ b/api/logic/CMakeLists.txt
@@ -416,12 +416,8 @@ set(TOOLS_SOURCES
 
 set(META_SOURCES
 	# Metadata sources
-	meta/tasks/RemoteLoadTask.cpp
-	meta/tasks/RemoteLoadTask.h
-	meta/tasks/LocalLoadTask.cpp
-	meta/tasks/LocalLoadTask.h
-	meta/format/Format.cpp
-	meta/format/Format.h
+	meta/JsonFormat.cpp
+	meta/JsonFormat.h
 	meta/BaseEntity.cpp
 	meta/BaseEntity.h
 	meta/VersionList.cpp
@@ -430,8 +426,6 @@ set(META_SOURCES
 	meta/Version.h
 	meta/Index.cpp
 	meta/Index.h
-	meta/Util.cpp
-	meta/Util.h
 	meta/Reference.cpp
 	meta/Reference.h
 )
diff --git a/api/logic/meta/BaseEntity.cpp b/api/logic/meta/BaseEntity.cpp
index 87cd55c8..18b7f92f 100644
--- a/api/logic/meta/BaseEntity.cpp
+++ b/api/logic/meta/BaseEntity.cpp
@@ -16,26 +16,125 @@
 #include "BaseEntity.h"
 
 #include "Json.h"
-#include "Util.h"
 
-namespace Meta
+#include "net/Download.h"
+#include "net/HttpMetaCache.h"
+#include "net/NetJob.h"
+
+#include "Env.h"
+#include "Json.h"
+
+class ParsingValidator : public Net::Validator
 {
-BaseEntity::~BaseEntity()
+public: /* con/des */
+	ParsingValidator(Meta::BaseEntity *entity) : m_entity(entity)
+	{
+	};
+	virtual ~ParsingValidator()
+	{
+	};
+
+public: /* methods */
+	bool init(QNetworkRequest &) override
+	{
+		return true;
+	}
+	bool write(QByteArray & data) override
+	{
+		this->data.append(data);
+		return true;
+	}
+	bool abort() override
+	{
+		return true;
+	}
+	bool validate(QNetworkReply &) override
+	{
+		auto fname = m_entity->localFilename();
+		try
+		{
+			m_entity->parse(Json::requireObject(Json::requireDocument(data, fname), fname));
+			return true;
+		}
+		catch (Exception &e)
+		{
+			qWarning() << "Unable to parse response:" << e.cause();
+			return false;
+		}
+	}
+
+private: /* data */
+	QByteArray data;
+	Meta::BaseEntity *m_entity;
+};
+
+Meta::BaseEntity::~BaseEntity()
 {
 }
 
-QUrl BaseEntity::url() const
+QUrl Meta::BaseEntity::url() const
 {
-	return rootUrl().resolved(localFilename());
+	return QUrl("https://meta.multimc.org").resolved(localFilename());
 }
 
-void BaseEntity::notifyLocalLoadComplete()
+bool Meta::BaseEntity::loadLocalFile()
 {
-	m_localLoaded = true;
+	const QString fname = QDir("meta").absoluteFilePath(localFilename());
+	if (!QFile::exists(fname))
+	{
+		return false;
+	}
+	// TODO: check if the file has the expected checksum
+	try
+	{
+		parse(Json::requireObject(Json::requireDocument(fname, fname), fname));
+		return true;
+	}
+	catch (Exception &e)
+	{
+		qDebug() << QString("Unable to parse file %1: %2").arg(fname, e.cause());
+		// just make sure it's gone and we never consider it again.
+		QFile::remove(fname);
+		return false;
+	}
 }
 
-void BaseEntity::notifyRemoteLoadComplete()
+void Meta::BaseEntity::load()
 {
-	m_remoteLoaded = true;
-}
+	if(!isLoaded())
+	{
+		loadLocalFile();
+	}
+	if(!shouldStartRemoteUpdate())
+	{
+		return;
+	}
+	NetJob *job = new NetJob(QObject::tr("Download of meta file %1").arg(localFilename()));
+
+	auto url = this->url();
+	auto entry = ENV.metacache()->resolveEntry("meta", localFilename());
+	entry->setStale(true);
+	auto dl = Net::Download::makeCached(url, entry);
+	/*
+	 * The validator parses the file and loads it into the object.
+	 * If that fails, the file is not written to storage.
+	 */
+	dl->addValidator(new ParsingValidator(this));
+	job->addNetAction(dl);
+	m_updateStatus = UpdateStatus::InProgress;
+	m_updateTask.reset(job);
+	QObject::connect(job, &NetJob::succeeded, [&]()
+	{
+		m_loadStatus = LoadStatus::Remote;
+		m_updateStatus = UpdateStatus::Succeeded;
+		m_updateTask.reset();
+	});
+	QObject::connect(job, &NetJob::failed, [&]()
+	{
+		m_updateStatus = UpdateStatus::Failed;
+		m_updateTask.reset();
+	});
+	m_updateTask->start();
 }
+
+#include "BaseEntity.moc"
diff --git a/api/logic/meta/BaseEntity.h b/api/logic/meta/BaseEntity.h
index 7064e9d2..92a39272 100644
--- a/api/logic/meta/BaseEntity.h
+++ b/api/logic/meta/BaseEntity.h
@@ -15,9 +15,9 @@
 
 #pragma once
 
-#include <QObject>
-#include <memory>
 #include <QJsonObject>
+#include <QObject>
+#include "QObjectPtr.h"
 
 #include "multimc_logic_export.h"
 
@@ -26,29 +26,48 @@ namespace Meta
 {
 class MULTIMC_LOGIC_EXPORT BaseEntity
 {
+public: /* types */
+	using Ptr = std::shared_ptr<BaseEntity>;
+	enum class LoadStatus
+	{
+		NotLoaded,
+		Local,
+		Remote
+	};
+	enum class UpdateStatus
+	{
+		NotDone,
+		InProgress,
+		Failed,
+		Succeeded
+	};
+
 public:
 	virtual ~BaseEntity();
 
-	using Ptr = std::shared_ptr<BaseEntity>;
-
-	virtual std::unique_ptr<Task> remoteUpdateTask() = 0;
-	virtual std::unique_ptr<Task> localUpdateTask() = 0;
 	virtual void merge(const std::shared_ptr<BaseEntity> &other) = 0;
 	virtual void parse(const QJsonObject &obj) = 0;
 
 	virtual QString localFilename() const = 0;
 	virtual QUrl url() const;
 
-	bool isComplete() const { return m_localLoaded || m_remoteLoaded; }
+	bool isLoaded() const
+	{
+		return m_loadStatus > LoadStatus::NotLoaded;
+	}
+	bool shouldStartRemoteUpdate() const
+	{
+		return m_updateStatus == UpdateStatus::NotDone;
+	}
 
-	bool isLocalLoaded() const { return m_localLoaded; }
-	bool isRemoteLoaded() const { return m_remoteLoaded; }
+	void load();
 
-	void notifyLocalLoadComplete();
-	void notifyRemoteLoadComplete();
+protected: /* methods */
+	bool loadLocalFile();
 
 private:
-	bool m_localLoaded = false;
-	bool m_remoteLoaded = false;
+	LoadStatus m_loadStatus = LoadStatus::NotLoaded;
+	UpdateStatus m_updateStatus = UpdateStatus::NotDone;
+	shared_qobject_ptr<Task> m_updateTask;
 };
 }
diff --git a/api/logic/meta/Index.cpp b/api/logic/meta/Index.cpp
index e0e8bc5d..35b9fb6f 100644
--- a/api/logic/meta/Index.cpp
+++ b/api/logic/meta/Index.cpp
@@ -16,9 +16,7 @@
 #include "Index.h"
 
 #include "VersionList.h"
-#include "tasks/LocalLoadTask.h"
-#include "tasks/RemoteLoadTask.h"
-#include "format/Format.h"
+#include "JsonFormat.h"
 
 namespace Meta
 {
@@ -78,15 +76,6 @@ QVariant Index::headerData(int section, Qt::Orientation orientation, int role) c
 	}
 }
 
-std::unique_ptr<Task> Index::remoteUpdateTask()
-{
-	return std::unique_ptr<RemoteLoadTask>(new RemoteLoadTask(this));
-}
-std::unique_ptr<Task> Index::localUpdateTask()
-{
-	return std::unique_ptr<LocalLoadTask>(new LocalLoadTask(this));
-}
-
 bool Index::hasUid(const QString &uid) const
 {
 	return m_uids.contains(uid);
diff --git a/api/logic/meta/Index.h b/api/logic/meta/Index.h
index 37341656..544a8b96 100644
--- a/api/logic/meta/Index.h
+++ b/api/logic/meta/Index.h
@@ -48,19 +48,12 @@ public:
 	int columnCount(const QModelIndex &parent) const override;
 	QVariant headerData(int section, Qt::Orientation orientation, int role) const override;
 
-	std::unique_ptr<Task> remoteUpdateTask() override;
-	std::unique_ptr<Task> localUpdateTask() override;
-
 	QString localFilename() const override { return "index.json"; }
 
 	// queries
 	VersionListPtr get(const QString &uid);
 	VersionPtr get(const QString &uid, const QString &version);
 	bool hasUid(const QString &uid) const;
-	/*
-	VersionListPtr getList(const QString &uid) const;
-	VersionListPtr getListGuaranteed(const QString &uid) const;
-	*/
 
 	QVector<VersionListPtr> lists() const { return m_lists; }
 
diff --git a/api/logic/meta/Index_test.cpp b/api/logic/meta/Index_test.cpp
index b4dbd009..d4343c37 100644
--- a/api/logic/meta/Index_test.cpp
+++ b/api/logic/meta/Index_test.cpp
@@ -16,12 +16,6 @@ slots:
 		QCOMPARE(ENV.metadataIndex(), ENV.metadataIndex());
 	}
 
-	void test_providesTasks()
-	{
-		QVERIFY(ENV.metadataIndex()->localUpdateTask() != nullptr);
-		QVERIFY(ENV.metadataIndex()->remoteUpdateTask() != nullptr);
-	}
-
 	void test_hasUid_and_getList()
 	{
 		Meta::Index windex({std::make_shared<Meta::VersionList>("list1"), std::make_shared<Meta::VersionList>("list2"), std::make_shared<Meta::VersionList>("list3")});
diff --git a/api/logic/meta/format/Format.cpp b/api/logic/meta/JsonFormat.cpp
similarity index 95%
rename from api/logic/meta/format/Format.cpp
rename to api/logic/meta/JsonFormat.cpp
index 39d3f14f..4e43b715 100644
--- a/api/logic/meta/format/Format.cpp
+++ b/api/logic/meta/JsonFormat.cpp
@@ -13,15 +13,16 @@
  * limitations under the License.
  */
 
-#include "Format.h"
-
-#include "minecraft/onesix/OneSixVersionFormat.h""
-
-#include "meta/Index.h"
-#include "meta/Version.h"
-#include "meta/VersionList.h"
+#include "JsonFormat.h"
 
+// FIXME: remove this from here... somehow
+#include "minecraft/onesix/OneSixVersionFormat.h"
 #include "Json.h"
+
+#include "Index.h"
+#include "Version.h"
+#include "VersionList.h"
+
 using namespace Json;
 
 namespace Meta
diff --git a/api/logic/meta/format/Format.h b/api/logic/meta/JsonFormat.h
similarity index 100%
rename from api/logic/meta/format/Format.h
rename to api/logic/meta/JsonFormat.h
diff --git a/api/logic/meta/Util.cpp b/api/logic/meta/Util.cpp
deleted file mode 100644
index 76941f83..00000000
--- a/api/logic/meta/Util.cpp
+++ /dev/null
@@ -1,50 +0,0 @@
-/* Copyright 2015-2017 MultiMC Contributors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#include "Util.h"
-
-#include <QUrl>
-#include <QDir>
-
-#include "Env.h"
-
-namespace Meta
-{
-QUrl rootUrl()
-{
-	return QUrl("https://meta.multimc.org");
-}
-
-QUrl indexUrl()
-{
-	return rootUrl().resolved(QStringLiteral("index.json"));
-}
-
-QUrl versionListUrl(const QString &uid)
-{
-	return rootUrl().resolved(uid + "/index.json");
-}
-
-QUrl versionUrl(const QString &uid, const QString &version)
-{
-	return rootUrl().resolved(uid + "/" + version + ".json");
-}
-
-QDir localDir()
-{
-	return QDir("meta");
-}
-
-}
diff --git a/api/logic/meta/Util.h b/api/logic/meta/Util.h
deleted file mode 100644
index 188bcaa3..00000000
--- a/api/logic/meta/Util.h
+++ /dev/null
@@ -1,28 +0,0 @@
-/* Copyright 2015-2017 MultiMC Contributors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#pragma once
-
-#include "multimc_logic_export.h"
-
-class QUrl;
-class QString;
-class QDir;
-
-namespace Meta
-{
-MULTIMC_LOGIC_EXPORT QUrl rootUrl();
-MULTIMC_LOGIC_EXPORT QDir localDir();
-}
diff --git a/api/logic/meta/Version.cpp b/api/logic/meta/Version.cpp
index b79c178a..f8c865e7 100644
--- a/api/logic/meta/Version.cpp
+++ b/api/logic/meta/Version.cpp
@@ -17,9 +17,7 @@
 
 #include <QDateTime>
 
-#include "tasks/LocalLoadTask.h"
-#include "tasks/RemoteLoadTask.h"
-#include "format/Format.h"
+#include "JsonFormat.h"
 
 namespace Meta
 {
@@ -46,15 +44,6 @@ QDateTime Version::time() const
 	return QDateTime::fromMSecsSinceEpoch(m_time * 1000, Qt::UTC);
 }
 
-std::unique_ptr<Task> Version::remoteUpdateTask()
-{
-	return std::unique_ptr<RemoteLoadTask>(new RemoteLoadTask(this));
-}
-std::unique_ptr<Task> Version::localUpdateTask()
-{
-	return std::unique_ptr<LocalLoadTask>(new LocalLoadTask(this));
-}
-
 void Version::parse(const QJsonObject& obj)
 {
 	parseVersion(obj, this);
diff --git a/api/logic/meta/Version.h b/api/logic/meta/Version.h
index 635b79f6..0be2d94a 100644
--- a/api/logic/meta/Version.h
+++ b/api/logic/meta/Version.h
@@ -56,8 +56,6 @@ public:
 	QVector<Reference> requires() const { return m_requires; }
 	VersionFilePtr data() const { return m_data; }
 
-	std::unique_ptr<Task> remoteUpdateTask() override;
-	std::unique_ptr<Task> localUpdateTask() override;
 	void merge(const std::shared_ptr<BaseEntity> &other) override;
 	void parse(const QJsonObject &obj) override;
 
diff --git a/api/logic/meta/VersionList.cpp b/api/logic/meta/VersionList.cpp
index 7196d4be..a12f5418 100644
--- a/api/logic/meta/VersionList.cpp
+++ b/api/logic/meta/VersionList.cpp
@@ -18,64 +18,11 @@
 #include <QDateTime>
 
 #include "Version.h"
-#include "tasks/RemoteLoadTask.h"
-#include "tasks/LocalLoadTask.h"
-#include "format/Format.h"
+#include "JsonFormat.h"
 #include "Reference.h"
 
 namespace Meta
 {
-
-class WVLLoadTask : public Task
-{
-	Q_OBJECT
-public:
-	explicit WVLLoadTask(VersionList *list, QObject *parent = nullptr)
-		: Task(parent), m_list(list)
-	{
-	}
-
-	bool canAbort() const override
-	{
-		return !m_currentTask || m_currentTask->canAbort();
-	}
-	bool abort() override
-	{
-		return m_currentTask->abort();
-	}
-
-private:
-	void executeTask() override
-	{
-		if (!m_list->isLocalLoaded())
-		{
-			m_currentTask = m_list->localUpdateTask();
-			connect(m_currentTask.get(), &Task::succeeded, this, &WVLLoadTask::next);
-		}
-		else
-		{
-			m_currentTask = m_list->remoteUpdateTask();
-			connect(m_currentTask.get(), &Task::succeeded, this, &WVLLoadTask::emitSucceeded);
-		}
-		connect(m_currentTask.get(), &Task::status, this, &WVLLoadTask::setStatus);
-		connect(m_currentTask.get(), &Task::progress, this, &WVLLoadTask::setProgress);
-		connect(m_currentTask.get(), &Task::failed, this, &WVLLoadTask::emitFailed);
-		m_currentTask->start();
-	}
-
-	void next()
-	{
-		m_currentTask = m_list->remoteUpdateTask();
-		connect(m_currentTask.get(), &Task::status, this, &WVLLoadTask::setStatus);
-		connect(m_currentTask.get(), &Task::progress, this, &WVLLoadTask::setProgress);
-		connect(m_currentTask.get(), &Task::succeeded, this, &WVLLoadTask::emitSucceeded);
-		m_currentTask->start();
-	}
-
-	VersionList *m_list;
-	std::unique_ptr<Task> m_currentTask;
-};
-
 VersionList::VersionList(const QString &uid, QObject *parent)
 	: BaseVersionList(parent), m_uid(uid)
 {
@@ -84,12 +31,13 @@ VersionList::VersionList(const QString &uid, QObject *parent)
 
 Task *VersionList::getLoadTask()
 {
-	return new WVLLoadTask(this);
+	// TODO: create a wrapper task that will chain from root to here.
+	return nullptr;
 }
 
 bool VersionList::isLoaded()
 {
-	return isLocalLoaded() && isRemoteLoaded();
+	return isLoaded();
 }
 
 const BaseVersionPtr VersionList::at(int i) const
@@ -167,15 +115,6 @@ QHash<int, QByteArray> VersionList::roleNames() const
 	return roles;
 }
 
-std::unique_ptr<Task> VersionList::remoteUpdateTask()
-{
-	return std::unique_ptr<RemoteLoadTask>(new RemoteLoadTask(this));
-}
-std::unique_ptr<Task> VersionList::localUpdateTask()
-{
-	return std::unique_ptr<LocalLoadTask>(new LocalLoadTask(this));
-}
-
 QString VersionList::localFilename() const
 {
 	return m_uid + "/index.json";
@@ -200,6 +139,7 @@ void VersionList::setName(const QString &name)
 	m_name = name;
 	emit nameChanged(name);
 }
+
 void VersionList::setVersions(const QVector<VersionPtr> &versions)
 {
 	beginResetModel();
diff --git a/api/logic/meta/VersionList.h b/api/logic/meta/VersionList.h
index 934b20e4..e958475e 100644
--- a/api/logic/meta/VersionList.h
+++ b/api/logic/meta/VersionList.h
@@ -54,9 +54,6 @@ public:
 	RoleList providesRoles() const override;
 	QHash<int, QByteArray> roleNames() const override;
 
-	std::unique_ptr<Task> remoteUpdateTask() override;
-	std::unique_ptr<Task> localUpdateTask() override;
-
 	QString localFilename() const override;
 
 	QString uid() const { return m_uid; }
diff --git a/api/logic/meta/tasks/LocalLoadTask.cpp b/api/logic/meta/tasks/LocalLoadTask.cpp
deleted file mode 100644
index b64fc5d3..00000000
--- a/api/logic/meta/tasks/LocalLoadTask.cpp
+++ /dev/null
@@ -1,57 +0,0 @@
-/* Copyright 2015-2017 MultiMC Contributors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#include "LocalLoadTask.h"
-
-#include <QFile>
-
-#include "meta/format/Format.h"
-#include "meta/Util.h"
-#include "meta/Index.h"
-#include "meta/Version.h"
-#include "meta/VersionList.h"
-#include "Env.h"
-#include "Json.h"
-
-namespace Meta
-{
-LocalLoadTask::LocalLoadTask(BaseEntity *entity, QObject *parent)
-	: Task(parent), m_entity(entity)
-{
-}
-
-void LocalLoadTask::executeTask()
-{
-	const QString fname = Meta::localDir().absoluteFilePath(m_entity->localFilename());
-	if (!QFile::exists(fname))
-	{
-		emitFailed(tr("File doesn't exist"));
-		return;
-	}
-	setStatus(tr("Reading %1...").arg(fname));
-	setProgress(0, 0);
-
-	try
-	{
-		m_entity->parse(Json::requireObject(Json::requireDocument(fname, fname), fname));
-		m_entity->notifyLocalLoadComplete();
-		emitSucceeded();
-	}
-	catch (Exception &e)
-	{
-		emitFailed(tr("Unable to parse file %1: %2").arg(fname, e.cause()));
-	}
-}
-}
diff --git a/api/logic/meta/tasks/LocalLoadTask.h b/api/logic/meta/tasks/LocalLoadTask.h
deleted file mode 100644
index 905660ed..00000000
--- a/api/logic/meta/tasks/LocalLoadTask.h
+++ /dev/null
@@ -1,39 +0,0 @@
-/* Copyright 2015-2017 MultiMC Contributors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#pragma once
-
-#include "tasks/Task.h"
-#include <memory>
-
-namespace Meta
-{
-class BaseEntity;
-class Index;
-class VersionList;
-class Version;
-
-// FIXME: this is now just an odd function, get rid of it
-class LocalLoadTask : public Task
-{
-	Q_OBJECT
-public:
-	explicit LocalLoadTask(BaseEntity *entity, QObject *parent = nullptr);
-
-private:
-	void executeTask() override;
-	BaseEntity *m_entity;
-};
-}
diff --git a/api/logic/meta/tasks/RemoteLoadTask.cpp b/api/logic/meta/tasks/RemoteLoadTask.cpp
deleted file mode 100644
index b73af021..00000000
--- a/api/logic/meta/tasks/RemoteLoadTask.cpp
+++ /dev/null
@@ -1,103 +0,0 @@
-/* Copyright 2015-2017 MultiMC Contributors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#include "RemoteLoadTask.h"
-
-#include "net/Download.h"
-#include "net/HttpMetaCache.h"
-#include "net/NetJob.h"
-#include "meta/format/Format.h"
-#include "meta/Util.h"
-#include "meta/Index.h"
-#include "meta/Version.h"
-#include "meta/VersionList.h"
-#include "Env.h"
-#include "Json.h"
-
-namespace Meta
-{
-
-RemoteLoadTask::RemoteLoadTask(BaseEntity *entity, QObject *parent)
-	: Task(parent), m_entity(entity)
-{
-}
-
-class ParsingValidator : public Net::Validator
-{
-public: /* con/des */
-	ParsingValidator(BaseEntity *entity) : m_entity(entity)
-	{
-	};
-	virtual ~ParsingValidator()
-	{
-	};
-
-public: /* methods */
-	bool init(QNetworkRequest &) override
-	{
-		return true;
-	}
-	bool write(QByteArray & data) override
-	{
-		this->data.append(data);
-		return true;
-	}
-	bool abort() override
-	{
-		return true;
-	}
-	bool validate(QNetworkReply &) override
-	{
-		auto fname = m_entity->localFilename();
-		try
-		{
-			m_entity->parse(Json::requireObject(Json::requireDocument(data, fname), fname));
-			m_entity->notifyRemoteLoadComplete();
-			return true;
-		}
-		catch (Exception &e)
-		{
-			qWarning() << "Unable to parse response:" << e.cause();
-			return false;
-		}
-	}
-
-private: /* data */
-	QByteArray data;
-	BaseEntity *m_entity;
-};
-
-void RemoteLoadTask::executeTask()
-{
-	// FIXME: leak here!!!
-	NetJob *job = new NetJob(tr("Download of meta file %1").arg(m_entity->localFilename()));
-
-	auto url = m_entity->url();
-	auto entry = ENV.metacache()->resolveEntry("meta", m_entity->localFilename());
-	entry->setStale(true);
-	m_dl = Net::Download::makeCached(url, entry);
-	/*
-	 * The validator parses the file and loads it into the object.
-	 * If that fails, the file is not written to storage.
-	 */
-	m_dl->addValidator(new ParsingValidator(m_entity));
-	job->addNetAction(m_dl);
-	connect(job, &NetJob::failed, this, &RemoteLoadTask::emitFailed);
-	connect(job, &NetJob::succeeded, this, &RemoteLoadTask::succeeded);
-	connect(job, &NetJob::status, this, &RemoteLoadTask::setStatus);
-	connect(job, &NetJob::progress, this, &RemoteLoadTask::setProgress);
-	job->start();
-}
-}
diff --git a/api/logic/meta/tasks/RemoteLoadTask.h b/api/logic/meta/tasks/RemoteLoadTask.h
deleted file mode 100644
index 6d81d8ea..00000000
--- a/api/logic/meta/tasks/RemoteLoadTask.h
+++ /dev/null
@@ -1,46 +0,0 @@
-/* Copyright 2015-2017 MultiMC Contributors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#pragma once
-
-#include "tasks/Task.h"
-#include <memory>
-
-namespace Net
-{
-class Download;
-}
-
-namespace Meta
-{
-class BaseEntity;
-class Index;
-class VersionList;
-class Version;
-
-// FIXME: this is now just an oddly constructed NetJob, get rid of it.
-class RemoteLoadTask : public Task
-{
-	Q_OBJECT
-public:
-	explicit RemoteLoadTask(BaseEntity *entity, QObject *parent = nullptr);
-
-private:
-	void executeTask() override;
-
-	BaseEntity *m_entity;
-	std::shared_ptr<Net::Download> m_dl;
-};
-}
diff --git a/application/MainWindow.cpp b/application/MainWindow.cpp
index 9073c006..e0870d06 100644
--- a/application/MainWindow.cpp
+++ b/application/MainWindow.cpp
@@ -554,21 +554,8 @@ MainWindow::MainWindow(QWidget *parent) : QMainWindow(parent), ui(new MainWindow
 		job->start();
 	}
 
-	// run the things that load and download other things... FIXME: this is NOT the place
-	// FIXME: invisible actions in the background = NOPE.
+	// load the news
 	{
-		/*
-		if (!MMC->minecraftlist()->isLoaded())
-		{
-			m_versionLoadTask = MMC->minecraftlist()->getLoadTask();
-			startTask(m_versionLoadTask);
-		}
-		if (!MMC->lwjgllist()->isLoaded())
-		{
-			MMC->lwjgllist()->loadList();
-		}
-		*/
-
 		m_newsChecker->reloadNews();
 		updateNewsLabel();
 	}
diff --git a/application/pages/global/PackagesPage.cpp b/application/pages/global/PackagesPage.cpp
index 81ad4da1..e4967532 100644
--- a/application/pages/global/PackagesPage.cpp
+++ b/application/pages/global/PackagesPage.cpp
@@ -97,7 +97,7 @@ QIcon PackagesPage::icon() const
 
 void PackagesPage::on_refreshIndexBtn_clicked()
 {
-	ProgressDialog(this).execWithTask(ENV.metadataIndex()->remoteUpdateTask());
+	ENV.metadataIndex()->load();
 }
 void PackagesPage::on_refreshFileBtn_clicked()
 {
@@ -106,7 +106,7 @@ void PackagesPage::on_refreshFileBtn_clicked()
 	{
 		return;
 	}
-	ProgressDialog(this).execWithTask(list->remoteUpdateTask());
+	list->load();
 }
 void PackagesPage::on_refreshVersionBtn_clicked()
 {
@@ -115,7 +115,7 @@ void PackagesPage::on_refreshVersionBtn_clicked()
 	{
 		return;
 	}
-	ProgressDialog(this).execWithTask(version->remoteUpdateTask());
+	version->load();
 }
 
 void PackagesPage::on_fileSearchEdit_textChanged(const QString &search)
@@ -158,19 +158,7 @@ void PackagesPage::updateCurrentVersionList(const QModelIndex &index)
 		ui->fileName->setText(list->name());
 		m_versionProxy->setSourceModel(list.get());
 		ui->refreshFileBtn->setText(tr("Refresh %1").arg(list->humanReadable()));
-
-		if (!list->isLocalLoaded())
-		{
-			std::unique_ptr<Task> task = list->localUpdateTask();
-			connect(task.get(), &Task::finished, this, [this, list]()
-			{
-				if (list->count() == 0 && !list->isRemoteLoaded())
-				{
-					ProgressDialog(this).execWithTask(list->remoteUpdateTask());
-				}
-			});
-			ProgressDialog(this).execWithTask(task);
-		}
+		list->load();
 	}
 	else
 	{
@@ -227,16 +215,5 @@ void PackagesPage::updateVersion()
 
 void PackagesPage::opened()
 {
-	if (!ENV.metadataIndex()->isLocalLoaded())
-	{
-		std::unique_ptr<Task> task = ENV.metadataIndex()->localUpdateTask();
-		connect(task.get(), &Task::finished, this, [this]()
-		{
-			if (!ENV.metadataIndex()->isRemoteLoaded())
-			{
-				ProgressDialog(this).execWithTask(ENV.metadataIndex()->remoteUpdateTask());
-			}
-		});
-		ProgressDialog(this).execWithTask(task);
-	}
+	ENV.metadataIndex()->load();
 }

From 2660418d58efb33cd3a0ab8ed9d48c359c076905 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= <peterix@gmail.com>
Date: Sun, 19 Mar 2017 02:13:49 +0100
Subject: [PATCH 11/28] NOISSUE hack it together enough to get launching back

Meta index will now always return valid objects.
They just might never load if they don't exist on the server.
---
 api/logic/meta/BaseEntity.cpp                 |  9 ++
 api/logic/meta/BaseEntity.h                   |  1 +
 api/logic/meta/Index.cpp                      | 14 ++--
 api/logic/meta/Index.h                        |  1 +
 api/logic/meta/Version.cpp                    | 35 ++++----
 api/logic/meta/Version.h                      | 84 ++++++++++++++++++-
 api/logic/meta/VersionList.cpp                | 14 ++--
 api/logic/meta/VersionList.h                  |  3 +-
 api/logic/minecraft/ProfilePatch.h            |  4 -
 .../onesix/OneSixProfileStrategy.cpp          |  6 +-
 api/logic/minecraft/onesix/OneSixUpdate.cpp   | 48 ++++++-----
 application/pages/VersionPage.cpp             |  1 +
 12 files changed, 162 insertions(+), 58 deletions(-)

diff --git a/api/logic/meta/BaseEntity.cpp b/api/logic/meta/BaseEntity.cpp
index 18b7f92f..809f88cb 100644
--- a/api/logic/meta/BaseEntity.cpp
+++ b/api/logic/meta/BaseEntity.cpp
@@ -137,4 +137,13 @@ void Meta::BaseEntity::load()
 	m_updateTask->start();
 }
 
+shared_qobject_ptr<Task> Meta::BaseEntity::getCurrentTask()
+{
+	if(m_updateStatus == UpdateStatus::InProgress)
+	{
+		return m_updateTask;
+	}
+	return nullptr;
+}
+
 #include "BaseEntity.moc"
diff --git a/api/logic/meta/BaseEntity.h b/api/logic/meta/BaseEntity.h
index 92a39272..85051d97 100644
--- a/api/logic/meta/BaseEntity.h
+++ b/api/logic/meta/BaseEntity.h
@@ -61,6 +61,7 @@ public:
 	}
 
 	void load();
+	shared_qobject_ptr<Task> getCurrentTask();
 
 protected: /* methods */
 	bool loadLocalFile();
diff --git a/api/logic/meta/Index.cpp b/api/logic/meta/Index.cpp
index 35b9fb6f..0749651a 100644
--- a/api/logic/meta/Index.cpp
+++ b/api/logic/meta/Index.cpp
@@ -83,17 +83,19 @@ bool Index::hasUid(const QString &uid) const
 
 VersionListPtr Index::get(const QString &uid)
 {
-	return m_uids.value(uid, nullptr);
+	VersionListPtr out = m_uids.value(uid, nullptr);
+	if(!out)
+	{
+		out = std::make_shared<VersionList>(uid);
+		m_uids[uid] = out;
+	}
+	return out;
 }
 
 VersionPtr Index::get(const QString &uid, const QString &version)
 {
 	auto list = get(uid);
-	if(list)
-	{
-		return list->getVersion(version);
-	}
-	return nullptr;
+	return list->getVersion(version);
 }
 
 void Index::parse(const QJsonObject& obj)
diff --git a/api/logic/meta/Index.h b/api/logic/meta/Index.h
index 544a8b96..9811e152 100644
--- a/api/logic/meta/Index.h
+++ b/api/logic/meta/Index.h
@@ -68,3 +68,4 @@ private:
 	void connectVersionList(const int row, const VersionListPtr &list);
 };
 }
+
diff --git a/api/logic/meta/Version.cpp b/api/logic/meta/Version.cpp
index f8c865e7..2790b2f3 100644
--- a/api/logic/meta/Version.cpp
+++ b/api/logic/meta/Version.cpp
@@ -18,38 +18,45 @@
 #include <QDateTime>
 
 #include "JsonFormat.h"
+#include "minecraft/MinecraftProfile.h"
 
-namespace Meta
+void Meta::Version::applyTo(MinecraftProfile* profile)
 {
-Version::Version(const QString &uid, const QString &version)
+	if(m_data)
+	{
+		m_data->applyTo(profile);
+	}
+}
+
+Meta::Version::Version(const QString &uid, const QString &version)
 	: BaseVersion(), m_uid(uid), m_version(version)
 {
 }
 
-QString Version::descriptor()
+QString Meta::Version::descriptor()
 {
 	return m_version;
 }
-QString Version::name()
+QString Meta::Version::name()
 {
 	return m_version;
 }
-QString Version::typeString() const
+QString Meta::Version::typeString() const
 {
 	return m_type;
 }
 
-QDateTime Version::time() const
+QDateTime Meta::Version::time() const
 {
 	return QDateTime::fromMSecsSinceEpoch(m_time * 1000, Qt::UTC);
 }
 
-void Version::parse(const QJsonObject& obj)
+void Meta::Version::parse(const QJsonObject& obj)
 {
 	parseVersion(obj, this);
 }
 
-void Version::merge(const std::shared_ptr<BaseEntity> &other)
+void Meta::Version::merge(const std::shared_ptr<BaseEntity> &other)
 {
 	VersionPtr version = std::dynamic_pointer_cast<Version>(other);
 	if (m_type != version->m_type)
@@ -68,28 +75,28 @@ void Version::merge(const std::shared_ptr<BaseEntity> &other)
 	setData(version->m_data);
 }
 
-QString Version::localFilename() const
+QString Meta::Version::localFilename() const
 {
 	return m_uid + '/' + m_version + ".json";
 }
 
-void Version::setType(const QString &type)
+void Meta::Version::setType(const QString &type)
 {
 	m_type = type;
 	emit typeChanged();
 }
-void Version::setTime(const qint64 time)
+void Meta::Version::setTime(const qint64 time)
 {
 	m_time = time;
 	emit timeChanged();
 }
-void Version::setRequires(const QVector<Reference> &requires)
+void Meta::Version::setRequires(const QVector<Reference> &requires)
 {
 	m_requires = requires;
 	emit requiresChanged();
 }
-void Version::setData(const VersionFilePtr &data)
+void Meta::Version::setData(const VersionFilePtr &data)
 {
 	m_data = data;
 }
-}
+
diff --git a/api/logic/meta/Version.h b/api/logic/meta/Version.h
index 0be2d94a..b8ea7e44 100644
--- a/api/logic/meta/Version.h
+++ b/api/logic/meta/Version.h
@@ -33,7 +33,7 @@ namespace Meta
 {
 using VersionPtr = std::shared_ptr<class Version>;
 
-class MULTIMC_LOGIC_EXPORT Version : public QObject, public BaseVersion, public BaseEntity
+class MULTIMC_LOGIC_EXPORT Version : public QObject, public BaseVersion, public BaseEntity, public ProfilePatch
 {
 	Q_OBJECT
 	Q_PROPERTY(QString uid READ uid CONSTANT)
@@ -41,9 +41,89 @@ class MULTIMC_LOGIC_EXPORT Version : public QObject, public BaseVersion, public
 	Q_PROPERTY(QString type READ type NOTIFY typeChanged)
 	Q_PROPERTY(QDateTime time READ time NOTIFY timeChanged)
 	Q_PROPERTY(QVector<Reference> requires READ requires NOTIFY requiresChanged)
-public:
+
+public: /* con/des */
 	explicit Version(const QString &uid, const QString &version);
 
+// FIXME: none of this belongs here...
+public: /* ProfilePatch overrides */
+	QString getFilename() override
+	{
+		return QString();
+	}
+	QString getID() override
+	{
+		return m_uid;
+	}
+	QList<JarmodPtr> getJarMods() override
+	{
+		return {};
+	}
+	QString getName() override
+	{
+		return name();
+	}
+	QDateTime getReleaseDateTime() override
+	{
+		return time();
+	}
+	QString getVersion() override
+	{
+		return m_version;
+	}
+	std::shared_ptr<class VersionFile> getVersionFile() override
+	{
+		return m_data;
+	}
+	int getOrder() override
+	{
+		return 0;
+	}
+	VersionSource getVersionSource() override
+	{
+		return VersionSource::Local;
+	}
+	bool isVersionChangeable() override
+	{
+		return true;
+	}
+	bool isRevertible() override
+	{
+		return false;
+	}
+	bool isRemovable() override
+	{
+		return true;
+	}
+	bool isCustom() override
+	{
+		return false;
+	}
+	bool isCustomizable() override
+	{
+		return true;
+	}
+	bool isMoveable() override
+	{
+		return true;
+	}
+	bool isEditable() override
+	{
+		return false;
+	}
+	void setOrder(int) override
+	{
+	}
+	bool hasJarMods() override
+	{
+		return false;
+	}
+	bool isMinecraftVersion() override
+	{
+		return m_uid == "net.minecraft";
+	}
+	void applyTo(MinecraftProfile * profile) override;
+
 	QString descriptor() override;
 	QString name() override;
 	QString typeString() const override;
diff --git a/api/logic/meta/VersionList.cpp b/api/logic/meta/VersionList.cpp
index a12f5418..d6bbf70f 100644
--- a/api/logic/meta/VersionList.cpp
+++ b/api/logic/meta/VersionList.cpp
@@ -125,13 +125,15 @@ QString VersionList::humanReadable() const
 	return m_name.isEmpty() ? m_uid : m_name;
 }
 
-bool VersionList::hasVersion(const QString &version) const
+VersionPtr VersionList::getVersion(const QString &version)
 {
-	return m_lookup.contains(version);
-}
-VersionPtr VersionList::getVersion(const QString &version) const
-{
-	return m_lookup.value(version);
+	VersionPtr out = m_lookup.value(version, nullptr);
+	if(!out)
+	{
+		out = std::make_shared<Version>(m_uid, version);
+		m_lookup[version] = out;
+	}
+	return out;
 }
 
 void VersionList::setName(const QString &name)
diff --git a/api/logic/meta/VersionList.h b/api/logic/meta/VersionList.h
index e958475e..26fa6c5a 100644
--- a/api/logic/meta/VersionList.h
+++ b/api/logic/meta/VersionList.h
@@ -60,8 +60,7 @@ public:
 	QString name() const { return m_name; }
 	QString humanReadable() const;
 
-	bool hasVersion(const QString &version) const;
-	VersionPtr getVersion(const QString &version) const;
+	VersionPtr getVersion(const QString &version);
 
 	QVector<VersionPtr> versions() const { return m_versions; }
 
diff --git a/api/logic/minecraft/ProfilePatch.h b/api/logic/minecraft/ProfilePatch.h
index 26230092..b61fb8b3 100644
--- a/api/logic/minecraft/ProfilePatch.h
+++ b/api/logic/minecraft/ProfilePatch.h
@@ -92,10 +92,6 @@ public:
 	{
 		return m_problemSeverity;
 	}
-	virtual bool hasFailed()
-	{
-		return getProblemSeverity() == PROBLEM_ERROR;
-	}
 
 protected:
 	QList<PatchProblem> m_problems;
diff --git a/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp b/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
index e3d3f674..b19a2dea 100644
--- a/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
+++ b/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
@@ -12,6 +12,8 @@
 #include <QJsonArray>
 #include <QSaveFile>
 #include <QResource>
+#include <meta/Index.h>
+#include <meta/Version.h>
 
 OneSixProfileStrategy::OneSixProfileStrategy(OneSixInstance* instance)
 {
@@ -98,7 +100,7 @@ void OneSixProfileStrategy::loadDefaultBuiltinPatches()
 		}
 		else
 		{
-			auto mcversion = ENV.getVersion("net.minecraft", m_instance->intendedVersionId());
+			auto mcversion = ENV.metadataIndex()->get("net.minecraft", m_instance->intendedVersionId());
 			minecraftPatch = std::dynamic_pointer_cast<ProfilePatch>(mcversion);
 		}
 		if (!minecraftPatch)
@@ -121,7 +123,7 @@ void OneSixProfileStrategy::loadDefaultBuiltinPatches()
 		}
 		else
 		{
-			auto lwjglversion = ENV.getVersion("org.lwjgl", "2.9.1" /*m_instance->intendedVersionId()*/);
+			auto lwjglversion = ENV.metadataIndex()->get("org.lwjgl", "2.9.1");
 			lwjglPatch = std::dynamic_pointer_cast<ProfilePatch>(lwjglversion);
 		}
 		if (!lwjglPatch)
diff --git a/api/logic/minecraft/onesix/OneSixUpdate.cpp b/api/logic/minecraft/onesix/OneSixUpdate.cpp
index ec40e086..5bc76b01 100644
--- a/api/logic/minecraft/onesix/OneSixUpdate.cpp
+++ b/api/logic/minecraft/onesix/OneSixUpdate.cpp
@@ -34,6 +34,9 @@
 #include "update/FMLLibrariesTask.h"
 #include "update/AssetUpdateTask.h"
 
+#include <meta/Index.h>
+#include <meta/Version.h>
+
 OneSixUpdate::OneSixUpdate(OneSixInstance *inst, QObject *parent) : Task(parent), m_inst(inst)
 {
 	// create folders
@@ -44,30 +47,22 @@ OneSixUpdate::OneSixUpdate(OneSixInstance *inst, QObject *parent) : Task(parent)
 	// add a version update task, if necessary
 	{
 		/*
-		auto list = std::dynamic_pointer_cast<MinecraftVersionList>(ENV.getVersionList("net.minecraft"));
-		auto version = std::dynamic_pointer_cast<MinecraftVersion>(list->findVersion(m_inst->intendedVersionId()));
-		if (version == nullptr)
+		 * FIXME: there are some corner cases here that remain unhandled:
+		 * what if local load succeeds but remote fails? The version is still usable...
+		 */
+		// FIXME: derive this from the actual list of version patches...
+		auto loadVersion = [&](const QString & uid, const QString & version)
 		{
-			// don't do anything if it was invalid
-			m_preFailure = tr("The specified Minecraft version is invalid. Choose a different one.");
-		}
-		else if (m_inst->providesVersionFile() || !version->needsUpdate())
-		{
-			qDebug() << "Instance either provides a version file or doesn't need an update.";
-		}
-		else
-		{
-			auto versionUpdateTask = list->createUpdateTask(m_inst->intendedVersionId());
-			if (!versionUpdateTask)
+			auto obj = ENV.metadataIndex()->get(uid, version);
+			obj->load();
+			auto task = obj->getCurrentTask();
+			if(task)
 			{
-				qDebug() << "Didn't spawn an update task.";
+				m_tasks.append(task.unwrap());
 			}
-			else
-			{
-				m_tasks.append(versionUpdateTask);
-			}
-		}
-		*/
+		};
+		loadVersion("org.lwjgl", "2.9.1");
+		loadVersion("net.minecraft", m_inst->intendedVersionId());
 	}
 
 	// libraries download
@@ -118,11 +113,20 @@ void OneSixUpdate::next()
 		return;
 	}
 	auto task = m_tasks[m_currentTask];
+	// if the task is already finished by the time we look at it, skip it
+	if(task->isFinished())
+	{
+		next();
+	}
 	connect(task.get(), &Task::succeeded, this, &OneSixUpdate::subtaskSucceeded);
 	connect(task.get(), &Task::failed, this, &OneSixUpdate::subtaskFailed);
 	connect(task.get(), &Task::progress, this, &OneSixUpdate::progress);
 	connect(task.get(), &Task::status, this, &OneSixUpdate::setStatus);
-	task->start();
+	// if the task is already running, do not start it again
+	if(!task->isRunning())
+	{
+		task->start();
+	}
 }
 
 void OneSixUpdate::subtaskSucceeded()
diff --git a/application/pages/VersionPage.cpp b/application/pages/VersionPage.cpp
index 42eb31de..78e2a888 100644
--- a/application/pages/VersionPage.cpp
+++ b/application/pages/VersionPage.cpp
@@ -320,6 +320,7 @@ void VersionPage::on_moveDownBtn_clicked()
 
 void VersionPage::on_changeVersionBtn_clicked()
 {
+	// FIXME: this is hilariously broken because it assumes m_inst->versionList() is a sensible thing...
 	VersionSelectDialog vselect(m_inst->versionList().get(), tr("Change Minecraft version"),
 								this);
 	if (!vselect.exec() || !vselect.selectedVersion())

From f557c1367994a61935fa0e8d0b1b67688d2692d0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= <peterix@gmail.com>
Date: Sun, 19 Mar 2017 23:58:54 +0100
Subject: [PATCH 12/28] NOISSUE stuff and things happened. Maybe.

---
 api/logic/BaseVersionList.h                   |  13 +-
 api/logic/java/JavaInstallList.cpp            |   2 +-
 api/logic/java/JavaInstallList.h              |  18 +--
 api/logic/meta/BaseEntity.cpp                 |   8 +-
 api/logic/meta/Index_test.cpp                 |   2 +-
 api/logic/meta/Version.cpp                    |  12 +-
 api/logic/meta/Version.h                      |  82 +----------
 api/logic/meta/VersionList.cpp                |   8 +-
 api/logic/meta/VersionList.h                  |   2 +-
 api/logic/minecraft/MinecraftInstance.cpp     |   4 +-
 api/logic/minecraft/MojangVersionFormat.cpp   |   2 +-
 api/logic/minecraft/ProfilePatch.h            |   2 -
 api/logic/minecraft/ProfileUtils.cpp          |   2 +-
 api/logic/minecraft/VersionFile.cpp           |   9 +-
 api/logic/minecraft/VersionFile.h             |  17 +--
 .../minecraft/ftb/FTBProfileStrategy.cpp      |   4 +-
 .../minecraft/legacy/LwjglVersionList.cpp     |   5 +-
 api/logic/minecraft/legacy/LwjglVersionList.h |   4 +-
 .../onesix/OneSixProfileStrategy.cpp          | 130 ++++++++++++++++--
 .../minecraft/onesix/OneSixVersionFormat.cpp  |  20 ++-
 application/pages/VersionPage.cpp             |  25 +---
 application/widgets/VersionSelectWidget.cpp   |  46 +++----
 application/widgets/VersionSelectWidget.h     |   5 +-
 23 files changed, 210 insertions(+), 212 deletions(-)

diff --git a/api/logic/BaseVersionList.h b/api/logic/BaseVersionList.h
index eadc6933..8afcae1d 100644
--- a/api/logic/BaseVersionList.h
+++ b/api/logic/BaseVersionList.h
@@ -22,6 +22,7 @@
 #include "BaseVersion.h"
 #include "tasks/Task.h"
 #include "multimc_logic_export.h"
+#include "QObjectPtr.h"
 
 /*!
  * \brief Class that each instance type's version list derives from.
@@ -63,7 +64,7 @@ public:
 	 * The task returned by this function should reset the model when it's done.
 	 * \return A pointer to a task that reloads the version list.
 	 */
-	virtual Task *getLoadTask() = 0;
+	virtual shared_qobject_ptr<Task> getLoadTask() = 0;
 
 	//! Checks whether or not the list is loaded. If this returns false, the list should be
 	//loaded.
@@ -76,17 +77,17 @@ public:
 	virtual int count() const = 0;
 
 	//////// List Model Functions ////////
-	virtual QVariant data(const QModelIndex &index, int role) const;
-	virtual int rowCount(const QModelIndex &parent) const;
-	virtual int columnCount(const QModelIndex &parent) const;
-	virtual QHash<int, QByteArray> roleNames() const override;
+	QVariant data(const QModelIndex &index, int role) const override;
+	int rowCount(const QModelIndex &parent) const override;
+	int columnCount(const QModelIndex &parent) const override;
+	virtual QHash<int, QByteArray> roleNames() const;
 
 	//! which roles are provided by this version list?
 	virtual RoleList providesRoles() const;
 
 	/*!
 	 * \brief Finds a version by its descriptor.
-	 * \param The descriptor of the version to find.
+	 * \param descriptor The descriptor of the version to find.
 	 * \return A const pointer to the version with the given descriptor. NULL if
 	 * one doesn't exist.
 	 */
diff --git a/api/logic/java/JavaInstallList.cpp b/api/logic/java/JavaInstallList.cpp
index c98ef279..dbf66f5f 100644
--- a/api/logic/java/JavaInstallList.cpp
+++ b/api/logic/java/JavaInstallList.cpp
@@ -29,7 +29,7 @@ JavaInstallList::JavaInstallList(QObject *parent) : BaseVersionList(parent)
 {
 }
 
-Task *JavaInstallList::getLoadTask()
+shared_qobject_ptr<Task> JavaInstallList::getLoadTask()
 {
 	return new JavaListLoadTask(this);
 }
diff --git a/api/logic/java/JavaInstallList.h b/api/logic/java/JavaInstallList.h
index 2055d154..afc5ef43 100644
--- a/api/logic/java/JavaInstallList.h
+++ b/api/logic/java/JavaInstallList.h
@@ -34,17 +34,17 @@ class MULTIMC_LOGIC_EXPORT JavaInstallList : public BaseVersionList
 public:
 	explicit JavaInstallList(QObject *parent = 0);
 
-	virtual Task *getLoadTask() override;
-	virtual bool isLoaded() override;
-	virtual const BaseVersionPtr at(int i) const override;
-	virtual int count() const override;
-	virtual void sortVersions() override;
+	shared_qobject_ptr<Task> getLoadTask() override;
+	bool isLoaded() override;
+	const BaseVersionPtr at(int i) const override;
+	int count() const override;
+	void sortVersions() override;
 
-	virtual QVariant data(const QModelIndex &index, int role) const override;
-	virtual RoleList providesRoles() const override;
+	QVariant data(const QModelIndex &index, int role) const override;
+	RoleList providesRoles() const override;
 
 public slots:
-	virtual void updateListData(QList<BaseVersionPtr> versions) override;
+	void updateListData(QList<BaseVersionPtr> versions) override;
 
 protected:
 	QList<BaseVersionPtr> m_vlist;
@@ -60,7 +60,7 @@ public:
 	explicit JavaListLoadTask(JavaInstallList *vlist);
 	~JavaListLoadTask();
 
-	virtual void executeTask();
+	void executeTask() override;
 public slots:
 	void javaCheckerFinished(QList<JavaCheckResult> results);
 
diff --git a/api/logic/meta/BaseEntity.cpp b/api/logic/meta/BaseEntity.cpp
index 809f88cb..633afab2 100644
--- a/api/logic/meta/BaseEntity.cpp
+++ b/api/logic/meta/BaseEntity.cpp
@@ -101,16 +101,20 @@ bool Meta::BaseEntity::loadLocalFile()
 
 void Meta::BaseEntity::load()
 {
+	// load local file if nothing is loaded yet
 	if(!isLoaded())
 	{
-		loadLocalFile();
+		if(loadLocalFile())
+		{
+			m_loadStatus = LoadStatus::Local;
+		}
 	}
+	// if we need remote update, run the update task
 	if(!shouldStartRemoteUpdate())
 	{
 		return;
 	}
 	NetJob *job = new NetJob(QObject::tr("Download of meta file %1").arg(localFilename()));
-
 	auto url = this->url();
 	auto entry = ENV.metacache()->resolveEntry("meta", localFilename());
 	entry->setStale(true);
diff --git a/api/logic/meta/Index_test.cpp b/api/logic/meta/Index_test.cpp
index d4343c37..1c5face2 100644
--- a/api/logic/meta/Index_test.cpp
+++ b/api/logic/meta/Index_test.cpp
@@ -23,7 +23,7 @@ slots:
 		QVERIFY(!windex.hasUid("asdf"));
 		QVERIFY(windex.get("list2") != nullptr);
 		QCOMPARE(windex.get("list2")->uid(), QString("list2"));
-		QVERIFY(windex.get("adsf") == nullptr);
+		QVERIFY(windex.get("adsf") != nullptr);
 	}
 
 	void test_merge()
diff --git a/api/logic/meta/Version.cpp b/api/logic/meta/Version.cpp
index 2790b2f3..fee7d049 100644
--- a/api/logic/meta/Version.cpp
+++ b/api/logic/meta/Version.cpp
@@ -20,14 +20,6 @@
 #include "JsonFormat.h"
 #include "minecraft/MinecraftProfile.h"
 
-void Meta::Version::applyTo(MinecraftProfile* profile)
-{
-	if(m_data)
-	{
-		m_data->applyTo(profile);
-	}
-}
-
 Meta::Version::Version(const QString &uid, const QString &version)
 	: BaseVersion(), m_uid(uid), m_version(version)
 {
@@ -39,7 +31,9 @@ QString Meta::Version::descriptor()
 }
 QString Meta::Version::name()
 {
-	return m_version;
+	if(m_data)
+		return m_data->getName();
+	return m_uid;
 }
 QString Meta::Version::typeString() const
 {
diff --git a/api/logic/meta/Version.h b/api/logic/meta/Version.h
index b8ea7e44..b3943f47 100644
--- a/api/logic/meta/Version.h
+++ b/api/logic/meta/Version.h
@@ -33,7 +33,7 @@ namespace Meta
 {
 using VersionPtr = std::shared_ptr<class Version>;
 
-class MULTIMC_LOGIC_EXPORT Version : public QObject, public BaseVersion, public BaseEntity, public ProfilePatch
+class MULTIMC_LOGIC_EXPORT Version : public QObject, public BaseVersion, public BaseEntity
 {
 	Q_OBJECT
 	Q_PROPERTY(QString uid READ uid CONSTANT)
@@ -45,85 +45,6 @@ class MULTIMC_LOGIC_EXPORT Version : public QObject, public BaseVersion, public
 public: /* con/des */
 	explicit Version(const QString &uid, const QString &version);
 
-// FIXME: none of this belongs here...
-public: /* ProfilePatch overrides */
-	QString getFilename() override
-	{
-		return QString();
-	}
-	QString getID() override
-	{
-		return m_uid;
-	}
-	QList<JarmodPtr> getJarMods() override
-	{
-		return {};
-	}
-	QString getName() override
-	{
-		return name();
-	}
-	QDateTime getReleaseDateTime() override
-	{
-		return time();
-	}
-	QString getVersion() override
-	{
-		return m_version;
-	}
-	std::shared_ptr<class VersionFile> getVersionFile() override
-	{
-		return m_data;
-	}
-	int getOrder() override
-	{
-		return 0;
-	}
-	VersionSource getVersionSource() override
-	{
-		return VersionSource::Local;
-	}
-	bool isVersionChangeable() override
-	{
-		return true;
-	}
-	bool isRevertible() override
-	{
-		return false;
-	}
-	bool isRemovable() override
-	{
-		return true;
-	}
-	bool isCustom() override
-	{
-		return false;
-	}
-	bool isCustomizable() override
-	{
-		return true;
-	}
-	bool isMoveable() override
-	{
-		return true;
-	}
-	bool isEditable() override
-	{
-		return false;
-	}
-	void setOrder(int) override
-	{
-	}
-	bool hasJarMods() override
-	{
-		return false;
-	}
-	bool isMinecraftVersion() override
-	{
-		return m_uid == "net.minecraft";
-	}
-	void applyTo(MinecraftProfile * profile) override;
-
 	QString descriptor() override;
 	QString name() override;
 	QString typeString() const override;
@@ -153,6 +74,7 @@ signals:
 	void requiresChanged();
 
 private:
+	QString m_name;
 	QString m_uid;
 	QString m_version;
 	QString m_type;
diff --git a/api/logic/meta/VersionList.cpp b/api/logic/meta/VersionList.cpp
index d6bbf70f..28d9dd26 100644
--- a/api/logic/meta/VersionList.cpp
+++ b/api/logic/meta/VersionList.cpp
@@ -29,15 +29,15 @@ VersionList::VersionList(const QString &uid, QObject *parent)
 	setObjectName("Version list: " + uid);
 }
 
-Task *VersionList::getLoadTask()
+shared_qobject_ptr<Task> VersionList::getLoadTask()
 {
-	// TODO: create a wrapper task that will chain from root to here.
-	return nullptr;
+	load();
+	return getCurrentTask();
 }
 
 bool VersionList::isLoaded()
 {
-	return isLoaded();
+	return BaseEntity::isLoaded();
 }
 
 const BaseVersionPtr VersionList::at(int i) const
diff --git a/api/logic/meta/VersionList.h b/api/logic/meta/VersionList.h
index 26fa6c5a..08d71230 100644
--- a/api/logic/meta/VersionList.h
+++ b/api/logic/meta/VersionList.h
@@ -41,7 +41,7 @@ public:
 		VersionPtrRole
 	};
 
-	Task *getLoadTask() override;
+	shared_qobject_ptr<Task> getLoadTask() override;
 	bool isLoaded() override;
 	const BaseVersionPtr at(int i) const override;
 	int count() const override;
diff --git a/api/logic/minecraft/MinecraftInstance.cpp b/api/logic/minecraft/MinecraftInstance.cpp
index b88d0c2a..cb080bfe 100644
--- a/api/logic/minecraft/MinecraftInstance.cpp
+++ b/api/logic/minecraft/MinecraftInstance.cpp
@@ -20,6 +20,8 @@
 #include "minecraft/launch/ModMinecraftJar.h"
 #include "minecraft/launch/ClaimAccount.h"
 #include "java/launch/CheckJava.h"
+#include <meta/Index.h>
+#include <meta/VersionList.h>
 
 #include <icons/IIconList.h>
 
@@ -105,7 +107,7 @@ QString MinecraftInstance::binRoot() const
 
 std::shared_ptr< BaseVersionList > MinecraftInstance::versionList() const
 {
-	return ENV.getVersionList("net.minecraft");
+	return ENV.metadataIndex()->get("net.minecraft");
 }
 
 QStringList MinecraftInstance::javaArguments() const
diff --git a/api/logic/minecraft/MojangVersionFormat.cpp b/api/logic/minecraft/MojangVersionFormat.cpp
index 1312421f..651e2fbc 100644
--- a/api/logic/minecraft/MojangVersionFormat.cpp
+++ b/api/logic/minecraft/MojangVersionFormat.cpp
@@ -210,7 +210,7 @@ VersionFilePtr MojangVersionFormat::versionFileFromJson(const QJsonDocument &doc
 	readVersionProperties(root, out.get());
 
 	out->name = "Minecraft";
-	out->fileId = "net.minecraft";
+	out->uid = "net.minecraft";
 	out->version = out->minecraftVersion;
 	out->filename = filename;
 
diff --git a/api/logic/minecraft/ProfilePatch.h b/api/logic/minecraft/ProfilePatch.h
index b61fb8b3..6f63f3c4 100644
--- a/api/logic/minecraft/ProfilePatch.h
+++ b/api/logic/minecraft/ProfilePatch.h
@@ -51,8 +51,6 @@ public:
 	virtual void applyTo(MinecraftProfile *profile) = 0;
 
 	virtual bool isMinecraftVersion() = 0;
-	virtual bool hasJarMods() = 0;
-	virtual QList<JarmodPtr> getJarMods() = 0;
 
 	virtual bool isMoveable() = 0;
 	virtual bool isCustomizable() = 0;
diff --git a/api/logic/minecraft/ProfileUtils.cpp b/api/logic/minecraft/ProfileUtils.cpp
index ef9b3b28..c7c56dd6 100644
--- a/api/logic/minecraft/ProfileUtils.cpp
+++ b/api/logic/minecraft/ProfileUtils.cpp
@@ -102,7 +102,7 @@ bool readOverrideOrders(QString path, PatchOrder &order)
 static VersionFilePtr createErrorVersionFile(QString fileId, QString filepath, QString error)
 {
 	auto outError = std::make_shared<VersionFile>();
-	outError->fileId = outError->name = fileId;
+	outError->uid = outError->name = fileId;
 	outError->filename = filepath;
 	outError->addProblem(PROBLEM_ERROR, error);
 	return outError;
diff --git a/api/logic/minecraft/VersionFile.cpp b/api/logic/minecraft/VersionFile.cpp
index 573c4cb4..17dc6a49 100644
--- a/api/logic/minecraft/VersionFile.cpp
+++ b/api/logic/minecraft/VersionFile.cpp
@@ -14,12 +14,7 @@
 
 bool VersionFile::isMinecraftVersion()
 {
-	return fileId == "net.minecraft";
-}
-
-bool VersionFile::hasJarMods()
-{
-	return !jarMods.isEmpty();
+	return uid == "net.minecraft";
 }
 
 void VersionFile::applyTo(MinecraftProfile *profile)
@@ -29,7 +24,7 @@ void VersionFile::applyTo(MinecraftProfile *profile)
 	{
 		if (QRegExp(dependsOnMinecraftVersion, Qt::CaseInsensitive, QRegExp::Wildcard).indexIn(theirVersion) == -1)
 		{
-			throw MinecraftVersionMismatch(fileId, dependsOnMinecraftVersion, theirVersion);
+			throw MinecraftVersionMismatch(uid, dependsOnMinecraftVersion, theirVersion);
 		}
 	}
 	profile->applyMinecraftVersion(minecraftVersion);
diff --git a/api/logic/minecraft/VersionFile.h b/api/logic/minecraft/VersionFile.h
index 249d0965..6a922d74 100644
--- a/api/logic/minecraft/VersionFile.h
+++ b/api/logic/minecraft/VersionFile.h
@@ -25,7 +25,6 @@ class VersionFile : public ProfilePatch
 public: /* methods */
 	virtual void applyTo(MinecraftProfile *profile) override;
 	virtual bool isMinecraftVersion() override;
-	virtual bool hasJarMods() override;
 	virtual int getOrder() override
 	{
 		return order;
@@ -34,13 +33,9 @@ public: /* methods */
 	{
 		this->order = order;
 	}
-	virtual QList<JarmodPtr> getJarMods() override
-	{
-		return jarMods;
-	}
 	virtual QString getID() override
 	{
-		return fileId;
+		return uid;
 	}
 	virtual QString getName() override
 	{
@@ -120,9 +115,6 @@ public: /* methods */
 
 
 public: /* data */
-	/// MultiMC: order hint for this version file if no explicit order is set
-	int order = 0;
-
 	// Flags for UI and version file manipulation in general
 	bool m_isVanilla = false;
 	bool m_isRemovable = false;
@@ -130,6 +122,9 @@ public: /* data */
 	bool m_isCustomizable = false;
 	bool m_isMovable = false;
 
+	/// MultiMC: order hint for this version file if no explicit order is set
+	int order = 0;
+
 	/// MultiMC: filename of the file this was loaded from
 	QString filename;
 
@@ -137,7 +132,7 @@ public: /* data */
 	QString name;
 
 	/// MultiMC: package ID of this package
-	QString fileId;
+	QString uid;
 
 	/// MultiMC: version of this package
 	QString version;
@@ -191,5 +186,3 @@ public:
 	// Mojang: extended asset index download information
 	std::shared_ptr<MojangAssetIndexInfo> mojangAssetIndex;
 };
-
-
diff --git a/api/logic/minecraft/ftb/FTBProfileStrategy.cpp b/api/logic/minecraft/ftb/FTBProfileStrategy.cpp
index 92a1555a..45765cd4 100644
--- a/api/logic/minecraft/ftb/FTBProfileStrategy.cpp
+++ b/api/logic/minecraft/ftb/FTBProfileStrategy.cpp
@@ -27,7 +27,7 @@ void FTBProfileStrategy::loadDefaultBuiltinPatches()
 		if(QFile::exists(mcJson))
 		{
 			auto file = ProfileUtils::parseJsonFile(QFileInfo(mcJson), false);
-			file->fileId = "net.minecraft";
+			file->uid = "net.minecraft";
 			file->name = QObject::tr("Minecraft (tracked)");
 			file->setVanilla(true);
 			if(file->version.isEmpty())
@@ -64,7 +64,7 @@ void FTBProfileStrategy::loadDefaultBuiltinPatches()
 				addLib->setHint("local");
 				addLib->setStoragePrefix(nativeInstance->librariesPath().absolutePath());
 			}
-			file->fileId = "org.multimc.ftb.pack";
+			file->uid = "org.multimc.ftb.pack";
 			file->setVanilla(true);
 			file->name = QObject::tr("%1 (FTB pack)").arg(m_instance->name());
 			if(file->version.isEmpty())
diff --git a/api/logic/minecraft/legacy/LwjglVersionList.cpp b/api/logic/minecraft/legacy/LwjglVersionList.cpp
index 7f4e7b38..3d7ad2d4 100644
--- a/api/logic/minecraft/legacy/LwjglVersionList.cpp
+++ b/api/logic/minecraft/legacy/LwjglVersionList.cpp
@@ -99,6 +99,7 @@ inline QDomElement getDomElementByTagName(QDomElement parent, QString tagname)
 
 void LWJGLVersionList::rssFailed(const QString& reason)
 {
+	m_rssDLJob.reset();
 	m_loading = false;
 	qWarning() << "Failed to load LWJGL list. Network error: " + reason;
 }
@@ -116,8 +117,9 @@ void LWJGLVersionList::rssSucceeded()
 	if (!doc.setContent(m_rssData, false, &xmlErrorMsg, &errorLine))
 	{
 		qWarning() << "Failed to load LWJGL list. XML error: " + xmlErrorMsg + " at line " + QString::number(errorLine);
-		m_loading = false;
+		m_rssDLJob.reset();
 		m_rssData.clear();
+		m_loading = false;
 		return;
 	}
 	m_rssData.clear();
@@ -162,5 +164,6 @@ void LWJGLVersionList::rssSucceeded()
 	endResetModel();
 
 	qDebug() << "Loaded LWJGL list.";
+	m_rssDLJob.reset();
 	m_loading = false;
 }
diff --git a/api/logic/minecraft/legacy/LwjglVersionList.h b/api/logic/minecraft/legacy/LwjglVersionList.h
index 652a3fda..f5312e2c 100644
--- a/api/logic/minecraft/legacy/LwjglVersionList.h
+++ b/api/logic/minecraft/legacy/LwjglVersionList.h
@@ -78,9 +78,9 @@ public:
 		return m_vlist[i];
 	}
 
-	virtual Task* getLoadTask() override
+	virtual shared_qobject_ptr<Task> getLoadTask() override
 	{
-		return nullptr;
+		return m_rssDLJob;
 	}
 
 	virtual void sortVersions() override {};
diff --git a/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp b/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
index b19a2dea..3a9b10e6 100644
--- a/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
+++ b/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
@@ -56,7 +56,7 @@ void OneSixProfileStrategy::upgradeDeprecatedFiles()
 		}
 		auto file = ProfileUtils::parseJsonFile(QFileInfo(sourceFile), false);
 		ProfileUtils::removeLwjglFromPatch(file);
-		file->fileId = "net.minecraft";
+		file->uid = "net.minecraft";
 		file->version = file->minecraftVersion;
 		file->name = "Minecraft";
 		auto data = OneSixVersionFormat::versionFileToJson(file, false).toJson();
@@ -81,6 +81,107 @@ void OneSixProfileStrategy::upgradeDeprecatedFiles()
 	}
 }
 
+class MetaPatchProvider : public ProfilePatch
+{
+public: /* con/des */
+	MetaPatchProvider(std::shared_ptr<Meta::Version> data)
+		:m_version(data)
+	{
+	}
+public:
+	QString getFilename() override
+	{
+		return QString();
+	}
+	QString getID() override
+	{
+		return m_version->uid();
+	}
+	QString getName() override
+	{
+		auto vfile = getFile();
+		if(vfile)
+		{
+			return vfile->getName();
+		}
+		return m_version->name();
+	}
+	QDateTime getReleaseDateTime() override
+	{
+		return m_version->time();
+	}
+	QString getVersion() override
+	{
+		return m_version->version();
+	}
+	std::shared_ptr<class VersionFile> getVersionFile() override
+	{
+		return m_version->data();
+	}
+	void setOrder(int) override
+	{
+	}
+	int getOrder() override
+	{
+		return 0;
+	}
+	VersionSource getVersionSource() override
+	{
+		return VersionSource::Local;
+	}
+	bool isVersionChangeable() override
+	{
+		return true;
+	}
+	bool isRevertible() override
+	{
+		return false;
+	}
+	bool isRemovable() override
+	{
+		return true;
+	}
+	bool isCustom() override
+	{
+		return false;
+	}
+	bool isCustomizable() override
+	{
+		return true;
+	}
+	bool isMoveable() override
+	{
+		return true;
+	}
+	bool isEditable() override
+	{
+		return false;
+	}
+	bool isMinecraftVersion() override
+	{
+		return getID() == "net.minecraft";
+	}
+	void applyTo(MinecraftProfile * profile) override
+	{
+		auto vfile = getFile();
+		if(vfile)
+		{
+			vfile->applyTo(profile);
+		}
+	}
+private:
+	VersionFilePtr getFile()
+	{
+		if(!m_version->isLoaded())
+		{
+			m_version->load();
+		}
+		return m_version->data();
+	}
+private:
+	std::shared_ptr<Meta::Version> m_version;
+};
+
 void OneSixProfileStrategy::loadDefaultBuiltinPatches()
 {
 	{
@@ -101,7 +202,7 @@ void OneSixProfileStrategy::loadDefaultBuiltinPatches()
 		else
 		{
 			auto mcversion = ENV.metadataIndex()->get("net.minecraft", m_instance->intendedVersionId());
-			minecraftPatch = std::dynamic_pointer_cast<ProfilePatch>(mcversion);
+			minecraftPatch = std::make_shared<MetaPatchProvider>(mcversion);
 		}
 		if (!minecraftPatch)
 		{
@@ -124,7 +225,7 @@ void OneSixProfileStrategy::loadDefaultBuiltinPatches()
 		else
 		{
 			auto lwjglversion = ENV.metadataIndex()->get("org.lwjgl", "2.9.1");
-			lwjglPatch = std::dynamic_pointer_cast<ProfilePatch>(lwjglversion);
+			lwjglPatch = std::make_shared<MetaPatchProvider>(lwjglversion);
 		}
 		if (!lwjglPatch)
 		{
@@ -162,10 +263,10 @@ void OneSixProfileStrategy::loadUserPatches()
 		qDebug() << "Reading" << filename << "by user order";
 		VersionFilePtr file = ProfileUtils::parseJsonFile(finfo, false);
 		// sanity check. prevent tampering with files.
-		if (file->fileId != id)
+		if (file->uid != id)
 		{
-			file->addProblem(PROBLEM_WARNING, QObject::tr("load id %1 does not match internal id %2").arg(id, file->fileId));
-			seen_extra.insert(file->fileId);
+			file->addProblem(PROBLEM_WARNING, QObject::tr("load id %1 does not match internal id %2").arg(id, file->uid));
+			seen_extra.insert(file->uid);
 		}
 		file->setRemovable(true);
 		file->setMovable(true);
@@ -185,15 +286,15 @@ void OneSixProfileStrategy::loadUserPatches()
 		qDebug() << "Reading" << info.fileName();
 		auto file = ProfileUtils::parseJsonFile(info, true);
 		// ignore builtins
-		if (file->fileId == "net.minecraft")
+		if (file->uid == "net.minecraft")
 			continue;
-		if (file->fileId == "org.lwjgl")
+		if (file->uid == "org.lwjgl")
 			continue;
 		// do not load versions with broken IDs twice
-		if(seen_extra.contains(file->fileId))
+		if(seen_extra.contains(file->uid))
 			continue;
 		// do not load what we already loaded in the first pass
-		if (userOrder.contains(file->fileId))
+		if (userOrder.contains(file->uid))
 			continue;
 		file->setRemovable(true);
 		file->setMovable(true);
@@ -203,7 +304,7 @@ void OneSixProfileStrategy::loadUserPatches()
 		file->assets = QString();
 		file->mojangAssetIndex.reset();
 		// HACK
-		files.insert(file->order, file);
+		files.insert(file->getOrder(), file);
 	}
 	QSet<int> seen;
 	for (auto order : files.keys())
@@ -284,7 +385,8 @@ bool OneSixProfileStrategy::removePatch(ProfilePatchPtr patch)
 		return true;
 	};
 
-	for(auto &jarmod: patch->getJarMods())
+	auto &jarMods = patch->getVersionFile()->jarMods;
+	for(auto &jarmod: jarMods)
 	{
 		ok &= preRemoveJarMod(jarmod);
 	}
@@ -404,8 +506,8 @@ bool OneSixProfileStrategy::installJarMods(QStringList filepaths)
 		jarMod->originalName = sourceInfo.completeBaseName();
 		f->jarMods.append(jarMod);
 		f->name = target_name;
-		f->fileId = target_id;
-		f->order = profile->getFreeOrderNumber();
+		f->uid = target_id;
+		f->setOrder(profile->getFreeOrderNumber());
 		QString patchFileName = FS::PathCombine(patchDir, target_id + ".json");
 		f->filename = patchFileName;
 		f->setMovable(true);
diff --git a/api/logic/minecraft/onesix/OneSixVersionFormat.cpp b/api/logic/minecraft/onesix/OneSixVersionFormat.cpp
index 403eb112..944e68a4 100644
--- a/api/logic/minecraft/onesix/OneSixVersionFormat.cpp
+++ b/api/logic/minecraft/onesix/OneSixVersionFormat.cpp
@@ -51,7 +51,7 @@ VersionFilePtr OneSixVersionFormat::versionFileFromJson(const QJsonDocument &doc
 	{
 		if (root.contains("order"))
 		{
-			out->order = requireInteger(root.value("order"));
+			out->setOrder(requireInteger(root.value("order")));
 		}
 		else
 		{
@@ -61,7 +61,16 @@ VersionFilePtr OneSixVersionFormat::versionFileFromJson(const QJsonDocument &doc
 	}
 
 	out->name = root.value("name").toString();
-	out->fileId = root.value("fileId").toString();
+
+	if(root.contains("uid"))
+	{
+		out->uid = root.value("uid").toString();
+	}
+	else
+	{
+		out->uid = root.value("fileId").toString();
+	}
+
 	out->version = root.value("version").toString();
 	out->dependsOnMinecraftVersion = root.value("mcVersion").toString();
 	out->filename = filename;
@@ -161,10 +170,13 @@ QJsonDocument OneSixVersionFormat::versionFileToJson(const VersionFilePtr &patch
 	QJsonObject root;
 	if (saveOrder)
 	{
-		root.insert("order", patch->order);
+		root.insert("order", patch->getOrder());
 	}
 	writeString(root, "name", patch->name);
-	writeString(root, "fileId", patch->fileId);
+
+	writeString(root, "uid", patch->uid);
+	writeString(root, "fileId", patch->uid);
+
 	writeString(root, "version", patch->version);
 	writeString(root, "mcVersion", patch->dependsOnMinecraftVersion);
 
diff --git a/application/pages/VersionPage.cpp b/application/pages/VersionPage.cpp
index 78e2a888..732a33eb 100644
--- a/application/pages/VersionPage.cpp
+++ b/application/pages/VersionPage.cpp
@@ -487,22 +487,16 @@ int VersionPage::currentRow()
 
 void VersionPage::on_customizeBtn_clicked()
 {
-	// TODO: implement
-	/*
 	auto version = currentRow();
 	if(version == -1)
 	{
 		return;
 	}
-	//HACK HACK remove, this is dumb
 	auto patch = m_profile->versionPatch(version);
-	auto mc = std::dynamic_pointer_cast<MinecraftVersion>(patch);
-	if(mc && mc->needsUpdate())
+	if(!patch->getVersionFile())
 	{
-		if(!doUpdate())
-		{
-			return;
-		}
+		// TODO: wait for the update task to finish here...
+		return;
 	}
 	if(!m_profile->customize(version))
 	{
@@ -510,7 +504,6 @@ void VersionPage::on_customizeBtn_clicked()
 	}
 	updateButtons();
 	preselect(currentIdx);
-	*/
 }
 
 void VersionPage::on_editBtn_clicked()
@@ -531,22 +524,11 @@ void VersionPage::on_editBtn_clicked()
 
 void VersionPage::on_revertBtn_clicked()
 {
-	// TODO: implement
-	/*
 	auto version = currentRow();
 	if(version == -1)
 	{
 		return;
 	}
-	auto mcraw = MMC->minecraftlist()->findVersion(m_inst->intendedVersionId());
-	auto mc = std::dynamic_pointer_cast<MinecraftVersion>(mcraw);
-	if(mc && mc->needsUpdate())
-	{
-		if(!doUpdate())
-		{
-			return;
-		}
-	}
 	if(!m_profile->revertToBase(version))
 	{
 		// TODO: some error box here
@@ -554,7 +536,6 @@ void VersionPage::on_revertBtn_clicked()
 	updateButtons();
 	preselect(currentIdx);
 	m_container->refreshContainer();
-	*/
 }
 
 #include "VersionPage.moc"
diff --git a/application/widgets/VersionSelectWidget.cpp b/application/widgets/VersionSelectWidget.cpp
index 18284a91..a4eb428b 100644
--- a/application/widgets/VersionSelectWidget.cpp
+++ b/application/widgets/VersionSelectWidget.cpp
@@ -80,52 +80,42 @@ void VersionSelectWidget::initialize()
 
 void VersionSelectWidget::closeEvent(QCloseEvent * event)
 {
-	if(loadTask)
-	{
-		loadTask->abort();
-		loadTask->deleteLater();
-		loadTask = nullptr;
-	}
 	QWidget::closeEvent(event);
 }
 
 void VersionSelectWidget::loadList()
 {
-	if(loadTask)
+	auto newTask = m_vlist->getLoadTask();
+	if (!newTask)
 	{
 		return;
 	}
-	loadTask = m_vlist->getLoadTask();
-	if (!loadTask)
-	{
-		return;
-	}
-	connect(loadTask, &Task::finished, this, &VersionSelectWidget::onTaskFinished);
+	loadTask = newTask.get();
+	connect(loadTask, &Task::succeeded, this, &VersionSelectWidget::onTaskSucceeded);
+	connect(loadTask, &Task::failed, this, &VersionSelectWidget::onTaskFailed);
 	connect(loadTask, &Task::progress, this, &VersionSelectWidget::changeProgress);
-	loadTask->start();
+	if(!loadTask->isRunning())
+	{
+		loadTask->start();
+	}
 	sneakyProgressBar->setHidden(false);
 }
 
-void VersionSelectWidget::onTaskFinished()
+void VersionSelectWidget::onTaskSucceeded()
 {
-	if (!loadTask->successful())
-	{
-		CustomMessageBox::selectable(this, tr("Error"),
-									 tr("List update failed:\n%1").arg(loadTask->failReason()),
-									 QMessageBox::Warning)->show();
-		if (m_proxyModel->rowCount() == 0)
-		{
-			listView->setEmptyMode(VersionListView::ErrorString);
-		}
-	}
-	else if (m_proxyModel->rowCount() == 0)
+	if (m_proxyModel->rowCount() == 0)
 	{
 		listView->setEmptyMode(VersionListView::String);
 	}
 	sneakyProgressBar->setHidden(true);
-	loadTask->deleteLater();
-	loadTask = nullptr;
 	preselect();
+	loadTask = nullptr;
+}
+
+void VersionSelectWidget::onTaskFailed(const QString& reason)
+{
+	CustomMessageBox::selectable(this, tr("Error"), tr("List update failed:\n%1").arg(reason), QMessageBox::Warning)->show();
+	onTaskSucceeded();
 }
 
 void VersionSelectWidget::changeProgress(qint64 current, qint64 total)
diff --git a/application/widgets/VersionSelectWidget.h b/application/widgets/VersionSelectWidget.h
index 0fc9f2e6..66e512ac 100644
--- a/application/widgets/VersionSelectWidget.h
+++ b/application/widgets/VersionSelectWidget.h
@@ -55,7 +55,8 @@ protected:
 	virtual void closeEvent ( QCloseEvent* );
 
 private slots:
-	void onTaskFinished();
+	void onTaskSucceeded();
+	void onTaskFailed(const QString &reason);
 	void changeProgress(qint64 current, qint64 total);
 	void currentRowChanged(const QModelIndex &current, const QModelIndex &);
 
@@ -66,7 +67,7 @@ private:
 	BaseVersionList *m_vlist = nullptr;
 	VersionProxyModel *m_proxyModel = nullptr;
 	int resizeOnColumn = 0;
-	Task * loadTask = nullptr;
+	Task * loadTask;
 	bool preselectedAlready = false;
 
 private:

From 77f27a628f33a591f7562ca05c206ac604212443 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= <peterix@gmail.com>
Date: Mon, 20 Mar 2017 00:44:49 +0100
Subject: [PATCH 13/28] NOISSUE bring back instance creation

---
 application/dialogs/NewInstanceDialog.cpp | 38 ++++++++++++++++++++---
 application/dialogs/NewInstanceDialog.h   |  4 +--
 2 files changed, 35 insertions(+), 7 deletions(-)

diff --git a/application/dialogs/NewInstanceDialog.cpp b/application/dialogs/NewInstanceDialog.cpp
index 2e8e3ff7..8180aa27 100644
--- a/application/dialogs/NewInstanceDialog.cpp
+++ b/application/dialogs/NewInstanceDialog.cpp
@@ -31,6 +31,9 @@
 #include <QFileDialog>
 #include <QValidator>
 
+#include <meta/Index.h>
+#include <meta/VersionList.h>
+
 class UrlValidator : public QValidator
 {
 public:
@@ -61,12 +64,25 @@ NewInstanceDialog::NewInstanceDialog(const QString & initialGroup, QWidget *pare
 	resize(minimumSizeHint());
 	layout()->setSizeConstraint(QLayout::SetFixedSize);
 
-	// FIXME: bring this back...
-	auto vlist = ENV.getVersionList("net.minecraft");
-	if(vlist)
+	auto vlist = ENV.metadataIndex()->get("net.minecraft");
+	if(vlist->isLoaded())
 	{
 		setSelectedVersion(vlist->getRecommended());
 	}
+	else
+	{
+		vlist->load();
+		auto task = vlist->getLoadTask();
+		if(vlist->isLoaded())
+		{
+			setSelectedVersion(vlist->getRecommended());
+		}
+		if(task)
+		{
+			connect(task.get(), &Task::succeeded, this, &NewInstanceDialog::versionListUpdated);
+		}
+	}
+
 	InstIconKey = "default";
 	ui->iconButton->setIcon(MMC->icons()->getIcon(InstIconKey));
 
@@ -99,6 +115,15 @@ NewInstanceDialog::NewInstanceDialog(const QString & initialGroup, QWidget *pare
 	updateDialogState();
 }
 
+void NewInstanceDialog::versionListUpdated()
+{
+	if(!m_versionSetByUser)
+	{
+		auto vlist = ENV.metadataIndex()->get("net.minecraft");
+		setSelectedVersion(vlist->getRecommended());
+	}
+}
+
 NewInstanceDialog::~NewInstanceDialog()
 {
 	delete ui;
@@ -138,7 +163,7 @@ void NewInstanceDialog::setSelectedVersion(BaseVersionPtr version)
 
 	if (m_selectedVersion)
 	{
-		ui->versionTextBox->setText(version->name());
+		ui->versionTextBox->setText(version->descriptor());
 	}
 	else
 	{
@@ -196,13 +221,16 @@ BaseVersionPtr NewInstanceDialog::selectedVersion() const
 
 void NewInstanceDialog::on_btnChangeVersion_clicked()
 {
-	VersionSelectDialog vselect(ENV.getVersionList("net.minecraft").get(), tr("Change Minecraft version"), this);
+	VersionSelectDialog vselect(ENV.metadataIndex()->get("net.minecraft").get(), tr("Change Minecraft version"), this);
 	vselect.exec();
 	if (vselect.result() == QDialog::Accepted)
 	{
 		BaseVersionPtr version = vselect.selectedVersion();
 		if (version)
+		{
+			m_versionSetByUser = true;
 			setSelectedVersion(version);
+		}
 	}
 }
 
diff --git a/application/dialogs/NewInstanceDialog.h b/application/dialogs/NewInstanceDialog.h
index 1f7fadfb..1741dab8 100644
--- a/application/dialogs/NewInstanceDialog.h
+++ b/application/dialogs/NewInstanceDialog.h
@@ -36,8 +36,6 @@ public:
 
 	void setSelectedVersion(BaseVersionPtr version);
 
-	void loadVersionList();
-
 	QString instName() const;
 	QString instGroup() const;
 	QString iconKey() const;
@@ -50,10 +48,12 @@ slots:
 	void on_iconButton_clicked();
 	void on_modpackBtn_clicked();
 	void on_instNameTextBox_textChanged(const QString &arg1);
+	void versionListUpdated();
 
 private:
 	Ui::NewInstanceDialog *ui;
 
+	bool m_versionSetByUser = false;
 	BaseVersionPtr m_selectedVersion;
 	QString InstIconKey;
 	QString originalPlaceholderText;

From da4ae1bc1ec74cdb4e75f4ebac30886ba4a1909c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= <peterix@gmail.com>
Date: Fri, 24 Mar 2017 02:26:06 +0100
Subject: [PATCH 14/28] NOISSUE reimplement package dependencies

It is now stored as a hashmap
There is also a parentUid to limit depsolving by encapsulating by version
---
 api/logic/CMakeLists.txt                  |  2 -
 api/logic/meta/JsonFormat.cpp             | 25 ++++++------
 api/logic/meta/Reference.cpp              | 48 -----------------------
 api/logic/meta/Reference.h                | 44 ---------------------
 api/logic/meta/Version.cpp                | 15 ++++++-
 api/logic/meta/Version.h                  | 48 +++++++++++++++++------
 api/logic/meta/VersionList.cpp            | 26 ++++++++----
 api/logic/meta/VersionList.h              | 28 ++++++++++---
 application/pages/VersionPage.cpp         |  7 +++-
 application/pages/global/PackagesPage.cpp | 18 ++++-----
 10 files changed, 118 insertions(+), 143 deletions(-)
 delete mode 100644 api/logic/meta/Reference.cpp
 delete mode 100644 api/logic/meta/Reference.h

diff --git a/api/logic/CMakeLists.txt b/api/logic/CMakeLists.txt
index 544ace80..7f04a41e 100644
--- a/api/logic/CMakeLists.txt
+++ b/api/logic/CMakeLists.txt
@@ -426,8 +426,6 @@ set(META_SOURCES
 	meta/Version.h
 	meta/Index.cpp
 	meta/Index.h
-	meta/Reference.cpp
-	meta/Reference.h
 )
 
 add_unit_test(Index
diff --git a/api/logic/meta/JsonFormat.cpp b/api/logic/meta/JsonFormat.cpp
index 4e43b715..8a063f48 100644
--- a/api/logic/meta/JsonFormat.cpp
+++ b/api/logic/meta/JsonFormat.cpp
@@ -48,20 +48,22 @@ static BaseEntity::Ptr parseIndexInternal(const QJsonObject &obj)
 // Version
 static VersionPtr parseCommonVersion(const QString &uid, const QJsonObject &obj)
 {
-	const QVector<QJsonObject> requiresRaw = obj.contains("requires") ? requireIsArrayOf<QJsonObject>(obj, "requires") : QVector<QJsonObject>();
-	QVector<Reference> requires;
-	requires.reserve(requiresRaw.size());
-	std::transform(requiresRaw.begin(), requiresRaw.end(), std::back_inserter(requires), [](const QJsonObject &rObj)
-	{
-		Reference ref(requireString(rObj, "uid"));
-		ref.setVersion(ensureString(rObj, "version", QString()));
-		return ref;
-	});
-
 	VersionPtr version = std::make_shared<Version>(uid, requireString(obj, "version"));
 	version->setTime(QDateTime::fromString(requireString(obj, "releaseTime"), Qt::ISODate).toMSecsSinceEpoch() / 1000);
 	version->setType(ensureString(obj, "type", QString()));
-	version->setRequires(requires);
+	version->setParentUid(ensureString(obj, "parentUid", QString()));
+	if(obj.contains("requires"))
+	{
+		QHash<QString, QString> requires;
+		auto reqobj = requireObject(obj, "requires");
+		auto iter = reqobj.begin();
+		while(iter != reqobj.end())
+		{
+			requires[iter.key()] = requireString(iter.value());
+			iter++;
+		}
+		version->setRequires(requires);
+	}
 	return version;
 }
 
@@ -90,6 +92,7 @@ static BaseEntity::Ptr parseVersionListInternal(const QJsonObject &obj)
 
 	VersionListPtr list = std::make_shared<VersionList>(uid);
 	list->setName(ensureString(obj, "name", QString()));
+	list->setParentUid(ensureString(obj, "parentUid", QString()));
 	list->setVersions(versions);
 	return list;
 }
diff --git a/api/logic/meta/Reference.cpp b/api/logic/meta/Reference.cpp
deleted file mode 100644
index c5cef172..00000000
--- a/api/logic/meta/Reference.cpp
+++ /dev/null
@@ -1,48 +0,0 @@
-/* Copyright 2015-2017 MultiMC Contributors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#include "Reference.h"
-
-namespace Meta
-{
-Reference::Reference(const QString &uid)
-	: m_uid(uid)
-{
-}
-
-QString Reference::uid() const
-{
-	return m_uid;
-}
-
-QString Reference::version() const
-{
-	return m_version;
-}
-void Reference::setVersion(const QString &version)
-{
-	m_version = version;
-}
-
-bool Reference::operator==(const Reference &other) const
-{
-	return m_uid == other.m_uid && m_version == other.m_version;
-}
-
-bool Reference::operator!=(const Reference &other) const
-{
-	return m_uid != other.m_uid || m_version != other.m_version;
-}
-}
diff --git a/api/logic/meta/Reference.h b/api/logic/meta/Reference.h
deleted file mode 100644
index 027076cc..00000000
--- a/api/logic/meta/Reference.h
+++ /dev/null
@@ -1,44 +0,0 @@
-/* Copyright 2015-2017 MultiMC Contributors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#pragma once
-
-#include <QString>
-#include <QMetaType>
-
-#include "multimc_logic_export.h"
-
-namespace Meta
-{
-class MULTIMC_LOGIC_EXPORT Reference
-{
-public:
-	Reference() {}
-	explicit Reference(const QString &uid);
-
-	QString uid() const;
-
-	QString version() const;
-	void setVersion(const QString &version);
-
-	bool operator==(const Reference &other) const;
-	bool operator!=(const Reference &other) const;
-
-private:
-	QString m_uid;
-	QString m_version;
-};
-}
-Q_DECLARE_METATYPE(Meta::Reference)
diff --git a/api/logic/meta/Version.cpp b/api/logic/meta/Version.cpp
index fee7d049..af9d4f10 100644
--- a/api/logic/meta/Version.cpp
+++ b/api/logic/meta/Version.cpp
@@ -65,6 +65,10 @@ void Meta::Version::merge(const std::shared_ptr<BaseEntity> &other)
 	{
 		setRequires(version->m_requires);
 	}
+	if (m_parentUid != version->m_parentUid)
+	{
+		setParentUid(version->m_parentUid);
+	}
 
 	setData(version->m_data);
 }
@@ -74,21 +78,30 @@ QString Meta::Version::localFilename() const
 	return m_uid + '/' + m_version + ".json";
 }
 
+void Meta::Version::setParentUid(const QString& parentUid)
+{
+	m_parentUid = parentUid;
+	emit requiresChanged();
+}
+
 void Meta::Version::setType(const QString &type)
 {
 	m_type = type;
 	emit typeChanged();
 }
+
 void Meta::Version::setTime(const qint64 time)
 {
 	m_time = time;
 	emit timeChanged();
 }
-void Meta::Version::setRequires(const QVector<Reference> &requires)
+
+void Meta::Version::setRequires(const QHash<QString, QString> &requires)
 {
 	m_requires = requires;
 	emit requiresChanged();
 }
+
 void Meta::Version::setData(const VersionFilePtr &data)
 {
 	m_data = data;
diff --git a/api/logic/meta/Version.h b/api/logic/meta/Version.h
index b3943f47..1d921035 100644
--- a/api/logic/meta/Version.h
+++ b/api/logic/meta/Version.h
@@ -17,15 +17,14 @@
 
 #include "BaseVersion.h"
 
-#include <QVector>
-#include <QStringList>
 #include <QJsonObject>
+#include <QStringList>
+#include <QVector>
 #include <memory>
 
 #include "minecraft/VersionFile.h"
 
 #include "BaseEntity.h"
-#include "Reference.h"
 
 #include "multimc_logic_export.h"
 
@@ -37,10 +36,11 @@ class MULTIMC_LOGIC_EXPORT Version : public QObject, public BaseVersion, public
 {
 	Q_OBJECT
 	Q_PROPERTY(QString uid READ uid CONSTANT)
+	Q_PROPERTY(QString parentUid READ parentUid)
 	Q_PROPERTY(QString version READ version CONSTANT)
 	Q_PROPERTY(QString type READ type NOTIFY typeChanged)
 	Q_PROPERTY(QDateTime time READ time NOTIFY timeChanged)
-	Q_PROPERTY(QVector<Reference> requires READ requires NOTIFY requiresChanged)
+	Q_PROPERTY(QHash<QString, QString> requires READ requires NOTIFY requiresChanged)
 
 public: /* con/des */
 	explicit Version(const QString &uid, const QString &version);
@@ -49,13 +49,35 @@ public: /* con/des */
 	QString name() override;
 	QString typeString() const override;
 
-	QString uid() const { return m_uid; }
-	QString version() const { return m_version; }
-	QString type() const { return m_type; }
+	QString uid() const
+	{
+		return m_uid;
+	}
+	QString parentUid() const
+	{
+		return m_parentUid;
+	}
+	QString version() const
+	{
+		return m_version;
+	}
+	QString type() const
+	{
+		return m_type;
+	}
 	QDateTime time() const;
-	qint64 rawTime() const { return m_time; }
-	QVector<Reference> requires() const { return m_requires; }
-	VersionFilePtr data() const { return m_data; }
+	qint64 rawTime() const
+	{
+		return m_time;
+	}
+	const QHash<QString, QString> &requires() const
+	{
+		return m_requires;
+	}
+	VersionFilePtr data() const
+	{
+		return m_data;
+	}
 
 	void merge(const std::shared_ptr<BaseEntity> &other) override;
 	void parse(const QJsonObject &obj) override;
@@ -63,9 +85,10 @@ public: /* con/des */
 	QString localFilename() const override;
 
 public: // for usage by format parsers only
+	void setParentUid(const QString &parentUid);
 	void setType(const QString &type);
 	void setTime(const qint64 time);
-	void setRequires(const QVector<Reference> &requires);
+	void setRequires(const QHash<QString, QString> &requires);
 	void setData(const VersionFilePtr &data);
 
 signals:
@@ -76,10 +99,11 @@ signals:
 private:
 	QString m_name;
 	QString m_uid;
+	QString m_parentUid;
 	QString m_version;
 	QString m_type;
 	qint64 m_time;
-	QVector<Reference> m_requires;
+	QHash<QString, QString> m_requires;
 	VersionFilePtr m_data;
 };
 }
diff --git a/api/logic/meta/VersionList.cpp b/api/logic/meta/VersionList.cpp
index 28d9dd26..c2712155 100644
--- a/api/logic/meta/VersionList.cpp
+++ b/api/logic/meta/VersionList.cpp
@@ -19,7 +19,6 @@
 
 #include "Version.h"
 #include "JsonFormat.h"
-#include "Reference.h"
 
 namespace Meta
 {
@@ -76,14 +75,17 @@ QVariant VersionList::data(const QModelIndex &index, int role) const
 		return version->version();
 	case ParentGameVersionRole:
 	{
-		const auto end = version->requires().end();
-		const auto it = std::find_if(version->requires().begin(), end,
-									 [](const Reference &ref) { return ref.uid() == "net.minecraft"; });
-		if (it != end)
+		auto parentUid = this->parentUid();
+		if(parentUid.isEmpty())
 		{
-			return (*it).version();
+			return QVariant();
+		}
+		auto & reqs = version->requires();
+		auto iter = reqs.find(parentUid);
+		if (iter != reqs.end())
+		{
+			return iter.value();
 		}
-		return QVariant();
 	}
 	case TypeRole: return version->type();
 
@@ -175,6 +177,11 @@ void VersionList::merge(const BaseEntity::Ptr &other)
 		setName(list->m_name);
 	}
 
+	if(m_parentUid != list->m_parentUid)
+	{
+		setParentUid(list->m_parentUid);
+	}
+
 	if (m_versions.isEmpty())
 	{
 		setVersions(list->m_versions);
@@ -228,5 +235,10 @@ BaseVersionPtr VersionList::getRecommended() const
 
 }
 
+void Meta::VersionList::setParentUid(const QString& parentUid)
+{
+	m_parentUid = parentUid;
+}
+
 
 #include "VersionList.moc"
diff --git a/api/logic/meta/VersionList.h b/api/logic/meta/VersionList.h
index 08d71230..faacdbf8 100644
--- a/api/logic/meta/VersionList.h
+++ b/api/logic/meta/VersionList.h
@@ -15,8 +15,8 @@
 
 #pragma once
 
-#include "BaseVersionList.h"
 #include "BaseEntity.h"
+#include "BaseVersionList.h"
 #include <QJsonObject>
 #include <memory>
 
@@ -56,16 +56,30 @@ public:
 
 	QString localFilename() const override;
 
-	QString uid() const { return m_uid; }
-	QString name() const { return m_name; }
+	QString parentUid() const
+	{
+		return m_parentUid;
+	}
+	QString uid() const
+	{
+		return m_uid;
+	}
+	QString name() const
+	{
+		return m_name;
+	}
 	QString humanReadable() const;
 
 	VersionPtr getVersion(const QString &version);
 
-	QVector<VersionPtr> versions() const { return m_versions; }
+	QVector<VersionPtr> versions() const
+	{
+		return m_versions;
+	}
 
 public: // for usage only by parsers
 	void setName(const QString &name);
+	void setParentUid(const QString &parentUid);
 	void setVersions(const QVector<VersionPtr> &versions);
 	void merge(const BaseEntity::Ptr &other) override;
 	void parse(const QJsonObject &obj) override;
@@ -74,12 +88,15 @@ signals:
 	void nameChanged(const QString &name);
 
 protected slots:
-	void updateListData(QList<BaseVersionPtr>) override {}
+	void updateListData(QList<BaseVersionPtr>) override
+	{
+	}
 
 private:
 	QVector<VersionPtr> m_versions;
 	QHash<QString, VersionPtr> m_lookup;
 	QString m_uid;
+	QString m_parentUid;
 	QString m_name;
 
 	VersionPtr m_recommended;
@@ -87,6 +104,5 @@ private:
 
 	void setupAddedVersion(const int row, const VersionPtr &version);
 };
-
 }
 Q_DECLARE_METATYPE(Meta::VersionListPtr)
diff --git a/application/pages/VersionPage.cpp b/application/pages/VersionPage.cpp
index 732a33eb..0608b2bf 100644
--- a/application/pages/VersionPage.cpp
+++ b/application/pages/VersionPage.cpp
@@ -43,6 +43,9 @@
 
 #include "MultiMC.h"
 
+#include <meta/Index.h>
+#include <meta/VersionList.h>
+
 class IconProxy : public QIdentityProxyModel
 {
 	Q_OBJECT
@@ -372,7 +375,7 @@ int VersionPage::doUpdate()
 
 void VersionPage::on_forgeBtn_clicked()
 {
-	auto vlist = ENV.getVersionList("net.minecraftforge");
+	auto vlist = ENV.metadataIndex()->get("net.minecraftforge");
 	if(!vlist)
 	{
 		return;
@@ -391,7 +394,7 @@ void VersionPage::on_forgeBtn_clicked()
 
 void VersionPage::on_liteloaderBtn_clicked()
 {
-	auto vlist = ENV.getVersionList("com.liteloader");
+	auto vlist = ENV.metadataIndex()->get("com.liteloader");
 	if(!vlist)
 	{
 		return;
diff --git a/application/pages/global/PackagesPage.cpp b/application/pages/global/PackagesPage.cpp
index e4967532..e15ddbab 100644
--- a/application/pages/global/PackagesPage.cpp
+++ b/application/pages/global/PackagesPage.cpp
@@ -34,17 +34,15 @@ using namespace Meta;
 static QString formatRequires(const VersionPtr &version)
 {
 	QStringList lines;
-	for (const Reference &ref : version->requires())
+	auto & reqs = version->requires();
+	auto iter = reqs.begin();
+	while (iter != reqs.end())
 	{
-		const QString readable = ENV.metadataIndex()->hasUid(ref.uid()) ? ENV.metadataIndex()->get(ref.uid())->humanReadable() : ref.uid();
-		if (ref.version().isEmpty())
-		{
-			lines.append(readable);
-		}
-		else
-		{
-			lines.append(QString("%1 (%2)").arg(readable, ref.version()));
-		}
+		auto &uid = iter.key();
+		auto &version = iter.value();
+		const QString readable = ENV.metadataIndex()->hasUid(uid) ? ENV.metadataIndex()->get(uid)->humanReadable() : uid;
+		lines.append(QString("%1 (%2)").arg(readable, version));
+		iter++;
 	}
 	return lines.join('\n');
 }

From 3aa28bd64ad4efc0b9b2d5eaec66a460156895a9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= <peterix@gmail.com>
Date: Sun, 26 Mar 2017 20:40:03 +0200
Subject: [PATCH 15/28] NOISSUE fix some warning on linux related to the GNU C
 library

---
 api/logic/java/JavaVersion.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/api/logic/java/JavaVersion.h b/api/logic/java/JavaVersion.h
index deba5654..de13998c 100644
--- a/api/logic/java/JavaVersion.h
+++ b/api/logic/java/JavaVersion.h
@@ -3,6 +3,14 @@
 #include "multimc_logic_export.h"
 #include <QString>
 
+// NOTE: apparently the GNU C library pollutes the global namespace with these... undef them.
+#ifdef major
+	#undef major
+#endif
+#ifdef minor
+	#undef minor
+#endif
+
 class MULTIMC_LOGIC_EXPORT JavaVersion
 {
 	friend class JavaVersionTest;

From 6f2a87167a13101d80d2fbc096bbb6a5eb5ab0c9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= <peterix@gmail.com>
Date: Sun, 26 Mar 2017 20:50:31 +0200
Subject: [PATCH 16/28] NOISSUE remove some dead code from version related
 classes

---
 api/logic/meta/Version.h                             |  6 ------
 api/logic/minecraft/ProfilePatch.h                   | 10 ----------
 api/logic/minecraft/VersionFile.h                    |  4 ----
 api/logic/minecraft/onesix/OneSixProfileStrategy.cpp |  4 ----
 4 files changed, 24 deletions(-)

diff --git a/api/logic/meta/Version.h b/api/logic/meta/Version.h
index 1d921035..8aac8ea1 100644
--- a/api/logic/meta/Version.h
+++ b/api/logic/meta/Version.h
@@ -35,12 +35,6 @@ using VersionPtr = std::shared_ptr<class Version>;
 class MULTIMC_LOGIC_EXPORT Version : public QObject, public BaseVersion, public BaseEntity
 {
 	Q_OBJECT
-	Q_PROPERTY(QString uid READ uid CONSTANT)
-	Q_PROPERTY(QString parentUid READ parentUid)
-	Q_PROPERTY(QString version READ version CONSTANT)
-	Q_PROPERTY(QString type READ type NOTIFY typeChanged)
-	Q_PROPERTY(QDateTime time READ time NOTIFY timeChanged)
-	Q_PROPERTY(QHash<QString, QString> requires READ requires NOTIFY requiresChanged)
 
 public: /* con/des */
 	explicit Version(const QString &uid, const QString &version);
diff --git a/api/logic/minecraft/ProfilePatch.h b/api/logic/minecraft/ProfilePatch.h
index 6f63f3c4..699a38ae 100644
--- a/api/logic/minecraft/ProfilePatch.h
+++ b/api/logic/minecraft/ProfilePatch.h
@@ -15,14 +15,6 @@ enum ProblemSeverity
 	PROBLEM_ERROR
 };
 
-/// where is a version from?
-enum class VersionSource
-{
-	Builtin, //!< version loaded from the internal resources.
-	Local, //!< version loaded from a file in the cache.
-	Remote, //!< incomplete version on a remote server.
-};
-
 class PatchProblem
 {
 public:
@@ -70,8 +62,6 @@ public:
 
 	virtual QString getFilename() = 0;
 
-	virtual VersionSource getVersionSource() = 0;
-
 	virtual std::shared_ptr<class VersionFile> getVersionFile() = 0;
 
 	virtual const QList<PatchProblem>& getProblems()
diff --git a/api/logic/minecraft/VersionFile.h b/api/logic/minecraft/VersionFile.h
index 6a922d74..dad9a057 100644
--- a/api/logic/minecraft/VersionFile.h
+++ b/api/logic/minecraft/VersionFile.h
@@ -53,10 +53,6 @@ public: /* methods */
 	{
 		return m_releaseTime;
 	}
-	VersionSource getVersionSource() override
-	{
-		return VersionSource::Local;
-	}
 
 	std::shared_ptr<class VersionFile> getVersionFile() override
 	{
diff --git a/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp b/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
index 3a9b10e6..3f33dd7f 100644
--- a/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
+++ b/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
@@ -125,10 +125,6 @@ public:
 	{
 		return 0;
 	}
-	VersionSource getVersionSource() override
-	{
-		return VersionSource::Local;
-	}
 	bool isVersionChangeable() override
 	{
 		return true;

From 5fabb4f2546fa6b79a4e2c29679f506e587a0070 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= <peterix@gmail.com>
Date: Mon, 27 Mar 2017 03:34:39 +0200
Subject: [PATCH 17/28] NOISSUE Rough refactor of ProfilePatch and VersionFile
 internals.

They are now distinct classes with distinct responsibilities.

* ProfilePatch is an entry in MinecraftProfile and can hold VersionFile or Meta::Version.
* VersionFile is the basic element that holds version information loaded from JSON.
* Meta::Version is the loader class for VersionFile(s) from a server.
---
 api/logic/BaseVersionList.cpp                 |   2 +-
 api/logic/BaseVersionList.h                   |   2 +-
 api/logic/CMakeLists.txt                      |   1 +
 api/logic/ProblemProvider.h                   |  54 +++++
 api/logic/meta/Version.cpp                    |   2 +-
 api/logic/meta/VersionList.cpp                |   4 +-
 api/logic/minecraft/MinecraftProfile.cpp      |   6 +-
 api/logic/minecraft/MinecraftProfile.h        |   4 +-
 api/logic/minecraft/MojangVersionFormat.cpp   |  18 +-
 api/logic/minecraft/ProfilePatch.cpp          | 214 ++++++++++++++++++
 api/logic/minecraft/ProfilePatch.h            | 104 ++++-----
 api/logic/minecraft/ProfileStrategy.h         |   1 +
 api/logic/minecraft/ProfileUtils.cpp          |   4 +-
 api/logic/minecraft/VersionBuildError.h       |  17 --
 api/logic/minecraft/VersionFile.cpp           |  35 +--
 api/logic/minecraft/VersionFile.h             | 108 +--------
 .../minecraft/ftb/FTBProfileStrategy.cpp      |   8 +-
 api/logic/minecraft/onesix/OneSixInstance.cpp |   2 +-
 .../onesix/OneSixProfileStrategy.cpp          | 178 ++++-----------
 .../minecraft/onesix/OneSixVersionFormat.cpp  |  19 +-
 application/VersionProxyModel.cpp             |   6 +-
 application/pages/VersionPage.cpp             |  16 +-
 22 files changed, 431 insertions(+), 374 deletions(-)
 create mode 100644 api/logic/ProblemProvider.h
 create mode 100644 api/logic/minecraft/ProfilePatch.cpp

diff --git a/api/logic/BaseVersionList.cpp b/api/logic/BaseVersionList.cpp
index 5ad4df3c..dae604a2 100644
--- a/api/logic/BaseVersionList.cpp
+++ b/api/logic/BaseVersionList.cpp
@@ -93,7 +93,7 @@ QHash<int, QByteArray> BaseVersionList::roleNames() const
 	QHash<int, QByteArray> roles = QAbstractListModel::roleNames();
 	roles.insert(VersionRole, "version");
 	roles.insert(VersionIdRole, "versionId");
-	roles.insert(ParentGameVersionRole, "parentGameVersion");
+	roles.insert(ParentVersionRole, "parentGameVersion");
 	roles.insert(RecommendedRole, "recommended");
 	roles.insert(LatestRole, "latest");
 	roles.insert(TypeRole, "type");
diff --git a/api/logic/BaseVersionList.h b/api/logic/BaseVersionList.h
index 8afcae1d..eb3b622a 100644
--- a/api/logic/BaseVersionList.h
+++ b/api/logic/BaseVersionList.h
@@ -45,7 +45,7 @@ public:
 		VersionPointerRole = Qt::UserRole,
 		VersionRole,
 		VersionIdRole,
-		ParentGameVersionRole,
+		ParentVersionRole,
 		RecommendedRole,
 		LatestRole,
 		TypeRole,
diff --git a/api/logic/CMakeLists.txt b/api/logic/CMakeLists.txt
index 7f04a41e..da673c13 100644
--- a/api/logic/CMakeLists.txt
+++ b/api/logic/CMakeLists.txt
@@ -267,6 +267,7 @@ set(MINECRAFT_SOURCES
 	minecraft/VersionBuildError.h
 	minecraft/VersionFile.cpp
 	minecraft/VersionFile.h
+	minecraft/ProfilePatch.cpp
 	minecraft/ProfilePatch.h
 	minecraft/VersionFilterData.h
 	minecraft/VersionFilterData.cpp
diff --git a/api/logic/ProblemProvider.h b/api/logic/ProblemProvider.h
new file mode 100644
index 00000000..64a31c59
--- /dev/null
+++ b/api/logic/ProblemProvider.h
@@ -0,0 +1,54 @@
+#pragma once
+
+enum class ProblemSeverity
+{
+	None,
+	Warning,
+	Error
+};
+
+class PatchProblem
+{
+public:
+	PatchProblem(ProblemSeverity severity, const QString & description)
+	{
+		m_severity = severity;
+		m_description = description;
+	}
+	const QString & getDescription() const
+	{
+		return m_description;
+	}
+	const ProblemSeverity getSeverity() const
+	{
+		return m_severity;
+	}
+private:
+	ProblemSeverity m_severity;
+	QString m_description;
+};
+
+class ProblemProvider
+{
+public:
+	virtual const QList<PatchProblem>& getProblems()
+	{
+		return m_problems;
+	}
+	virtual void addProblem(ProblemSeverity severity, const QString &description)
+	{
+		if(severity > m_problemSeverity)
+		{
+			m_problemSeverity = severity;
+		}
+		m_problems.append(PatchProblem(severity, description));
+	}
+	virtual ProblemSeverity getProblemSeverity()
+	{
+		return m_problemSeverity;
+	}
+
+private:
+	QList<PatchProblem> m_problems;
+	ProblemSeverity m_problemSeverity = ProblemSeverity::None;
+};
diff --git a/api/logic/meta/Version.cpp b/api/logic/meta/Version.cpp
index af9d4f10..2a8e1780 100644
--- a/api/logic/meta/Version.cpp
+++ b/api/logic/meta/Version.cpp
@@ -32,7 +32,7 @@ QString Meta::Version::descriptor()
 QString Meta::Version::name()
 {
 	if(m_data)
-		return m_data->getName();
+		return m_data->name;
 	return m_uid;
 }
 QString Meta::Version::typeString() const
diff --git a/api/logic/meta/VersionList.cpp b/api/logic/meta/VersionList.cpp
index c2712155..41ed1352 100644
--- a/api/logic/meta/VersionList.cpp
+++ b/api/logic/meta/VersionList.cpp
@@ -73,7 +73,7 @@ QVariant VersionList::data(const QModelIndex &index, int role) const
 	case VersionRole:
 	case VersionIdRole:
 		return version->version();
-	case ParentGameVersionRole:
+	case ParentVersionRole:
 	{
 		auto parentUid = this->parentUid();
 		if(parentUid.isEmpty())
@@ -102,7 +102,7 @@ QVariant VersionList::data(const QModelIndex &index, int role) const
 
 BaseVersionList::RoleList VersionList::providesRoles() const
 {
-	return {VersionPointerRole, VersionRole, VersionIdRole, ParentGameVersionRole,
+	return {VersionPointerRole, VersionRole, VersionIdRole, ParentVersionRole,
 				TypeRole, UidRole, TimeRole, RequiresRole, SortRole,
 				RecommendedRole, LatestRole, VersionPtrRole};
 }
diff --git a/api/logic/minecraft/MinecraftProfile.cpp b/api/logic/minecraft/MinecraftProfile.cpp
index b74141d6..8638f5fa 100644
--- a/api/logic/minecraft/MinecraftProfile.cpp
+++ b/api/logic/minecraft/MinecraftProfile.cpp
@@ -80,7 +80,7 @@ void MinecraftProfile::clear()
 	m_traits.clear();
 	m_jarMods.clear();
 	mojangDownloads.clear();
-	m_problemSeverity = ProblemSeverity::PROBLEM_NONE;
+	m_problemSeverity = ProblemSeverity::None;
 }
 
 void MinecraftProfile::clearPatches()
@@ -273,9 +273,9 @@ QVariant MinecraftProfile::data(const QModelIndex &index, int role) const
 			auto severity = patch->getProblemSeverity();
 			switch (severity)
 			{
-				case PROBLEM_WARNING:
+				case ProblemSeverity::Warning:
 					return "warning";
-				case PROBLEM_ERROR:
+				case ProblemSeverity::Error:
 					return "error";
 				default:
 					return QVariant();
diff --git a/api/logic/minecraft/MinecraftProfile.h b/api/logic/minecraft/MinecraftProfile.h
index a6845e9c..a3b8fb61 100644
--- a/api/logic/minecraft/MinecraftProfile.h
+++ b/api/logic/minecraft/MinecraftProfile.h
@@ -22,7 +22,7 @@
 #include <memory>
 
 #include "Library.h"
-#include "VersionFile.h"
+#include "ProfilePatch.h"
 #include "JarMod.h"
 #include "BaseVersion.h"
 #include "MojangDownloadInfo.h"
@@ -175,7 +175,7 @@ private: /* data */
 	/// A list of jar mods. version files can add those.
 	QList<JarmodPtr> m_jarMods;
 
-	ProblemSeverity m_problemSeverity = PROBLEM_NONE;
+	ProblemSeverity m_problemSeverity = ProblemSeverity::None;
 
 	/*
 	FIXME: add support for those rules here? Looks like a pile of quick hacks to me though.
diff --git a/api/logic/minecraft/MojangVersionFormat.cpp b/api/logic/minecraft/MojangVersionFormat.cpp
index 651e2fbc..ea8dcd4d 100644
--- a/api/logic/minecraft/MojangVersionFormat.cpp
+++ b/api/logic/minecraft/MojangVersionFormat.cpp
@@ -151,7 +151,7 @@ void MojangVersionFormat::readVersionProperties(const QJsonObject &in, VersionFi
 		}
 		else if (!toCompare.isEmpty())
 		{
-			out->addProblem(PROBLEM_ERROR, QObject::tr("processArguments is set to unknown value '%1'").arg(processArguments));
+			out->addProblem(ProblemSeverity::Error, QObject::tr("processArguments is set to unknown value '%1'").arg(processArguments));
 		}
 	}
 	Bits::readString(in, "type", out->type);
@@ -166,8 +166,8 @@ void MojangVersionFormat::readVersionProperties(const QJsonObject &in, VersionFi
 		out->mojangAssetIndex = std::make_shared<MojangAssetIndexInfo>(out->assets);
 	}
 
-	out->m_releaseTime = timeFromS3Time(in.value("releaseTime").toString(""));
-	out->m_updateTime = timeFromS3Time(in.value("time").toString(""));
+	out->releaseTime = timeFromS3Time(in.value("releaseTime").toString(""));
+	out->updateTime = timeFromS3Time(in.value("time").toString(""));
 
 	if (in.contains("minimumLauncherVersion"))
 	{
@@ -175,7 +175,7 @@ void MojangVersionFormat::readVersionProperties(const QJsonObject &in, VersionFi
 		if (out->minimumLauncherVersion > CURRENT_MINIMUM_LAUNCHER_VERSION)
 		{
 			out->addProblem(
-				PROBLEM_WARNING,
+				ProblemSeverity::Warning,
 				QObject::tr("The 'minimumLauncherVersion' value of this version (%1) is higher than supported by MultiMC (%2). It might not work properly!")
 					.arg(out->minimumLauncherVersion)
 					.arg(CURRENT_MINIMUM_LAUNCHER_VERSION));
@@ -212,7 +212,7 @@ VersionFilePtr MojangVersionFormat::versionFileFromJson(const QJsonDocument &doc
 	out->name = "Minecraft";
 	out->uid = "net.minecraft";
 	out->version = out->minecraftVersion;
-	out->filename = filename;
+	// out->filename = filename;
 
 
 	if (root.contains("libraries"))
@@ -234,13 +234,13 @@ void MojangVersionFormat::writeVersionProperties(const VersionFile* in, QJsonObj
 	writeString(out, "mainClass", in->mainClass);
 	writeString(out, "minecraftArguments", in->minecraftArguments);
 	writeString(out, "type", in->type);
-	if(!in->m_releaseTime.isNull())
+	if(!in->releaseTime.isNull())
 	{
-		writeString(out, "releaseTime", timeToS3Time(in->m_releaseTime));
+		writeString(out, "releaseTime", timeToS3Time(in->releaseTime));
 	}
-	if(!in->m_updateTime.isNull())
+	if(!in->updateTime.isNull())
 	{
-		writeString(out, "time", timeToS3Time(in->m_updateTime));
+		writeString(out, "time", timeToS3Time(in->updateTime));
 	}
 	if(in->minimumLauncherVersion != -1)
 	{
diff --git a/api/logic/minecraft/ProfilePatch.cpp b/api/logic/minecraft/ProfilePatch.cpp
new file mode 100644
index 00000000..0ff5895d
--- /dev/null
+++ b/api/logic/minecraft/ProfilePatch.cpp
@@ -0,0 +1,214 @@
+#include "ProfilePatch.h"
+
+#include "meta/Version.h"
+#include "VersionFile.h"
+
+ProfilePatch::ProfilePatch(std::shared_ptr<Meta::Version> version)
+	:m_metaVersion(version)
+{
+}
+
+ProfilePatch::ProfilePatch(std::shared_ptr<VersionFile> file, const QString& filename)
+	:m_file(file), m_filename(filename)
+{
+}
+
+void ProfilePatch::applyTo(MinecraftProfile* profile)
+{
+	auto vfile = getVersionFile();
+	if(vfile)
+	{
+		vfile->applyTo(profile);
+	}
+}
+
+std::shared_ptr<class VersionFile> ProfilePatch::getVersionFile()
+{
+	if(m_metaVersion)
+	{
+		if(!m_metaVersion->isLoaded())
+		{
+			m_metaVersion->load();
+		}
+		return m_metaVersion->data();
+	}
+	return m_file;
+}
+
+int ProfilePatch::getOrder()
+{
+	if(m_orderOverride)
+		return m_order;
+
+	auto vfile = getVersionFile();
+	if(vfile)
+	{
+		return vfile->order;
+	}
+	return 0;
+}
+void ProfilePatch::setOrder(int order)
+{
+	m_orderOverride = true;
+	m_order = order;
+}
+QString ProfilePatch::getID()
+{
+	if(m_metaVersion)
+		return m_metaVersion->uid();
+	return getVersionFile()->uid;
+}
+QString ProfilePatch::getName()
+{
+	if(m_metaVersion)
+		return m_metaVersion->name();
+	return getVersionFile()->name;
+}
+QString ProfilePatch::getVersion()
+{
+	if(m_metaVersion)
+		return m_metaVersion->version();
+	return getVersionFile()->version;
+}
+QString ProfilePatch::getFilename()
+{
+	return m_filename;
+}
+QDateTime ProfilePatch::getReleaseDateTime()
+{
+	if(m_metaVersion)
+	{
+		return m_metaVersion->time();
+	}
+	return getVersionFile()->releaseTime;
+}
+
+bool ProfilePatch::isCustom()
+{
+	return !m_isVanilla;
+};
+
+bool ProfilePatch::isCustomizable()
+{
+	if(m_metaVersion)
+	{
+		if(getVersionFile())
+		{
+			return true;
+		}
+	}
+	return false;
+}
+bool ProfilePatch::isRemovable()
+{
+	return m_isRemovable;
+}
+bool ProfilePatch::isRevertible()
+{
+	return m_isRevertible;
+}
+bool ProfilePatch::isMoveable()
+{
+	return m_isMovable;
+}
+bool ProfilePatch::isVersionChangeable()
+{
+	return false;
+}
+
+void ProfilePatch::setVanilla (bool state)
+{
+	m_isVanilla = state;
+}
+void ProfilePatch::setRemovable (bool state)
+{
+	m_isRemovable = state;
+}
+void ProfilePatch::setRevertible (bool state)
+{
+	m_isRevertible = state;
+}
+void ProfilePatch::setMovable (bool state)
+{
+	m_isMovable = state;
+}
+
+/*
+class MetaPatchProvider : public ProfilePatch
+{
+public:
+	MetaPatchProvider(std::shared_ptr<Meta::Version> data)
+		:m_version(data)
+	{
+	}
+public:
+	QString getFilename() override
+	{
+		return QString();
+	}
+	QString getID() override
+	{
+		return m_version->uid();
+	}
+	QString getName() override
+	{
+		auto vfile = getFile();
+		if(vfile)
+		{
+			return vfile->name;
+		}
+		return m_version->name();
+	}
+	QDateTime getReleaseDateTime() override
+	{
+		return m_version->time();
+	}
+	QString getVersion() override
+	{
+		return m_version->version();
+	}
+	std::shared_ptr<class VersionFile> getVersionFile() override
+	{
+		return m_version->data();
+	}
+	void setOrder(int) override
+	{
+	}
+	int getOrder() override
+	{
+		return 0;
+	}
+	bool isVersionChangeable() override
+	{
+		return true;
+	}
+	bool isRevertible() override
+	{
+		return false;
+	}
+	bool isRemovable() override
+	{
+		return true;
+	}
+	bool isCustom() override
+	{
+		return false;
+	}
+	bool isCustomizable() override
+	{
+		return true;
+	}
+	bool isMoveable() override
+	{
+		return true;
+	}
+
+private:
+	VersionFilePtr getFile()
+	{
+
+	}
+private:
+	std::shared_ptr<Meta::Version> m_version;
+};
+*/
\ No newline at end of file
diff --git a/api/logic/minecraft/ProfilePatch.h b/api/logic/minecraft/ProfilePatch.h
index 699a38ae..9e2555af 100644
--- a/api/logic/minecraft/ProfilePatch.h
+++ b/api/logic/minecraft/ProfilePatch.h
@@ -5,85 +5,63 @@
 #include <QJsonDocument>
 #include <QDateTime>
 #include "JarMod.h"
+#include "ProblemProvider.h"
 
 class MinecraftProfile;
-
-enum ProblemSeverity
+namespace Meta
 {
-	PROBLEM_NONE,
-	PROBLEM_WARNING,
-	PROBLEM_ERROR
-};
+	class Version;
+}
+class VersionFile;
 
-class PatchProblem
+class ProfilePatch : public ProblemProvider
 {
 public:
-	PatchProblem(ProblemSeverity severity, const QString & description)
-	{
-		m_severity = severity;
-		m_description = description;
-	}
-	const QString & getDescription() const
-	{
-		return m_description;
-	}
-	const ProblemSeverity getSeverity() const
-	{
-		return m_severity;
-	}
-private:
-	ProblemSeverity m_severity;
-	QString m_description;
-};
+	ProfilePatch(std::shared_ptr<Meta::Version> version);
+	ProfilePatch(std::shared_ptr<VersionFile> file, const QString &filename = QString());
 
-class ProfilePatch : public std::enable_shared_from_this<ProfilePatch>
-{
-public:
 	virtual ~ProfilePatch(){};
-	virtual void applyTo(MinecraftProfile *profile) = 0;
+	virtual void applyTo(MinecraftProfile *profile);
 
-	virtual bool isMinecraftVersion() = 0;
+	virtual bool isMoveable();
+	virtual bool isCustomizable();
+	virtual bool isRevertible();
+	virtual bool isRemovable();
+	virtual bool isCustom();
+	virtual bool isVersionChangeable();
 
-	virtual bool isMoveable() = 0;
-	virtual bool isCustomizable() = 0;
-	virtual bool isRevertible() = 0;
-	virtual bool isRemovable() = 0;
-	virtual bool isCustom() = 0;
-	virtual bool isEditable() = 0;
-	virtual bool isVersionChangeable() = 0;
+	virtual void setOrder(int order);
+	virtual int getOrder();
 
-	virtual void setOrder(int order) = 0;
-	virtual int getOrder() = 0;
+	virtual QString getID();
+	virtual QString getName();
+	virtual QString getVersion();
+	virtual QDateTime getReleaseDateTime();
 
-	virtual QString getID() = 0;
-	virtual QString getName() = 0;
-	virtual QString getVersion() = 0;
-	virtual QDateTime getReleaseDateTime() = 0;
+	virtual QString getFilename();
 
-	virtual QString getFilename() = 0;
+	virtual std::shared_ptr<class VersionFile> getVersionFile();
 
-	virtual std::shared_ptr<class VersionFile> getVersionFile() = 0;
-
-	virtual const QList<PatchProblem>& getProblems()
-	{
-		return m_problems;
-	}
-	virtual void addProblem(ProblemSeverity severity, const QString &description)
-	{
-		if(severity > m_problemSeverity)
-		{
-			m_problemSeverity = severity;
-		}
-		m_problems.append(PatchProblem(severity, description));
-	}
-	virtual ProblemSeverity getProblemSeverity()
-	{
-		return m_problemSeverity;
-	}
+	void setVanilla (bool state);
+	void setRemovable (bool state);
+	void setRevertible (bool state);
+	void setCustomizable (bool state);
+	void setMovable (bool state);
 
 protected:
-	QList<PatchProblem> m_problems;
-	ProblemSeverity m_problemSeverity = PROBLEM_NONE;
+	// Properties for UI and version manipulation from UI in general
+	bool m_isMovable = false;
+	bool m_isCustomizable = false;
+	bool m_isRevertible = false;
+	bool m_isRemovable = false;
+	bool m_isVanilla = false;
+
+	bool m_orderOverride = false;
+	int m_order = 0;
+
+	std::shared_ptr<Meta::Version> m_metaVersion;
+	std::shared_ptr<VersionFile> m_file;
+	QString m_filename;
 };
 
 typedef std::shared_ptr<ProfilePatch> ProfilePatchPtr;
diff --git a/api/logic/minecraft/ProfileStrategy.h b/api/logic/minecraft/ProfileStrategy.h
index b4dfc4b3..26bdf661 100644
--- a/api/logic/minecraft/ProfileStrategy.h
+++ b/api/logic/minecraft/ProfileStrategy.h
@@ -1,6 +1,7 @@
 #pragma once
 
 #include "ProfileUtils.h"
+#include "ProfilePatch.h"
 
 class MinecraftProfile;
 
diff --git a/api/logic/minecraft/ProfileUtils.cpp b/api/logic/minecraft/ProfileUtils.cpp
index c7c56dd6..8c5bc052 100644
--- a/api/logic/minecraft/ProfileUtils.cpp
+++ b/api/logic/minecraft/ProfileUtils.cpp
@@ -103,8 +103,8 @@ static VersionFilePtr createErrorVersionFile(QString fileId, QString filepath, Q
 {
 	auto outError = std::make_shared<VersionFile>();
 	outError->uid = outError->name = fileId;
-	outError->filename = filepath;
-	outError->addProblem(PROBLEM_ERROR, error);
+	// outError->filename = filepath;
+	outError->addProblem(ProblemSeverity::Error, error);
 	return outError;
 }
 
diff --git a/api/logic/minecraft/VersionBuildError.h b/api/logic/minecraft/VersionBuildError.h
index fda453e5..f362c405 100644
--- a/api/logic/minecraft/VersionBuildError.h
+++ b/api/logic/minecraft/VersionBuildError.h
@@ -26,23 +26,6 @@ public:
 	}
 };
 
-/**
- * some patch was intended for a different version of minecraft
- */
-class MinecraftVersionMismatch : public VersionBuildError
-{
-public:
-	MinecraftVersionMismatch(QString fileId, QString mcVersion, QString parentMcVersion)
-		: VersionBuildError(QObject::tr("The patch %1 is for a different version of Minecraft "
-										"(%2) than that of the instance (%3).")
-								.arg(fileId)
-								.arg(mcVersion)
-								.arg(parentMcVersion)) {};
-	virtual ~MinecraftVersionMismatch() noexcept
-	{
-	}
-};
-
 /**
  * files required for the version are not (yet?) present
  */
diff --git a/api/logic/minecraft/VersionFile.cpp b/api/logic/minecraft/VersionFile.cpp
index 17dc6a49..b261ff2a 100644
--- a/api/logic/minecraft/VersionFile.cpp
+++ b/api/logic/minecraft/VersionFile.cpp
@@ -12,32 +12,28 @@
 #include "VersionBuildError.h"
 #include <Version.h>
 
-bool VersionFile::isMinecraftVersion()
+static bool isMinecraftVersion(const QString &uid)
 {
 	return uid == "net.minecraft";
 }
 
 void VersionFile::applyTo(MinecraftProfile *profile)
 {
-	auto theirVersion = profile->getMinecraftVersion();
-	if (!theirVersion.isNull() && !dependsOnMinecraftVersion.isNull())
+	// Only real Minecraft can set those. Don't let anything override them.
+	if (isMinecraftVersion(uid))
 	{
-		if (QRegExp(dependsOnMinecraftVersion, Qt::CaseInsensitive, QRegExp::Wildcard).indexIn(theirVersion) == -1)
-		{
-			throw MinecraftVersionMismatch(uid, dependsOnMinecraftVersion, theirVersion);
-		}
+		profile->applyMinecraftVersion(minecraftVersion);
+		profile->applyMinecraftVersionType(type);
+		// HACK: ignore assets from other version files than Minecraft
+		// workaround for stupid assets issue caused by amazon:
+		// https://www.theregister.co.uk/2017/02/28/aws_is_awol_as_s3_goes_haywire/
+		profile->applyMinecraftAssets(mojangAssetIndex);
 	}
-	profile->applyMinecraftVersion(minecraftVersion);
+
 	profile->applyMainClass(mainClass);
 	profile->applyAppletClass(appletClass);
 	profile->applyMinecraftArguments(minecraftArguments);
-	if (isMinecraftVersion())
-	{
-		profile->applyMinecraftVersionType(type);
-	}
-	profile->applyMinecraftAssets(mojangAssetIndex);
 	profile->applyTweakers(addTweakers);
-
 	profile->applyJarMods(jarMods);
 	profile->applyTraits(traits);
 
@@ -53,3 +49,14 @@ void VersionFile::applyTo(MinecraftProfile *profile)
 		iter++;
 	}
 }
+
+/*
+	auto theirVersion = profile->getMinecraftVersion();
+	if (!theirVersion.isNull() && !dependsOnMinecraftVersion.isNull())
+	{
+		if (QRegExp(dependsOnMinecraftVersion, Qt::CaseInsensitive, QRegExp::Wildcard).indexIn(theirVersion) == -1)
+		{
+			throw MinecraftVersionMismatch(uid, dependsOnMinecraftVersion, theirVersion);
+		}
+	}
+*/
\ No newline at end of file
diff --git a/api/logic/minecraft/VersionFile.h b/api/logic/minecraft/VersionFile.h
index dad9a057..a71c6228 100644
--- a/api/logic/minecraft/VersionFile.h
+++ b/api/logic/minecraft/VersionFile.h
@@ -8,7 +8,7 @@
 #include <memory>
 #include "minecraft/OpSys.h"
 #include "minecraft/Rule.h"
-#include "ProfilePatch.h"
+#include "ProblemProvider.h"
 #include "Library.h"
 #include "JarMod.h"
 
@@ -18,111 +18,19 @@ struct MojangDownloadInfo;
 struct MojangAssetIndexInfo;
 
 typedef std::shared_ptr<VersionFile> VersionFilePtr;
-class VersionFile : public ProfilePatch
+class VersionFile : public ProblemProvider
 {
 	friend class MojangVersionFormat;
 	friend class OneSixVersionFormat;
 public: /* methods */
-	virtual void applyTo(MinecraftProfile *profile) override;
-	virtual bool isMinecraftVersion() override;
-	virtual int getOrder() override
-	{
-		return order;
-	}
-	virtual void setOrder(int order) override
-	{
-		this->order = order;
-	}
-	virtual QString getID() override
-	{
-		return uid;
-	}
-	virtual QString getName() override
-	{
-		return name;
-	}
-	virtual QString getVersion() override
-	{
-		return version;
-	}
-	virtual QString getFilename() override
-	{
-		return filename;
-	}
-	virtual QDateTime getReleaseDateTime() override
-	{
-		return m_releaseTime;
-	}
-
-	std::shared_ptr<class VersionFile> getVersionFile() override
-	{
-		return std::dynamic_pointer_cast<VersionFile>(shared_from_this());
-	}
-
-	virtual bool isCustom() override
-	{
-		return !m_isVanilla;
-	};
-	virtual bool isCustomizable() override
-	{
-		return m_isCustomizable;
-	}
-	virtual bool isRemovable() override
-	{
-		return m_isRemovable;
-	}
-	virtual bool isRevertible() override
-	{
-		return m_isRevertible;
-	}
-    virtual bool isMoveable() override
-	{
-		return m_isMovable;
-	}
-    virtual bool isEditable() override
-	{
-		return isCustom();
-	}
-	virtual bool isVersionChangeable() override
-	{
-		return false;
-	}
-
-	void setVanilla (bool state)
-	{
-		m_isVanilla = state;
-	}
-	void setRemovable (bool state)
-	{
-		m_isRemovable = state;
-	}
-	void setRevertible (bool state)
-	{
-		m_isRevertible = state;
-	}
-	void setCustomizable (bool state)
-	{
-		m_isCustomizable = state;
-	}
-	void setMovable (bool state)
-	{
-		m_isMovable = state;
-	}
-
+	void applyTo(MinecraftProfile *profile);
 
 public: /* data */
-	// Flags for UI and version file manipulation in general
-	bool m_isVanilla = false;
-	bool m_isRemovable = false;
-	bool m_isRevertible = false;
-	bool m_isCustomizable = false;
-	bool m_isMovable = false;
-
 	/// MultiMC: order hint for this version file if no explicit order is set
 	int order = 0;
 
 	/// MultiMC: filename of the file this was loaded from
-	QString filename;
+	// QString filename;
 
 	/// MultiMC: human readable name of this package
 	QString name;
@@ -139,13 +47,13 @@ public: /* data */
 	/// Mojang: used to version the Mojang version format
 	int minimumLauncherVersion = -1;
 
-	/// Mojang: version of Minecraft this is
+	/// Mojang: DEPRECATED version of Minecraft this is
 	QString minecraftVersion;
 
 	/// Mojang: class to launch Minecraft with
 	QString mainClass;
 
-	/// MultiMC: DEPRECATED class to launch legacy Minecraft with (ambed in a custom window)
+	/// MultiMC: class to launch legacy Minecraft with (embed in a custom window)
 	QString appletClass;
 
 	/// Mojang: Minecraft launch arguments (may contain placeholders for variable substitution)
@@ -155,10 +63,10 @@ public: /* data */
 	QString type;
 
 	/// Mojang: the time this version was actually released by Mojang
-	QDateTime m_releaseTime;
+	QDateTime releaseTime;
 
 	/// Mojang: the time this version was last updated by Mojang
-	QDateTime m_updateTime;
+	QDateTime updateTime;
 
 	/// Mojang: DEPRECATED asset group to be used with Minecraft
 	QString assets;
diff --git a/api/logic/minecraft/ftb/FTBProfileStrategy.cpp b/api/logic/minecraft/ftb/FTBProfileStrategy.cpp
index 45765cd4..c3d9cc6a 100644
--- a/api/logic/minecraft/ftb/FTBProfileStrategy.cpp
+++ b/api/logic/minecraft/ftb/FTBProfileStrategy.cpp
@@ -29,7 +29,6 @@ void FTBProfileStrategy::loadDefaultBuiltinPatches()
 			auto file = ProfileUtils::parseJsonFile(QFileInfo(mcJson), false);
 			file->uid = "net.minecraft";
 			file->name = QObject::tr("Minecraft (tracked)");
-			file->setVanilla(true);
 			if(file->version.isEmpty())
 			{
 				file->version = mcVersion;
@@ -39,7 +38,8 @@ void FTBProfileStrategy::loadDefaultBuiltinPatches()
 				addLib->setHint("local");
 				addLib->setStoragePrefix(nativeInstance->librariesPath().absolutePath());
 			}
-			minecraftPatch = std::dynamic_pointer_cast<ProfilePatch>(file);
+			minecraftPatch = std::make_shared<ProfilePatch>(file);
+			minecraftPatch->setVanilla(true);
 		}
 		else
 		{
@@ -65,7 +65,6 @@ void FTBProfileStrategy::loadDefaultBuiltinPatches()
 				addLib->setStoragePrefix(nativeInstance->librariesPath().absolutePath());
 			}
 			file->uid = "org.multimc.ftb.pack";
-			file->setVanilla(true);
 			file->name = QObject::tr("%1 (FTB pack)").arg(m_instance->name());
 			if(file->version.isEmpty())
 			{
@@ -81,7 +80,8 @@ void FTBProfileStrategy::loadDefaultBuiltinPatches()
 					}
 				}
 			}
-			packPatch = std::dynamic_pointer_cast<ProfilePatch>(file);
+			packPatch = std::make_shared<ProfilePatch>(file);
+			packPatch->setVanilla(true);
 		}
 		else
 		{
diff --git a/api/logic/minecraft/onesix/OneSixInstance.cpp b/api/logic/minecraft/onesix/OneSixInstance.cpp
index b471ff3e..6e4a5bdc 100644
--- a/api/logic/minecraft/onesix/OneSixInstance.cpp
+++ b/api/logic/minecraft/onesix/OneSixInstance.cpp
@@ -523,7 +523,7 @@ QString OneSixInstance::currentVersionId() const
 void OneSixInstance::reloadProfile()
 {
 	m_profile->reload();
-	setVersionBroken(m_profile->getProblemSeverity() == ProblemSeverity::PROBLEM_ERROR);
+	setVersionBroken(m_profile->getProblemSeverity() == ProblemSeverity::Error);
 	emit versionReloaded();
 }
 
diff --git a/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp b/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
index 3f33dd7f..a9cad832 100644
--- a/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
+++ b/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
@@ -15,6 +15,8 @@
 #include <meta/Index.h>
 #include <meta/Version.h>
 
+#include <tuple>
+
 OneSixProfileStrategy::OneSixProfileStrategy(OneSixInstance* instance)
 {
 	m_instance = instance;
@@ -81,103 +83,6 @@ void OneSixProfileStrategy::upgradeDeprecatedFiles()
 	}
 }
 
-class MetaPatchProvider : public ProfilePatch
-{
-public: /* con/des */
-	MetaPatchProvider(std::shared_ptr<Meta::Version> data)
-		:m_version(data)
-	{
-	}
-public:
-	QString getFilename() override
-	{
-		return QString();
-	}
-	QString getID() override
-	{
-		return m_version->uid();
-	}
-	QString getName() override
-	{
-		auto vfile = getFile();
-		if(vfile)
-		{
-			return vfile->getName();
-		}
-		return m_version->name();
-	}
-	QDateTime getReleaseDateTime() override
-	{
-		return m_version->time();
-	}
-	QString getVersion() override
-	{
-		return m_version->version();
-	}
-	std::shared_ptr<class VersionFile> getVersionFile() override
-	{
-		return m_version->data();
-	}
-	void setOrder(int) override
-	{
-	}
-	int getOrder() override
-	{
-		return 0;
-	}
-	bool isVersionChangeable() override
-	{
-		return true;
-	}
-	bool isRevertible() override
-	{
-		return false;
-	}
-	bool isRemovable() override
-	{
-		return true;
-	}
-	bool isCustom() override
-	{
-		return false;
-	}
-	bool isCustomizable() override
-	{
-		return true;
-	}
-	bool isMoveable() override
-	{
-		return true;
-	}
-	bool isEditable() override
-	{
-		return false;
-	}
-	bool isMinecraftVersion() override
-	{
-		return getID() == "net.minecraft";
-	}
-	void applyTo(MinecraftProfile * profile) override
-	{
-		auto vfile = getFile();
-		if(vfile)
-		{
-			vfile->applyTo(profile);
-		}
-	}
-private:
-	VersionFilePtr getFile()
-	{
-		if(!m_version->isLoaded())
-		{
-			m_version->load();
-		}
-		return m_version->data();
-	}
-private:
-	std::shared_ptr<Meta::Version> m_version;
-};
-
 void OneSixProfileStrategy::loadDefaultBuiltinPatches()
 {
 	{
@@ -191,14 +96,15 @@ void OneSixProfileStrategy::loadDefaultBuiltinPatches()
 			{
 				file->version = m_instance->intendedVersionId();
 			}
-			file->setVanilla(false);
-			file->setRevertible(true);
-			minecraftPatch = std::dynamic_pointer_cast<ProfilePatch>(file);
+			minecraftPatch = std::make_shared<ProfilePatch>(file, mcJson);
+			minecraftPatch->setVanilla(false);
+			minecraftPatch->setRevertible(true);
 		}
 		else
 		{
 			auto mcversion = ENV.metadataIndex()->get("net.minecraft", m_instance->intendedVersionId());
-			minecraftPatch = std::make_shared<MetaPatchProvider>(mcversion);
+			minecraftPatch = std::make_shared<ProfilePatch>(mcversion);
+			minecraftPatch->setVanilla(true);
 		}
 		if (!minecraftPatch)
 		{
@@ -214,14 +120,15 @@ void OneSixProfileStrategy::loadDefaultBuiltinPatches()
 		if(QFile::exists(lwjglJson))
 		{
 			auto file = ProfileUtils::parseJsonFile(QFileInfo(lwjglJson), false);
-			file->setVanilla(false);
-			file->setRevertible(true);
-			lwjglPatch = std::dynamic_pointer_cast<ProfilePatch>(file);
+			lwjglPatch = std::make_shared<ProfilePatch>(file, lwjglJson);
+			lwjglPatch->setVanilla(false);
+			lwjglPatch->setRevertible(true);
 		}
 		else
 		{
 			auto lwjglversion = ENV.metadataIndex()->get("org.lwjgl", "2.9.1");
-			lwjglPatch = std::make_shared<MetaPatchProvider>(lwjglversion);
+			lwjglPatch = std::make_shared<ProfilePatch>(lwjglversion);
+			lwjglPatch->setVanilla(true);
 		}
 		if (!lwjglPatch)
 		{
@@ -261,21 +168,17 @@ void OneSixProfileStrategy::loadUserPatches()
 		// sanity check. prevent tampering with files.
 		if (file->uid != id)
 		{
-			file->addProblem(PROBLEM_WARNING, QObject::tr("load id %1 does not match internal id %2").arg(id, file->uid));
+			file->addProblem(ProblemSeverity::Warning, QObject::tr("load id %1 does not match internal id %2").arg(id, file->uid));
 			seen_extra.insert(file->uid);
 		}
-		file->setRemovable(true);
-		file->setMovable(true);
-		// HACK: ignore assets from other version files than Minecraft
-		// workaround for stupid assets issue caused by amazon:
-		// https://www.theregister.co.uk/2017/02/28/aws_is_awol_as_s3_goes_haywire/
-		file->assets = QString();
-		file->mojangAssetIndex.reset();
-		// HACK
-		profile->appendPatch(file);
+		auto patchEntry = std::make_shared<ProfilePatch>(file, filename);
+		patchEntry->setRemovable(true);
+		patchEntry->setMovable(true);
+		profile->appendPatch(patchEntry);
 	}
 	// now load the rest by internal preference.
-	QMultiMap<int, VersionFilePtr> files;
+	using FileEntry = std::tuple<VersionFilePtr, QString>;
+	QMultiMap<int, FileEntry> files;
 	for (auto info : patches.entryInfoList(QStringList() << "*.json", QDir::Files))
 	{
 		// parse the file
@@ -292,16 +195,18 @@ void OneSixProfileStrategy::loadUserPatches()
 		// do not load what we already loaded in the first pass
 		if (userOrder.contains(file->uid))
 			continue;
-		file->setRemovable(true);
-		file->setMovable(true);
-		// HACK: ignore assets from other version files than Minecraft
-		// workaround for stupid assets issue caused by amazon:
-		// https://www.theregister.co.uk/2017/02/28/aws_is_awol_as_s3_goes_haywire/
-		file->assets = QString();
-		file->mojangAssetIndex.reset();
-		// HACK
-		files.insert(file->getOrder(), file);
+		files.insert(file->order, std::make_tuple(file, info.filePath()));
 	}
+	auto appendFilePatch = [&](FileEntry tuple)
+	{
+		VersionFilePtr file;
+		QString filename;
+		std::tie(file, filename) = tuple;
+		auto patchEntry = std::make_shared<ProfilePatch>(file, filename);
+		patchEntry->setRemovable(true);
+		patchEntry->setMovable(true);
+		profile->appendPatch(patchEntry);
+	};
 	QSet<int> seen;
 	for (auto order : files.keys())
 	{
@@ -311,7 +216,7 @@ void OneSixProfileStrategy::loadUserPatches()
 		const auto &values = files.values(order);
 		if(values.size() == 1)
 		{
-			profile->appendPatch(values[0]);
+			appendFilePatch(values[0]);
 			continue;
 		}
 		for(auto &file: values)
@@ -320,10 +225,13 @@ void OneSixProfileStrategy::loadUserPatches()
 			for(auto &file2: values)
 			{
 				if(file != file2)
-					list.append(file2->name);
+				{
+					list.append(std::get<0>(file2)->name);
+				}
 			}
-			file->addProblem(PROBLEM_WARNING, QObject::tr("%1 has the same order as the following components:\n%2").arg(file->name, list.join(", ")));
-			profile->appendPatch(file);
+			auto vfileptr = std::get<0>(file);
+			vfileptr->addProblem(ProblemSeverity::Warning, QObject::tr("%1 has the same order as the following components:\n%2").arg(vfileptr->name, list.join(", ")));
+			appendFilePatch(file);
 		}
 	}
 }
@@ -503,11 +411,9 @@ bool OneSixProfileStrategy::installJarMods(QStringList filepaths)
 		f->jarMods.append(jarMod);
 		f->name = target_name;
 		f->uid = target_id;
-		f->setOrder(profile->getFreeOrderNumber());
+		f->order = profile->getFreeOrderNumber();
 		QString patchFileName = FS::PathCombine(patchDir, target_id + ".json");
-		f->filename = patchFileName;
-		f->setMovable(true);
-		f->setRemovable(true);
+		// f->filename = patchFileName;
 
 		QFile file(patchFileName);
 		if (!file.open(QFile::WriteOnly))
@@ -518,7 +424,11 @@ bool OneSixProfileStrategy::installJarMods(QStringList filepaths)
 		}
 		file.write(OneSixVersionFormat::versionFileToJson(f, true).toJson());
 		file.close();
-		profile->appendPatch(f);
+
+		auto patch = std::make_shared<ProfilePatch>(f);
+		patch->setMovable(true);
+		patch->setRemovable(true);
+		profile->appendPatch(patch);
 	}
 	profile->saveCurrentOrder();
 	profile->reapplyPatches();
diff --git a/api/logic/minecraft/onesix/OneSixVersionFormat.cpp b/api/logic/minecraft/onesix/OneSixVersionFormat.cpp
index 944e68a4..266bd4bd 100644
--- a/api/logic/minecraft/onesix/OneSixVersionFormat.cpp
+++ b/api/logic/minecraft/onesix/OneSixVersionFormat.cpp
@@ -51,7 +51,7 @@ VersionFilePtr OneSixVersionFormat::versionFileFromJson(const QJsonDocument &doc
 	{
 		if (root.contains("order"))
 		{
-			out->setOrder(requireInteger(root.value("order")));
+			out->order = requireInteger(root.value("order"));
 		}
 		else
 		{
@@ -73,7 +73,7 @@ VersionFilePtr OneSixVersionFormat::versionFileFromJson(const QJsonDocument &doc
 
 	out->version = root.value("version").toString();
 	out->dependsOnMinecraftVersion = root.value("mcVersion").toString();
-	out->filename = filename;
+	// out->filename = filename;
 
 	MojangVersionFormat::readVersionProperties(root, out.get());
 
@@ -128,7 +128,8 @@ VersionFilePtr OneSixVersionFormat::versionFileFromJson(const QJsonDocument &doc
 	bool hasLibs = root.contains("libraries");
 	if (hasPlusLibs && hasLibs)
 	{
-		out->addProblem(PROBLEM_WARNING, QObject::tr("Version file has both '+libraries' and 'libraries'. This is no longer supported."));
+		out->addProblem(ProblemSeverity::Warning,
+						QObject::tr("Version file has both '+libraries' and 'libraries'. This is no longer supported."));
 		readLibs("libraries");
 		readLibs("+libraries");
 	}
@@ -144,23 +145,23 @@ VersionFilePtr OneSixVersionFormat::versionFileFromJson(const QJsonDocument &doc
 	/* removed features that shouldn't be used */
 	if (root.contains("tweakers"))
 	{
-		out->addProblem(PROBLEM_ERROR, QObject::tr("Version file contains unsupported element 'tweakers'"));
+		out->addProblem(ProblemSeverity::Error, QObject::tr("Version file contains unsupported element 'tweakers'"));
 	}
 	if (root.contains("-libraries"))
 	{
-		out->addProblem(PROBLEM_ERROR, QObject::tr("Version file contains unsupported element '-libraries'"));
+		out->addProblem(ProblemSeverity::Error, QObject::tr("Version file contains unsupported element '-libraries'"));
 	}
 	if (root.contains("-tweakers"))
 	{
-		out->addProblem(PROBLEM_ERROR, QObject::tr("Version file contains unsupported element '-tweakers'"));
+		out->addProblem(ProblemSeverity::Error, QObject::tr("Version file contains unsupported element '-tweakers'"));
 	}
 	if (root.contains("-minecraftArguments"))
 	{
-		out->addProblem(PROBLEM_ERROR, QObject::tr("Version file contains unsupported element '-minecraftArguments'"));
+		out->addProblem(ProblemSeverity::Error, QObject::tr("Version file contains unsupported element '-minecraftArguments'"));
 	}
 	if (root.contains("+minecraftArguments"))
 	{
-		out->addProblem(PROBLEM_ERROR, QObject::tr("Version file contains unsupported element '+minecraftArguments'"));
+		out->addProblem(ProblemSeverity::Error, QObject::tr("Version file contains unsupported element '+minecraftArguments'"));
 	}
 	return out;
 }
@@ -170,7 +171,7 @@ QJsonDocument OneSixVersionFormat::versionFileToJson(const VersionFilePtr &patch
 	QJsonObject root;
 	if (saveOrder)
 	{
-		root.insert("order", patch->getOrder());
+		root.insert("order", patch->order);
 	}
 	writeString(root, "name", patch->name);
 
diff --git a/application/VersionProxyModel.cpp b/application/VersionProxyModel.cpp
index 50b94d9e..00390b36 100644
--- a/application/VersionProxyModel.cpp
+++ b/application/VersionProxyModel.cpp
@@ -26,7 +26,7 @@ public:
 
 			switch(role)
 			{
-				case BaseVersionList::ParentGameVersionRole:
+				case BaseVersionList::ParentVersionRole:
 				case BaseVersionList::VersionIdRole:
 				{
 					auto versionString = data.toString();
@@ -146,7 +146,7 @@ QVariant VersionProxyModel::data(const QModelIndex &index, int role) const
 				case Name:
 					return sourceModel()->data(parentIndex, BaseVersionList::VersionRole);
 				case ParentVersion:
-					return sourceModel()->data(parentIndex, BaseVersionList::ParentGameVersionRole);
+					return sourceModel()->data(parentIndex, BaseVersionList::ParentVersionRole);
 				case Branch:
 					return sourceModel()->data(parentIndex, BaseVersionList::BranchRole);
 				case Type:
@@ -327,7 +327,7 @@ void VersionProxyModel::setSourceModel(QAbstractItemModel *replacingRaw)
 		m_columns.push_back(Name);
 	}
 	/*
-	if(roles.contains(BaseVersionList::ParentGameVersionRole))
+	if(roles.contains(BaseVersionList::ParentVersionRole))
 	{
 		m_columns.push_back(ParentVersion);
 	}
diff --git a/application/pages/VersionPage.cpp b/application/pages/VersionPage.cpp
index 0608b2bf..5a0b2243 100644
--- a/application/pages/VersionPage.cpp
+++ b/application/pages/VersionPage.cpp
@@ -152,14 +152,14 @@ void VersionPage::packageCurrent(const QModelIndex &current, const QModelIndex &
 	auto severity = patch->getProblemSeverity();
 	switch(severity)
 	{
-		case PROBLEM_WARNING:
+		case ProblemSeverity::Warning:
 			ui->frame->setModText(tr("%1 possibly has issues.").arg(patch->getName()));
 			break;
-		case PROBLEM_ERROR:
+		case ProblemSeverity::Error:
 			ui->frame->setModText(tr("%1 has issues!").arg(patch->getName()));
 			break;
 		default:
-		case PROBLEM_NONE:
+		case ProblemSeverity::None:
 			ui->frame->clear();
 			return;
 	}
@@ -168,11 +168,11 @@ void VersionPage::packageCurrent(const QModelIndex &current, const QModelIndex &
 	QString problemOut;
 	for (auto &problem: problems)
 	{
-		if(problem.getSeverity() == PROBLEM_ERROR)
+		if(problem.getSeverity() == ProblemSeverity::Error)
 		{
 			problemOut += tr("Error: ");
 		}
-		else if(problem.getSeverity() == PROBLEM_WARNING)
+		else if(problem.getSeverity() == ProblemSeverity::Warning)
 		{
 			problemOut += tr("Warning: ");
 		}
@@ -381,7 +381,7 @@ void VersionPage::on_forgeBtn_clicked()
 		return;
 	}
 	VersionSelectDialog vselect(vlist.get(), tr("Select Forge version"), this);
-	vselect.setExactFilter(BaseVersionList::ParentGameVersionRole, m_inst->currentVersionId());
+	vselect.setExactFilter(BaseVersionList::ParentVersionRole, m_inst->currentVersionId());
 	vselect.setEmptyString(tr("No Forge versions are currently available for Minecraft ") + m_inst->currentVersionId());
 	vselect.setEmptyErrorString(tr("Couldn't load or download the Forge version lists!"));
 	if (vselect.exec() && vselect.selectedVersion())
@@ -400,7 +400,7 @@ void VersionPage::on_liteloaderBtn_clicked()
 		return;
 	}
 	VersionSelectDialog vselect(vlist.get(), tr("Select LiteLoader version"), this);
-	vselect.setExactFilter(BaseVersionList::ParentGameVersionRole, m_inst->currentVersionId());
+	vselect.setExactFilter(BaseVersionList::ParentVersionRole, m_inst->currentVersionId());
 	vselect.setEmptyString(tr("No LiteLoader versions are currently available for Minecraft ") + m_inst->currentVersionId());
 	vselect.setEmptyErrorString(tr("Couldn't load or download the LiteLoader version lists!"));
 	if (vselect.exec() && vselect.selectedVersion())
@@ -457,7 +457,7 @@ void VersionPage::updateButtons(int row)
 		ui->moveDownBtn->setEnabled(patch->isMoveable());
 		ui->moveUpBtn->setEnabled(patch->isMoveable());
 		ui->changeVersionBtn->setEnabled(patch->isVersionChangeable());
-		ui->editBtn->setEnabled(patch->isEditable());
+		ui->editBtn->setEnabled(patch->isCustom());
 		ui->customizeBtn->setEnabled(patch->isCustomizable());
 		ui->revertBtn->setEnabled(patch->isRevertible());
 	}

From 22735f275e9abee202c34e41af759fc9a3123089 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= <peterix@gmail.com>
Date: Mon, 27 Mar 2017 08:30:02 +0200
Subject: [PATCH 18/28] NOISSUE remove dead code

---
 api/logic/minecraft/ProfilePatch.cpp | 80 ----------------------------
 1 file changed, 80 deletions(-)

diff --git a/api/logic/minecraft/ProfilePatch.cpp b/api/logic/minecraft/ProfilePatch.cpp
index 0ff5895d..e0014798 100644
--- a/api/logic/minecraft/ProfilePatch.cpp
+++ b/api/logic/minecraft/ProfilePatch.cpp
@@ -132,83 +132,3 @@ void ProfilePatch::setMovable (bool state)
 {
 	m_isMovable = state;
 }
-
-/*
-class MetaPatchProvider : public ProfilePatch
-{
-public:
-	MetaPatchProvider(std::shared_ptr<Meta::Version> data)
-		:m_version(data)
-	{
-	}
-public:
-	QString getFilename() override
-	{
-		return QString();
-	}
-	QString getID() override
-	{
-		return m_version->uid();
-	}
-	QString getName() override
-	{
-		auto vfile = getFile();
-		if(vfile)
-		{
-			return vfile->name;
-		}
-		return m_version->name();
-	}
-	QDateTime getReleaseDateTime() override
-	{
-		return m_version->time();
-	}
-	QString getVersion() override
-	{
-		return m_version->version();
-	}
-	std::shared_ptr<class VersionFile> getVersionFile() override
-	{
-		return m_version->data();
-	}
-	void setOrder(int) override
-	{
-	}
-	int getOrder() override
-	{
-		return 0;
-	}
-	bool isVersionChangeable() override
-	{
-		return true;
-	}
-	bool isRevertible() override
-	{
-		return false;
-	}
-	bool isRemovable() override
-	{
-		return true;
-	}
-	bool isCustom() override
-	{
-		return false;
-	}
-	bool isCustomizable() override
-	{
-		return true;
-	}
-	bool isMoveable() override
-	{
-		return true;
-	}
-
-private:
-	VersionFilePtr getFile()
-	{
-
-	}
-private:
-	std::shared_ptr<Meta::Version> m_version;
-};
-*/
\ No newline at end of file

From af3384c649cb0f71a78ade376386d0c873754bb5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= <peterix@gmail.com>
Date: Mon, 27 Mar 2017 08:30:21 +0200
Subject: [PATCH 19/28] NOISSUE add filename to newly created jar mod patches

---
 api/logic/minecraft/onesix/OneSixProfileStrategy.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp b/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
index a9cad832..c8d4aa2e 100644
--- a/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
+++ b/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
@@ -413,7 +413,6 @@ bool OneSixProfileStrategy::installJarMods(QStringList filepaths)
 		f->uid = target_id;
 		f->order = profile->getFreeOrderNumber();
 		QString patchFileName = FS::PathCombine(patchDir, target_id + ".json");
-		// f->filename = patchFileName;
 
 		QFile file(patchFileName);
 		if (!file.open(QFile::WriteOnly))
@@ -425,7 +424,7 @@ bool OneSixProfileStrategy::installJarMods(QStringList filepaths)
 		file.write(OneSixVersionFormat::versionFileToJson(f, true).toJson());
 		file.close();
 
-		auto patch = std::make_shared<ProfilePatch>(f);
+		auto patch = std::make_shared<ProfilePatch>(f, patchFileName);
 		patch->setMovable(true);
 		patch->setRemovable(true);
 		profile->appendPatch(patch);

From 53188386b807f1f1ca5eebcd08303633ca4a13fb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= <peterix@gmail.com>
Date: Tue, 28 Mar 2017 09:45:51 +0200
Subject: [PATCH 20/28] NOISSUE refactor builtin patch loading slightly

---
 .../onesix/OneSixProfileStrategy.cpp          | 59 ++++++-------------
 1 file changed, 19 insertions(+), 40 deletions(-)

diff --git a/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp b/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
index c8d4aa2e..8125b1d6 100644
--- a/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
+++ b/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
@@ -85,58 +85,37 @@ void OneSixProfileStrategy::upgradeDeprecatedFiles()
 
 void OneSixProfileStrategy::loadDefaultBuiltinPatches()
 {
+	auto addBuiltinPatch = [&](const QString &uid, const QString intendedVersion, int order)
 	{
-		auto mcJson = FS::PathCombine(m_instance->instanceRoot(), "patches" , "net.minecraft.json");
+		auto jsonFilePath = FS::PathCombine(m_instance->instanceRoot(), "patches" , uid + ".json");
 		// load up the base minecraft patch
-		ProfilePatchPtr minecraftPatch;
-		if(QFile::exists(mcJson))
+		ProfilePatchPtr profilePatch;
+		if(QFile::exists(jsonFilePath))
 		{
-			auto file = ProfileUtils::parseJsonFile(QFileInfo(mcJson), false);
+			auto file = ProfileUtils::parseJsonFile(QFileInfo(jsonFilePath), false);
 			if(file->version.isEmpty())
 			{
-				file->version = m_instance->intendedVersionId();
+				file->version = intendedVersion;
 			}
-			minecraftPatch = std::make_shared<ProfilePatch>(file, mcJson);
-			minecraftPatch->setVanilla(false);
-			minecraftPatch->setRevertible(true);
+			profilePatch = std::make_shared<ProfilePatch>(file, jsonFilePath);
+			profilePatch->setVanilla(false);
+			profilePatch->setRevertible(true);
 		}
 		else
 		{
-			auto mcversion = ENV.metadataIndex()->get("net.minecraft", m_instance->intendedVersionId());
-			minecraftPatch = std::make_shared<ProfilePatch>(mcversion);
-			minecraftPatch->setVanilla(true);
+			auto metaVersion = ENV.metadataIndex()->get(uid, intendedVersion);
+			profilePatch = std::make_shared<ProfilePatch>(metaVersion);
+			profilePatch->setVanilla(true);
 		}
-		if (!minecraftPatch)
+		if (!profilePatch)
 		{
-			throw VersionIncomplete("net.minecraft");
+			throw VersionIncomplete(uid);
 		}
-		minecraftPatch->setOrder(-2);
-		profile->appendPatch(minecraftPatch);
-	}
-
-	{
-		auto lwjglJson = FS::PathCombine(m_instance->instanceRoot(), "patches" , "org.lwjgl.json");
-		ProfilePatchPtr lwjglPatch;
-		if(QFile::exists(lwjglJson))
-		{
-			auto file = ProfileUtils::parseJsonFile(QFileInfo(lwjglJson), false);
-			lwjglPatch = std::make_shared<ProfilePatch>(file, lwjglJson);
-			lwjglPatch->setVanilla(false);
-			lwjglPatch->setRevertible(true);
-		}
-		else
-		{
-			auto lwjglversion = ENV.metadataIndex()->get("org.lwjgl", "2.9.1");
-			lwjglPatch = std::make_shared<ProfilePatch>(lwjglversion);
-			lwjglPatch->setVanilla(true);
-		}
-		if (!lwjglPatch)
-		{
-			throw VersionIncomplete("org.lwjgl");
-		}
-		lwjglPatch->setOrder(-1);
-		profile->appendPatch(lwjglPatch);
-	}
+		profilePatch->setOrder(order);
+		profile->appendPatch(profilePatch);
+	};
+	addBuiltinPatch("net.minecraft", m_instance->intendedVersionId(), -2);
+	addBuiltinPatch("org.lwjgl", "2.9.1", -1);
 }
 
 void OneSixProfileStrategy::loadUserPatches()

From 2ac0edbbdb27e12bae00c4779da135582bde89f5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= <peterix@gmail.com>
Date: Thu, 30 Mar 2017 01:05:58 +0200
Subject: [PATCH 21/28] NOISSUE preview of LWJGL version changing

It still needs work - some LWJGL versions are exclusive to macOS.
This has to be encoded in the json.
---
 api/logic/ProblemProvider.h                   | 17 ++++---
 api/logic/minecraft/Library.cpp               | 10 ++++-
 api/logic/minecraft/ProfilePatch.cpp          | 41 +++++++++++++++++
 api/logic/minecraft/ProfilePatch.h            |  8 +++-
 api/logic/minecraft/VersionFile.h             |  2 +-
 api/logic/minecraft/onesix/OneSixInstance.cpp | 44 +++++++++++++++---
 api/logic/minecraft/onesix/OneSixInstance.h   |  4 +-
 .../onesix/OneSixProfileStrategy.cpp          |  4 +-
 api/logic/minecraft/onesix/OneSixUpdate.cpp   |  4 +-
 application/pages/VersionPage.cpp             | 45 ++++++++++++-------
 10 files changed, 143 insertions(+), 36 deletions(-)

diff --git a/api/logic/ProblemProvider.h b/api/logic/ProblemProvider.h
index 64a31c59..b30e1776 100644
--- a/api/logic/ProblemProvider.h
+++ b/api/logic/ProblemProvider.h
@@ -31,10 +31,21 @@ private:
 class ProblemProvider
 {
 public:
-	virtual const QList<PatchProblem>& getProblems()
+	virtual const QList<PatchProblem> getProblems() = 0;
+	virtual ProblemSeverity getProblemSeverity() = 0;
+};
+
+class ProblemContainer : public ProblemProvider
+{
+public:
+	const QList<PatchProblem> getProblems() override
 	{
 		return m_problems;
 	}
+	ProblemSeverity getProblemSeverity() override
+	{
+		return m_problemSeverity;
+	}
 	virtual void addProblem(ProblemSeverity severity, const QString &description)
 	{
 		if(severity > m_problemSeverity)
@@ -43,10 +54,6 @@ public:
 		}
 		m_problems.append(PatchProblem(severity, description));
 	}
-	virtual ProblemSeverity getProblemSeverity()
-	{
-		return m_problemSeverity;
-	}
 
 private:
 	QList<PatchProblem> m_problems;
diff --git a/api/logic/minecraft/Library.cpp b/api/logic/minecraft/Library.cpp
index 5a75fe79..ad0a64cf 100644
--- a/api/logic/minecraft/Library.cpp
+++ b/api/logic/minecraft/Library.cpp
@@ -55,7 +55,15 @@ void Library::getApplicableFiles(OpSys system, QStringList& jar, QStringList& na
 			}
 			else
 			{
-				native += actualPath(m_mojangDownloads->getDownloadInfo(nativeClassifier)->path);
+				auto dlinfo = m_mojangDownloads->getDownloadInfo(nativeClassifier);
+				if(!dlinfo)
+				{
+					qWarning() << "Cannot get native for" << nativeClassifier << "while processing" << m_name;
+				}
+				else
+				{
+					native += actualPath(dlinfo->path);
+				}
 			}
 		}
 	}
diff --git a/api/logic/minecraft/ProfilePatch.cpp b/api/logic/minecraft/ProfilePatch.cpp
index e0014798..6a90f64b 100644
--- a/api/logic/minecraft/ProfilePatch.cpp
+++ b/api/logic/minecraft/ProfilePatch.cpp
@@ -1,3 +1,6 @@
+#include <meta/VersionList.h>
+#include <meta/Index.h>
+#include <Env.h>
 #include "ProfilePatch.h"
 
 #include "meta/Version.h"
@@ -35,6 +38,15 @@ std::shared_ptr<class VersionFile> ProfilePatch::getVersionFile()
 	return m_file;
 }
 
+std::shared_ptr<class Meta::VersionList> ProfilePatch::getVersionList()
+{
+	if(m_metaVersion)
+	{
+		return ENV.metadataIndex()->get(m_metaVersion->uid());
+	}
+	return nullptr;
+}
+
 int ProfilePatch::getOrder()
 {
 	if(m_orderOverride)
@@ -113,6 +125,15 @@ bool ProfilePatch::isMoveable()
 }
 bool ProfilePatch::isVersionChangeable()
 {
+	auto list = getVersionList();
+	if(list)
+	{
+		if(!list->isLoaded())
+		{
+			list->load();
+		}
+		return list->count() != 0;
+	}
 	return false;
 }
 
@@ -132,3 +153,23 @@ void ProfilePatch::setMovable (bool state)
 {
 	m_isMovable = state;
 }
+
+ProblemSeverity ProfilePatch::getProblemSeverity()
+{
+	auto file = getVersionFile();
+	if(file)
+	{
+		return file->getProblemSeverity();
+	}
+	return ProblemSeverity::Error;
+}
+
+const QList<PatchProblem> ProfilePatch::getProblems()
+{
+	auto file = getVersionFile();
+	if(file)
+	{
+		return file->getProblems();
+	}
+	return {PatchProblem(ProblemSeverity::Error, QObject::tr("Patch is not loaded yet."))};
+}
diff --git a/api/logic/minecraft/ProfilePatch.h b/api/logic/minecraft/ProfilePatch.h
index 9e2555af..fb6b2f05 100644
--- a/api/logic/minecraft/ProfilePatch.h
+++ b/api/logic/minecraft/ProfilePatch.h
@@ -11,6 +11,7 @@ class MinecraftProfile;
 namespace Meta
 {
 	class Version;
+	class VersionList;
 }
 class VersionFile;
 
@@ -41,17 +42,20 @@ public:
 	virtual QString getFilename();
 
 	virtual std::shared_ptr<class VersionFile> getVersionFile();
+	virtual std::shared_ptr<class Meta::VersionList> getVersionList();
 
 	void setVanilla (bool state);
 	void setRemovable (bool state);
 	void setRevertible (bool state);
-	void setCustomizable (bool state);
 	void setMovable (bool state);
 
+
+	const QList<PatchProblem> getProblems() override;
+	ProblemSeverity getProblemSeverity() override;
+
 protected:
 	// Properties for UI and version manipulation from UI in general
 	bool m_isMovable = false;
-	bool m_isCustomizable = false;
 	bool m_isRevertible = false;
 	bool m_isRemovable = false;
 	bool m_isVanilla = false;
diff --git a/api/logic/minecraft/VersionFile.h b/api/logic/minecraft/VersionFile.h
index a71c6228..312d0a3b 100644
--- a/api/logic/minecraft/VersionFile.h
+++ b/api/logic/minecraft/VersionFile.h
@@ -18,7 +18,7 @@ struct MojangDownloadInfo;
 struct MojangAssetIndexInfo;
 
 typedef std::shared_ptr<VersionFile> VersionFilePtr;
-class VersionFile : public ProblemProvider
+class VersionFile : public ProblemContainer
 {
 	friend class MojangVersionFormat;
 	friend class OneSixVersionFormat;
diff --git a/api/logic/minecraft/onesix/OneSixInstance.cpp b/api/logic/minecraft/onesix/OneSixInstance.cpp
index 6e4a5bdc..d89f6f87 100644
--- a/api/logic/minecraft/onesix/OneSixInstance.cpp
+++ b/api/logic/minecraft/onesix/OneSixInstance.cpp
@@ -35,6 +35,7 @@ OneSixInstance::OneSixInstance(SettingsObjectPtr globalSettings, SettingsObjectP
 	: MinecraftInstance(globalSettings, settings, rootDir)
 {
 	m_settings->registerSetting({"IntendedVersion", "MinecraftVersion"}, "");
+	m_settings->registerSetting("LWJGLVersion", "");
 }
 
 void OneSixInstance::init()
@@ -480,7 +481,24 @@ std::shared_ptr<WorldList> OneSixInstance::worldList() const
 
 bool OneSixInstance::setIntendedVersionId(QString version)
 {
-	settings()->set("IntendedVersion", version);
+	return setComponentVersion("net.minecraft", version);
+}
+
+QString OneSixInstance::intendedVersionId() const
+{
+	return getComponentVersion("net.minecraft");
+}
+
+bool OneSixInstance::setComponentVersion(const QString& uid, const QString& version)
+{
+	if(uid == "net.minecraft")
+	{
+		settings()->set("IntendedVersion", version);
+	}
+	else if (uid == "org.lwjgl")
+	{
+		settings()->set("LWJGLVersion", version);
+	}
 	if(getMinecraftProfile())
 	{
 		clearProfile();
@@ -489,6 +507,24 @@ bool OneSixInstance::setIntendedVersionId(QString version)
 	return true;
 }
 
+QString OneSixInstance::getComponentVersion(const QString& uid) const
+{
+	if(uid == "net.minecraft")
+	{
+		return settings()->get("IntendedVersion").toString();
+	}
+	else if(uid == "org.lwjgl")
+	{
+		auto version = settings()->get("LWJGLVersion").toString();
+		if(version.isEmpty())
+		{
+			return "2.9.1";
+		}
+		return version;
+	}
+	return QString();
+}
+
 QList< Mod > OneSixInstance::getJarMods() const
 {
 	QList<Mod> mods;
@@ -500,12 +536,6 @@ QList< Mod > OneSixInstance::getJarMods() const
 	return mods;
 }
 
-
-QString OneSixInstance::intendedVersionId() const
-{
-	return settings()->get("IntendedVersion").toString();
-}
-
 void OneSixInstance::setShouldUpdate(bool)
 {
 }
diff --git a/api/logic/minecraft/onesix/OneSixInstance.h b/api/logic/minecraft/onesix/OneSixInstance.h
index 72c05ad7..ec8c2597 100644
--- a/api/logic/minecraft/onesix/OneSixInstance.h
+++ b/api/logic/minecraft/onesix/OneSixInstance.h
@@ -59,9 +59,11 @@ public:
 
 	virtual QString intendedVersionId() const override;
 	virtual bool setIntendedVersionId(QString version) override;
-
 	virtual QString currentVersionId() const override;
 
+	QString getComponentVersion(const QString &uid) const;
+	bool setComponentVersion(const QString &uid, const QString &version);
+
 	virtual bool shouldUpdate() const override;
 	virtual void setShouldUpdate(bool val) override;
 
diff --git a/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp b/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
index 8125b1d6..4a56a810 100644
--- a/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
+++ b/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
@@ -114,8 +114,8 @@ void OneSixProfileStrategy::loadDefaultBuiltinPatches()
 		profilePatch->setOrder(order);
 		profile->appendPatch(profilePatch);
 	};
-	addBuiltinPatch("net.minecraft", m_instance->intendedVersionId(), -2);
-	addBuiltinPatch("org.lwjgl", "2.9.1", -1);
+	addBuiltinPatch("net.minecraft", m_instance->getComponentVersion("net.minecraft"), -2);
+	addBuiltinPatch("org.lwjgl", m_instance->getComponentVersion("org.lwjgl"), -1);
 }
 
 void OneSixProfileStrategy::loadUserPatches()
diff --git a/api/logic/minecraft/onesix/OneSixUpdate.cpp b/api/logic/minecraft/onesix/OneSixUpdate.cpp
index 5bc76b01..bf234189 100644
--- a/api/logic/minecraft/onesix/OneSixUpdate.cpp
+++ b/api/logic/minecraft/onesix/OneSixUpdate.cpp
@@ -61,8 +61,8 @@ OneSixUpdate::OneSixUpdate(OneSixInstance *inst, QObject *parent) : Task(parent)
 				m_tasks.append(task.unwrap());
 			}
 		};
-		loadVersion("org.lwjgl", "2.9.1");
-		loadVersion("net.minecraft", m_inst->intendedVersionId());
+		loadVersion("org.lwjgl", m_inst->getComponentVersion("org.lwjgl"));
+		loadVersion("net.minecraft", m_inst->getComponentVersion("net.minecraft"));
 	}
 
 	// libraries download
diff --git a/application/pages/VersionPage.cpp b/application/pages/VersionPage.cpp
index 5a0b2243..94068786 100644
--- a/application/pages/VersionPage.cpp
+++ b/application/pages/VersionPage.cpp
@@ -323,9 +323,20 @@ void VersionPage::on_moveDownBtn_clicked()
 
 void VersionPage::on_changeVersionBtn_clicked()
 {
-	// FIXME: this is hilariously broken because it assumes m_inst->versionList() is a sensible thing...
-	VersionSelectDialog vselect(m_inst->versionList().get(), tr("Change Minecraft version"),
-								this);
+	auto versionRow = currentRow();
+	if(versionRow == -1)
+	{
+		return;
+	}
+	auto patch = m_profile->versionPatch(versionRow);
+	auto name = patch->getName();
+	auto list = patch->getVersionList();
+	if(!list)
+	{
+		return;
+	}
+	auto uid = list->uid();
+	VersionSelectDialog vselect(list.get(), tr("Change %1 version").arg(name), this);
 	if (!vselect.exec() || !vselect.selectedVersion())
 		return;
 
@@ -339,21 +350,25 @@ void VersionPage::on_changeVersionBtn_clicked()
 		return;
 	}
 
-	if (!m_profile->isVanilla())
+	qDebug() << "Change" << uid << "to" << vselect.selectedVersion()->descriptor();
+	if(uid == "net.minecraft")
 	{
-		auto result = CustomMessageBox::selectable(
-			this, tr("Are you sure?"),
-			tr("This will remove any library/version customization you did previously. "
-			   "This includes things like Forge install and similar."),
-			QMessageBox::Warning, QMessageBox::Ok | QMessageBox::Abort,
-			QMessageBox::Abort)->exec();
+		if (!m_profile->isVanilla())
+		{
+			auto result = CustomMessageBox::selectable(
+				this, tr("Are you sure?"),
+				tr("This will remove any library/version customization you did previously. "
+				"This includes things like Forge install and similar."),
+				QMessageBox::Warning, QMessageBox::Ok | QMessageBox::Abort,
+				QMessageBox::Abort)->exec();
 
-		if (result != QMessageBox::Ok)
-			return;
-		m_profile->revertToVanilla();
-		reloadMinecraftProfile();
+			if (result != QMessageBox::Ok)
+				return;
+			m_profile->revertToVanilla();
+			reloadMinecraftProfile();
+		}
 	}
-	m_inst->setIntendedVersionId(vselect.selectedVersion()->descriptor());
+	m_inst->setComponentVersion(uid, vselect.selectedVersion()->descriptor());
 	doUpdate();
 	m_container->refreshContainer();
 }

From e0596d3c86806d952a9811f306f497f84430ae3c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= <peterix@gmail.com>
Date: Fri, 31 Mar 2017 23:47:56 +0200
Subject: [PATCH 22/28] NOISSUE Make forge installable again

---
 api/logic/minecraft/onesix/OneSixInstance.cpp |  32 +++-
 .../onesix/OneSixProfileStrategy.cpp          | 149 +++++++++---------
 application/pages/VersionPage.cpp             |  10 +-
 3 files changed, 106 insertions(+), 85 deletions(-)

diff --git a/api/logic/minecraft/onesix/OneSixInstance.cpp b/api/logic/minecraft/onesix/OneSixInstance.cpp
index d89f6f87..4a4380a4 100644
--- a/api/logic/minecraft/onesix/OneSixInstance.cpp
+++ b/api/logic/minecraft/onesix/OneSixInstance.cpp
@@ -34,8 +34,15 @@
 OneSixInstance::OneSixInstance(SettingsObjectPtr globalSettings, SettingsObjectPtr settings, const QString &rootDir)
 	: MinecraftInstance(globalSettings, settings, rootDir)
 {
+	// set explicitly during instance creation
 	m_settings->registerSetting({"IntendedVersion", "MinecraftVersion"}, "");
-	m_settings->registerSetting("LWJGLVersion", "");
+
+	// defaults to the version we've been using for years (2.9.1)
+	m_settings->registerSetting("LWJGLVersion", "2.9.1");
+
+	// optionals
+	m_settings->registerSetting("ForgeVersion", "");
+	m_settings->registerSetting("LiteloaderVersion", "");
 }
 
 void OneSixInstance::init()
@@ -499,6 +506,14 @@ bool OneSixInstance::setComponentVersion(const QString& uid, const QString& vers
 	{
 		settings()->set("LWJGLVersion", version);
 	}
+	else if (uid == "net.minecraftforge")
+	{
+		settings()->set("ForgeVersion", version);
+	}
+	else if (uid == "com.liteloader")
+	{
+		settings()->set("LiteloaderVersion", version);
+	}
 	if(getMinecraftProfile())
 	{
 		clearProfile();
@@ -515,12 +530,15 @@ QString OneSixInstance::getComponentVersion(const QString& uid) const
 	}
 	else if(uid == "org.lwjgl")
 	{
-		auto version = settings()->get("LWJGLVersion").toString();
-		if(version.isEmpty())
-		{
-			return "2.9.1";
-		}
-		return version;
+		return settings()->get("LWJGLVersion").toString();
+	}
+	else if(uid == "net.minecraftforge")
+	{
+		return settings()->get("ForgeVersion").toString();
+	}
+	else if(uid == "com.liteloader")
+	{
+		return settings()->get("LiteloaderVersion").toString();
 	}
 	return QString();
 }
diff --git a/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp b/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
index 4a56a810..e08dd529 100644
--- a/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
+++ b/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
@@ -120,45 +120,10 @@ void OneSixProfileStrategy::loadDefaultBuiltinPatches()
 
 void OneSixProfileStrategy::loadUserPatches()
 {
-	// load all patches, put into map for ordering, apply in the right order
-	ProfileUtils::PatchOrder userOrder;
-	ProfileUtils::readOverrideOrders(FS::PathCombine(m_instance->instanceRoot(), "order.json"), userOrder);
-	QDir patches(FS::PathCombine(m_instance->instanceRoot(),"patches"));
-	QSet<QString> seen_extra;
-
-	// first, load things by sort order.
-	for (auto id : userOrder)
-	{
-		// ignore builtins
-		if (id == "net.minecraft")
-			continue;
-		if (id == "org.lwjgl")
-			continue;
-		// parse the file
-		QString filename = patches.absoluteFilePath(id + ".json");
-		QFileInfo finfo(filename);
-		if(!finfo.exists())
-		{
-			qDebug() << "Patch file " << filename << " was deleted by external means...";
-			continue;
-		}
-		qDebug() << "Reading" << filename << "by user order";
-		VersionFilePtr file = ProfileUtils::parseJsonFile(finfo, false);
-		// sanity check. prevent tampering with files.
-		if (file->uid != id)
-		{
-			file->addProblem(ProblemSeverity::Warning, QObject::tr("load id %1 does not match internal id %2").arg(id, file->uid));
-			seen_extra.insert(file->uid);
-		}
-		auto patchEntry = std::make_shared<ProfilePatch>(file, filename);
-		patchEntry->setRemovable(true);
-		patchEntry->setMovable(true);
-		profile->appendPatch(patchEntry);
-	}
-	// now load the rest by internal preference.
-	using FileEntry = std::tuple<VersionFilePtr, QString>;
-	QMultiMap<int, FileEntry> files;
-	for (auto info : patches.entryInfoList(QStringList() << "*.json", QDir::Files))
+	// first, collect all patches (that are not builtins of OneSix) and load them
+	QMap<QString, ProfilePatchPtr> loadedPatches;
+	QDir patchesDir(FS::PathCombine(m_instance->instanceRoot(),"patches"));
+	for (auto info : patchesDir.entryInfoList(QStringList() << "*.json", QDir::Files))
 	{
 		// parse the file
 		qDebug() << "Reading" << info.fileName();
@@ -168,51 +133,80 @@ void OneSixProfileStrategy::loadUserPatches()
 			continue;
 		if (file->uid == "org.lwjgl")
 			continue;
-		// do not load versions with broken IDs twice
-		if(seen_extra.contains(file->uid))
-			continue;
-		// do not load what we already loaded in the first pass
-		if (userOrder.contains(file->uid))
-			continue;
-		files.insert(file->order, std::make_tuple(file, info.filePath()));
+		auto patch = std::make_shared<ProfilePatch>(file, info.filePath());
+		patch->setRemovable(true);
+		patch->setMovable(true);
+		if(ENV.metadataIndex()->hasUid(file->uid))
+		{
+			// FIXME: requesting a uid/list creates it in the index... this allows reverting to possibly invalid versions...
+			patch->setRevertible(true);
+		}
+		loadedPatches[file->uid] = patch;
 	}
-	auto appendFilePatch = [&](FileEntry tuple)
+	// these are 'special'... if not already loaded from instance files, grab them from the metadata repo.
+	auto loadSpecial = [&](const QString & uid, int order)
 	{
-		VersionFilePtr file;
-		QString filename;
-		std::tie(file, filename) = tuple;
-		auto patchEntry = std::make_shared<ProfilePatch>(file, filename);
-		patchEntry->setRemovable(true);
-		patchEntry->setMovable(true);
-		profile->appendPatch(patchEntry);
+		auto patchVersion = m_instance->getComponentVersion(uid);
+		if(!patchVersion.isEmpty() && !loadedPatches.contains(uid))
+		{
+			auto patch = std::make_shared<ProfilePatch>(ENV.metadataIndex()->get(uid, patchVersion));
+			patch->setOrder(order);
+			patch->setVanilla(true);
+			patch->setRemovable(true);
+			patch->setMovable(true);
+			loadedPatches[uid] = patch;
+		}
 	};
-	QSet<int> seen;
+	loadSpecial("net.minecraftforge", 5);
+	loadSpecial("com.liteloader", 10);
+
+	// now add all the patches by user sort order
+	ProfileUtils::PatchOrder userOrder;
+	ProfileUtils::readOverrideOrders(FS::PathCombine(m_instance->instanceRoot(), "order.json"), userOrder);
+	bool orderIsDirty = false;
+	for (auto uid : userOrder)
+	{
+		// ignore builtins
+		if (uid == "net.minecraft")
+			continue;
+		if (uid == "org.lwjgl")
+			continue;
+		// ordering has a patch that is gone?
+		if(!loadedPatches.contains(uid))
+		{
+			orderIsDirty = true;
+			continue;
+		}
+		profile->appendPatch(loadedPatches.take(uid));
+	}
+
+	// is there anything left to sort?
+	if(loadedPatches.isEmpty())
+	{
+		// TODO: save the order here?
+		return;
+	}
+
+	// inserting into multimap by order number as key sorts the patches and detects duplicates
+	QMultiMap<int, ProfilePatchPtr> files;
+	auto iter = loadedPatches.begin();
+	while(iter != loadedPatches.end())
+	{
+		files.insert((*iter)->getOrder(), *iter);
+		iter++;
+	}
+
+	// then just extract the patches and put them in the list
 	for (auto order : files.keys())
 	{
-		if(seen.contains(order))
-			continue;
-		seen.insert(order);
 		const auto &values = files.values(order);
-		if(values.size() == 1)
+		for(auto &value: values)
 		{
-			appendFilePatch(values[0]);
-			continue;
-		}
-		for(auto &file: values)
-		{
-			QStringList list;
-			for(auto &file2: values)
-			{
-				if(file != file2)
-				{
-					list.append(std::get<0>(file2)->name);
-				}
-			}
-			auto vfileptr = std::get<0>(file);
-			vfileptr->addProblem(ProblemSeverity::Warning, QObject::tr("%1 has the same order as the following components:\n%2").arg(vfileptr->name, list.join(", ")));
-			appendFilePatch(file);
+			// TODO: put back the insertion of problem messages here, so the user knows about the id duplication
+			profile->appendPatch(value);
 		}
 	}
+	// TODO: save the order here?
 }
 
 
@@ -249,7 +243,10 @@ bool OneSixProfileStrategy::removePatch(ProfilePatchPtr patch)
 			return false;
 		}
 	}
-
+	if(!m_instance->getComponentVersion(patch->getID()).isEmpty())
+	{
+		m_instance->setComponentVersion(patch->getID(), QString());
+	}
 
 	auto preRemoveJarMod = [&](JarmodPtr jarMod) -> bool
 	{
diff --git a/application/pages/VersionPage.cpp b/application/pages/VersionPage.cpp
index 94068786..a7029b36 100644
--- a/application/pages/VersionPage.cpp
+++ b/application/pages/VersionPage.cpp
@@ -401,7 +401,10 @@ void VersionPage::on_forgeBtn_clicked()
 	vselect.setEmptyErrorString(tr("Couldn't load or download the Forge version lists!"));
 	if (vselect.exec() && vselect.selectedVersion())
 	{
-		m_profile->installVersion(vselect.selectedVersion());
+		auto vsn = vselect.selectedVersion();
+		m_inst->setComponentVersion("net.minecraftforge", vsn->descriptor());
+		m_profile->reload();
+		// m_profile->installVersion();
 		preselect(m_profile->rowCount(QModelIndex())-1);
 		m_container->refreshContainer();
 	}
@@ -420,7 +423,10 @@ void VersionPage::on_liteloaderBtn_clicked()
 	vselect.setEmptyErrorString(tr("Couldn't load or download the LiteLoader version lists!"));
 	if (vselect.exec() && vselect.selectedVersion())
 	{
-		m_profile->installVersion(vselect.selectedVersion());
+		auto vsn = vselect.selectedVersion();
+		m_inst->setComponentVersion("com.liteloader", vsn->descriptor());
+		m_profile->reload();
+		// m_profile->installVersion(vselect.selectedVersion());
 		preselect(m_profile->rowCount(QModelIndex())-1);
 		m_container->refreshContainer();
 	}

From f565798650b453ed8c94422096d9b37ba81ebf3e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= <peterix@gmail.com>
Date: Sat, 1 Apr 2017 18:38:04 +0200
Subject: [PATCH 23/28] NOISSUE remove unused version range filtering

---
 api/logic/Version.cpp                       | 57 +--------------------
 api/logic/Version.h                         |  4 --
 api/logic/Version_test.cpp                  | 38 --------------
 application/VersionProxyModel.cpp           | 12 +----
 application/widgets/VersionSelectWidget.cpp |  2 +-
 5 files changed, 3 insertions(+), 110 deletions(-)

diff --git a/api/logic/Version.cpp b/api/logic/Version.cpp
index 3c4727ad..2c83374f 100644
--- a/api/logic/Version.cpp
+++ b/api/logic/Version.cpp
@@ -75,6 +75,7 @@ void Version::parse()
 {
 	m_sections.clear();
 
+	// FIXME: this is bad. versions can contain a lot more separators...
 	QStringList parts = m_string.split('.');
 
 	for (const auto part : parts)
@@ -82,59 +83,3 @@ void Version::parse()
 		m_sections.append(Section(part));
 	}
 }
-
-bool versionIsInInterval(const QString &version, const QString &interval)
-{
-	return versionIsInInterval(Version(version), interval);
-}
-bool versionIsInInterval(const Version &version, const QString &interval)
-{
-	if (interval.isEmpty() || version.toString() == interval)
-	{
-		return true;
-	}
-
-	// Interval notation is used
-	QRegularExpression exp(
-		"(?<start>[\\[\\]\\(\\)])(?<bottom>.*?)(,(?<top>.*?))?(?<end>[\\[\\]\\(\\)]),?");
-	QRegularExpressionMatch match = exp.match(interval);
-	if (match.hasMatch())
-	{
-		const QChar start = match.captured("start").at(0);
-		const QChar end = match.captured("end").at(0);
-		const QString bottom = match.captured("bottom");
-		const QString top = match.captured("top");
-
-		// check if in range (bottom)
-		if (!bottom.isEmpty())
-		{
-			const auto bottomVersion = Version(bottom);
-			if ((start == '[') && !(version >= bottomVersion))
-			{
-				return false;
-			}
-			else if ((start == '(') && !(version > bottomVersion))
-			{
-				return false;
-			}
-		}
-
-		// check if in range (top)
-		if (!top.isEmpty())
-		{
-			const auto topVersion = Version(top);
-			if ((end == ']') && !(version <= topVersion))
-			{
-				return false;
-			}
-			else if ((end == ')') && !(version < topVersion))
-			{
-				return false;
-			}
-		}
-
-		return true;
-	}
-
-	return false;
-}
diff --git a/api/logic/Version.h b/api/logic/Version.h
index b5946ced..08dfb6e9 100644
--- a/api/logic/Version.h
+++ b/api/logic/Version.h
@@ -104,7 +104,3 @@ private:
 
 	void parse();
 };
-
-MULTIMC_LOGIC_EXPORT bool versionIsInInterval(const QString &version, const QString &interval);
-MULTIMC_LOGIC_EXPORT bool versionIsInInterval(const Version &version, const QString &interval);
-
diff --git a/api/logic/Version_test.cpp b/api/logic/Version_test.cpp
index aa6cb4dd..1e7920ad 100644
--- a/api/logic/Version_test.cpp
+++ b/api/logic/Version_test.cpp
@@ -60,44 +60,6 @@ private slots:
 
 	}
 
-	void test_versionIsInInterval_data()
-	{
-		QTest::addColumn<QString>("version");
-		QTest::addColumn<QString>("interval");
-		QTest::addColumn<bool>("result");
-
-		QTest::newRow("empty, true") << "1.2.3" << "" << true;
-		QTest::newRow("one version, true") << "1.2.3" << "1.2.3" << true;
-		QTest::newRow("one version, false") << "1.2.3" << "1.2.2" << false;
-
-		QTest::newRow("one version inclusive <-> infinity, true") << "1.2.3" << "[1.2.3,)" << true;
-		QTest::newRow("one version exclusive <-> infinity, true") << "1.2.3" << "(1.2.2,)" << true;
-		QTest::newRow("one version inclusive <-> infitity, false") << "1.2.3" << "[1.2.4,)" << false;
-		QTest::newRow("one version exclusive <-> infinity, false") << "1.2.3" << "(1.2.3,)" << false;
-
-		QTest::newRow("infinity <-> one version inclusive, true") << "1.2.3" << "(,1.2.3]" << true;
-		QTest::newRow("infinity <-> one version exclusive, true") << "1.2.3" << "(,1.2.4)" << true;
-		QTest::newRow("infinity <-> one version inclusive, false") << "1.2.3" << "(,1.2.2]" << false;
-		QTest::newRow("infinity <-> one version exclusive, false") << "1.2.3" << "(,1.2.3)" << false;
-
-		QTest::newRow("inclusive <-> inclusive, true") << "1.2.3" << "[1.2.2,1.2.3]" << true;
-		QTest::newRow("inclusive <-> exclusive, true") << "1.2.3" << "[1.2.3,1.2.4)" << true;
-		QTest::newRow("exclusive <-> inclusive, true") << "1.2.3" << "(1.2.2,1.2.3]" << true;
-		QTest::newRow("exclusive <-> exclusive, true") << "1.2.3" << "(1.2.2,1.2.4)" << true;
-		QTest::newRow("inclusive <-> inclusive, false") << "1.2.3" << "[1.0.0,1.2.2]" << false;
-		QTest::newRow("inclusive <-> exclusive, false") << "1.2.3" << "[1.0.0,1.2.3)" << false;
-		QTest::newRow("exclusive <-> inclusive, false") << "1.2.3" << "(1.2.3,2.0.0]" << false;
-		QTest::newRow("exclusive <-> exclusive, false") << "1.2.3" << "(1.0.0,1.2.3)" << false;
-	}
-	void test_versionIsInInterval()
-	{
-		QFETCH(QString, version);
-		QFETCH(QString, interval);
-		QFETCH(bool, result);
-
-		QCOMPARE(versionIsInInterval(version, interval), result);
-	}
-
 	void test_versionCompare_data()
 	{
 		setupVersions();
diff --git a/application/VersionProxyModel.cpp b/application/VersionProxyModel.cpp
index 00390b36..96bdc9ab 100644
--- a/application/VersionProxyModel.cpp
+++ b/application/VersionProxyModel.cpp
@@ -28,17 +28,7 @@ public:
 			{
 				case BaseVersionList::ParentVersionRole:
 				case BaseVersionList::VersionIdRole:
-				{
-					auto versionString = data.toString();
-					if(it.value().exact)
-					{
-						return versionString == it.value().string;
-					}
-					else
-					{
-						return versionIsInInterval(versionString, it.value().string);
-					}
-				}
+					// TODO: work with metadata here. Previous implementation based on the Version class is not sufficient
 				default:
 				{
 					auto match = data.toString();
diff --git a/application/widgets/VersionSelectWidget.cpp b/application/widgets/VersionSelectWidget.cpp
index a4eb428b..1696d9d1 100644
--- a/application/widgets/VersionSelectWidget.cpp
+++ b/application/widgets/VersionSelectWidget.cpp
@@ -168,4 +168,4 @@ void VersionSelectWidget::setExactFilter(BaseVersionList::ModelRoles role, QStri
 void VersionSelectWidget::setFuzzyFilter(BaseVersionList::ModelRoles role, QString filter)
 {
 	m_proxyModel->setFilter(role, filter, false);
-}
\ No newline at end of file
+}

From 643d74f66c2b22660264a393d5c3fa38f68a5d59 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= <peterix@gmail.com>
Date: Thu, 6 Apr 2017 23:30:18 +0200
Subject: [PATCH 24/28] NOISSUE implement recommended versions using the new
 JSON format

---
 api/logic/BaseVersionList.cpp  |  7 +------
 api/logic/BaseVersionList.h    |  5 -----
 api/logic/meta/JsonFormat.cpp  |  5 ++++-
 api/logic/meta/Version.cpp     | 16 ++++++++++++++++
 api/logic/meta/Version.h       |  8 ++++++++
 api/logic/meta/VersionList.cpp | 15 +++------------
 api/logic/meta/VersionList.h   |  2 --
 7 files changed, 32 insertions(+), 26 deletions(-)

diff --git a/api/logic/BaseVersionList.cpp b/api/logic/BaseVersionList.cpp
index dae604a2..8b424c11 100644
--- a/api/logic/BaseVersionList.cpp
+++ b/api/logic/BaseVersionList.cpp
@@ -30,7 +30,7 @@ BaseVersionPtr BaseVersionList::findVersion(const QString &descriptor)
 	return BaseVersionPtr();
 }
 
-BaseVersionPtr BaseVersionList::getLatestStable() const
+BaseVersionPtr BaseVersionList::getRecommended() const
 {
 	if (count() <= 0)
 		return BaseVersionPtr();
@@ -38,11 +38,6 @@ BaseVersionPtr BaseVersionList::getLatestStable() const
 		return at(0);
 }
 
-BaseVersionPtr BaseVersionList::getRecommended() const
-{
-	return getLatestStable();
-}
-
 QVariant BaseVersionList::data(const QModelIndex &index, int role) const
 {
 	if (!index.isValid())
diff --git a/api/logic/BaseVersionList.h b/api/logic/BaseVersionList.h
index eb3b622a..655bbd43 100644
--- a/api/logic/BaseVersionList.h
+++ b/api/logic/BaseVersionList.h
@@ -93,11 +93,6 @@ public:
 	 */
 	virtual BaseVersionPtr findVersion(const QString &descriptor);
 
-	/*!
-	 * \brief Gets the latest stable version from this list
-	 */
-	virtual BaseVersionPtr getLatestStable() const;
-
 	/*!
 	 * \brief Gets the recommended version from this list
 	 * If the list doesn't support recommended versions, this works exactly as getLatestStable
diff --git a/api/logic/meta/JsonFormat.cpp b/api/logic/meta/JsonFormat.cpp
index 8a063f48..1638105a 100644
--- a/api/logic/meta/JsonFormat.cpp
+++ b/api/logic/meta/JsonFormat.cpp
@@ -52,6 +52,7 @@ static VersionPtr parseCommonVersion(const QString &uid, const QJsonObject &obj)
 	version->setTime(QDateTime::fromString(requireString(obj, "releaseTime"), Qt::ISODate).toMSecsSinceEpoch() / 1000);
 	version->setType(ensureString(obj, "type", QString()));
 	version->setParentUid(ensureString(obj, "parentUid", QString()));
+	version->setRecommended(ensureBoolean(obj, "recommended", false));
 	if(obj.contains("requires"))
 	{
 		QHash<QString, QString> requires;
@@ -87,7 +88,9 @@ static BaseEntity::Ptr parseVersionListInternal(const QJsonObject &obj)
 	versions.reserve(versionsRaw.size());
 	std::transform(versionsRaw.begin(), versionsRaw.end(), std::back_inserter(versions), [uid](const QJsonObject &vObj)
 	{
-		return parseCommonVersion(uid, vObj);
+		auto version = parseCommonVersion(uid, vObj);
+		version->setProvidesRecommendations();
+		return version;
 	});
 
 	VersionListPtr list = std::make_shared<VersionList>(uid);
diff --git a/api/logic/meta/Version.cpp b/api/logic/meta/Version.cpp
index 2a8e1780..338e180b 100644
--- a/api/logic/meta/Version.cpp
+++ b/api/logic/meta/Version.cpp
@@ -53,6 +53,13 @@ void Meta::Version::parse(const QJsonObject& obj)
 void Meta::Version::merge(const std::shared_ptr<BaseEntity> &other)
 {
 	VersionPtr version = std::dynamic_pointer_cast<Version>(other);
+	if(version->m_providesRecommendations)
+	{
+		if(m_recommended != version->m_recommended)
+		{
+			setRecommended(version->m_recommended);
+		}
+	}
 	if (m_type != version->m_type)
 	{
 		setType(version->m_type);
@@ -107,3 +114,12 @@ void Meta::Version::setData(const VersionFilePtr &data)
 	m_data = data;
 }
 
+void Meta::Version::setProvidesRecommendations()
+{
+	m_providesRecommendations = true;
+}
+
+void Meta::Version::setRecommended(bool recommended)
+{
+	m_recommended = recommended;
+}
diff --git a/api/logic/meta/Version.h b/api/logic/meta/Version.h
index 8aac8ea1..f132b861 100644
--- a/api/logic/meta/Version.h
+++ b/api/logic/meta/Version.h
@@ -72,6 +72,10 @@ public: /* con/des */
 	{
 		return m_data;
 	}
+	bool isRecommended() const
+	{
+		return m_recommended;
+	}
 
 	void merge(const std::shared_ptr<BaseEntity> &other) override;
 	void parse(const QJsonObject &obj) override;
@@ -83,6 +87,8 @@ public: // for usage by format parsers only
 	void setType(const QString &type);
 	void setTime(const qint64 time);
 	void setRequires(const QHash<QString, QString> &requires);
+	void setRecommended(bool recommended);
+	void setProvidesRecommendations();
 	void setData(const VersionFilePtr &data);
 
 signals:
@@ -91,6 +97,8 @@ signals:
 	void requiresChanged();
 
 private:
+	bool m_providesRecommendations = false;
+	bool m_recommended = false;
 	QString m_name;
 	QString m_uid;
 	QString m_parentUid;
diff --git a/api/logic/meta/VersionList.cpp b/api/logic/meta/VersionList.cpp
index 41ed1352..0f1404ba 100644
--- a/api/logic/meta/VersionList.cpp
+++ b/api/logic/meta/VersionList.cpp
@@ -94,8 +94,9 @@ QVariant VersionList::data(const QModelIndex &index, int role) const
 	case RequiresRole: return QVariant::fromValue(version->requires());
 	case SortRole: return version->rawTime();
 	case VersionPtrRole: return QVariant::fromValue(version);
-	case RecommendedRole: return version == getRecommended();
-	case LatestRole: return version == getLatestStable();
+	case RecommendedRole: return version->isRecommended();
+	// FIXME: this should be determined in whatever view/proxy is used...
+	// case LatestRole: return version == getLatestStable();
 	default: return QVariant();
 	}
 }
@@ -158,7 +159,6 @@ void VersionList::setVersions(const QVector<VersionPtr> &versions)
 		setupAddedVersion(i, m_versions.at(i));
 	}
 
-	m_latest = m_versions.isEmpty() ? nullptr : m_versions.first();
 	auto recommendedIt = std::find_if(m_versions.constBegin(), m_versions.constEnd(), [](const VersionPtr &ptr) { return ptr->type() == "release"; });
 	m_recommended = recommendedIt == m_versions.constEnd() ? nullptr : *recommendedIt;
 	endResetModel();
@@ -202,11 +202,6 @@ void VersionList::merge(const BaseEntity::Ptr &other)
 				m_lookup.insert(version->uid(), version);
 				endInsertRows();
 
-				if (!m_latest || version->rawTime() > m_latest->rawTime())
-				{
-					m_latest = version;
-					emit dataChanged(index(0), index(m_versions.size() - 1), QVector<int>() << LatestRole);
-				}
 				if (!m_recommended || (version->type() == "release" && version->rawTime() > m_recommended->rawTime()))
 				{
 					m_recommended = version;
@@ -224,10 +219,6 @@ void VersionList::setupAddedVersion(const int row, const VersionPtr &version)
 	connect(version.get(), &Version::typeChanged, this, [this, row]() { emit dataChanged(index(row), index(row), QVector<int>() << TypeRole); });
 }
 
-BaseVersionPtr VersionList::getLatestStable() const
-{
-	return m_latest;
-}
 BaseVersionPtr VersionList::getRecommended() const
 {
 	return m_recommended;
diff --git a/api/logic/meta/VersionList.h b/api/logic/meta/VersionList.h
index faacdbf8..e8016314 100644
--- a/api/logic/meta/VersionList.h
+++ b/api/logic/meta/VersionList.h
@@ -47,7 +47,6 @@ public:
 	int count() const override;
 	void sortVersions() override;
 
-	BaseVersionPtr getLatestStable() const override;
 	BaseVersionPtr getRecommended() const override;
 
 	QVariant data(const QModelIndex &index, int role) const override;
@@ -100,7 +99,6 @@ private:
 	QString m_name;
 
 	VersionPtr m_recommended;
-	VersionPtr m_latest;
 
 	void setupAddedVersion(const int row, const VersionPtr &version);
 };

From dff307557bf69cb2dc6cc264b485865469ef64fd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= <peterix@gmail.com>
Date: Thu, 6 Apr 2017 23:32:20 +0200
Subject: [PATCH 25/28] NOISSUE fix liteloader uid where it is hardcoded
 hardcoded

---
 api/logic/minecraft/onesix/OneSixInstance.cpp        | 4 ++--
 api/logic/minecraft/onesix/OneSixProfileStrategy.cpp | 2 +-
 application/pages/VersionPage.cpp                    | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/api/logic/minecraft/onesix/OneSixInstance.cpp b/api/logic/minecraft/onesix/OneSixInstance.cpp
index 4a4380a4..2d50330f 100644
--- a/api/logic/minecraft/onesix/OneSixInstance.cpp
+++ b/api/logic/minecraft/onesix/OneSixInstance.cpp
@@ -510,7 +510,7 @@ bool OneSixInstance::setComponentVersion(const QString& uid, const QString& vers
 	{
 		settings()->set("ForgeVersion", version);
 	}
-	else if (uid == "com.liteloader")
+	else if (uid == "com.mumfrey.liteloader")
 	{
 		settings()->set("LiteloaderVersion", version);
 	}
@@ -536,7 +536,7 @@ QString OneSixInstance::getComponentVersion(const QString& uid) const
 	{
 		return settings()->get("ForgeVersion").toString();
 	}
-	else if(uid == "com.liteloader")
+	else if(uid == "com.mumfrey.liteloader")
 	{
 		return settings()->get("LiteloaderVersion").toString();
 	}
diff --git a/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp b/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
index e08dd529..d3e137c7 100644
--- a/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
+++ b/api/logic/minecraft/onesix/OneSixProfileStrategy.cpp
@@ -158,7 +158,7 @@ void OneSixProfileStrategy::loadUserPatches()
 		}
 	};
 	loadSpecial("net.minecraftforge", 5);
-	loadSpecial("com.liteloader", 10);
+	loadSpecial("com.mumfrey.liteloader", 10);
 
 	// now add all the patches by user sort order
 	ProfileUtils::PatchOrder userOrder;
diff --git a/application/pages/VersionPage.cpp b/application/pages/VersionPage.cpp
index a7029b36..8c14818f 100644
--- a/application/pages/VersionPage.cpp
+++ b/application/pages/VersionPage.cpp
@@ -412,7 +412,7 @@ void VersionPage::on_forgeBtn_clicked()
 
 void VersionPage::on_liteloaderBtn_clicked()
 {
-	auto vlist = ENV.metadataIndex()->get("com.liteloader");
+	auto vlist = ENV.metadataIndex()->get("com.mumfrey.liteloader");
 	if(!vlist)
 	{
 		return;
@@ -424,7 +424,7 @@ void VersionPage::on_liteloaderBtn_clicked()
 	if (vselect.exec() && vselect.selectedVersion())
 	{
 		auto vsn = vselect.selectedVersion();
-		m_inst->setComponentVersion("com.liteloader", vsn->descriptor());
+		m_inst->setComponentVersion("com.mumfrey.liteloader", vsn->descriptor());
 		m_profile->reload();
 		// m_profile->installVersion(vselect.selectedVersion());
 		preselect(m_profile->rowCount(QModelIndex())-1);

From d864c95e2b5e172116370694d59a615a97cf390f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= <peterix@gmail.com>
Date: Thu, 6 Apr 2017 23:39:50 +0200
Subject: [PATCH 26/28] NOISSUE disable version customization until further
 notice

---
 application/pages/VersionPage.cpp | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/application/pages/VersionPage.cpp b/application/pages/VersionPage.cpp
index 8c14818f..8e8c3d5f 100644
--- a/application/pages/VersionPage.cpp
+++ b/application/pages/VersionPage.cpp
@@ -479,7 +479,8 @@ void VersionPage::updateButtons(int row)
 		ui->moveUpBtn->setEnabled(patch->isMoveable());
 		ui->changeVersionBtn->setEnabled(patch->isVersionChangeable());
 		ui->editBtn->setEnabled(patch->isCustom());
-		ui->customizeBtn->setEnabled(patch->isCustomizable());
+		// FIXME: temporarily disabled, bring it back when the new format is stable and ready to replace the 'OneSix' one...
+		ui->customizeBtn->setEnabled(false); // patch->isCustomizable()
 		ui->revertBtn->setEnabled(patch->isRevertible());
 	}
 }
@@ -511,6 +512,8 @@ int VersionPage::currentRow()
 
 void VersionPage::on_customizeBtn_clicked()
 {
+	// FIXME: temporarily disabled, bring it back when the new format is stable and ready to replace the 'OneSix' one...
+	return;
 	auto version = currentRow();
 	if(version == -1)
 	{

From dddc5cedf380d1321b94b0bc7d244d23289e6d3c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= <peterix@gmail.com>
Date: Thu, 6 Apr 2017 23:45:24 +0200
Subject: [PATCH 27/28] NOISSUE make a call to ensureBoolean in the JSON format
 code less ambiguous

---
 api/logic/meta/JsonFormat.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/api/logic/meta/JsonFormat.cpp b/api/logic/meta/JsonFormat.cpp
index 1638105a..fda1cf97 100644
--- a/api/logic/meta/JsonFormat.cpp
+++ b/api/logic/meta/JsonFormat.cpp
@@ -52,7 +52,7 @@ static VersionPtr parseCommonVersion(const QString &uid, const QJsonObject &obj)
 	version->setTime(QDateTime::fromString(requireString(obj, "releaseTime"), Qt::ISODate).toMSecsSinceEpoch() / 1000);
 	version->setType(ensureString(obj, "type", QString()));
 	version->setParentUid(ensureString(obj, "parentUid", QString()));
-	version->setRecommended(ensureBoolean(obj, "recommended", false));
+	version->setRecommended(ensureBoolean(obj, QString("recommended"), false));
 	if(obj.contains("requires"))
 	{
 		QHash<QString, QString> requires;

From 8e58d61150b0bdbe9eb91065d36342f3004fe97b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= <peterix@gmail.com>
Date: Thu, 6 Apr 2017 23:31:23 +0200
Subject: [PATCH 28/28] NOISSUE fix issue with the narrator feature by
 splitting java and native libraries

---
 api/logic/minecraft/Library.cpp               | 15 +++++-----
 api/logic/minecraft/Library_test.cpp          |  2 +-
 api/logic/minecraft/MinecraftProfile.cpp      | 28 +++++++++++++++----
 api/logic/minecraft/MinecraftProfile.h        |  4 +++
 api/logic/minecraft/onesix/OneSixInstance.cpp |  2 ++
 .../minecraft/onesix/update/LibrariesTask.cpp | 18 +++++++-----
 6 files changed, 49 insertions(+), 20 deletions(-)

diff --git a/api/logic/minecraft/Library.cpp b/api/logic/minecraft/Library.cpp
index ad0a64cf..7521a049 100644
--- a/api/logic/minecraft/Library.cpp
+++ b/api/logic/minecraft/Library.cpp
@@ -30,14 +30,15 @@ void Library::getApplicableFiles(OpSys system, QStringList& jar, QStringList& na
 	};
 	if(m_mojangDownloads)
 	{
-		if(m_mojangDownloads->artifact)
-		{
-			auto artifact = m_mojangDownloads->artifact;
-			jar += actualPath(artifact->path);
-		}
 		if(!isNative())
-			return;
-		if(m_nativeClassifiers.contains(system))
+		{
+			if(m_mojangDownloads->artifact)
+			{
+				auto artifact = m_mojangDownloads->artifact;
+				jar += actualPath(artifact->path);
+			}
+		}
+		else if(m_nativeClassifiers.contains(system))
 		{
 			auto nativeClassifier = m_nativeClassifiers[system];
 			if(nativeClassifier.contains("${arch}"))
diff --git a/api/logic/minecraft/Library_test.cpp b/api/logic/minecraft/Library_test.cpp
index fe61d305..3f4828c9 100644
--- a/api/logic/minecraft/Library_test.cpp
+++ b/api/logic/minecraft/Library_test.cpp
@@ -234,7 +234,7 @@ slots:
 		auto test = readMojangJson("data/lib-native.json");
 		QStringList jar, native, native32, native64;
 		test->getApplicableFiles(Os_OSX, jar, native, native32, native64, QString());
-		QCOMPARE(jar, getStorage("org/lwjgl/lwjgl/lwjgl-platform/2.9.4-nightly-20150209/lwjgl-platform-2.9.4-nightly-20150209.jar"));
+		QCOMPARE(jar, QStringList());
 		QCOMPARE(native, getStorage("org/lwjgl/lwjgl/lwjgl-platform/2.9.4-nightly-20150209/lwjgl-platform-2.9.4-nightly-20150209-natives-osx.jar"));
 		QCOMPARE(native32, {});
 		QCOMPARE(native64, {});
diff --git a/api/logic/minecraft/MinecraftProfile.cpp b/api/logic/minecraft/MinecraftProfile.cpp
index 8638f5fa..c04669c1 100644
--- a/api/logic/minecraft/MinecraftProfile.cpp
+++ b/api/logic/minecraft/MinecraftProfile.cpp
@@ -491,20 +491,29 @@ void MinecraftProfile::applyLibrary(LibraryPtr library)
 	{
 		return;
 	}
+
+	QList<LibraryPtr> * list = &m_libraries;
+	if(library->isNative())
+	{
+		list = &m_nativeLibraries;
+	}
+
+	auto libraryCopy = Library::limitedCopy(library);
+
 	// find the library by name.
-	const int index = findLibraryByName(m_libraries, library->rawName());
+	const int index = findLibraryByName(*list, library->rawName());
 	// library not found? just add it.
 	if (index < 0)
 	{
-		m_libraries.append(Library::limitedCopy(library));
+		list->append(libraryCopy);
 		return;
 	}
-	auto existingLibrary = m_libraries.at(index);
+
+	auto existingLibrary = list->at(index);
 	// if we are higher it means we should update
 	if (Version(library->version()) > Version(existingLibrary->version()))
 	{
-		auto libraryCopy = Library::limitedCopy(library);
-		m_libraries.replace(index, libraryCopy);
+		list->replace(index, libraryCopy);
 	}
 }
 
@@ -581,6 +590,11 @@ const QList<LibraryPtr> & MinecraftProfile::getLibraries() const
 	return m_libraries;
 }
 
+const QList<LibraryPtr> & MinecraftProfile::getNativeLibraries() const
+{
+	return m_nativeLibraries;
+}
+
 void MinecraftProfile::getLibraryFiles(const QString& architecture, QStringList& jars, QStringList& nativeJars, const QString& overridePath) const
 {
 	QStringList native32, native64;
@@ -590,6 +604,10 @@ void MinecraftProfile::getLibraryFiles(const QString& architecture, QStringList&
 	{
 		lib->getApplicableFiles(currentSystem, jars, nativeJars, native32, native64, overridePath);
 	}
+	for (auto lib : getNativeLibraries())
+	{
+		lib->getApplicableFiles(currentSystem, jars, nativeJars, native32, native64, overridePath);
+	}
 	if(architecture == "32")
 	{
 		nativeJars.append(native32);
diff --git a/api/logic/minecraft/MinecraftProfile.h b/api/logic/minecraft/MinecraftProfile.h
index a3b8fb61..5b1ea539 100644
--- a/api/logic/minecraft/MinecraftProfile.h
+++ b/api/logic/minecraft/MinecraftProfile.h
@@ -115,6 +115,7 @@ public: /* getters for profile variables */
 	const QStringList & getTweakers() const;
 	const QList<JarmodPtr> & getJarMods() const;
 	const QList<LibraryPtr> & getLibraries() const;
+	const QList<LibraryPtr> & getNativeLibraries() const;
 	void getLibraryFiles(const QString & architecture, QStringList & jars, QStringList & nativeJars, const QString & overridePath) const;
 	QString getMainJarUrl() const;
 	bool hasTrait(const QString & trait) const;
@@ -169,6 +170,9 @@ private: /* data */
 	/// the list of libraries
 	QList<LibraryPtr> m_libraries;
 
+	/// the list of libraries
+	QList<LibraryPtr> m_nativeLibraries;
+
 	/// traits, collected from all the version files (version files can only add)
 	QSet<QString> m_traits;
 
diff --git a/api/logic/minecraft/onesix/OneSixInstance.cpp b/api/logic/minecraft/onesix/OneSixInstance.cpp
index 2d50330f..fd54f544 100644
--- a/api/logic/minecraft/onesix/OneSixInstance.cpp
+++ b/api/logic/minecraft/onesix/OneSixInstance.cpp
@@ -283,6 +283,8 @@ QStringList OneSixInstance::verboseDescription(AuthSessionPtr session)
 			printLibFile(file);
 		}
 		printLibFile(mainJarPath());
+		out << "";
+		out << "Native libraries:";
 		for(auto file: nativeJars)
 		{
 			printLibFile(file);
diff --git a/api/logic/minecraft/onesix/update/LibrariesTask.cpp b/api/logic/minecraft/onesix/update/LibrariesTask.cpp
index f60c2b5e..3e6bb12a 100644
--- a/api/logic/minecraft/onesix/update/LibrariesTask.cpp
+++ b/api/logic/minecraft/onesix/update/LibrariesTask.cpp
@@ -35,19 +35,23 @@ void LibrariesTask::executeTask()
 		downloadJob.reset(job);
 	}
 
-	auto libs = profile->getLibraries();
-
 	auto metacache = ENV.metacache();
 	QList<LibraryPtr> brokenLocalLibs;
 	QStringList failedFiles;
-	for (auto lib : libs)
+	auto createJobs = [&](const QList<LibraryPtr> & libs)
 	{
-		auto dls = lib->getDownloads(currentSystem, metacache.get(), failedFiles, inst->getLocalLibraryPath());
-		for(auto dl : dls)
+		for (auto lib : libs)
 		{
-			downloadJob->addNetAction(dl);
+			auto dls = lib->getDownloads(currentSystem, metacache.get(), failedFiles, inst->getLocalLibraryPath());
+			for(auto dl : dls)
+			{
+				downloadJob->addNetAction(dl);
+			}
 		}
-	}
+	};
+	createJobs(profile->getLibraries());
+	createJobs(profile->getNativeLibraries());
+
 	// FIXME: this is never filled!!!!
 	if (!brokenLocalLibs.empty())
 	{