From 7436c94976b2ee0c6f8a9e69d6acb8369ba4cbe6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20Mr=C3=A1zek?= Date: Mon, 14 Jan 2019 01:36:04 +0100 Subject: [PATCH] NOISSUE Replace Quality with Completeness in language widget Completeness does no imply quality. --- api/logic/minecraft/SimpleModList.cpp | 9 --------- api/logic/translations/TranslationsModel.cpp | 12 ++++++------ 2 files changed, 6 insertions(+), 15 deletions(-) diff --git a/api/logic/minecraft/SimpleModList.cpp b/api/logic/minecraft/SimpleModList.cpp index bc15dde7..2b686635 100644 --- a/api/logic/minecraft/SimpleModList.cpp +++ b/api/logic/minecraft/SimpleModList.cpp @@ -349,11 +349,6 @@ bool SimpleModList::dropMimeData(const QMimeData* data, Qt::DropAction action, i // files dropped from outside? if (data->hasUrls()) { - bool was_watching = is_watching; - if (was_watching) - { - stopWatching(); - } auto urls = data->urls(); for (auto url : urls) { @@ -366,10 +361,6 @@ bool SimpleModList::dropMimeData(const QMimeData* data, Qt::DropAction action, i // FIXME: handle errors here installMod(url.toLocalFile()); } - if (was_watching) - { - startWatching(); - } return true; } return false; diff --git a/api/logic/translations/TranslationsModel.cpp b/api/logic/translations/TranslationsModel.cpp index b1c65917..58ff4384 100644 --- a/api/logic/translations/TranslationsModel.cpp +++ b/api/logic/translations/TranslationsModel.cpp @@ -308,7 +308,7 @@ namespace { enum class Column { Language, - Quality + Completeness }; } @@ -335,7 +335,7 @@ QVariant TranslationsModel::data(const QModelIndex& index, int role) const { return d->m_languages[row].locale.nativeLanguageName(); } - case Column::Quality: + case Column::Completeness: { QString text; text.sprintf("%3.1f %%", lang.percentTranslated()); @@ -365,9 +365,9 @@ QVariant TranslationsModel::headerData(int section, Qt::Orientation orientation, { return tr("Language"); } - case Column::Quality: + case Column::Completeness: { - return tr("Quality"); + return tr("Completeness"); } } } @@ -379,9 +379,9 @@ QVariant TranslationsModel::headerData(int section, Qt::Orientation orientation, { return tr("The native language name."); } - case Column::Quality: + case Column::Completeness: { - return tr("Quality is the percentage of fully translated strings, not counting automatically guessed ones."); + return tr("Completeness is the percentage of fully translated strings, not counting automatically guessed ones."); } } }