From 6dd1fdbaf96ebd4845d1596c06dc37099e7b4caa Mon Sep 17 00:00:00 2001 From: Jamie Mansfield Date: Thu, 3 Jun 2021 15:16:03 +0100 Subject: [PATCH] NOISSUE Fail pack installation for download errors for FTB This effectively reverts the changes made in [1] to resolve GH-3304. [1] 05ffcf706bff92bdc48f3063d6a64508f8b7674c --- api/logic/modplatform/modpacksch/FTBPackInstallTask.cpp | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/api/logic/modplatform/modpacksch/FTBPackInstallTask.cpp b/api/logic/modplatform/modpacksch/FTBPackInstallTask.cpp index 068e3592..ddc7fe35 100644 --- a/api/logic/modplatform/modpacksch/FTBPackInstallTask.cpp +++ b/api/logic/modplatform/modpacksch/FTBPackInstallTask.cpp @@ -109,12 +109,7 @@ void PackInstallTask::downloadPack() connect(jobPtr.get(), &NetJob::failed, [&](QString reason) { jobPtr.reset(); - - // FIXME: Temporarily ignore file download failures (matching FTB's installer), - // while FTB's data is fucked. - qWarning() << "Failed to download files for modpack: " + reason; - - install(); + emitFailed(reason); }); connect(jobPtr.get(), &NetJob::progress, [&](qint64 current, qint64 total) {