Merge pull request #5063 from arthomnix/feature/mrpack_export

NOISSUE Set Modrinth export dialog window title
This commit is contained in:
Petr Mrázek 2023-05-24 10:03:38 +02:00 committed by GitHub
commit 33a8b916a1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 2 additions and 10 deletions

View File

@ -122,13 +122,6 @@ void Download::downloadError(QNetworkReply::NetworkError error)
qCritical() << "Aborted " << m_url.toString();
m_status = Job_Aborted;
}
else if(error == QNetworkReply::ContentNotFoundError && (m_options & Option::AllowNotFound))
{
// The Modrinth API returns a 404 when a hash was not found when performing reverse hash lookup, we don't want to treat this as a failure
qDebug() << "Received 404 from " << m_url.toString() << ", continuing...";
m_status = Job_Finished;
return;
}
else
{
if(m_options & Option::AcceptLocalFiles)

View File

@ -32,8 +32,7 @@ public: /* types */
enum class Option
{
NoOptions = 0,
AcceptLocalFiles = 1,
AllowNotFound = 2
AcceptLocalFiles = 1
};
Q_DECLARE_FLAGS(Options, Option)

View File

@ -17,7 +17,7 @@
</sizepolicy>
</property>
<property name="windowTitle">
<string>ModrinthExportDialog</string>
<string>Export Modrinth modpack</string>
</property>
<widget class="QWidget" name="verticalLayoutWidget">
<property name="geometry">